@dadado/agent-kit-cli 5.0.0 → 5.2.0

package/README.md

@@ -55,6 +55,8 @@ NO_COLOR=1 agent-kit
 
 Subcommands and `agent-kit --version` are unchanged. Chat-only HITL flows (`/start-project`, `/git-staging`, `/git-prod`, `/run-plan-all`, backlog CRUD) are not CLI commands.
 
+On an interactive TTY, long-running commands (`init`, `install`, `doctor`, `update`, `run-plan` ticks) show an in-process ANSI spinner plus a rotating Mission Kit tip. Set `AGENT_KIT_REDUCED_MOTION=1` for static text on a capable TTY. Runtime dependencies stay `@clack/prompts`, `citty`, and `kolorist` (no `ora` / `figlet` / `chalk` / `ink`). Window titles for `agent-kit dashboard` and `agent-kit dashboard-broadcast` use the workspace basename, not the CLI package folder.
+
 ## Common commands
 
 | Command | Purpose |

package/dashboard/dashboard.html

@@ -743,16 +743,19 @@ body.mc-fullscreen .top-tabs-row {
 }
 
 /* ===== Progress Bar ===== */
+/* Track must stay visibly a track at 0% (contract item 5): --border-active
+   reads against --bg-card in both skins where --border blended in, and 6px
+   with rounded ends keeps mid fills from collapsing into a hairline. */
 .progress-bar {
-  height: 4px;
-  background: var(--border);
-  border-radius: 2px;
+  height: 6px;
+  background: var(--border-active);
+  border-radius: 3px;
   overflow: hidden;
   margin-top: 8px;
 }
 .progress-fill {
   height: 100%;
-  border-radius: 2px;
+  border-radius: 3px;
   transition: width 0.5s ease;
 }
 .progress-fill.green { background: var(--green); }
@@ -4267,11 +4270,11 @@ function fmtDate(iso) {
   return d.toLocaleString('en-US', { month: 'short', day: 'numeric', hour: '2-digit', minute: '2-digit' });
 }
 
+// Presentation contract (Phase 2): progress is never an error signal. Any
+// in-flight percentage (0-99) renders the neutral accent; 100% renders green
+// (lifecycle completed with total > 0 implies 100 per the Phase 0 contract).
 function progressColor(pct) {
-  if (pct >= 100) return 'green';
-  if (pct >= 50) return 'blue';
-  if (pct >= 25) return 'yellow';
-  return 'red';
+  return pct >= 100 ? 'green' : 'blue';
 }
 
 // Dot semantics: only state signals survive. completed = good, cancelled =
@@ -5606,9 +5609,31 @@ function renderConfigSection(d) {
           <div class="config-row">
             <label for="config-epr-backend">Backend</label>
             <select id="config-epr-backend" name="eprBackend" data-focus-key="config-epr-backend">
+              <option value="auto"${epr.backend === 'auto' ? ' selected' : ''}>auto</option>
               <option value="claude"${epr.backend === 'claude' || !epr.backend ? ' selected' : ''}>claude</option>
+              <option value="cursor"${epr.backend === 'cursor' ? ' selected' : ''}>cursor</option>
             </select>
-            <span class="config-hint">claude is the only backend today.</span>
+            <span class="config-hint">auto uses Claude when usable, else Cursor Agent. Pin claude or cursor to force one backend.</span>
+          </div>
+          <div class="config-row">
+            <label for="config-epr-reviewerModel">Reviewer model</label>
+            <input type="text" id="config-epr-reviewerModel" name="eprReviewerModel" value="${escapeAttr(epr.reviewerModel || 'sonnet')}" maxlength="64" data-focus-key="config-epr-reviewerModel" />
+            <span class="config-hint">Claude default sonnet (auto permission mode). Must differ from the implementer stamp (Auto/Auto refused).</span>
+          </div>
+          <div class="config-row">
+            <label for="config-epr-advisorModel">Advisor model</label>
+            <input type="text" id="config-epr-advisorModel" name="eprAdvisorModel" value="${escapeAttr(epr.advisorModel || 'opus')}" maxlength="64" data-focus-key="config-epr-advisorModel" />
+            <span class="config-hint">Opus only when the monitor marks high severity or uncertainty.</span>
+          </div>
+          <div class="config-row">
+            <label for="config-epr-waitSlice">Wait slice (seconds)</label>
+            <input type="number" id="config-epr-waitSlice" name="eprWaitSlice" min="1" max="3600" step="1" value="${escapeAttr(String(epr.waitSliceSeconds || 90))}" data-focus-key="config-epr-waitSlice" />
+            <span class="config-hint">Chat AwaitShell budget per session. Default 90.</span>
+          </div>
+          <div class="config-row">
+            <label for="config-epr-waitTimeout">Wait timeout (seconds)</label>
+            <input type="number" id="config-epr-waitTimeout" name="eprWaitTimeout" min="1" max="86400" step="1" value="${escapeAttr(String(epr.waitTimeoutSeconds || 900))}" data-focus-key="config-epr-waitTimeout" />
+            <span class="config-hint">Total remaining budget across slices and CI. Default 900.</span>
           </div>
           <div class="config-row">
             <label for="config-epr-mode">Arming mode</label>
@@ -5680,6 +5705,18 @@ function collectMissionConfigPayload() {
       offerOnExhausted: !!document.getElementById('config-epr-offer')?.checked,
       autoRemediate: !!document.getElementById('config-epr-auto')?.checked,
       backend: document.getElementById('config-epr-backend')?.value || 'claude',
+      reviewerModel: (document.getElementById('config-epr-reviewerModel')?.value || 'sonnet').trim(),
+      advisorModel: (document.getElementById('config-epr-advisorModel')?.value || 'opus').trim(),
+      waitSliceSeconds: (() => {
+        const raw = document.getElementById('config-epr-waitSlice')?.value;
+        const n = Number.parseInt(String(raw || '90'), 10);
+        return Number.isFinite(n) && n >= 1 ? n : 90;
+      })(),
+      waitTimeoutSeconds: (() => {
+        const raw = document.getElementById('config-epr-waitTimeout')?.value;
+        const n = Number.parseInt(String(raw || '900'), 10);
+        return Number.isFinite(n) && n >= 1 ? n : 900;
+      })(),
       mode: document.getElementById('config-epr-mode')?.value || 'paste',
       midBatchAudits: !!document.getElementById('config-epr-midBatch')?.checked,
       preflight: document.getElementById('config-epr-preflight')?.value || 'off',
@@ -6300,10 +6337,18 @@ function mergePlansForUi(d) {
     const inProgress = fromItems
       ? items.filter((t) => t.status === 'in_progress').length
       : (raw.todos?.inProgress ?? 0);
+    // Cancelled counts toward the fill numerator (terminal work, mirrors
+    // TERMINAL_TODO_STATUSES / todoStats in dashboard/lib/semantic-model.mjs)
+    // so the bar reaches 100% whenever the lifecycle pill says COMPLETED.
+    const cancelled = fromItems
+      ? items.filter((t) => t.status === 'cancelled').length
+      : (raw.todos?.cancelled ?? enriched.progress?.cancelled ?? 0);
     const nextActionTodo = planNextActionTodo(items);
     let lifecycle = enriched.lifecycle;
     if (!lifecycle) {
-      if (total > 0 && completed >= total && (raw.todos?.inProgress || 0) === 0) {
+      // Mirrors classifyPlan: terminal (completed + cancelled) exhausting the
+      // list means todoStats.open === 0 → completed.
+      if (total > 0 && completed + cancelled >= total && inProgress === 0) {
         lifecycle = 'completed';
       } else {
         lifecycle = 'incomplete';
@@ -6317,12 +6362,13 @@ function mergePlansForUi(d) {
       modifiedAt: raw.modifiedAt || enriched.modifiedAt || null,
       progressPct:
         total > 0
-          ? Math.round((completed / total) * 100)
+          ? Math.round(((completed + cancelled) / total) * 100)
           : typeof raw.progress === 'number'
             ? raw.progress
             : 0,
-      progressLabel: `${completed} of ${total} complete`,
+      progressLabel: `${completed} of ${total} complete` + (cancelled > 0 ? ` · ${cancelled} cancelled` : ''),
       progressCompleted: completed,
+      progressCancelled: cancelled,
       progressTotal: total,
       progressInProgress: inProgress,
       nextActionTodo,

package/dashboard/lib/guards.d.mts

@@ -1,5 +1,84 @@
 /** Ambient types for dashboard/lib/guards.mjs (consumed by CLI TypeScript). */
 
+type ProcessEnvLike = NodeJS.ProcessEnv | Record<string, string | undefined>;
+type HeaderMap = Record<string, string | string[] | undefined>;
+type GuardRequest = { headers?: HeaderMap };
+type PortOpts = { base?: number; range?: number };
+type GitStatusFile = {
+  path: string;
+  status: string;
+  staged: boolean;
+  unstaged: boolean;
+  untracked: boolean;
+  oldPath?: string;
+  renamed?: boolean;
+};
+
+export const DEFAULT_HOST: "127.0.0.1";
+export const BROADCAST_TOKEN_ENV: "MISSION_CONTROL_TOKEN";
+export const REPO_ROOT_ENV: "MISSION_CONTROL_REPO_ROOT";
+export const KIT_ROOT_ENV_KEYS: readonly ["MISSION_CONTROL_KIT_ROOT", "AGENT_KIT_HOME"];
+export const BROADCAST_TOKEN_MIN_LEN: 16;
+export const BROADCAST_TOKEN_COOKIE: "mc_token";
+export const DEFAULT_PORT_BASE: 3333;
+export const DEFAULT_PORT_RANGE: 256;
+export const MAX_STRING: {
+  branch: number;
+  lastCommit: number;
+  terminalCwd: number;
+  terminalCommand: number;
+  processCommand: number;
+};
+export const MAX_GIT_FILES: 50;
+export const MAX_GIT_PATH: 240;
+export const CONTEXT_CONFIG_REL: ".cursor/context/config.json";
+export const CONFIG_PERSONA_IDS: readonly ["autopilot", "night-shift", "ghost-runner"];
+export const CONFIG_PERSONA_MODES: readonly ["continue-plan", "run-plan", "cli-run-plan"];
+export const CONFIG_REVIEW_BACKENDS: readonly ["auto", "claude", "cursor"];
+export const CONFIG_REVIEW_MODES: readonly ["paste", "autonomous"];
+export const CONFIG_REVIEW_PREFLIGHT: readonly ["off", "warn", "block"];
+
+export function escapePerlDoubleQuoted(value: string): string;
+export function resolveSnapshotRepoRoot(env: ProcessEnvLike | undefined, kitRoot: string): string;
+export function normalizeRepoRootKey(repoRoot: string): string;
+export function hashRepoRoot(repoRoot: string): number;
+export function repoRootLogId(repoRoot: string): string;
+export function preferredPortForRepoRoot(repoRoot: string, opts?: PortOpts): number;
+export function portCandidatesForRepoRoot(repoRoot: string, opts?: PortOpts): number[];
+export function sameRepoRoot(a: string | null | undefined, b: string | null | undefined): boolean;
+export function resolveMissionControlPort(args: {
+  repoRoot: string;
+  envPort?: string | number | null;
+  probe: (port: number) => { listening: boolean; repoRoot: string | null };
+  opts?: PortOpts;
+}): { port: number; reuse: boolean; explicit: boolean };
+export function isSafeRepoRelativePath(relPath: unknown): boolean;
+export function resolveBindHost(envHost?: string | null): string;
+export function isLoopbackBindHost(host: string | undefined | null): boolean;
+export function normalizeAuthToken(raw: unknown): string;
+export function isValidBroadcastToken(token: unknown): boolean;
+export function generateBroadcastToken(): string;
+export function tokensMatch(a: unknown, b: unknown): boolean;
+export function resolveBroadcastAuth(
+  env?: ProcessEnvLike,
+):
+  | { ok: true; host: string; tokenRequired: boolean; token: string | null; broadcast: boolean }
+  | { ok: false; error: string };
+export function extractRequestToken(req: GuardRequest, url: URL): string;
+export function authorizeMissionControlRequest(
+  req: GuardRequest,
+  url: URL,
+  opts: { tokenRequired: boolean; expectedToken: string | null },
+): { ok: true; viaQuery: boolean } | { ok: false; status: number; error: string };
+export function broadcastAuthCookieHeader(token: string): string;
+export function listLanIPv4Addresses(): string[];
+export function truncateStr(value: unknown, maxLen: number): unknown;
+export function parseGitStatusShort(output: unknown): {
+  files: GitStatusFile[];
+  total: number;
+  truncated: boolean;
+};
+export function isLoopbackAddress(addr: string | undefined | null): boolean;
 export function resolveContextConfigPath(
   repoRoot: string,
   fsHooks?: {
@@ -8,3 +87,27 @@ export function resolveContextConfigPath(
     mkdirSync?: (path: string, opts?: { recursive?: boolean }) => void;
   },
 ): { ok: true; path: string } | { ok: false; error: string };
+export function validateConfigWriteBody(
+  body: unknown,
+): { ok: true; patch: Record<string, unknown> } | { ok: false; error: string };
+export function mergeConfigAllowlist(
+  existing: Record<string, unknown> | object,
+  patch: Record<string, unknown> | object,
+): Record<string, unknown>;
+export function allowlistConfig(raw: unknown): Record<string, unknown>;
+export function isAllowedOrigin(origin: unknown, port: unknown): boolean;
+export function applyCorsHeaders(
+  req: GuardRequest,
+  res: { setHeader: (name: string, value: string) => unknown },
+  port: unknown,
+): boolean;
+export function isUnderDashboard(resolvedPath: string, dashboardReal: string): boolean;
+export function resolveDashboardStatic(
+  pathname: string,
+  hooks: {
+    dashboardDir: string;
+    dashboardReal: string;
+    existsSync: (path: string) => boolean;
+    realpathSync: (path: string) => string;
+  },
+): string | null;

package/dashboard/lib/guards.mjs

@@ -445,7 +445,10 @@ export const CONFIG_PERSONA_IDS = Object.freeze(["autopilot", "night-shift", "gh
 export const CONFIG_PERSONA_MODES = Object.freeze(["continue-plan", "run-plan", "cli-run-plan"]);
 
 /** Allowed externalPlanReview.backend values. */
-export const CONFIG_REVIEW_BACKENDS = Object.freeze(["claude"]);
+export const CONFIG_REVIEW_BACKENDS = Object.freeze(["auto", "claude", "cursor"]);
+
+/** Named reviewer / advisor / implementer model id (no secrets). */
+const REVIEW_MODEL_ID = /^[A-Za-z0-9._:+-]{1,64}$/;
 
 /** Allowed externalPlanReview.mode values (audits arming path). */
 export const CONFIG_REVIEW_MODES = Object.freeze(["paste", "autonomous"]);
@@ -591,6 +594,10 @@ export function validateConfigWriteBody(body) {
     const eprAllowed = new Set([
       "enabled",
       "backend",
+      "reviewerModel",
+      "advisorModel",
+      "waitSliceSeconds",
+      "waitTimeoutSeconds",
       "autoRemediate",
       "offerOnExhausted",
       "mode",
@@ -612,10 +619,45 @@ export function validateConfigWriteBody(body) {
     }
     if ("backend" in epr) {
       if (typeof epr.backend !== "string" || !CONFIG_REVIEW_BACKENDS.includes(epr.backend)) {
-        return { ok: false, error: "externalPlanReview.backend must be a known backend" };
+        return { ok: false, error: "externalPlanReview.backend must be auto, claude, or cursor" };
       }
       eprPatch.backend = epr.backend;
     }
+    if ("reviewerModel" in epr) {
+      if (
+        typeof epr.reviewerModel !== "string" ||
+        !REVIEW_MODEL_ID.test(epr.reviewerModel.trim())
+      ) {
+        return { ok: false, error: "externalPlanReview.reviewerModel must be a model id" };
+      }
+      eprPatch.reviewerModel = epr.reviewerModel.trim();
+    }
+    if ("advisorModel" in epr) {
+      if (typeof epr.advisorModel !== "string" || !REVIEW_MODEL_ID.test(epr.advisorModel.trim())) {
+        return { ok: false, error: "externalPlanReview.advisorModel must be a model id" };
+      }
+      eprPatch.advisorModel = epr.advisorModel.trim();
+    }
+    if ("waitSliceSeconds" in epr) {
+      const n = epr.waitSliceSeconds;
+      if (typeof n !== "number" || !Number.isInteger(n) || n < 1 || n > 3600) {
+        return {
+          ok: false,
+          error: "externalPlanReview.waitSliceSeconds must be an integer 1..3600",
+        };
+      }
+      eprPatch.waitSliceSeconds = n;
+    }
+    if ("waitTimeoutSeconds" in epr) {
+      const n = epr.waitTimeoutSeconds;
+      if (typeof n !== "number" || !Number.isInteger(n) || n < 1 || n > 86400) {
+        return {
+          ok: false,
+          error: "externalPlanReview.waitTimeoutSeconds must be an integer 1..86400",
+        };
+      }
+      eprPatch.waitTimeoutSeconds = n;
+    }
     if ("autoRemediate" in epr) {
       if (typeof epr.autoRemediate !== "boolean") {
         return { ok: false, error: "externalPlanReview.autoRemediate must be boolean" };
@@ -847,6 +889,18 @@ export function allowlistConfig(raw) {
     if (typeof raw.externalPlanReview.preflight === "string") {
       epr.preflight = truncateStr(raw.externalPlanReview.preflight, 16);
     }
+    if (typeof raw.externalPlanReview.reviewerModel === "string") {
+      epr.reviewerModel = truncateStr(raw.externalPlanReview.reviewerModel, 64);
+    }
+    if (typeof raw.externalPlanReview.advisorModel === "string") {
+      epr.advisorModel = truncateStr(raw.externalPlanReview.advisorModel, 64);
+    }
+    if (typeof raw.externalPlanReview.waitSliceSeconds === "number") {
+      epr.waitSliceSeconds = raw.externalPlanReview.waitSliceSeconds;
+    }
+    if (typeof raw.externalPlanReview.waitTimeoutSeconds === "number") {
+      epr.waitTimeoutSeconds = raw.externalPlanReview.waitTimeoutSeconds;
+    }
     summary.externalPlanReview = epr;
   }
   if (raw.agentPersona && typeof raw.agentPersona === "object") {

package/dashboard/lib/open-browser.mjs

@@ -201,16 +201,11 @@ export function openBrowser(url, options = {}) {
 
   /**
    * Preferred open: detect failure before claiming success, then caller may fall back.
-   * Hermetic tests that only inject spawnFn use the detached path (throw = fail).
    *
    * @param {{ command: string, args: string[] }} built
    * @returns {{ opened: boolean, reason?: string, command: string, args: string[] }}
    */
   function runPreferred(built) {
-    if (options.spawnFn && !spawnSyncFn) {
-      return runDetached(built);
-    }
-
     const sync = spawnSyncFn ?? spawnSync;
 
     if (platform !== "darwin" && platform !== "win32") {

package/dashboard/lib/semantic-model.mjs

@@ -3064,10 +3064,16 @@ export function enrichPlans(plans, handoff) {
       path: plan.path,
       overview: truncateStr(plan.overview || "", MAX_SEMANTIC_LABEL),
       modifiedAt: plan.modifiedAt || null,
+      // Counter SoT for plan progress (todoStats / TERMINAL_TODO_STATUSES).
+      // `terminal` (completed + cancelled) is the fill numerator so the bar can
+      // reach 100% exactly when classifyPlan says completed (open === 0).
+      // Label format is mirrored by mergePlansForUi in dashboard/dashboard.html.
       progress: {
         completed: stats.completed,
+        cancelled: stats.cancelled,
+        terminal: stats.completed + stats.cancelled,
         total: stats.total,
-        label: `${stats.completed} of ${stats.total}`,
+        label: `${stats.completed} of ${stats.total} complete${stats.cancelled > 0 ? ` · ${stats.cancelled} cancelled` : ""}`,
       },
       lifecycle: classifyPlan(plan, handoff),
       // Preserved when lifecycle is completed so UI/sort can still know provenance.

package/dashboard/start-broadcast.mjs

@@ -8,8 +8,8 @@
  */
 
 import { execFileSync, execSync, spawn } from "node:child_process";
-import { existsSync, openSync } from "node:fs";
-import { dirname, join } from "node:path";
+import { existsSync, openSync, realpathSync } from "node:fs";
+import { basename, dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
 import {
   buildBroadcastShareUrl,
@@ -35,6 +35,7 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
 const KIT_ROOT = join(__dirname, "..");
 /** Workspace snapshots / preference config. Defaults to KIT_ROOT. */
 const ROOT = resolveSnapshotRepoRoot(process.env, KIT_ROOT);
+process.title = `Mission Control · ${basename(ROOT) || "workspace"}`;
 const SERVE = join(__dirname, "serve.mjs");
 const LOG = process.env.MISSION_CONTROL_LOG || "/tmp/mission-control-broadcast.log";
 const PORT = Number.parseInt(process.env.PORT || "3333", 10);
@@ -240,7 +241,7 @@ async function main() {
     return;
   }
   let configValue = null;
-  const cfg = resolveContextConfigPath(ROOT, { existsSync });
+  const cfg = resolveContextConfigPath(ROOT, { existsSync, realpathSync });
   if (cfg.ok) {
     configValue = readPreferredBrowserFromConfig(cfg.path);
   }

package/dashboard/start.mjs

@@ -17,8 +17,8 @@
  */
 
 import { execFileSync, execSync, spawn } from "node:child_process";
-import { existsSync, openSync } from "node:fs";
-import { dirname, join, resolve } from "node:path";
+import { existsSync, openSync, realpathSync } from "node:fs";
+import { basename, dirname, join, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
 import {
   REPO_ROOT_ENV,
@@ -34,6 +34,7 @@ import { openBrowser, readPreferredBrowserFromConfig } from "./lib/open-browser.
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const KIT_ROOT = join(__dirname, "..");
 const ROOT = resolveSnapshotRepoRoot(process.env, KIT_ROOT);
+process.title = `Mission Control · ${basename(ROOT) || "workspace"}`;
 const SERVE = join(__dirname, "serve.mjs");
 const HOST = process.env.HOST || "127.0.0.1";
 const DISPLAY_HOST = HOST === "0.0.0.0" ? "127.0.0.1" : HOST;
@@ -256,7 +257,7 @@ async function main() {
     return;
   }
   let configValue = null;
-  const cfg = resolveContextConfigPath(ROOT, { existsSync });
+  const cfg = resolveContextConfigPath(ROOT, { existsSync, realpathSync });
   if (cfg.ok) {
     configValue = readPreferredBrowserFromConfig(cfg.path);
   }