@dadado/agent-kit-cli 4.8.2 → 4.8.4

package/dashboard/lib/guards.mjs

@@ -29,6 +29,22 @@ export const DEFAULT_PORT_BASE = 3333;
  */
 export const DEFAULT_PORT_RANGE = 256;
 
+/**
+ * Escape a path/string for embedding in a Perl double-quoted literal.
+ * Scoped npm package paths contain `@` (e.g. `node_modules/@dadado/...`);
+ * unescaped `@name` is array interpolation in Perl and strips the scope segment,
+ * so macOS detach-start via `perl -e` cannot exec `dashboard/serve.mjs`.
+ * @param {string} value
+ * @returns {string}
+ */
+export function escapePerlDoubleQuoted(value) {
+  return String(value)
+    .replace(/\\/g, "\\\\")
+    .replace(/"/g, '\\"')
+    .replace(/\$/g, "\\$")
+    .replace(/@/g, "\\@");
+}
+
 /**
  * Resolve the repository root Mission Control should snapshot.
  * @param {NodeJS.ProcessEnv | Record<string, string | undefined>} [env]
@@ -141,7 +157,9 @@ export function sameRepoRoot(a, b) {
 export function resolveMissionControlPort({ repoRoot, envPort, probe, opts = {} }) {
   const root = resolve(String(repoRoot || "").trim() || ".");
   const raw =
-    envPort != null && String(envPort).trim() !== "" ? Number.parseInt(String(envPort), 10) : NaN;
+    envPort != null && String(envPort).trim() !== ""
+      ? Number.parseInt(String(envPort), 10)
+      : Number.NaN;
 
   if (Number.isFinite(raw) && raw > 0) {
     const info = probe(raw);

package/dashboard/lib/semantic-model.mjs

@@ -2,6 +2,10 @@
 // Pure Mission Control view-model helpers (testable; no fs/git I/O).
 
 import { truncateStr } from "./guards.mjs";
+import { TRIAGE_HEADING_RE, hasTriageHeading } from "./triage-heading.mjs";
+
+/** Durable triage heading SoT (shared with CLI `monitors --untriaged`). */
+export { TRIAGE_HEADING_RE, hasTriageHeading };
 
 export const MAX_ACTIVITY = 28;
 export const MAX_ATTENTION = 15;
@@ -62,15 +66,6 @@ export const MAX_CHECKLIST_NOTES = 15;
  * External review reports are `.cursor/memory/plan-monitor-<slug>.md`. */
 export const EXTERNAL_REPORT_FILE_RE = /^plan-monitor-(.+)\.md$/;
 
-/**
- * A heading the triage step leaves behind in the report itself. Confirmed
- * against the local reports: `## Triage note - residual (A) verified` and
- * `## Follow-up plan - hitl_ask_questions_residuals_2026_07_20.plan.md`.
- * `/plan-review-triage` must write one of these for every outcome, including
- * Ack and stop, so Field Report can clear the untriaged row.
- */
-export const TRIAGE_HEADING_RE = /^#{2,6}\s+.*\b(triage|follow-?up plan|residuals plan)\b/im;
-
 /**
  * Local Field Report dismissals store (IDs only). Valid attention ids that
  * `/field-report-resolve` may append: External reviews, agent prompts, and
@@ -576,21 +571,23 @@ export function buildFlightLogWarnings(handoff, opts = {}) {
 
 /**
  * Bounded untriaged external-review rows for Flight Log quiet state.
- * Filters attention to `kind === "report"` only (no cadence, prompts, readiness,
- * or bulk FR CTAs). Used when Gaps + Warnings are empty; callers must not mix
- * these rows into a non-quiet Gaps/Warnings stack.
- * @param {object[]|null|undefined} attention - buildAttentionItems output
+ * Filters to `kind === "report"` with a non-empty `sourcePath` (no cadence,
+ * prompts, readiness, or bulk FR CTAs). Prefer calling with
+ * `buildExternalReportItems(...)` output so the quiet lane is not starved by
+ * the shared `buildAttentionItems` cap. Callers must not mix these rows into a
+ * non-quiet Gaps/Warnings stack.
+ * @param {object[]|null|undefined} reportOrAttentionItems
  * @param {{ limit?: number }} [opts]
  * @returns {object[]}
  */
-export function listFlightLogQuietOpenTriages(attention, opts = {}) {
+export function listFlightLogQuietOpenTriages(reportOrAttentionItems, opts = {}) {
   const limit =
     typeof opts.limit === "number" && opts.limit > 0
       ? Math.floor(opts.limit)
       : FLIGHT_LOG_QUIET_OPEN_TRIAGES_CAP;
-  if (!Array.isArray(attention) || attention.length === 0) return [];
+  if (!Array.isArray(reportOrAttentionItems) || reportOrAttentionItems.length === 0) return [];
   const out = [];
-  for (const item of attention) {
+  for (const item of reportOrAttentionItems) {
     if (!item || item.kind !== "report") continue;
     if (typeof item.sourcePath !== "string" || !item.sourcePath.trim()) continue;
     out.push(item);
@@ -1369,26 +1366,33 @@ export function normalizeHandoffGaps(raw) {
 
 /**
  * Classify a Flight Log Gaps/Warning body for palette chrome.
+ * Runs heuristics on whitespace-collapsed text **before** display truncation so
+ * long Gaps whose only warning/prompt/advice keyword sits past MAX_SEMANTIC_LABEL
+ * still match the inline dashboard.html classifier (which does not truncate).
  * @param {string | null | undefined} text
  * @param {{ lane?: 'gaps' | 'warning' }} [opts]
  * @returns {FlightLogMessageKind}
  */
 export function classifyFlightLogMessageKind(text, opts = {}) {
   if (opts.lane === "warning") return "warning";
-  const normalized = typeof text === "string" ? normalizeHandoffGaps(text) : null;
-  if (normalized == null) return "ok";
+  if (!text || typeof text !== "string") return "ok";
+  const collapsed = text.replace(/\s+/g, " ").trim();
+  if (!collapsed) return "ok";
+  if (/^(none|n\/a)$/i.test(collapsed)) return "ok";
+  if (/^(none|n\/a)\s*[.:,;\/(\-–—…]/i.test(collapsed)) return "ok";
+  if (/^([-–—.…]|empty|no gaps?|cleared|all clear|ok)$/i.test(collapsed)) return "ok";
   if (
-    /\bAPI\s*\/\s*usage\s+limit\b|\bAPI\s+usage\s+limit\b|\bSTOPPED:\s*API\b/i.test(normalized) ||
-    /\b(hard.?stop|quota\s+pause)\b/i.test(normalized)
+    /\bAPI\s*\/\s*usage\s+limit\b|\bAPI\s+usage\s+limit\b|\bSTOPPED:\s*API\b/i.test(collapsed) ||
+    /\b(hard.?stop|quota\s+pause)\b/i.test(collapsed)
   ) {
     return "warning";
   }
   if (
-    /\b(confirm|ask questions|hitl|\bpaste\b|choose\b|approve\b|operator yes)\b/i.test(normalized)
+    /\b(confirm|ask questions|hitl|\bpaste\b|choose\b|approve\b|operator yes)\b/i.test(collapsed)
   ) {
     return "prompt";
   }
-  if (/\b(tip:|advice:|consider\b|recommends?\b|recommended\b|prefer\b)/i.test(normalized)) {
+  if (/\b(tip:|advice:|consider\b|recommends?\b|recommended\b|prefer\b)/i.test(collapsed)) {
     return "advice";
   }
   return "residual";
@@ -3544,6 +3548,15 @@ export function buildMissionControlView({
   // Field Report attention inbox left the Flight Log card; builders stay
   // exported for /field-report-resolve + cadence scripts (ADR keep).
   // Quiet Gaps+Warnings: bounded report rows may surface on Flight Log.
+  // Build quiet lane from external reports directly (not capped attention) so
+  // prompt/readiness pressure cannot starve Reviews awaiting triage to All clear.
+  const dismissedForQuiet = new Set(
+    (dismissedIds || []).filter((id) => typeof id === "string" && id.length > 0),
+  );
+  const quietReportItems = buildExternalReportItems(externalReports, plans, {
+    handoff,
+    archivedPlanFiles,
+  }).filter((item) => item && !dismissedForQuiet.has(item.id));
   const attention = buildAttentionItems({
     plans,
     handoff,
@@ -3556,7 +3569,7 @@ export function buildMissionControlView({
     cadenceLedger,
     cadenceConfig,
   });
-  flightLog.quietOpenTriages = listFlightLogQuietOpenTriages(attention);
+  flightLog.quietOpenTriages = listFlightLogQuietOpenTriages(quietReportItems);
   // Deprecated: attention owns Field Report rows. Kept empty so older panel
   // code that still reads the field does not double-render.
   const checklistNotes = [];
@@ -3571,6 +3584,8 @@ export function buildMissionControlView({
     plans: classifiedPlans,
     // Crew Monitor hero display cap (SoT for dashboard.html; no HTML literal).
     monitorFeedCap: MONITOR_FEED_CAP,
+    // Quiet open-triage fallback cap for dashboard.html attention mirror.
+    flightLogQuietOpenTriagesCap: FLIGHT_LOG_QUIET_OPEN_TRIAGES_CAP,
     // /run-plan-all queue slice (null outside queue mode). Copy-only data:
     // display order and roles; the panel never writes the queue back.
     runQueue: buildRunQueueView(handoff),

package/dashboard/lib/triage-heading.mjs

@@ -0,0 +1,20 @@
+/**
+ * Durable triage headings written by `/plan-review-triage` (L0).
+ *
+ * Shared SoT for Mission Control (`isReportTriaged`) and
+ * `agent-kit monitors --untriaged`. Match ONLY these heading titles, not tick
+ * headings that merely name a `triage-*` to-do id (hyphens are word boundaries,
+ * so `\btriage\b` falsely matched those).
+ *
+ * Allowed forms (case-insensitive; optional suffix after the title):
+ *   ## Triage note
+ *   ## Follow-up plan  (also "Followup plan")
+ *   ## Residuals plan
+ */
+export const TRIAGE_HEADING_RE =
+  /^#{2,6}\s+(?:Triage note|Follow-?up plan|Residuals plan)\b/im;
+
+/** True when markdown carries a durable triage heading. */
+export function hasTriageHeading(text) {
+  return TRIAGE_HEADING_RE.test(String(text ?? ""));
+}

package/dashboard/start-broadcast.mjs

@@ -7,13 +7,14 @@
  * prints LAN URL(s) with token. Does not weaken loopback `/dashboard`.
  */
 
-import { spawn, execFileSync, execSync } from "node:child_process";
+import { execFileSync, execSync, spawn } from "node:child_process";
 import { existsSync, openSync } from "node:fs";
+import { platform } from "node:os";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
-import { platform } from "node:os";
 import {
   BROADCAST_TOKEN_ENV,
+  escapePerlDoubleQuoted,
   generateBroadcastToken,
   isLoopbackBindHost,
   isValidBroadcastToken,
@@ -26,7 +27,7 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
 const ROOT = join(__dirname, "..");
 const SERVE = join(__dirname, "serve.mjs");
 const LOG = process.env.MISSION_CONTROL_LOG || "/tmp/mission-control-broadcast.log";
-const PORT = parseInt(process.env.PORT || "3333", 10);
+const PORT = Number.parseInt(process.env.PORT || "3333", 10);
 const READY_TIMEOUT_MS = 20_000;
 const READY_POLL_MS = 250;
 
@@ -57,11 +58,10 @@ function urlsForProbe(token) {
 
 function probeHttp(url) {
   try {
-    const code = execFileSync(
-      "curl",
-      ["-sf", "-o", "/dev/null", "-w", "%{http_code}", url],
-      { encoding: "utf8", timeout: 3000 },
-    ).trim();
+    const code = execFileSync("curl", ["-sf", "-o", "/dev/null", "-w", "%{http_code}", url], {
+      encoding: "utf8",
+      timeout: 3000,
+    }).trim();
     return code === "200";
   } catch {
     return false;
@@ -70,11 +70,10 @@ function probeHttp(url) {
 
 function listeningPids() {
   try {
-    const out = execFileSync(
-      "lsof",
-      ["-nP", `-iTCP:${PORT}`, "-sTCP:LISTEN", "-t"],
-      { encoding: "utf8", timeout: 3000 },
-    ).trim();
+    const out = execFileSync("lsof", ["-nP", `-iTCP:${PORT}`, "-sTCP:LISTEN", "-t"], {
+      encoding: "utf8",
+      timeout: 3000,
+    }).trim();
     return out ? out.split(/\n+/).filter(Boolean) : [];
   } catch {
     return [];
@@ -107,12 +106,13 @@ function detachStart(env) {
     return;
   }
 
-  const rootEsc = ROOT.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const serveEsc = SERVE.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const logEsc = LOG.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const hostEsc = String(env.HOST).replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const tokenEsc = String(env[BROADCAST_TOKEN_ENV]).replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const portEsc = String(PORT);
+  // Escape @/$ so scoped package paths (node_modules/@scope/...) survive Perl qq.
+  const rootEsc = escapePerlDoubleQuoted(ROOT);
+  const serveEsc = escapePerlDoubleQuoted(SERVE);
+  const logEsc = escapePerlDoubleQuoted(LOG);
+  const hostEsc = escapePerlDoubleQuoted(String(env.HOST));
+  const tokenEsc = escapePerlDoubleQuoted(String(env[BROADCAST_TOKEN_ENV]));
+  const portEsc = escapePerlDoubleQuoted(String(PORT));
   const perl = [
     "use POSIX qw(setsid);",
     "exit if fork;",
@@ -169,7 +169,9 @@ function openBrowser(url) {
 async function main() {
   const { env, host, token } = resolveBroadcastEnv();
   if (isLoopbackBindHost(host)) {
-    console.error("Broadcast refused: bind host resolved to loopback. Set HOST to a non-loopback address.");
+    console.error(
+      "Broadcast refused: bind host resolved to loopback. Set HOST to a non-loopback address.",
+    );
     process.exit(1);
   }
 
@@ -193,9 +195,7 @@ async function main() {
     detachStart(env);
     const ready = await waitReady(urls);
     if (!ready) {
-      console.error(
-        `Mission Control broadcast did not answer within ${READY_TIMEOUT_MS}ms.`,
-      );
+      console.error(`Mission Control broadcast did not answer within ${READY_TIMEOUT_MS}ms.`);
       console.error(`Check the log: ${LOG}`);
       process.exit(1);
     }

package/dashboard/start.mjs

@@ -15,17 +15,18 @@
  * Foreground serve for debugging remains: `npm run start:dashboard`.
  */
 
-import { spawn, execFileSync, execSync } from "node:child_process";
+import { execFileSync, execSync, spawn } from "node:child_process";
 import { existsSync, openSync } from "node:fs";
+import { platform } from "node:os";
 import { dirname, join, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
-import { platform } from "node:os";
 import {
   REPO_ROOT_ENV,
-  resolveSnapshotRepoRoot,
+  escapePerlDoubleQuoted,
+  repoRootLogId,
   resolveMissionControlPort,
+  resolveSnapshotRepoRoot,
   sameRepoRoot,
-  repoRootLogId,
 } from "./lib/guards.mjs";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
@@ -50,18 +51,15 @@ function setPort(port) {
   PORT = port;
   URL = `http://${DISPLAY_HOST}:${PORT}/`;
   DATA_URL = `http://${DISPLAY_HOST}:${PORT}/dashboard-data.json`;
-  LOG =
-    process.env.MISSION_CONTROL_LOG ||
-    `/tmp/mission-control-${repoRootLogId(ROOT)}.log`;
+  LOG = process.env.MISSION_CONTROL_LOG || `/tmp/mission-control-${repoRootLogId(ROOT)}.log`;
 }
 
 function probeHttp(url = URL) {
   try {
-    const code = execFileSync(
-      "curl",
-      ["-sf", "-o", "/dev/null", "-w", "%{http_code}", url],
-      { encoding: "utf8", timeout: 3000 },
-    ).trim();
+    const code = execFileSync("curl", ["-sf", "-o", "/dev/null", "-w", "%{http_code}", url], {
+      encoding: "utf8",
+      timeout: 3000,
+    }).trim();
     return code === "200";
   } catch {
     return false;
@@ -70,11 +68,10 @@ function probeHttp(url = URL) {
 
 function listeningPids(port = PORT) {
   try {
-    const out = execFileSync(
-      "lsof",
-      ["-nP", `-iTCP:${port}`, "-sTCP:LISTEN", "-t"],
-      { encoding: "utf8", timeout: 3000 },
-    ).trim();
+    const out = execFileSync("lsof", ["-nP", `-iTCP:${port}`, "-sTCP:LISTEN", "-t"], {
+      encoding: "utf8",
+      timeout: 3000,
+    }).trim();
     return out ? out.split(/\n+/).filter(Boolean) : [];
   } catch {
     return [];
@@ -153,11 +150,12 @@ function detachStart() {
   }
 
   // macOS and other hosts without setsid: Perl double-fork + setsid().
-  const rootEsc = KIT_ROOT.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const serveEsc = SERVE.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const logEsc = LOG.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
-  const portEsc = String(PORT);
-  const snapEsc = ROOT.replace(/\\/g, "\\\\").replace(/"/g, '\\"');
+  // Escape @/$ so scoped package paths (node_modules/@scope/...) survive Perl qq.
+  const rootEsc = escapePerlDoubleQuoted(KIT_ROOT);
+  const serveEsc = escapePerlDoubleQuoted(SERVE);
+  const logEsc = escapePerlDoubleQuoted(LOG);
+  const portEsc = escapePerlDoubleQuoted(String(PORT));
+  const snapEsc = escapePerlDoubleQuoted(ROOT);
   const perl = [
     "use POSIX qw(setsid);",
     "exit if fork;",
@@ -258,9 +256,7 @@ async function ensureServer() {
   detachStart();
   const ready = await waitReady();
   if (!ready) {
-    console.error(
-      `Mission Control did not answer ${URL} within ${READY_TIMEOUT_MS}ms.`,
-    );
+    console.error(`Mission Control did not answer ${URL} within ${READY_TIMEOUT_MS}ms.`);
     console.error(`Check the log: ${LOG}`);
     process.exit(1);
   }
@@ -280,9 +276,7 @@ async function main() {
       "Opened in the default browser. In Cursor, Simple Browser or /dashboard also works.",
     );
   } else {
-    console.log(
-      "Open that URL in a browser (Cursor: Simple Browser, or run /dashboard in chat).",
-    );
+    console.log("Open that URL in a browser (Cursor: Simple Browser, or run /dashboard in chat).");
   }
 }