@d3lm/pr-stats 0.2.14 → 0.2.16

package/README.md

@@ -125,11 +125,13 @@ The Desktop notifications row in the settings dialog makes the TUI send a deskto
 }
 ```
 
-Notifications go through the terminal itself when it supports a notification escape sequence, which covers iTerm2, Kitty, Ghostty, WezTerm, and most VTE-based terminals like GNOME Terminal. The terminal posts the notification under its own notification permission and the sequence travels through SSH, so this path needs no setup. Some terminals only show the banner while their window is unfocused. Terminals without such support get the platform's own command instead, `osascript` on macOS and `notify-send` on Linux. A notification that fails to send reports in the footer, for example when `notify-send` is missing on a Linux machine.
+Notifications go through the terminal itself when it supports a notification escape sequence, which covers iTerm2, Kitty, Ghostty, WezTerm, and most VTE-based terminals like GNOME Terminal. The terminal posts the notification under its own notification permission and the sequence travels through SSH, so this path needs no setup beyond what the terminal asks for. Some terminals only show the banner while their window is unfocused. Terminals without such support get the platform's own command instead, the bundled `pr-stats.app` helper on macOS and `notify-send` on Linux. A notification that fails to send reports in the footer, for example when `notify-send` is missing on a Linux machine.
 
-The "Notification channel" row picks the path, and the choice persists as `notifyChannel` with the values `auto`, `terminal`, and `command`. On `auto` the TUI tries the terminal first and falls back to the platform command, while the other two force one path. The dialog shows the `command` value as the command's name on this platform. Forcing the command pays off inside editor terminals like the one in VS Code, which render the terminal path as a small in-editor toast instead of a system notification. The "Send test notification" row below it names the channel the next send takes and sends a sample notification, so you can check that your desktop displays it before relying on it.
+The "Notification channel" row picks the path, and the choice persists as `notifyChannel` with the values `auto`, `terminal`, `command`, and `bell`. On `auto` the TUI tries the terminal first and falls back to the platform command, `terminal` and `command` force one of those paths, and `bell` rings the terminal bell instead of posting any text. The dialog shows the `command` value as the command's name on this platform. Forcing the command pays off inside editor terminals like the one in VS Code, which render the terminal path as a small in-editor toast instead of a system notification. The bell reaches every terminal, including the ones that swallow notifications, and each terminal turns it into its own signal, a sound, a flashing screen, a bell icon on the tab, or a badge on the dock icon. The "Send test notification" row below the channel names the channel the next send takes and sends a sample notification, so you can check that your desktop displays it before relying on it.
 
-The macOS fallback posts through the built-in Script Editor, and since macOS 15 those notifications stay invisible until Script Editor holds notification permission, without any prompt appearing. To grant it once, open the Script Editor app, run the one-line script `display notification "test"`, and allow the prompt that appears. Script Editor then shows up under Notifications in the System Settings like any other app.
+Two terminals accept the notification sequence without showing anything, and the test row warns about both. iTerm2 drops it until the profile has "Notification Center Alerts" turned on under Settings → Profiles → Terminal, which is off by default. Behind the "Filter Alerts…" button next to it, "Send escape sequence-generated alerts" has to stay on as well, and macOS asks for iTerm2's notification permission on the first send. iTerm2 prefixes the banner with the session name unless its advanced setting "Omit session identifier from notifications" is on. Apple Terminal never implemented the sequence at all, so `auto` skips the terminal there and goes straight to the platform command.
+
+On macOS the command path runs a small app bundle that ships inside the package, `dist/pr-stats.app`, so the banner carries the pr-stats name and icon and the app gets its own entry under System Settings › Notifications. The first send asks for permission the way any app does, and the helper waits for your answer, because macOS treats a prompt that goes unanswered until the requesting app quits as a refusal. Should notifications end up turned off, the footer says so, and the switch to turn them back on sits under System Settings › Notifications › pr-stats. The helper runs on macOS 13 and later on both Apple silicon and Intel Macs. A source checkout without the bundle falls back to `osascript`, whose notifications post under Script Editor and stay invisible since macOS 15 until Script Editor holds notification permission, which the Script Editor app grants after running the one-line script `display notification "test"` once.
 
 ## Theming
 
@@ -152,6 +154,8 @@ The `preset` key names the active theme, one of `default`, `green`, `blue`, `pur
 
 The TUI runs with `bun tui/main.tsx`, or under Node with `pnpm tui:node`. The `--debug tui/testdata` flag serves canned data from the fake `gh` binary in that directory instead of fetching from GitHub, and `bun test tui` drives the whole pipeline against it. `pnpm build` bundles everything into `dist/`, where `tui.mjs` is the launcher and `tui-app.mjs` is the app bundle it loads.
 
+The macOS notification helper lives in `native/macos` as a Swift source, an `Info.plist`, and the icon PNG, and `pnpm build:notifier` compiles it into `dist/pr-stats.app` as a universal, ad-hoc signed bundle. The build needs the Xcode command line tools and only runs on macOS, so the publish workflow builds the bundle on a macOS runner and adds it to the package before publishing. Without the bundle the TUI falls back to `osascript`, so the rest of the development setup does not depend on it. The bundle identifier `dev.d3lm.pr-stats.notifier` keys the notification permission, so it must stay the same across releases.
+
 ## License
 
 OpenTUI is licensed under the [MIT License](LICENSE).

package/dist/pr-stats.app/Contents/Info.plist

@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>CFBundleDevelopmentRegion</key>
+	<string>en</string>
+	<key>CFBundleDisplayName</key>
+	<string>pr-stats</string>
+	<key>CFBundleExecutable</key>
+	<string>pr-stats-notifier</string>
+	<key>CFBundleIconFile</key>
+	<string>AppIcon</string>
+	<key>CFBundleIdentifier</key>
+	<string>dev.d3lm.pr-stats.notifier</string>
+	<key>CFBundleInfoDictionaryVersion</key>
+	<string>6.0</string>
+	<key>CFBundleName</key>
+	<string>pr-stats</string>
+	<key>CFBundlePackageType</key>
+	<string>APPL</string>
+	<key>CFBundleShortVersionString</key>
+	<string>0.2.16</string>
+	<key>CFBundleVersion</key>
+	<string>0.2.16</string>
+	<key>LSMinimumSystemVersion</key>
+	<string>13.0</string>
+	<key>LSUIElement</key>
+	<true/>
+	<key>NSHighResolutionCapable</key>
+	<true/>
+	<key>NSPrincipalClass</key>
+	<string>NSApplication</string>
+</dict>
+</plist>

package/dist/pr-stats.app/Contents/_CodeSignature/CodeResources

@@ -0,0 +1,128 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>files</key>
+	<dict>
+		<key>Resources/AppIcon.icns</key>
+		<data>
+		zC/K7ZKrclIys50SVpETzoH69zo=
+		</data>
+	</dict>
+	<key>files2</key>
+	<dict>
+		<key>Resources/AppIcon.icns</key>
+		<dict>
+			<key>hash2</key>
+			<data>
+			YNQOX7kwkBCY5/mW8PxQjE1wMJeXJdfF0dhZ3n7hBAo=
+			</data>
+		</dict>
+	</dict>
+	<key>rules</key>
+	<dict>
+		<key>^Resources/</key>
+		<true/>
+		<key>^Resources/.*\.lproj/</key>
+		<dict>
+			<key>optional</key>
+			<true/>
+			<key>weight</key>
+			<real>1000</real>
+		</dict>
+		<key>^Resources/.*\.lproj/locversion.plist$</key>
+		<dict>
+			<key>omit</key>
+			<true/>
+			<key>weight</key>
+			<real>1100</real>
+		</dict>
+		<key>^Resources/Base\.lproj/</key>
+		<dict>
+			<key>weight</key>
+			<real>1010</real>
+		</dict>
+		<key>^version.plist$</key>
+		<true/>
+	</dict>
+	<key>rules2</key>
+	<dict>
+		<key>.*\.dSYM($|/)</key>
+		<dict>
+			<key>weight</key>
+			<real>11</real>
+		</dict>
+		<key>^(.*/)?\.DS_Store$</key>
+		<dict>
+			<key>omit</key>
+			<true/>
+			<key>weight</key>
+			<real>2000</real>
+		</dict>
+		<key>^(Frameworks|SharedFrameworks|PlugIns|Plug-ins|XPCServices|Helpers|MacOS|Library/(Automator|Spotlight|LoginItems))/</key>
+		<dict>
+			<key>nested</key>
+			<true/>
+			<key>weight</key>
+			<real>10</real>
+		</dict>
+		<key>^.*</key>
+		<true/>
+		<key>^Info\.plist$</key>
+		<dict>
+			<key>omit</key>
+			<true/>
+			<key>weight</key>
+			<real>20</real>
+		</dict>
+		<key>^PkgInfo$</key>
+		<dict>
+			<key>omit</key>
+			<true/>
+			<key>weight</key>
+			<real>20</real>
+		</dict>
+		<key>^Resources/</key>
+		<dict>
+			<key>weight</key>
+			<real>20</real>
+		</dict>
+		<key>^Resources/.*\.lproj/</key>
+		<dict>
+			<key>optional</key>
+			<true/>
+			<key>weight</key>
+			<real>1000</real>
+		</dict>
+		<key>^Resources/.*\.lproj/locversion.plist$</key>
+		<dict>
+			<key>omit</key>
+			<true/>
+			<key>weight</key>
+			<real>1100</real>
+		</dict>
+		<key>^Resources/Base\.lproj/</key>
+		<dict>
+			<key>weight</key>
+			<real>1010</real>
+		</dict>
+		<key>^[^/]+$</key>
+		<dict>
+			<key>nested</key>
+			<true/>
+			<key>weight</key>
+			<real>10</real>
+		</dict>
+		<key>^embedded\.provisionprofile$</key>
+		<dict>
+			<key>weight</key>
+			<real>20</real>
+		</dict>
+		<key>^version\.plist$</key>
+		<dict>
+			<key>weight</key>
+			<real>20</real>
+		</dict>
+	</dict>
+</dict>
+</plist>

package/dist/tui-app.mjs

@@ -279,7 +279,7 @@ function percentile(sorted, percent) {
 }
 
 // src/settings.ts
-var NOTIFY_CHANNELS = ["auto", "terminal", "command"];
+var NOTIFY_CHANNELS = ["auto", "terminal", "command", "bell"];
 var DEFAULT_RELOAD_INTERVAL = "10m";
 var MAX_RELOAD_INTERVAL_MS = 24 * 60 * 60 * 1e3;
 function reloadIntervalMs(input) {
@@ -348,7 +348,7 @@ function loadSettings() {
     throw new CliError(`"notifications" in ${settingsFile()} must be true or false`);
   }
   if (settings.notifyChannel !== void 0 && !NOTIFY_CHANNELS.includes(settings.notifyChannel)) {
-    throw new CliError(`"notifyChannel" in ${settingsFile()} must be "auto", "terminal", or "command"`);
+    throw new CliError(`"notifyChannel" in ${settingsFile()} must be "auto", "terminal", "command", or "bell"`);
   }
   current = settings;
   return current;
@@ -2070,7 +2070,7 @@ function buildPendingReviewView(raw, repo = null, grouped = false) {
     empty: null,
     sections: [
       ...awaiting.length === 0 ? [] : [sectionOf(`Awaiting your review (n=${awaiting.length})`, awaiting)],
-      ...reviewing.length === 0 ? [] : [sectionOf(`Reviewing (n=${reviewing.length})`, reviewing)]
+      ...reviewing.length === 0 ? [] : [sectionOf(`Reviewed (n=${reviewing.length})`, reviewing)]
     ]
   };
 }
@@ -4095,7 +4095,7 @@ var SETTINGS = [
     key: "notifyChannel",
     section: "Notifications",
     label: "Notification channel",
-    hint: "auto posts through the terminal and falls back to the platform command \xB7 the other values force one channel"
+    hint: "auto tries the terminal, then the platform command \xB7 the others force one path \xB7 bell rings the terminal bell"
   },
   {
     key: "testNotification",
@@ -4169,28 +4169,104 @@ var CACHE_MESSAGES = {
 
 // src/tui/utils/notify.ts
 import { spawn } from "node:child_process";
+import { existsSync } from "node:fs";
+import { fileURLToPath } from "node:url";
+function notificationBoundary(renderer2) {
+  const raw = renderer2;
+  return {
+    get capabilities() {
+      return renderer2.capabilities;
+    },
+    triggerNotification: (message, title) => renderer2.triggerNotification(message, title),
+    writeOut: (data) => {
+      if (typeof raw.writeOut === "function") {
+        raw.writeOut(data);
+      } else {
+        process.stdout.write(data);
+      }
+    }
+  };
+}
+var BELL = "\x07";
+function terminalQuirk(renderer2) {
+  const name = renderer2.capabilities?.terminal.name ?? "";
+  if (/iterm/i.test(name)) {
+    return "iterm";
+  }
+  if (/apple_terminal|terminal\.app/i.test(name)) {
+    return "apple-terminal";
+  }
+  return null;
+}
 function createNotifier(renderer2, channel) {
   return (title, body, onError) => {
-    if (channel !== "command" && renderer2.triggerNotification(body, title)) {
+    if (channel === "bell") {
+      renderer2.writeOut(BELL);
+      return;
+    }
+    const tryTerminal = channel === "terminal" || channel === "auto" && terminalQuirk(renderer2) !== "apple-terminal";
+    if (tryTerminal && renderer2.triggerNotification(body, title)) {
       return;
     }
     if (channel === "terminal") {
-      onError("the terminal has no notification support, switch the channel to auto or the platform command");
+      onError("the terminal has no notification support, switch the channel to auto, the platform command, or bell");
       return;
     }
     sendNotification(title, body, onError);
   };
 }
 function notificationChannel(renderer2, channel) {
-  if (channel === "terminal" || channel === "auto" && renderer2.capabilities?.notifications === true) {
+  if (channel === "bell" || channel === "terminal") {
+    return channel;
+  }
+  if (channel === "auto" && renderer2.capabilities?.notifications === true && terminalQuirk(renderer2) !== "apple-terminal") {
     return "terminal";
   }
   return notificationTool();
 }
-function notificationTool() {
+function notificationCaveat(renderer2, channel) {
+  if (channel === "command" || channel === "bell") {
+    return null;
+  }
+  switch (terminalQuirk(renderer2)) {
+    case "iterm": {
+      return "iTerm2 shows these only once Notification Center Alerts is on under Settings \u203A Profiles \u203A Terminal";
+    }
+    case "apple-terminal": {
+      return channel === "auto" ? "Terminal.app ignores terminal notifications, so auto takes the platform command here" : "Terminal.app ignores terminal notifications \xB7 switch the channel to auto, command, or bell";
+    }
+    default: {
+      return null;
+    }
+  }
+}
+var HELPER_BINARY = "pr-stats.app/Contents/MacOS/pr-stats-notifier";
+var HELPER_NAME = "pr-stats.app";
+var HELPER_DENIED_EXIT = 3;
+var PROMPT_GRACE_MS = 5e3;
+var helperLookup;
+function notificationHelper() {
+  if (helperLookup === void 0) {
+    helperLookup = locateHelper();
+  }
+  return helperLookup;
+}
+function locateHelper() {
+  if (process.platform !== "darwin") {
+    return null;
+  }
+  for (const base of ["./", "../../../dist/"]) {
+    const path = fileURLToPath(new URL(base + HELPER_BINARY, import.meta.url));
+    if (existsSync(path)) {
+      return path;
+    }
+  }
+  return null;
+}
+function notificationTool(helper = notificationHelper()) {
   switch (process.platform) {
     case "darwin": {
-      return "osascript";
+      return helper === null ? "osascript" : HELPER_NAME;
     }
     case "linux": {
       return "notify-send";
@@ -4203,9 +4279,12 @@ function notificationTool() {
 function escapeMarkup(text) {
   return text.replaceAll("&", "&amp;").replaceAll("<", "&lt;").replaceAll(">", "&gt;");
 }
-function notifyCommand(title, body) {
+function notifyCommand(title, body, helper = notificationHelper()) {
   switch (process.platform) {
     case "darwin": {
+      if (helper !== null) {
+        return { command: helper, args: [title, body], name: HELPER_NAME };
+      }
       return {
         command: "osascript",
         args: [
@@ -4217,31 +4296,54 @@ function notifyCommand(title, body) {
           "end run",
           title,
           body
-        ]
+        ],
+        name: "osascript"
       };
     }
     case "linux": {
-      return { command: "notify-send", args: ["--app-name=pr-stats", "--", title, escapeMarkup(body)] };
+      return {
+        command: "notify-send",
+        args: ["--app-name=pr-stats", "--", title, escapeMarkup(body)],
+        name: "notify-send"
+      };
     }
     default: {
       return null;
     }
   }
 }
-function sendNotification(title, body, onError) {
-  const spec = notifyCommand(title, body);
+var spawnDetached = (command, args) => spawn(command, args, { stdio: "ignore", detached: true });
+var runningHelpers = /* @__PURE__ */ new Set();
+function sendNotification(title, body, onError, spawnProcess = spawnDetached, helper = notificationHelper()) {
+  const spec = notifyCommand(title, body, helper);
   if (spec === null) {
     onError("desktop notifications are not supported on this platform");
     return;
   }
-  const child = spawn(spec.command, spec.args, { stdio: "ignore", detached: true });
+  const isHelper = spec.name === HELPER_NAME;
+  const run = { started: Date.now() };
+  if (isHelper && [...runningHelpers].some(({ started }) => run.started - started > PROMPT_GRACE_MS)) {
+    onError("the notification permission prompt for pr-stats is still waiting for an answer");
+    return;
+  }
+  const child = spawnProcess(spec.command, spec.args);
+  if (isHelper) {
+    runningHelpers.add(run);
+  }
   child.on("error", (error) => {
+    runningHelpers.delete(run);
     onError(`could not send the notification (${error.message})`);
   });
   child.on("exit", (code) => {
-    if (code !== null && code !== 0) {
-      onError(`could not send the notification (${spec.command} exited with ${code})`);
+    runningHelpers.delete(run);
+    if (code === null || code === 0) {
+      return;
+    }
+    if (isHelper && code === HELPER_DENIED_EXIT) {
+      onError("notifications for pr-stats are turned off, allow them under System Settings \u203A Notifications \u203A pr-stats");
+      return;
     }
+    onError(`could not send the notification (${spec.name} exited with ${code})`);
   });
   child.unref();
 }
@@ -4273,9 +4375,11 @@ function SettingsModal({
   onSubmit
 }) {
   const message = cacheAction === null ? null : CACHE_MESSAGES[cacheAction];
-  const renderer2 = useRenderer2();
+  const renderer2 = notificationBoundary(useRenderer2());
   const channelValue = notifyChannel2 === "command" ? notificationTool() ?? "unsupported" : notifyChannel2;
   const deliveryValue = notificationChannel(renderer2, notifyChannel2) ?? "unsupported";
+  const caveat = SETTINGS[selected].key === "testNotification" ? notificationCaveat(renderer2, notifyChannel2) : null;
+  const bottomLine = error !== null ? { text: error, fg: theme.error } : message !== null ? { text: message.text, fg: message.warn ? theme.warn : theme.muted } : caveat !== null ? { text: caveat, fg: theme.warn } : { text: SETTINGS[selected].hint, fg: theme.muted };
   return /* @__PURE__ */ jsxs11(ModalFrame, { title: "Settings", children: [
     SECTIONS2.map((section) => /* @__PURE__ */ jsxs11("box", { flexDirection: "column", marginBottom: 1, children: [
       /* @__PURE__ */ jsx12("text", { wrapMode: "none", fg: theme.accent, marginLeft: 2, children: section.title }),
@@ -4302,17 +4406,7 @@ function SettingsModal({
         ) }, setting.key);
       })
     ] }, section.title)),
-    /* @__PURE__ */ jsx12(
-      "text",
-      {
-        wrapMode: "word",
-        height: 2,
-        fg: error !== null ? theme.error : message?.warn ? theme.warn : theme.muted,
-        marginLeft: 2,
-        marginRight: 2,
-        children: error ?? message?.text ?? SETTINGS[selected].hint
-      }
-    )
+    /* @__PURE__ */ jsx12("text", { wrapMode: "word", height: 2, fg: bottomLine.fg, marginLeft: 2, marginRight: 2, children: bottomLine.text })
   ] });
 }
 function SettingValue({
@@ -4782,7 +4876,7 @@ function buildSizeRepoOptions(raw) {
 }
 function pendingDetail(counts) {
   const awaiting = `${counts.awaiting} ${counts.awaiting === 1 ? "PR" : "PRs"} awaiting your review`;
-  return awaiting + (counts.reviewing > 0 ? `, ${counts.reviewing} reviewing` : "");
+  return awaiting + (counts.reviewing > 0 ? `, ${counts.reviewing} reviewed` : "");
 }
 function buildPendingRepoOptions(raw) {
   const countsByRepo = /* @__PURE__ */ new Map();
@@ -6905,7 +6999,10 @@ function App({
   const [notifyChannel2, setNotifyChannel] = useState4(initialNotifyChannel);
   const [copyLinks2, setCopyLinks] = useState4(initialCopyLinks);
   const [themeState, setThemeState] = useState4(initialTheme);
-  const defaultNotify = useMemo2(() => createNotifier(renderer2, notifyChannel2), [renderer2, notifyChannel2]);
+  const defaultNotify = useMemo2(
+    () => createNotifier(notificationBoundary(renderer2), notifyChannel2),
+    [renderer2, notifyChannel2]
+  );
   const notifier = notify ?? defaultNotify;
   const copyRow = (row) => {
     copyLink(row.url, (message) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@d3lm/pr-stats",
-  "version": "0.2.14",
+  "version": "0.2.16",
   "description": "GitHub PR stats in an interactive terminal UI, via the gh CLI or an access token",
   "type": "module",
   "author": "Dominic Elm",
@@ -33,6 +33,7 @@
     "build": "pnpm build:app && pnpm build:bin",
     "build:app": "esbuild src/tui/main.tsx --bundle --platform=node --format=esm --target=esnext --jsx=automatic --jsx-import-source=@opentui/react --external:@opentui/core --external:@opentui/react --external:react --outfile=dist/tui-app.mjs",
     "build:bin": "esbuild src/tui/launch.ts --platform=node --format=esm --target=node20 --outfile=dist/tui.mjs",
+    "build:notifier": "bash scripts/build-notifier.sh",
     "tui": "bun src/tui/main.tsx",
     "tui:node": "pnpm build && node dist/tui.mjs",
     "check": "tsc --noEmit",