@d3lm/pr-stats 0.2.14 → 0.2.15

package/README.md

@@ -125,11 +125,13 @@ The Desktop notifications row in the settings dialog makes the TUI send a deskto
 }
 ```
 
-Notifications go through the terminal itself when it supports a notification escape sequence, which covers iTerm2, Kitty, Ghostty, WezTerm, and most VTE-based terminals like GNOME Terminal. The terminal posts the notification under its own notification permission and the sequence travels through SSH, so this path needs no setup. Some terminals only show the banner while their window is unfocused. Terminals without such support get the platform's own command instead, `osascript` on macOS and `notify-send` on Linux. A notification that fails to send reports in the footer, for example when `notify-send` is missing on a Linux machine.
+Notifications go through the terminal itself when it supports a notification escape sequence, which covers iTerm2, Kitty, Ghostty, WezTerm, and most VTE-based terminals like GNOME Terminal. The terminal posts the notification under its own notification permission and the sequence travels through SSH, so this path needs no setup beyond what the terminal asks for. Some terminals only show the banner while their window is unfocused. Terminals without such support get the platform's own command instead, `osascript` on macOS and `notify-send` on Linux. A notification that fails to send reports in the footer, for example when `notify-send` is missing on a Linux machine.
 
-The "Notification channel" row picks the path, and the choice persists as `notifyChannel` with the values `auto`, `terminal`, and `command`. On `auto` the TUI tries the terminal first and falls back to the platform command, while the other two force one path. The dialog shows the `command` value as the command's name on this platform. Forcing the command pays off inside editor terminals like the one in VS Code, which render the terminal path as a small in-editor toast instead of a system notification. The "Send test notification" row below it names the channel the next send takes and sends a sample notification, so you can check that your desktop displays it before relying on it.
+The "Notification channel" row picks the path, and the choice persists as `notifyChannel` with the values `auto`, `terminal`, `command`, and `bell`. On `auto` the TUI tries the terminal first and falls back to the platform command, `terminal` and `command` force one of those paths, and `bell` rings the terminal bell instead of posting any text. The dialog shows the `command` value as the command's name on this platform. Forcing the command pays off inside editor terminals like the one in VS Code, which render the terminal path as a small in-editor toast instead of a system notification. The bell reaches every terminal, including the ones that swallow notifications, and each terminal turns it into its own signal, a sound, a flashing screen, a bell icon on the tab, or a badge on the dock icon. The "Send test notification" row below the channel names the channel the next send takes and sends a sample notification, so you can check that your desktop displays it before relying on it.
 
-The macOS fallback posts through the built-in Script Editor, and since macOS 15 those notifications stay invisible until Script Editor holds notification permission, without any prompt appearing. To grant it once, open the Script Editor app, run the one-line script `display notification "test"`, and allow the prompt that appears. Script Editor then shows up under Notifications in the System Settings like any other app.
+Two terminals accept the notification sequence without showing anything, and the test row warns about both. iTerm2 drops it until the profile has "Notification Center Alerts" turned on under Settings → Profiles → Terminal, which is off by default. Behind the "Filter Alerts…" button next to it, "Send escape sequence-generated alerts" has to stay on as well, and macOS asks for iTerm2's notification permission on the first send. iTerm2 prefixes the banner with the session name unless its advanced setting "Omit session identifier from notifications" is on. Apple Terminal never implemented the sequence at all, so `auto` skips the terminal there and goes straight to the platform command.
+
+The macOS command posts through the built-in Script Editor, and since macOS 15 those notifications stay invisible until Script Editor holds notification permission, without any prompt appearing. To grant it once, open the Script Editor app, run the one-line script `display notification "test"`, and allow the prompt that appears. Script Editor then shows up under Notifications in the System Settings like any other app.
 
 ## Theming
 

package/dist/tui-app.mjs

@@ -279,7 +279,7 @@ function percentile(sorted, percent) {
 }
 
 // src/settings.ts
-var NOTIFY_CHANNELS = ["auto", "terminal", "command"];
+var NOTIFY_CHANNELS = ["auto", "terminal", "command", "bell"];
 var DEFAULT_RELOAD_INTERVAL = "10m";
 var MAX_RELOAD_INTERVAL_MS = 24 * 60 * 60 * 1e3;
 function reloadIntervalMs(input) {
@@ -348,7 +348,7 @@ function loadSettings() {
     throw new CliError(`"notifications" in ${settingsFile()} must be true or false`);
   }
   if (settings.notifyChannel !== void 0 && !NOTIFY_CHANNELS.includes(settings.notifyChannel)) {
-    throw new CliError(`"notifyChannel" in ${settingsFile()} must be "auto", "terminal", or "command"`);
+    throw new CliError(`"notifyChannel" in ${settingsFile()} must be "auto", "terminal", "command", or "bell"`);
   }
   current = settings;
   return current;
@@ -4095,7 +4095,7 @@ var SETTINGS = [
     key: "notifyChannel",
     section: "Notifications",
     label: "Notification channel",
-    hint: "auto posts through the terminal and falls back to the platform command \xB7 the other values force one channel"
+    hint: "auto tries the terminal, then the platform command \xB7 the others force one path \xB7 bell rings the terminal bell"
   },
   {
     key: "testNotification",
@@ -4169,24 +4169,75 @@ var CACHE_MESSAGES = {
 
 // src/tui/utils/notify.ts
 import { spawn } from "node:child_process";
+function notificationBoundary(renderer2) {
+  const raw = renderer2;
+  return {
+    get capabilities() {
+      return renderer2.capabilities;
+    },
+    triggerNotification: (message, title) => renderer2.triggerNotification(message, title),
+    writeOut: (data) => {
+      if (typeof raw.writeOut === "function") {
+        raw.writeOut(data);
+      } else {
+        process.stdout.write(data);
+      }
+    }
+  };
+}
+var BELL = "\x07";
+function terminalQuirk(renderer2) {
+  const name = renderer2.capabilities?.terminal.name ?? "";
+  if (/iterm/i.test(name)) {
+    return "iterm";
+  }
+  if (/apple_terminal|terminal\.app/i.test(name)) {
+    return "apple-terminal";
+  }
+  return null;
+}
 function createNotifier(renderer2, channel) {
   return (title, body, onError) => {
-    if (channel !== "command" && renderer2.triggerNotification(body, title)) {
+    if (channel === "bell") {
+      renderer2.writeOut(BELL);
+      return;
+    }
+    const tryTerminal = channel === "terminal" || channel === "auto" && terminalQuirk(renderer2) !== "apple-terminal";
+    if (tryTerminal && renderer2.triggerNotification(body, title)) {
       return;
     }
     if (channel === "terminal") {
-      onError("the terminal has no notification support, switch the channel to auto or the platform command");
+      onError("the terminal has no notification support, switch the channel to auto, the platform command, or bell");
       return;
     }
     sendNotification(title, body, onError);
   };
 }
 function notificationChannel(renderer2, channel) {
-  if (channel === "terminal" || channel === "auto" && renderer2.capabilities?.notifications === true) {
+  if (channel === "bell" || channel === "terminal") {
+    return channel;
+  }
+  if (channel === "auto" && renderer2.capabilities?.notifications === true && terminalQuirk(renderer2) !== "apple-terminal") {
     return "terminal";
   }
   return notificationTool();
 }
+function notificationCaveat(renderer2, channel) {
+  if (channel === "command" || channel === "bell") {
+    return null;
+  }
+  switch (terminalQuirk(renderer2)) {
+    case "iterm": {
+      return "iTerm2 shows these only once Notification Center Alerts is on under Settings \u203A Profiles \u203A Terminal";
+    }
+    case "apple-terminal": {
+      return channel === "auto" ? "Terminal.app ignores terminal notifications, so auto takes the platform command here" : "Terminal.app ignores terminal notifications \xB7 switch the channel to auto, command, or bell";
+    }
+    default: {
+      return null;
+    }
+  }
+}
 function notificationTool() {
   switch (process.platform) {
     case "darwin": {
@@ -4273,9 +4324,11 @@ function SettingsModal({
   onSubmit
 }) {
   const message = cacheAction === null ? null : CACHE_MESSAGES[cacheAction];
-  const renderer2 = useRenderer2();
+  const renderer2 = notificationBoundary(useRenderer2());
   const channelValue = notifyChannel2 === "command" ? notificationTool() ?? "unsupported" : notifyChannel2;
   const deliveryValue = notificationChannel(renderer2, notifyChannel2) ?? "unsupported";
+  const caveat = SETTINGS[selected].key === "testNotification" ? notificationCaveat(renderer2, notifyChannel2) : null;
+  const bottomLine = error !== null ? { text: error, fg: theme.error } : message !== null ? { text: message.text, fg: message.warn ? theme.warn : theme.muted } : caveat !== null ? { text: caveat, fg: theme.warn } : { text: SETTINGS[selected].hint, fg: theme.muted };
   return /* @__PURE__ */ jsxs11(ModalFrame, { title: "Settings", children: [
     SECTIONS2.map((section) => /* @__PURE__ */ jsxs11("box", { flexDirection: "column", marginBottom: 1, children: [
       /* @__PURE__ */ jsx12("text", { wrapMode: "none", fg: theme.accent, marginLeft: 2, children: section.title }),
@@ -4302,17 +4355,7 @@ function SettingsModal({
         ) }, setting.key);
       })
     ] }, section.title)),
-    /* @__PURE__ */ jsx12(
-      "text",
-      {
-        wrapMode: "word",
-        height: 2,
-        fg: error !== null ? theme.error : message?.warn ? theme.warn : theme.muted,
-        marginLeft: 2,
-        marginRight: 2,
-        children: error ?? message?.text ?? SETTINGS[selected].hint
-      }
-    )
+    /* @__PURE__ */ jsx12("text", { wrapMode: "word", height: 2, fg: bottomLine.fg, marginLeft: 2, marginRight: 2, children: bottomLine.text })
   ] });
 }
 function SettingValue({
@@ -6905,7 +6948,10 @@ function App({
   const [notifyChannel2, setNotifyChannel] = useState4(initialNotifyChannel);
   const [copyLinks2, setCopyLinks] = useState4(initialCopyLinks);
   const [themeState, setThemeState] = useState4(initialTheme);
-  const defaultNotify = useMemo2(() => createNotifier(renderer2, notifyChannel2), [renderer2, notifyChannel2]);
+  const defaultNotify = useMemo2(
+    () => createNotifier(notificationBoundary(renderer2), notifyChannel2),
+    [renderer2, notifyChannel2]
+  );
   const notifier = notify ?? defaultNotify;
   const copyRow = (row) => {
     copyLink(row.url, (message) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@d3lm/pr-stats",
-  "version": "0.2.14",
+  "version": "0.2.15",
   "description": "GitHub PR stats in an interactive terminal UI, via the gh CLI or an access token",
   "type": "module",
   "author": "Dominic Elm",