@d3lm/pr-stats 0.2.10 → 0.2.12

package/dist/tui-app.mjs

@@ -558,11 +558,11 @@ function Footer({
   views,
   copyLinks: copyLinks2,
   openError,
-  copyNotice,
+  successNotice,
   stale
 }) {
-  const notice = openError ?? copyNotice ?? (stale ? "options changed \xB7 press r to reload" : "");
-  const check = openError === null && copyNotice !== null;
+  const notice = openError ?? successNotice ?? (stale ? "options changed \xB7 press r to reload" : "");
+  const check = openError === null && successNotice !== null;
   const noticeWidth = notice === "" ? 0 : notice.length + (check ? 2 : 0) + 2;
   const hints = truncated(hintsFor(modal, editing, tab, authoredTab, views, copyLinks2), width - 2 - noticeWidth);
   return /* @__PURE__ */ jsxs(Fragment, { children: [
@@ -580,7 +580,7 @@ function Footer({
           /* @__PURE__ */ jsx("text", { wrapMode: "none", fg: theme.dim, children: hints }),
           /* @__PURE__ */ jsxs("text", { wrapMode: "none", children: [
             check && /* @__PURE__ */ jsx("span", { fg: theme.success, children: "\u2714 " }),
-            /* @__PURE__ */ jsx("span", { fg: openError !== null ? theme.error : copyNotice !== null ? theme.muted : theme.warn, children: notice })
+            /* @__PURE__ */ jsx("span", { fg: openError !== null ? theme.error : successNotice !== null ? theme.muted : theme.warn, children: notice })
           ] })
         ]
       }
@@ -2361,6 +2361,12 @@ var OPTIONS = [
     placeholder: "<value>",
     help: "Report how many reviews finished within this time. Accepts hours (`24h` or plain `24`), minutes (`90m`), or days (`2d`). A day means 24 counted hours, or one working day when --work-hours is set. Open PRs that have already waited longer than the target count as misses."
   },
+  {
+    name: "target-percentile",
+    type: "string",
+    placeholder: "<p>",
+    help: "Check the --target against this percentile of your review times. Accepts a whole percentile from 1 to 100, with an optional p prefix (`90` or `p90`). The default is `90`, so the review headline reports whether your p90 review time meets the target."
+  },
   {
     name: "size-target",
     type: "string",
@@ -2525,6 +2531,15 @@ function parseTarget(input) {
   }
   return amount;
 }
+var DEFAULT_TARGET_PERCENTILE = 90;
+function parseTargetPercentile(input) {
+  const match = /^p?(\d{1,3})$/i.exec(input);
+  const value2 = match === null ? Number.NaN : Number(match[1]);
+  if (!Number.isInteger(value2) || value2 < 1 || value2 > 100) {
+    throw new CliError(`invalid --target-percentile value "${input}", use a percentile from 1 to 100 like 90 or p90`);
+  }
+  return value2;
+}
 function parseSizeTarget(input) {
   const target = {};
   for (const part of input.split(",")) {
@@ -2651,6 +2666,13 @@ var FIELDS = [
     kind: "text",
     fetch: false
   },
+  {
+    key: "targetPercentile",
+    label: "Target percentile",
+    hint: "the percentile the review target checks, like 90 or p99, empty means p90",
+    kind: "text",
+    fetch: false
+  },
   {
     key: "sizeTarget",
     label: "Size target",
@@ -2713,6 +2735,10 @@ function validateField(key, value2) {
       parseTarget(value2);
       break;
     }
+    case "targetPercentile": {
+      parseTargetPercentile(value2);
+      break;
+    }
     case "sizeTarget": {
       parseSizeTarget(value2);
       break;
@@ -2741,6 +2767,7 @@ function readSavedOptions() {
   }
   const record = value2;
   record.reviewTypes ??= "";
+  record.targetPercentile ??= "";
   const options = {};
   for (const field of FIELDS) {
     const raw = record[field.key];
@@ -2784,6 +2811,9 @@ function applySavedOptions(values, explicit) {
   if (!explicit.has("target") && saved2.target !== "") {
     values.target = saved2.target;
   }
+  if (!explicit.has("target-percentile") && saved2.targetPercentile !== "") {
+    values["target-percentile"] = saved2.targetPercentile;
+  }
   if (!explicit.has("size-target") && saved2.sizeTarget !== "") {
     values["size-target"] = saved2.sizeTarget;
   }
@@ -2880,6 +2910,7 @@ var EMPTY_PLACEHOLDERS = {
   repos: "(all accessible)",
   user: "(authenticated user)",
   target: "(none)",
+  targetPercentile: "(p90)",
   sizeTarget: "(none)",
   tz: "(system)",
   reviewTypes: "(every type)"
@@ -5170,9 +5201,17 @@ function buildVerdictCard(reviewed) {
     })
   });
 }
-function buildReviewView(raw, targetHours, targetLabel, repo = null, width = 100, expanded = false) {
+function targetStatus(sorted, target) {
+  const margin = target.hours - percentile(sorted, target.percentile);
+  if (margin < 0) {
+    return { text: `   ${formatDuration(-margin)} over the ${target.label} target`, fg: theme.error };
+  }
+  const lead = margin === 0 ? "at" : `${formatDuration(margin)} under`;
+  return { text: `   ${lead} the ${target.label} target`, fg: theme.success };
+}
+function buildReviewView(raw, target, repo = null, width = 100, expanded = false) {
   const results = repo === null ? raw.reviewResults : raw.reviewResults.filter((result) => result.pr.repo === repo);
-  const stats = computeReviewStats(results, { targetHours, now: raw.fetchedAt });
+  const stats = computeReviewStats(results, { targetHours: target?.hours, now: raw.fetchedAt });
   const strip = [
     countCell(stats.reviewed.length, "reviewed on request"),
     countCell(stats.pending.length, "awaiting you", true),
@@ -5193,9 +5232,9 @@ function buildReviewView(raw, targetHours, targetLabel, repo = null, width = 100
     return { empty: "No reviewed or review-requested PRs found.", ...base, lists: [] };
   }
   const lists = [];
-  if (targetHours !== void 0 && stats.misses.length > 0) {
+  if (target !== void 0 && stats.misses.length > 0) {
     lists.push({
-      title: `Reviews that missed the <= ${targetLabel} target`,
+      title: `Reviews that missed the <= ${target.label} target`,
       rows: toPrRows(stats.misses, stats.misses.map(durationLead))
     });
   }
@@ -5211,11 +5250,19 @@ function buildReviewView(raw, targetHours, targetLabel, repo = null, width = 100
   }
   const sorted = [...stats.allHours].toSorted((a, b) => a - b);
   const total = raw.reviewResults.filter((result) => result.kind === "reviewed").length;
+  const secondPercentile = target === void 0 || target.percentile === 50 ? 90 : target.percentile;
+  const percentileColor = (percent) => {
+    if (target === void 0 || percent !== target.percentile) {
+      return theme.accent;
+    }
+    return percentile(sorted, target.percentile) <= target.hours ? theme.success : theme.error;
+  };
   const headline = [
     { text: "p50 ", fg: theme.muted },
-    { text: formatDuration(percentile(sorted, 50)), fg: theme.accent },
-    { text: "   p90 ", fg: theme.muted },
-    { text: formatDuration(percentile(sorted, 90)), fg: theme.accent },
+    { text: formatDuration(percentile(sorted, 50)), fg: percentileColor(50) },
+    { text: `   p${secondPercentile} `, fg: theme.muted },
+    { text: formatDuration(percentile(sorted, secondPercentile)), fg: percentileColor(secondPercentile) },
+    ...target === void 0 ? [] : [targetStatus(sorted, target)],
     { text: `   ${stats.reviewed.length} of ${total} reviews`, fg: theme.muted }
   ];
   const requestDates = [...stats.reviewed, ...stats.pending].map((entry) => entry.requestedAt);
@@ -5224,15 +5271,15 @@ function buildReviewView(raw, targetHours, targetLabel, repo = null, width = 100
     (entry) => durationHours(entry.pr.createdAt, entry.requestedAt)
   );
   let serviceCard = null;
-  if (targetHours !== void 0 && targetLabel !== void 0) {
-    const inside = stats.allHours.filter((value2) => value2 <= targetHours).length;
-    const overdue = stats.pending.filter((entry) => entry.hours > targetHours).length;
+  if (target !== void 0) {
+    const inside = stats.allHours.filter((value2) => value2 <= target.hours).length;
+    const overdue = stats.pending.filter((entry) => entry.hours > target.hours).length;
     serviceCard = buildGaugeCard({
       title: "Service level",
-      subtitle: `reviewed within ${targetLabel}`,
+      subtitle: `reviewed within ${target.label}`,
       rows: [
-        { label: `inside ${targetLabel}`, count: inside, color: theme.accent },
-        { label: `over ${targetLabel}`, count: stats.allHours.length - inside, color: theme.chartDim },
+        { label: `inside ${target.label}`, count: inside, color: theme.accent },
+        { label: `over ${target.label}`, count: stats.allHours.length - inside, color: theme.chartDim },
         ...overdue > 0 ? [{ label: "awaiting and already over", count: overdue, color: theme.warn }] : []
       ]
     });
@@ -5254,6 +5301,7 @@ function buildReviewView(raw, targetHours, targetLabel, repo = null, width = 100
     expanded
   }) : null;
   const cards = [
+    ...serviceCard === null ? [] : [serviceCard],
     buildHistogramCard({
       title: "Time to review",
       subtitle: "elapsed time, request \u2192 review",
@@ -5306,7 +5354,6 @@ function buildReviewView(raw, targetHours, targetLabel, repo = null, width = 100
     buildVerdictCard(stats.reviewed),
     ...pendingCard === null ? [] : [pendingCard],
     buildOffHoursCard("reviews submitted, local time", reviewDates),
-    ...serviceCard === null ? [] : [serviceCard],
     ...byRepoCard === null ? [] : [byRepoCard]
   ];
   const distribution = buildDistribution({
@@ -5760,7 +5807,12 @@ function useViewModel(raw, options, width, scopes, grouping, expanded, themeEpoc
     if (!raw) {
       return null;
     }
-    const targetHours = options.target === "" ? void 0 : parseTarget(options.target);
+    const targetLabel = targetLabelOf(options.target);
+    const reviewTarget = targetLabel === void 0 ? void 0 : {
+      hours: parseTarget(options.target),
+      label: targetLabel,
+      percentile: options.targetPercentile === "" ? DEFAULT_TARGET_PERCENTILE : parseTargetPercentile(options.targetPercentile)
+    };
     const sizeTarget = options.sizeTarget === "" ? void 0 : parseSizeTarget(options.sizeTarget);
     const pendingRepos = buildPendingRepoOptions(raw);
     const openRepos = buildOpenRepoOptions(raw);
@@ -5774,7 +5826,7 @@ function useViewModel(raw, options, width, scopes, grouping, expanded, themeEpoc
     const reviewScope = resolveScope(scopes.review, reviewRepos);
     const sizeScope = resolveScope(scopes.size, sizeRepos);
     const commentScope = resolveScope(scopes.comment, commentRepos);
-    const review = reviewScope.view === "detail" ? buildReviewView(raw, targetHours, targetLabelOf(options.target), reviewScope.repo, width, expanded.review) : null;
+    const review = reviewScope.view === "detail" ? buildReviewView(raw, reviewTarget, reviewScope.repo, width, expanded.review) : null;
     return {
       pendingRepos,
       openRepos,
@@ -5801,6 +5853,7 @@ function useViewModel(raw, options, width, scopes, grouping, expanded, themeEpoc
     options.tz,
     options.wallClock,
     options.target,
+    options.targetPercentile,
     options.sizeTarget,
     width,
     scopes.pending,
@@ -5999,7 +6052,7 @@ function queueTabOf(context) {
 }
 function handleQueueKey(key, context) {
   const { key: tab, view, repos, scope } = queueTabOf(context);
-  if (scope !== null && scope.view === "list") {
+  if (scope?.view === "list") {
     switch (key.name) {
       case "up":
       case "k": {
@@ -6091,7 +6144,7 @@ function statsTabOf(context) {
 }
 function handleStatsKey(key, context) {
   const { key: tab, repos, scope, view } = statsTabOf(context);
-  if (scope !== null && scope.view === "list") {
+  if (scope?.view === "list") {
     switch (key.name) {
       case "up":
       case "k": {
@@ -6177,7 +6230,7 @@ var initialUiState = {
   themeColorError: null,
   cacheAction: null,
   openError: null,
-  copyNotice: null
+  successNotice: null
 };
 function cycled2(previous, delta, count2) {
   return (previous + count2 + delta) % count2;
@@ -6185,19 +6238,19 @@ function cycled2(previous, delta, count2) {
 function uiReducer(state, action) {
   switch (action.type) {
     case "noticesDismissed": {
-      if (state.openError === null && state.copyNotice === null) {
+      if (state.openError === null && state.successNotice === null) {
         return state;
       }
-      return { ...state, openError: null, copyNotice: null };
+      return { ...state, openError: null, successNotice: null };
     }
     case "openErrorReported": {
       return { ...state, openError: action.message };
     }
     case "copyReported": {
-      return { ...state, openError: null, copyNotice: { text: action.message } };
+      return { ...state, openError: null, successNotice: { text: action.message } };
     }
-    case "copyNoticeExpired": {
-      return { ...state, copyNotice: null };
+    case "successNoticeExpired": {
+      return { ...state, successNotice: null };
     }
     case "modalOpened": {
       return { ...state, modal: action.modal, fieldError: null, themeColorError: null, cacheAction: null };
@@ -6245,10 +6298,10 @@ function uiReducer(state, action) {
       return { ...state, fieldError: action.message };
     }
     case "optionsSaveReported": {
-      return {
-        ...state,
-        fieldError: action.saved ? null : "the cache is disabled for this session \xB7 options not saved"
-      };
+      if (action.saved) {
+        return { ...state, fieldError: null, successNotice: { text: "options saved" } };
+      }
+      return { ...state, fieldError: "the cache is disabled for this session \xB7 options not saved" };
     }
     case "themeColorCommitted": {
       return { ...state, editing: false, themeColorError: null, cacheAction: action.action };
@@ -6351,16 +6404,16 @@ function App({
     dispatchUi({ type: "copyReported", message: `copied ${row.ref} to the clipboard` });
   };
   useEffect6(() => {
-    if (ui.copyNotice === null) {
+    if (ui.successNotice === null) {
       return void 0;
     }
     const timer = setTimeout(() => {
-      dispatchUi({ type: "copyNoticeExpired" });
+      dispatchUi({ type: "successNoticeExpired" });
     }, 2500);
     return () => {
       clearTimeout(timer);
     };
-  }, [ui.copyNotice]);
+  }, [ui.successNotice]);
   const reviewScrollRef = useRef5(null);
   const sizeScrollRef = useRef5(null);
   const commentScrollRef = useRef5(null);
@@ -6477,7 +6530,7 @@ function App({
         views,
         copyLinks: copyLinks2,
         openError: ui.openError,
-        copyNotice: ui.copyNotice === null ? null : ui.copyNotice.text,
+        successNotice: ui.successNotice === null ? null : ui.successNotice.text,
         stale
       }
     ),
@@ -6523,6 +6576,7 @@ function bootstrap() {
       repos: values.repo.join(","),
       user: values.user ?? "",
       target: values.target ?? "",
+      targetPercentile: values["target-percentile"] ?? "",
       sizeTarget: values["size-target"] ?? "",
       workHours: values["work-hours"],
       tz: values.tz ?? "",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@d3lm/pr-stats",
-  "version": "0.2.10",
+  "version": "0.2.12",
   "description": "GitHub PR stats in an interactive terminal UI, via the gh CLI or an access token",
   "type": "module",
   "author": "Dominic Elm",
@@ -43,7 +43,7 @@
     "prepublishOnly": "pnpm build"
   },
   "dependencies": {
-    "@d3lm/lint-preset": "^1.1.7",
+    "@d3lm/lint-preset": "^1.2.0",
     "@opentui/core": "^0.5.8",
     "@opentui/react": "^0.5.8",
     "asciichart": "^1.5.25",