@czottmann/pi-automode 1.16.0 → 1.17.0

package/extensions/auto-mode/extension.ts

@@ -331,6 +331,10 @@ export function createPiAutomode(options: PiAutomodeOptions = {}) {
       };
     }
 
+    function blockedToolReason(reason: string): string {
+      return `[pi-automode] Action blocked; the tool did not run. ${reason} Do not claim success, rely on effects from this call, or attempt an equivalent workaround. Report the block to the user before continuing with dependent work. Independent work can continue.`;
+    }
+
     function block(
       ctx: ExtensionContext,
       denial: DenialRecord,
@@ -364,7 +368,10 @@ export function createPiAutomode(options: PiAutomodeOptions = {}) {
           "warning",
         );
       }
-      return { block: true, reason: `[pi-automode] ${denial.reason}` };
+      return {
+        block: true,
+        reason: blockedToolReason(denial.reason),
+      };
     }
 
     function allow(
@@ -440,11 +447,38 @@ export function createPiAutomode(options: PiAutomodeOptions = {}) {
       // 7. classifier for every remaining action, fail-closed on setup/parse errors.
       const cfg = effectiveConfig();
       if (!cfg.enabled) return undefined;
-      if (ctx.signal?.aborted) return { block: true, reason: "Cancelled" };
+
+      const input = event.input as Record<string, unknown>;
+      const summary = actionSummary(event.toolName, input);
+      const logCtx: LogCtx = {
+        logger: createLogger({
+          enabled: cfg.log.enabled,
+          classifierIo: cfg.log.classifierIo,
+          sessionFile: ctx.sessionManager.getSessionFile?.(),
+          sessionDir: ctx.sessionManager.getSessionDir?.() ?? "",
+          sessionCwd: ctx.cwd,
+          sessionId: ctx.sessionManager.getSessionId?.() ?? "unknown",
+          logRoot: options.logRoot,
+          now: now(),
+        }),
+        decisionId: newDecisionId(),
+        classifierModel: cfg.classifierModel,
+        reasoning: classifierReasoningForConfig(cfg.classifierReasoningLevel),
+      };
+
+      if (ctx.signal?.aborted) {
+        state.checkedActions += 1;
+        return block(ctx, {
+          timestamp: Date.now(),
+          toolName: event.toolName,
+          reason: "Cancelled",
+          action: summary,
+          kind: "setup",
+        }, logCtx);
+      }
 
       const isOwnedInspection = event.toolName === INSPECT_TOOL &&
         ownsInspectionTool();
-      const input = event.input as Record<string, unknown>;
       let bashAnalysis: BashAnalysis | undefined;
       if (event.toolName === "bash") {
         const source = typeof input.command === "string" ? input.command : "";
@@ -466,23 +500,7 @@ export function createPiAutomode(options: PiAutomodeOptions = {}) {
           };
         }
       }
-      const summary = actionSummary(event.toolName, input);
       if (!isOwnedInspection) state.checkedActions += 1;
-      const logCtx: LogCtx = {
-        logger: createLogger({
-          enabled: cfg.log.enabled,
-          classifierIo: cfg.log.classifierIo,
-          sessionFile: ctx.sessionManager.getSessionFile?.(),
-          sessionDir: ctx.sessionManager.getSessionDir?.() ?? "",
-          sessionCwd: ctx.cwd,
-          sessionId: ctx.sessionManager.getSessionId?.() ?? "unknown",
-          logRoot: options.logRoot,
-          now: now(),
-        }),
-        decisionId: newDecisionId(),
-        classifierModel: cfg.classifierModel,
-        reasoning: classifierReasoningForConfig(cfg.classifierReasoningLevel),
-      };
 
       for (const pattern of cfg.permissionDeny) {
         if (

package/extensions/auto-mode/permissions.ts

@@ -74,6 +74,16 @@ export function parseToolPattern(value: unknown): ToolPattern | undefined {
   return pattern;
 }
 
+/** Return whether a parsed permission entry is malformed. */
+export function isMalformedToolPattern(pattern: ToolPattern): boolean {
+  if (!pattern.toolName) return true;
+  if (pattern.argumentPattern === undefined) return false;
+  if (pattern.argumentPattern.trim() === "") return true;
+  return pattern.toolName === "bash" &&
+    (bashPatternAnalyses.get(pattern)?.errors.length ??
+        analyzeBash(pattern.argumentPattern).errors.length) > 0;
+}
+
 function literalPrefixTable(value: string): number[] {
   const table = new Array<number>(value.length).fill(0);
   let prefixLength = 0;
@@ -491,6 +501,93 @@ function redirectListsMatch(
   });
 }
 
+function containsUnquotedBracketExpression(text: string, start: number): boolean {
+  let index = start + 1;
+  if (text[index] === "!" || text[index] === "^") index += 1;
+  let hasMember = false;
+  if (text[index] === "]") {
+    hasMember = true;
+    index += 1;
+  }
+  let quote: "'" | '"' | "$'" | undefined;
+  for (; index < text.length; index += 1) {
+    const character = text[index];
+    if (quote) {
+      if (quote === "$'") {
+        if (character === "\\") {
+          if (index + 1 < text.length) {
+            hasMember = true;
+            index += 1;
+          }
+        } else if (character === "'") quote = undefined;
+        else hasMember = true;
+      } else {
+        if (character === quote) quote = undefined;
+        else if (quote === '"' && character === "\\") index += 1;
+        else hasMember = true;
+      }
+      continue;
+    }
+    if (character === "\\") {
+      if (index + 1 < text.length) {
+        hasMember = true;
+        index += 1;
+      }
+      continue;
+    }
+    if (character === "$" && text[index + 1] === "'") {
+      quote = "$'";
+      index += 1;
+      continue;
+    }
+    if (character === "'" || character === '"') {
+      quote = character;
+      continue;
+    }
+    if (character === "]") return hasMember;
+    hasMember = true;
+  }
+  return false;
+}
+
+function hasUnquotedPathnameExpansion(text: string): boolean {
+  let quote: "'" | '"' | "$'" | undefined;
+  for (let index = 0; index < text.length; index += 1) {
+    const character = text[index];
+    if (quote) {
+      if (quote === "$'") {
+        if (character === "\\") index += 1;
+        else if (character === "'") quote = undefined;
+      } else {
+        if (character === quote) quote = undefined;
+        else if (quote === '"' && character === "\\") index += 1;
+      }
+      continue;
+    }
+    if (character === "\\") {
+      index += 1;
+      continue;
+    }
+    if (character === "$" && text[index + 1] === "'") {
+      quote = "$'";
+      index += 1;
+      continue;
+    }
+    if (character === "'" || character === '"') {
+      quote = character;
+      continue;
+    }
+    if (character === "*" || character === "?") return true;
+    if (
+      character === "[" &&
+      containsUnquotedBracketExpression(text, index)
+    ) {
+      return true;
+    }
+  }
+  return false;
+}
+
 function commandMatchesAllowPattern(
   patternCommand: BashCommandAnalysis,
   inputCommand: BashCommandAnalysis,
@@ -560,7 +657,10 @@ export function matchesAllowedToolPatterns(
   }
   if (
     bashAnalysis.commands.some((command) =>
-      command.dynamicName || command.dynamicShellScript
+      command.dynamic ||
+      command.dynamicName ||
+      command.dynamicShellScript ||
+      command.argTexts.some(hasUnquotedPathnameExpansion)
     )
   ) {
     return false;

package/extensions/auto-mode/state.ts

@@ -20,7 +20,7 @@ export function statusLine(
   const classifier = state.classifierAllowed > 0 || state.classifierDenied > 0
     ? ` ca:${state.classifierAllowed} cd:${state.classifierDenied}`
     : "";
-  return `AM${circle} a:${allowed} d:${state.blockedActions}${classifier}`;
+  return `AM ${circle} a:${allowed} d:${state.blockedActions}${classifier}`;
 }
 
 export function statusText(

package/extensions/auto-mode/types.ts

@@ -154,6 +154,10 @@ export type ClassifierIoAttempt = {
   response?: {
     stopReason?: string;
     text: string;
+    toolCalls?: Array<{
+      name: string;
+      arguments: Record<string, unknown>;
+    }>;
     model: string;
     timestamp: number;
     usage: AssistantMessage["usage"];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@czottmann/pi-automode",
-  "version": "1.16.0",
+  "version": "1.17.0",
   "description": "Claude Code-style auto mode guardrail for pi.",
   "repository": {
     "url": "https://github.com/czottmann/pi-automode"
@@ -47,9 +47,9 @@
     "typebox": "*"
   },
   "devDependencies": {
-    "@earendil-works/pi-ai": "^0.84.1",
-    "@earendil-works/pi-coding-agent": "^0.84.1",
-    "@earendil-works/pi-tui": "^0.84.1",
+    "@earendil-works/pi-ai": "^0.86.0",
+    "@earendil-works/pi-coding-agent": "^0.86.0",
+    "@earendil-works/pi-tui": "^0.86.0",
     "@types/node": "^24.0.0",
     "tsx": "^4.22.4",
     "typebox": "^1.3.10",