@cynodia/axiom-core 0.6.0-alpha.1 → 0.6.2-alpha.1

package/README.md

@@ -21,13 +21,13 @@ builders, `Presentation`, `Theme`, `resolvePresentationMap`, `validateGraph`,
 ## Installation
 
 ```bash
-npm install @cynodia/axiom-core@alpha
+npm install @cynodia/axiom-core
 ```
 
 Most applications should install the facade package instead, which re-exports this one:
 
 ```bash
-npm install @cynodia/axiom@alpha
+npm install @cynodia/axiom
 ```
 
 

package/dist/diagnostics.d.ts

@@ -71,5 +71,6 @@ export declare const VALIDATION_CODES: {
     readonly principalReferenceOnClient: "PRINCIPAL_REFERENCE_ON_CLIENT";
     readonly serverOnlyStateObserved: "SERVER_ONLY_STATE_OBSERVED";
     readonly invalidPrincipalEntity: "INVALID_PRINCIPAL_ENTITY";
+    readonly missingActionArgument: "MISSING_ACTION_ARGUMENT";
 };
 //# sourceMappingURL=diagnostics.d.ts.map

package/dist/diagnostics.js

@@ -58,4 +58,5 @@ export const VALIDATION_CODES = {
     principalReferenceOnClient: 'PRINCIPAL_REFERENCE_ON_CLIENT',
     serverOnlyStateObserved: 'SERVER_ONLY_STATE_OBSERVED',
     invalidPrincipalEntity: 'INVALID_PRINCIPAL_ENTITY',
+    missingActionArgument: 'MISSING_ACTION_ARGUMENT',
 };

package/dist/graph.js

@@ -23,7 +23,7 @@ export class ApplicationGraph {
     /** Bumped by every change, so the derived edge index can never serve stale data. */
     revision = 0;
     semanticIndex;
-    constructor(id, name, version = '0.6.0') {
+    constructor(id, name, version = '0.6.2') {
         this.data = { id, name, version, nodes: {}, edges: {} };
     }
     get id() {

package/dist/resolve-presentation.js

@@ -1,4 +1,4 @@
-import { isUINode, uiChildIds } from './ui.js';
+import { formSubmitActionId, isUINode, uiChildIds } from './ui.js';
 import { TEXT_ROLE_HEADING_LEVELS, normalizeDensity, normalizeLayout, normalizePadding, normalizeRole, } from './presentation.js';
 import { DEFAULT_THEME } from './theme.js';
 /**
@@ -249,7 +249,10 @@ function semanticLayer(node, index) {
     const layer = { origin: 'inferred' };
     const formId = index.formOf.get(node.id);
     const form = formId ? index.nodes.get(formId) : undefined;
-    if (form && form.kind === 'form' && form.submitActionId === node.actionId) {
+    const submitActionId = form && form.kind === 'form'
+        ? formSubmitActionId(form, (id) => index.nodes.get(id))
+        : undefined;
+    if (submitActionId !== undefined && submitActionId === node.actionId) {
         layer.role = 'primary';
         layer.emphasis = 'strong';
         layer.uxRole = 'primary-action';

package/dist/ui.d.ts

@@ -198,6 +198,18 @@ export declare function isUINode(node: {
  * content that never appears at the same time.
  */
 export declare function primaryChildIds(node: UINode): NodeId[];
+/**
+ * The action a form submits, however it was declared.
+ *
+ * A form may name the action directly (`submitActionId`) or name a declared button that
+ * invokes it (`submitButtonId`). Every layer — execution, validation, presentation
+ * inference, `AgentAPI` — must resolve it the same way, or a form's primary action means
+ * one thing to the renderer and another to an agent.
+ */
+export declare function formSubmitActionId(form: FormNode, lookup: (id: NodeId) => {
+    kind: string;
+    actionId?: NodeId;
+} | undefined): NodeId | undefined;
 /** Child ids declared by a UI node, in render order. */
 export declare function uiChildIds(node: UINode): NodeId[];
 //# sourceMappingURL=ui.d.ts.map

package/dist/ui.js

@@ -32,6 +32,24 @@ export function primaryChildIds(node) {
             return uiChildIds(node);
     }
 }
+/**
+ * The action a form submits, however it was declared.
+ *
+ * A form may name the action directly (`submitActionId`) or name a declared button that
+ * invokes it (`submitButtonId`). Every layer — execution, validation, presentation
+ * inference, `AgentAPI` — must resolve it the same way, or a form's primary action means
+ * one thing to the renderer and another to an agent.
+ */
+export function formSubmitActionId(form, lookup) {
+    if (form.submitActionId) {
+        return form.submitActionId;
+    }
+    if (!form.submitButtonId) {
+        return undefined;
+    }
+    const button = lookup(form.submitButtonId);
+    return button?.kind === 'button' ? button.actionId : undefined;
+}
 /** Child ids declared by a UI node, in render order. */
 export function uiChildIds(node) {
     switch (node.kind) {

package/dist/validate-presentation.js

@@ -2,7 +2,7 @@ import { VALIDATION_CODES } from './diagnostics.js';
 import { ACTION_UX_ROLES, ALIGNMENTS, BOUNDED_SIZES, CONTROL_VARIANTS, DENSITIES, DEVICE_CLASSES, EMPHASIS_LEVELS, ICON_NAMES, JUSTIFICATIONS, LAYOUT_KINDS, PRESENTATION_ROLES, SIZING_VALUES, SPACING_TOKENS, SURFACE_ROLES, TEXT_ROLES, TREATMENTS, HEADING_LEVELS, UX_ROLES, VALUE_FORMAT_KINDS, } from './presentation.js';
 import { isDestructiveAction } from './resolve-presentation.js';
 import { APPEARANCES, RADIUS_TOKENS, SEMANTIC_COLOR_ROLES } from './theme.js';
-import { isUINode, primaryChildIds, uiChildIds } from './ui.js';
+import { formSubmitActionId, isUINode, primaryChildIds, uiChildIds } from './ui.js';
 /** More than this many controls side by side stops being a group and becomes a wall. */
 const HORIZONTAL_ACTION_LIMIT = 5;
 /** Below this a non-wrapping row is not yet a responsive problem. */
@@ -666,8 +666,11 @@ function checkPrimaryActions(bag, index, resolved) {
             continue;
         }
         const primary = new Set();
-        if (isForm && node.kind === 'form' && node.submitActionId) {
-            primary.add(node.submitActionId);
+        if (isForm && node.kind === 'form') {
+            const submitActionId = formSubmitActionId(node, (id) => index.nodes.get(id));
+            if (submitActionId) {
+                primary.add(submitActionId);
+            }
         }
         for (const child of descendants(index, node.id)) {
             if (child.kind === 'button' && resolved[child.id]?.uxRole === 'primary-action') {

package/dist/validate.js

@@ -449,6 +449,13 @@ function validateUiNode(node, context) {
             if (node.submitActionId) {
                 requireKind(node.submitActionId, 'action', node.id, context, VALIDATION_CODES.invalidActionRef);
             }
+            if (!node.submitButtonId && node.submitActionId) {
+                // A generated submit button carries no arguments, so an action needing any of them
+                // could never be satisfied. Silent omission is what produced ARGUMENT_TYPE_MISMATCH
+                // at run time; it is rejected here instead.
+                requireArguments(node.submitActionId, {}, node.id, context, `Form ${node.id} submits ${node.submitActionId}, whose generated button cannot supply arguments;` +
+                    ' declare a submit button with submitButtonId and give it');
+            }
             if (node.submitButtonId) {
                 const button = context.nodes.get(node.submitButtonId);
                 if (button?.kind !== 'button') {
@@ -497,6 +504,7 @@ function validateUiNode(node, context) {
             return;
         case 'button': {
             requireKind(node.actionId, 'action', node.id, context, VALIDATION_CODES.invalidActionRef);
+            requireArguments(node.actionId, node.arguments ?? {}, node.id, context, `Button ${node.id}`);
             if (typeof node.label !== 'string') {
                 validateExpression(node.label, node.id, context, new Set());
             }
@@ -522,6 +530,28 @@ function validateUiNode(node, context) {
         default:
     }
 }
+/**
+ * Every required parameter of an action must have an argument. A missing one is statically
+ * knowable, and would otherwise surface as a refusal at invocation time — on the authority,
+ * for a remote action.
+ */
+function requireArguments(actionId, args, ownerId, context, where) {
+    const action = context.nodes.get(actionId);
+    if (action?.kind !== 'action') {
+        return;
+    }
+    const missing = (action.parameters ?? [])
+        .filter((parameter) => parameter.required && !(String(parameter.id) in args))
+        .map((parameter) => String(parameter.id));
+    if (missing.length > 0) {
+        context.errors.push({
+            code: VALIDATION_CODES.missingActionArgument,
+            message: `${where} ${missing.length === 1 ? 'no argument for' : 'no arguments for'} ${missing.join(', ')}`,
+            nodeId: ownerId,
+            details: { actionId, missing },
+        });
+    }
+}
 /** Every UI node beneath this one, for checks that must know what a subtree contains. */
 function uiDescendants(id, context) {
     const found = new Set();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cynodia/axiom-core",
-  "version": "0.6.0-alpha.1",
+  "version": "0.6.2-alpha.1",
   "description": "Application Graph, semantic types, locations and validation for Axiom.",
   "license": "MIT",
   "author": "AskTech AS",