@cyberyozh/text-editor 0.5.0 → 0.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cyberyozh/text-editor",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Rich text editor library based on Tiptap for CyberYozh",
   "author": "CyberYozh",
   "license": "MIT",

package/src/editor/handlers/insertion-handlers.test.ts

@@ -0,0 +1,37 @@
+import { describe, expect, it, vi } from "vitest";
+import { shouldHandleInsertedFile } from "./markup-insertion";
+
+function fakeEvent() {
+  return {
+    preventDefault: vi.fn(),
+    stopPropagation: vi.fn(),
+  } as unknown as Event & {
+    preventDefault: ReturnType<typeof vi.fn>;
+    stopPropagation: ReturnType<typeof vi.fn>;
+  };
+}
+
+describe("shouldHandleInsertedFile", () => {
+  it("leaves the event untouched when clipboard has no files (plain text / html paste)", () => {
+    const event = fakeEvent();
+    expect(shouldHandleInsertedFile(undefined, event)).toBe(false);
+    expect(event.preventDefault).not.toHaveBeenCalled();
+    expect(event.stopPropagation).not.toHaveBeenCalled();
+  });
+
+  it("blocks the event for a non-image file and does not handle it", () => {
+    const event = fakeEvent();
+    const file = new File(["data"], "doc.pdf", { type: "application/pdf" });
+    expect(shouldHandleInsertedFile(file, event)).toBe(false);
+    expect(event.preventDefault).toHaveBeenCalledOnce();
+    expect(event.stopPropagation).toHaveBeenCalledOnce();
+  });
+
+  it("blocks the event for an image file and handles it", () => {
+    const event = fakeEvent();
+    const file = new File(["data"], "pic.png", { type: "image/png" });
+    expect(shouldHandleInsertedFile(file, event)).toBe(true);
+    expect(event.preventDefault).toHaveBeenCalledOnce();
+    expect(event.stopPropagation).toHaveBeenCalledOnce();
+  });
+});

package/src/editor/handlers/insertion-handlers.ts

@@ -3,7 +3,12 @@ import { useDialogCommand } from "../context";
 import { EditorView } from "@tiptap/pm/view";
 import { Slice } from "@tiptap/pm/model";
 import { ImageHandlers } from "@/types";
-import { applyUploadResultsToNodes, collectRehostableImages, removeImagesFromSlice } from "./markup-insertion";
+import {
+  applyUploadResultsToNodes,
+  collectRehostableImages,
+  removeImagesFromSlice,
+  shouldHandleInsertedFile,
+} from "./markup-insertion";
 
 export function useInsertionHandlers(imageHandlers?: ImageHandlers) {
   const [insertedImage, setInsertedImage] = useState<File | null>(null);
@@ -17,10 +22,7 @@ export function useInsertionHandlers(imageHandlers?: ImageHandlers) {
   }, [insertedImage, activeDialog]);
 
   function genericInsertionHandler(file: File | undefined, event: Event) {
-    event.preventDefault();
-    event.stopPropagation();
-
-    if (!file || !file.type.startsWith("image/")) return;
+    if (!file || !shouldHandleInsertedFile(file, event)) return;
     if (!imageHandlers?.upload) return;
 
     setInsertedImage(file);
@@ -48,7 +50,7 @@ export function useInsertionHandlers(imageHandlers?: ImageHandlers) {
     if (
       "clipboardData" in event &&
       Array.from(event.clipboardData?.items ?? []).some(
-        (item) => item.type === "text/html"
+        (item) => item.type === "text/html",
       )
     ) {
       hasMarkupInsertion = true;
@@ -57,7 +59,7 @@ export function useInsertionHandlers(imageHandlers?: ImageHandlers) {
     if (
       "dataTransfer" in event &&
       Array.from(event.dataTransfer?.items ?? []).some(
-        (item) => item.type === "text/html"
+        (item) => item.type === "text/html",
       )
     ) {
       hasMarkupInsertion = true;
@@ -69,7 +71,8 @@ export function useInsertionHandlers(imageHandlers?: ImageHandlers) {
 
         const imagesToNodes = collectRehostableImages(slice);
 
-        imageHandlers.uploadMultipleByURL(imagesToNodes.map(([url]) => url))
+        imageHandlers
+          .uploadMultipleByURL(imagesToNodes.map(([url]) => url))
           .then((results) => {
             applyUploadResultsToNodes(imagesToNodes, results);
             view.dispatch(view.state.tr.replaceSelection(slice));
@@ -78,7 +81,9 @@ export function useInsertionHandlers(imageHandlers?: ImageHandlers) {
             setDisabled(false);
           });
       } else {
-        view.dispatch(view.state.tr.replaceSelection(removeImagesFromSlice(slice)));
+        view.dispatch(
+          view.state.tr.replaceSelection(removeImagesFromSlice(slice)),
+        );
       }
 
       return true;

package/src/editor/handlers/markup-insertion.ts

@@ -70,3 +70,12 @@ export function applyUploadResultsToNodes(
     node.attrs.storageKey = result.storageKey;
   });
 }
+
+export function shouldHandleInsertedFile(file: File | undefined, event: Event): boolean {
+  if (!file) return false;
+
+  event.preventDefault();
+  event.stopPropagation();
+
+  return file.type.startsWith("image/");
+}