@cyberismo/data-handler 0.0.17 → 0.0.18

package/src/resources/workflow-resource.ts

@@ -56,10 +56,11 @@ export class WorkflowResource extends FileResource<Workflow> {
   }
 
   // When resource name changes.
-  private async handleNameChange(existingName: string) {
+  protected async onNameChange(existingName: string) {
     await Promise.all([
       super.updateHandleBars(existingName, this.content.name),
       super.updateCalculations(existingName, this.content.name),
+      this.updateCardTypes(existingName),
     ]);
     // Finally, write updated content.
     await this.write();
@@ -193,12 +194,15 @@ export class WorkflowResource extends FileResource<Workflow> {
       to: this.content.name,
     } as ChangeOperation<string>;
     for (const cardType of cardTypes) {
-      await cardType.update(
-        {
-          key: 'workflow',
-        },
-        op,
-      );
+      // Only update card types that use this workflow
+      if (cardType.data?.workflow === oldName) {
+        await cardType.update(
+          {
+            key: 'workflow',
+          },
+          op,
+        );
+      }
     }
   }
 
@@ -225,7 +229,7 @@ export class WorkflowResource extends FileResource<Workflow> {
   public async rename(newName: ResourceName) {
     const existingName = this.content.name;
     await super.rename(newName);
-    return this.handleNameChange(existingName);
+    return this.onNameChange(existingName);
   }
 
   /**
@@ -239,101 +243,106 @@ export class WorkflowResource extends FileResource<Workflow> {
     op: Operation<Type>,
   ) {
     const { key } = updateKey;
-    const nameChange = key === 'name';
-    const existingName = this.content.name;
 
-    await super.update(updateKey, op);
-
-    const content = structuredClone(this.content) as Workflow;
-
-    if (key === 'name') {
-      content.name = super.handleScalar(op) as string;
-    } else if (key === 'displayName') {
-      content.displayName = super.handleScalar(op) as string;
-    } else if (key === 'description') {
-      content.description = super.handleScalar(op) as string;
-    } else if (key === 'states') {
-      content.states = super.handleArray(
-        op,
-        key,
-        content.states as Type[],
-      ) as WorkflowState[];
-    } else if (key === 'transitions') {
-      content.transitions = super.handleArray(
-        op,
-        key,
-        content.transitions as WorkflowTransition[] as Type[],
-      ) as WorkflowTransition[];
+    if (key === 'name' || key === 'displayName' || key === 'description') {
+      await super.update(updateKey, op);
     } else {
-      throw new Error(`Unknown property '${key}' for Workflow`);
-    }
-
-    // If workflow transition is removed, then above call to 'handleArray' is all that is needed.
-
-    if (key === 'transitions' && op.name === 'change') {
-      // If workflow transition is changed, update to full object and change the content.
-      let changeOp: ChangeOperation<WorkflowTransition>;
-      if (this.isStringOperation(op)) {
-        const targetTransition = (this.content as Workflow).transitions.find(
-          (transition) => transition.name === op.target,
-        )!;
-        changeOp = {
-          name: 'change',
-          target: targetTransition as WorkflowTransition,
-          to: {
-            name: op.to,
-            toState: targetTransition.toState,
-            fromState: targetTransition.fromState,
-          },
-        };
-      } else {
-        changeOp = op as ChangeOperation<WorkflowTransition>;
+      const content = structuredClone(this.content) as Workflow;
+
+      // Validate state change operations before processing
+      if (key === 'states' && op.name === 'change') {
+        const changeOp = op as ChangeOperation<WorkflowState>;
+        if (
+          changeOp.to.name === undefined ||
+          changeOp.to.category === undefined
+        ) {
+          const stateName =
+            changeOp.target['name' as keyof typeof changeOp.target] ||
+            changeOp.target;
+          throw new Error(
+            `Cannot change state '${stateName}' for workflow '${this.content.name}'.
+         Updated state must have 'name' and 'category' properties.`,
+          );
+        }
       }
-      const newTransition = await this.transitionObject(changeOp);
-      content.transitions = content.transitions.map((item) =>
-        item.name == newTransition.name ? newTransition : item,
-      );
-    }
 
-    if (key === 'states' && op.name === 'remove') {
-      // If workflow state is removed, remove all transitions "to" and "from" this state.
-      let removeOp: RemoveOperation<WorkflowState>;
-      if (this.isStringOperation(op)) {
-        const toBeRemovedState = this.content.states.find(
-          (state) => state.name === op.target,
-        );
-        removeOp = {
-          name: 'remove',
-          target: toBeRemovedState as WorkflowState,
-        };
+      if (key === 'states') {
+        content.states = super.handleArray(
+          op,
+          key,
+          content.states as Type[],
+        ) as WorkflowState[];
+      } else if (key === 'transitions') {
+        content.transitions = super.handleArray(
+          op,
+          key,
+          content.transitions as WorkflowTransition[] as Type[],
+        ) as WorkflowTransition[];
       } else {
-        removeOp = op as RemoveOperation<WorkflowState>;
+        throw new Error(`Unknown property '${key}' for Workflow`);
       }
-      await this.handleStateRemoval(removeOp);
-    } else if (key === 'states' && op.name === 'change') {
-      // If workflow state is renamed, replace all transitions "to" and "from" the old state with new state.
-      let changeOp: ChangeOperation<WorkflowState>;
-      if (this.isStringOperation(op)) {
-        const toBeChangedState = this.content.states.find(
-          (state) => state.name === op.target,
+
+      // If workflow transition is removed, then above call to 'handleArray' is all that is needed.
+
+      if (key === 'transitions' && op.name === 'change') {
+        // If workflow transition is changed, update to full object and change the content.
+        let changeOp: ChangeOperation<WorkflowTransition>;
+        if (this.isStringOperation(op)) {
+          const targetTransition = (this.content as Workflow).transitions.find(
+            (transition) => transition.name === op.target,
+          )!;
+          changeOp = {
+            name: 'change',
+            target: targetTransition as WorkflowTransition,
+            to: {
+              name: op.to,
+              toState: targetTransition.toState,
+              fromState: targetTransition.fromState,
+            },
+          };
+        } else {
+          changeOp = op as ChangeOperation<WorkflowTransition>;
+        }
+        const newTransition = await this.transitionObject(changeOp);
+        content.transitions = content.transitions.map((item) =>
+          item.name == newTransition.name ? newTransition : item,
         );
-        changeOp = {
-          name: 'change',
-          target: toBeChangedState as WorkflowState,
-          to: { name: op.to },
-        };
-      } else {
-        changeOp = op as ChangeOperation<WorkflowState>;
       }
-      await this.handleStateChange(changeOp);
-    }
 
-    await super.postUpdate(content, updateKey, op);
+      if (key === 'states' && op.name === 'remove') {
+        // If workflow state is removed, remove all transitions "to" and "from" this state.
+        let removeOp: RemoveOperation<WorkflowState>;
+        if (this.isStringOperation(op)) {
+          const toBeRemovedState = this.content.states.find(
+            (state) => state.name === op.target,
+          );
+          removeOp = {
+            name: 'remove',
+            target: toBeRemovedState as WorkflowState,
+          };
+        } else {
+          removeOp = op as RemoveOperation<WorkflowState>;
+        }
+        await this.handleStateRemoval(removeOp);
+      } else if (key === 'states' && op.name === 'change') {
+        // If workflow state is renamed, replace all transitions "to" and "from" the old state with new state.
+        let changeOp: ChangeOperation<WorkflowState>;
+        if (this.isStringOperation(op)) {
+          const toBeChangedState = this.content.states.find(
+            (state) => state.name === op.target,
+          );
+          changeOp = {
+            name: 'change',
+            target: toBeChangedState as WorkflowState,
+            to: { name: op.to },
+          };
+        } else {
+          changeOp = op as ChangeOperation<WorkflowState>;
+        }
+        await this.handleStateChange(changeOp);
+      }
 
-    // Renaming this workflow causes that references to its name must be updated.
-    if (nameChange) {
-      await this.handleNameChange(existingName);
-      await this.updateCardTypes(existingName);
+      await super.postUpdate(content, updateKey, op);
     }
   }