@cursor/july 0.1.95 → 0.1.97

package/src/channels/origin/types.ts

@@ -58,6 +58,11 @@ export interface OriginEventContext {
   repository: OriginRepositoryRef;
   pullRequestNumber: number;
   pullRequestUrl: string;
+  /**
+   * Who opened the pull request, when the payload carries it. Distinct from
+   * {@link sender} — on a comment event the sender is the commenter.
+   */
+  pullRequestAuthor?: OriginActor;
   /**
    * Raw parsed `event.payload` record (`{}` when absent), for consumers
    * whose normalization needs more than the typed event — the GitHub
@@ -152,6 +157,12 @@ export interface OriginAppOptions {
   token?: string | OriginTokenProvider;
   /** Public Origin REST base, e.g. `https://api.cursor.com`. */
   apiBaseUrl?: string;
+  /**
+   * Origin ConnectRPC base for operations without a REST binding (comment
+   * reactions), e.g. `https://api.origin.cursor.com`. Falls back to
+   * `ORIGIN_RPC_BASE_URL`.
+   */
+  rpcBaseUrl?: string;
 }
 
 export interface OriginChannelOptions {

package/src/channels/slack/api.ts

@@ -193,6 +193,12 @@ export function truncateTitle(title: string, max?: number): string {
 // Assistant / stream helpers
 // ---------------------------------------------------------------------------
 
+/**
+ * Show or clear the Working chip. Agent UX ignores empty
+ * `assistant.threads.setStatus`; `agents.sessions.setStatus` `active` is
+ * what actually clears it. The assistant call stays for loading_messages
+ * and older workspaces.
+ */
 export async function setThreadStatus(args: {
   botToken: SlackBotToken | undefined;
   channelId: string;
@@ -204,13 +210,21 @@ export async function setThreadStatus(args: {
     return { ok: false, error: "missing_channel_or_thread" };
   }
   const status = truncateTypingStatus(args.status);
+  const sessionResult = await callSlackApiSoft({
+    botToken: args.botToken,
+    operation: "agents.sessions.setStatus",
+    body: {
+      channel_id: args.channelId,
+      thread_ts: args.threadTs,
+      status: status.length > 0 ? "processing" : "active",
+    },
+  });
+
   const body: Record<string, unknown> = {
     channel_id: args.channelId,
     thread_ts: args.threadTs,
     status,
   };
-  // Empty status clears Slack's assistant chip ("App is working…").
-  // Sending loading_messages with it keeps the chip rotating.
   if (status.length > 0) {
     const loadingRaw =
       args.loadingMessages !== undefined && args.loadingMessages.length > 0
@@ -224,11 +238,19 @@ export async function setThreadStatus(args: {
       body.loading_messages = loading_messages;
     }
   }
-  return callSlackApiSoft({
+  const assistantResult = await callSlackApiSoft({
     botToken: args.botToken,
     operation: "assistant.threads.setStatus",
     body,
   });
+
+  if (sessionResult.ok) {
+    return sessionResult;
+  }
+  if (sessionResult.unsupported === true || assistantResult.ok) {
+    return assistantResult;
+  }
+  return sessionResult;
 }
 
 export async function setThreadTitle(args: {
@@ -278,16 +300,30 @@ export async function startChatStream(args: {
   channel: string;
   thread_ts?: string;
   markdown_text?: string;
+  chunks?: StreamTaskChunk[];
+  recipient_user_id?: string;
+  recipient_team_id?: string;
 }): Promise<SoftSlackResult<{ ts: string; channel: string }>> {
   const body: Record<string, unknown> = {
     channel: args.channel,
   };
+  // Empty markdown_text is rejected or opens a stream the assistant pane
+  // never attaches. Recipients are required outside DMs.
   if (args.thread_ts !== undefined && args.thread_ts !== "") {
     body.thread_ts = args.thread_ts;
   }
-  if (args.markdown_text !== undefined) {
+  if (args.markdown_text !== undefined && args.markdown_text !== "") {
     body.markdown_text = args.markdown_text;
   }
+  if (args.chunks !== undefined && args.chunks.length > 0) {
+    body.chunks = args.chunks;
+  }
+  if (args.recipient_user_id !== undefined && args.recipient_user_id !== "") {
+    body.recipient_user_id = args.recipient_user_id;
+  }
+  if (args.recipient_team_id !== undefined && args.recipient_team_id !== "") {
+    body.recipient_team_id = args.recipient_team_id;
+  }
   const result = await callSlackApiSoft({
     botToken: args.botToken,
     operation: "chat.startStream",
@@ -642,7 +678,7 @@ export function buildSlackBinding(args: {
         ...(loadingMessages === undefined ? {} : { loadingMessages }),
       });
       if (!result.ok) {
-        log.warn("assistant.threads.setStatus not-ok", {
+        log.warn("slack setStatus not-ok", {
           error: result.error,
           channel: args.channelId,
           thread_ts: threadTs,

package/src/channels/slack/approvals.ts

@@ -6,6 +6,8 @@ import type { ApprovalDecision } from "../../types.js";
 
 export const SLACK_APPROVE_ACTION_ID = "agent_serve_approve";
 export const SLACK_DENY_ACTION_ID = "agent_serve_deny";
+export const SLACK_AUTH_CONNECTED_ACTION_ID = "agent_serve_auth_connected";
+export const SLACK_AUTH_CANCEL_ACTION_ID = "agent_serve_auth_cancel";
 
 export interface SlackApprovalActionValue {
   sessionId: string;
@@ -54,6 +56,29 @@ export function decisionFromActionId(
   return null;
 }
 
+export function decisionFromAuthActionId(
+  actionId: string
+): ApprovalDecision | null {
+  if (actionId === SLACK_AUTH_CONNECTED_ACTION_ID) {
+    return "approve";
+  }
+  if (actionId === SLACK_AUTH_CANCEL_ACTION_ID) {
+    return "deny";
+  }
+  return null;
+}
+
+export function authThreadStatus(connection: string): string {
+  const prefix = "Waiting for ";
+  const suffix = " auth…";
+  const budget = 50 - prefix.length - suffix.length;
+  const name =
+    connection.length <= budget
+      ? connection
+      : `${connection.slice(0, Math.max(0, budget - 1))}…`;
+  return `${prefix}${name}${suffix}`;
+}
+
 const REDACTED = "[REDACTED]";
 const SENSITIVE_KEY =
   /(?:pass(?:word|wd)?|secret|token|api[_-]?key|authorization|credential|private[_-]?key|access[_-]?key)/i;
@@ -176,6 +201,86 @@ export function buildApprovalBlocks(args: {
   ];
 }
 
+export function buildAuthBlocks(args: {
+  sessionId: string;
+  callId: string;
+  toolName: string;
+  connection: string;
+  authUrl: string;
+}): unknown[] {
+  const value = encodeApprovalActionValue({
+    sessionId: args.sessionId,
+    callId: args.callId,
+  });
+  const label =
+    args.connection.length > 20
+      ? `Authorize ${args.connection.slice(0, 17)}…`
+      : `Authorize ${args.connection}`;
+  return [
+    {
+      type: "header",
+      text: {
+        type: "plain_text",
+        text: "MCP authorization needed",
+        emoji: true,
+      },
+    },
+    {
+      type: "section",
+      text: {
+        type: "mrkdwn",
+        text: `Connect \`${args.connection}\` so \`${args.toolName}\` can continue.`,
+      },
+    },
+    {
+      type: "actions",
+      block_id: `auth_${args.callId}`.slice(0, 255),
+      elements: [
+        {
+          type: "button",
+          text: { type: "plain_text", text: label, emoji: true },
+          url: args.authUrl,
+        },
+        {
+          type: "button",
+          action_id: SLACK_AUTH_CONNECTED_ACTION_ID,
+          text: { type: "plain_text", text: "Connected", emoji: true },
+          style: "primary",
+          value,
+        },
+        {
+          type: "button",
+          action_id: SLACK_AUTH_CANCEL_ACTION_ID,
+          text: { type: "plain_text", text: "Cancel", emoji: true },
+          style: "danger",
+          value,
+        },
+      ],
+    },
+  ];
+}
+
+export function buildResolvedAuthBlocks(args: {
+  connection: string;
+  decision: ApprovalDecision;
+  byUserId?: string;
+}): unknown[] {
+  const verb = args.decision === "approve" ? "Connected" : "Cancelled";
+  const by =
+    args.byUserId === undefined || args.byUserId === ""
+      ? ""
+      : ` by <@${args.byUserId}>`;
+  return [
+    {
+      type: "section",
+      text: {
+        type: "mrkdwn",
+        text: `*${verb}*${by} — \`${args.connection}\``,
+      },
+    },
+  ];
+}
+
 export function buildResolvedApprovalBlocks(args: {
   toolName: string;
   decision: ApprovalDecision;

package/src/channels/slack/cli-project.ts

@@ -0,0 +1,267 @@
+/**
+ * Official Slack CLI project files for `slack init --manual`.
+ *
+ * `.slack/` is the committed Slack CLI project: hook, manifests, hooks.json.
+ * Agent SDK serve owns the socket; do not `slack deploy` / `slack run`.
+ */
+
+import { randomUUID } from "node:crypto";
+import { existsSync } from "node:fs";
+import { mkdir, readFile, writeFile } from "node:fs/promises";
+import { homedir } from "node:os";
+import { join } from "node:path";
+
+export const SLACK_CLI_HOME_BIN = ".slack/bin/slack";
+
+export const SLACK_CLI_GET_MANIFEST = "node .slack/get-manifest.mjs";
+
+export type SlackCliEnvironment = "local" | "deployed";
+
+const TEAM_ID_RE = /\(Team ID: ([TE][A-Z0-9]+)\)/g;
+
+const GET_MANIFEST_JS = `import { readFileSync } from "node:fs";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
+
+const here = dirname(fileURLToPath(import.meta.url));
+
+function target() {
+  const env = process.env.SLACK_ENV ?? process.env.SLACK_APP_ENVIRONMENT;
+  if (env === "deployed" || env === "prod") return "manifest.prod.json";
+  if (env === "local" || env === "dev") return "manifest.dev.json";
+  try {
+    const raw = readFileSync(join(here, "cli-environment"), "utf8").trim();
+    if (raw === "deployed" || raw === "prod") return "manifest.prod.json";
+  } catch {
+    // default local
+  }
+  return "manifest.dev.json";
+}
+
+process.stdout.write(readFileSync(join(here, target()), "utf8"));
+`;
+
+function isEnoent(error: unknown): boolean {
+  return (
+    error instanceof Error &&
+    "code" in error &&
+    (error as NodeJS.ErrnoException).code === "ENOENT"
+  );
+}
+
+/** Official Slack CLI, if present. `SLACK_CLI` overrides. */
+export function detectSlackCli(
+  env: NodeJS.ProcessEnv = process.env
+): string | undefined {
+  const override = env.SLACK_CLI;
+  if (override !== undefined && override !== "") {
+    return override;
+  }
+  const home = env.HOME ?? env.USERPROFILE ?? homedir();
+  const homeBin = join(home, SLACK_CLI_HOME_BIN);
+  return existsSync(homeBin) ? homeBin : undefined;
+}
+
+/** Hook + manifests under `.slack/`. Merge hooks.json; keep existing config. */
+export async function writeSlackCliProject(
+  rootDir: string,
+  manifests: ReadonlyArray<{ name: string; contents: string }>
+): Promise<string[]> {
+  const slackDir = join(rootDir, ".slack");
+  await mkdir(slackDir, { recursive: true });
+  const created: string[] = [];
+
+  await writeFile(join(slackDir, "get-manifest.mjs"), GET_MANIFEST_JS);
+  created.push(".slack/get-manifest.mjs");
+
+  for (const file of manifests) {
+    await writeFile(join(slackDir, file.name), file.contents);
+    created.push(`.slack/${file.name}`);
+  }
+
+  if (await upsertGetManifestHook(slackDir)) {
+    created.push(".slack/hooks.json");
+  }
+  if (
+    await writeIfMissing(
+      join(slackDir, "config.json"),
+      `${JSON.stringify(
+        {
+          manifest: { source: "local" },
+          project_id: randomUUID(),
+        },
+        null,
+        2
+      )}\n`
+    )
+  ) {
+    created.push(".slack/config.json");
+  }
+  if (await mergeGitignore(join(slackDir, ".gitignore"))) {
+    created.push(".slack/.gitignore");
+  }
+  return created;
+}
+
+async function upsertGetManifestHook(slackDir: string): Promise<boolean> {
+  const path = join(slackDir, "hooks.json");
+  let existing: { hooks?: Record<string, string> };
+  try {
+    const parsed: unknown = JSON.parse(await readFile(path, "utf8"));
+    if (
+      parsed === null ||
+      typeof parsed !== "object" ||
+      Array.isArray(parsed)
+    ) {
+      throw new Error(".slack/hooks.json is not a JSON object");
+    }
+    existing = parsed as { hooks?: Record<string, string> };
+  } catch (error) {
+    if (!isEnoent(error)) {
+      throw error;
+    }
+    await writeFile(
+      path,
+      `${JSON.stringify({ hooks: { "get-manifest": SLACK_CLI_GET_MANIFEST } }, null, 2)}\n`
+    );
+    return true;
+  }
+  const hooks = existing.hooks ?? {};
+  if (hooks["get-manifest"] === SLACK_CLI_GET_MANIFEST) {
+    return false;
+  }
+  hooks["get-manifest"] = SLACK_CLI_GET_MANIFEST;
+  existing.hooks = hooks;
+  await writeFile(path, `${JSON.stringify(existing, null, 2)}\n`);
+  return true;
+}
+
+async function writeIfMissing(
+  path: string,
+  contents: string
+): Promise<boolean> {
+  try {
+    await writeFile(path, contents, { flag: "wx" });
+    return true;
+  } catch (error) {
+    if (
+      error instanceof Error &&
+      "code" in error &&
+      (error as NodeJS.ErrnoException).code === "EEXIST"
+    ) {
+      return false;
+    }
+    throw error;
+  }
+}
+
+async function mergeGitignore(path: string): Promise<boolean> {
+  const lines = ["apps.dev.json", "cache/", "cli-environment"];
+  let existing = "";
+  try {
+    existing = await readFile(path, "utf8");
+  } catch (error) {
+    if (!isEnoent(error)) {
+      throw error;
+    }
+    await writeFile(path, `${lines.join("\n")}\n`);
+    return true;
+  }
+  const have = new Set(
+    existing
+      .split(/\r?\n/)
+      .map((line) => line.trim())
+      .filter((line) => line !== "")
+  );
+  const missing = lines.filter((line) => !have.has(line));
+  if (missing.length === 0) {
+    return false;
+  }
+  const prefix =
+    existing === "" || existing.endsWith("\n") ? existing : `${existing}\n`;
+  await writeFile(path, `${prefix}${missing.join("\n")}\n`);
+  return true;
+}
+
+export function parseSlackAuthTeams(text: string): string[] {
+  const ids: string[] = [];
+  for (const match of text.matchAll(TEAM_ID_RE)) {
+    const id = match[1];
+    if (id !== undefined && !ids.includes(id)) {
+      ids.push(id);
+    }
+  }
+  return ids;
+}
+
+export async function readSlackCliAppId(
+  dir: string,
+  environment: SlackCliEnvironment,
+  team?: string
+): Promise<string | undefined> {
+  const apps = await loadAppMap(dir, environment);
+  if (apps === undefined) {
+    return undefined;
+  }
+  if (team !== undefined) {
+    return appIdOf(apps[team]);
+  }
+  return firstAppId(apps);
+}
+
+async function loadAppMap(
+  dir: string,
+  environment: SlackCliEnvironment
+): Promise<Record<string, unknown> | undefined> {
+  if (environment === "local") {
+    return readJson(join(dir, ".slack/apps.dev.json"));
+  }
+  const deployed = await readJson(join(dir, ".slack/apps.json"));
+  if (deployed === undefined) {
+    return undefined;
+  }
+  const apps = deployed.apps;
+  if (apps !== undefined && typeof apps === "object" && apps !== null) {
+    return apps as Record<string, unknown>;
+  }
+  return deployed;
+}
+
+function firstAppId(value: Record<string, unknown>): string | undefined {
+  for (const entry of Object.values(value)) {
+    const id = appIdOf(entry);
+    if (id !== undefined) {
+      return id;
+    }
+  }
+  return undefined;
+}
+
+function appIdOf(entry: unknown): string | undefined {
+  if (entry === undefined || entry === null || typeof entry !== "object") {
+    return undefined;
+  }
+  const appId = (entry as { app_id?: unknown }).app_id;
+  if (typeof appId === "string" && appId.startsWith("A")) {
+    return appId;
+  }
+  return undefined;
+}
+
+async function readJson(
+  path: string
+): Promise<Record<string, unknown> | undefined> {
+  try {
+    const parsed: unknown = JSON.parse(await readFile(path, "utf8"));
+    if (
+      parsed === null ||
+      typeof parsed !== "object" ||
+      Array.isArray(parsed)
+    ) {
+      return undefined;
+    }
+    return parsed as Record<string, unknown>;
+  } catch {
+    return undefined;
+  }
+}