@cursor/july 0.1.5 → 0.1.7

package/src/internal/ab-collector.ts

@@ -16,7 +16,7 @@
 
 import {
   type ABDefinition,
-  type ABSamplePersistence,
+  type ABMetricSample,
   type ABSampleReason,
   cloneABMetrics,
 } from "../ab.js";
@@ -33,8 +33,11 @@ import { describeError } from "./describe-error.js";
 export type { DiscoveredAB };
 
 export interface ABCollectorOptions {
-  projectRoot: string;
-  persistSamples?: ABSamplePersistence;
+  /**
+   * Durable sample export (the `defineStorage` `abs` table, via the
+   * coordinator). Fire-and-forget; must never throw.
+   */
+  persistSample?: (sample: ABMetricSample) => void;
 }
 
 /** Drop cache after these — next event rehydrates from the durable log. */
@@ -47,8 +50,9 @@ const EVICT_ON: ReadonlySet<SessionEvent["type"]> = new Set([
 export class ABCollector {
   private readonly state = new Map<string, FoldedABSession>();
   private readonly hydrated = new Set<string>();
-  private readonly projectRoot: string | undefined;
-  private readonly persistSamples: ABSamplePersistence | undefined;
+  private readonly persistSample:
+    | ((sample: ABMetricSample) => void)
+    | undefined;
 
   constructor(
     private readonly experiments: readonly DiscoveredAB[],
@@ -56,8 +60,7 @@ export class ABCollector {
     private readonly loadEvents: (sessionId: string) => Promise<SessionEvent[]>,
     options?: ABCollectorOptions
   ) {
-    this.projectRoot = options?.projectRoot;
-    this.persistSamples = options?.persistSamples;
+    this.persistSample = options?.persistSample;
   }
 
   get enabled(): boolean {
@@ -155,7 +158,7 @@ export class ABCollector {
       }
       const reason = sampleReason(event);
       if (reason !== undefined) {
-        const sample = {
+        const sample: ABMetricSample = {
           experiment: experiment.name,
           variant,
           ...(def.variants[variant]?.label !== undefined
@@ -174,20 +177,7 @@ export class ABCollector {
             `[agentkit] ab "${experiment.name}" onSample threw: ${describeError(error)}`
           );
         }
-        if (
-          this.persistSamples !== undefined &&
-          this.projectRoot !== undefined
-        ) {
-          try {
-            await this.persistSamples.save(sample, {
-              projectRoot: this.projectRoot,
-            });
-          } catch (error) {
-            this.logger(
-              `[agentkit] ab persistSamples.save threw: ${describeError(error)}`
-            );
-          }
-        }
+        this.persistSample?.(sample);
       }
     }
   }

package/src/internal/ab-snapshot.ts

@@ -58,12 +58,10 @@ export interface ABSnapshotExperiment {
 export interface ABSnapshotConfig {
   /** Newest-first session fold window for this snapshot (`GET /v1/abs`). */
   maxPlaygroundSessions?: number;
-  /** True when `persistSamples` is configured. */
+  /** True when the `defineStorage` `abs` table is configured. */
   durableSamples?: boolean;
-  /** True when `persistSnapshots` is configured. */
+  /** True when the `abs` table also stores the aggregate snapshot. */
   durableSnapshots?: boolean;
-  /** Set when writing via filesystem snapshot persistence helpers. */
-  snapshotId?: string;
 }
 
 export interface ABSnapshot {