@cursor/july 0.1.24 → 0.1.25

package/src/internal/cli-slack.ts

@@ -491,6 +491,16 @@ interface ConnectWaitTarget {
   notConnectedAt?: string;
 }
 
+/**
+ * Slack's team-scoped admin page listing pending app-install requests.
+ * Provisioned apps have no OAuth flow (no redirect URLs, install-from-Slack
+ * disabled), so the oauth_authorize_url Slack returns from
+ * apps.manifest.create dead-ends; approval happens here instead.
+ */
+function slackAppRequestsUrl(slackTeamId: string): string {
+  return `https://app.slack.com/apps-manage/${encodeURIComponent(slackTeamId)}/integrations/requests`;
+}
+
 /** "Name (T0123ABCD)", or the bare id when the backend has no name. */
 function formatWorkspace(workspace: SlackConnectedWorkspace): string {
   const name = workspace.slackTeamName ?? "";
@@ -719,6 +729,7 @@ export async function cmdSlackCreate(
   const iconStatus = await applySlackCreateIcon(ctx, iconSource, result);
 
   if (result.status === "pending_admin_approval") {
+    const approveUrl = slackAppRequestsUrl(workspace.slackTeamId);
     if (ctx.json) {
       ctx.out(
         `${JSON.stringify(
@@ -729,7 +740,7 @@ export async function cmdSlackCreate(
             slackTeamId: workspace.slackTeamId,
             envKeys: target.envKeys,
             wrote,
-            oauthAuthorizeUrl: result.oauthAuthorizeUrl ?? null,
+            approveUrl,
             iconStatus,
           },
           null,
@@ -739,9 +750,7 @@ export async function cmdSlackCreate(
     } else {
       ctx.err(
         `The Slack app was created (app ${result.appId}), but installing it needs a Slack workspace-admin approval.\n` +
-          (result.oauthAuthorizeUrl === undefined
-            ? ""
-            : `\n  Approve it (or send this to a workspace admin):\n\n    ${result.oauthAuthorizeUrl}\n\n`) +
+          `\n  A workspace admin can approve it here:\n\n    ${approveUrl}\n\n` +
           `Once an admin approves the app, re-run \`${CLI} slack create\` to finish the install and mint the tokens.\n`
       );
     }

package/src/internal/cloud-merge.test.ts

@@ -0,0 +1,74 @@
+import { describe, expect, it } from "vitest";
+import type { AgentCloudOptions } from "../types.js";
+import { mergeCloudOptions, resolveSessionRuntime } from "./cloud-merge.js";
+import { isServerMintedCloudAgentId } from "./sdk-runner.js";
+
+describe("mergeCloudOptions", () => {
+  const base: AgentCloudOptions = {
+    env: { type: "cloud" },
+    autoCreatePR: false,
+    envVars: { A: "1", B: "2" },
+  };
+
+  it("returns the other side when one is undefined", () => {
+    expect(mergeCloudOptions({ base, override: undefined })).toBe(base);
+    expect(mergeCloudOptions({ base: undefined, override: base })).toBe(base);
+    expect(
+      mergeCloudOptions({ base: undefined, override: undefined })
+    ).toBeUndefined();
+  });
+
+  it("lets the per-session override win on repos/env and deep-merges envVars", () => {
+    const merged = mergeCloudOptions({
+      base,
+      override: {
+        repos: [
+          {
+            url: "https://github.com/o/r",
+            prUrl: "https://github.com/o/r/pull/1",
+          },
+        ],
+        envVars: { B: "override", C: "3" },
+      },
+    });
+    expect(merged?.repos).toEqual([
+      { url: "https://github.com/o/r", prUrl: "https://github.com/o/r/pull/1" },
+    ]);
+    // Scalar base flags survive; envVars are deep-merged with override winning.
+    expect(merged?.autoCreatePR).toBe(false);
+    expect(merged?.envVars).toEqual({ A: "1", B: "override", C: "3" });
+  });
+});
+
+describe("resolveSessionRuntime", () => {
+  it("keeps the agent default when there is no cloud override", () => {
+    expect(
+      resolveSessionRuntime({
+        agentRuntime: "local",
+        cloudOverride: undefined,
+      })
+    ).toBe("local");
+    expect(
+      resolveSessionRuntime({
+        agentRuntime: "cloud",
+        cloudOverride: undefined,
+      })
+    ).toBe("cloud");
+  });
+
+  it("forces cloud when a per-session cloud override is set", () => {
+    expect(
+      resolveSessionRuntime({
+        agentRuntime: "local",
+        cloudOverride: { env: { type: "cloud" } },
+      })
+    ).toBe("cloud");
+  });
+});
+
+describe("isServerMintedCloudAgentId", () => {
+  it("resumes bc- ids and treats other ids as creation seeds", () => {
+    expect(isServerMintedCloudAgentId("bc-2dd32425-da03")).toBe(true);
+    expect(isServerMintedCloudAgentId("ses_abc")).toBe(false);
+  });
+});

package/src/internal/cron.test.ts

@@ -0,0 +1,22 @@
+import { describe, expect, it } from "vitest";
+import { isValidCron, parseCron } from "./cron.js";
+
+describe("parseCron (croner)", () => {
+  it("matches */5 on the five-minute mark", () => {
+    const cron = parseCron("*/5 * * * *");
+    expect(cron.matches(new Date("2026-07-09T18:55:00.000Z"))).toBe(true);
+    expect(cron.matches(new Date("2026-07-09T18:56:00.000Z"))).toBe(false);
+  });
+
+  it("returns the next fire after a given time", () => {
+    const cron = parseCron("0 9 * * 1-5");
+    const next = cron.nextFire(new Date("2026-07-09T08:00:00.000Z")); // Thursday
+    expect(next.toISOString()).toBe("2026-07-09T09:00:00.000Z");
+  });
+
+  it("rejects non-5-field expressions", () => {
+    expect(() => parseCron("* * * *")).toThrow(/5 fields/);
+    expect(isValidCron("0 9 * * 1-5")).toBe(true);
+    expect(isValidCron("not a cron")).toBe(false);
+  });
+});