@curless/hotel-storefront 0.31.3 → 0.32.1

package/dist/huazhu/backend.js

@@ -189,6 +189,38 @@ const refusalWords = (err, room, currency) => {
             return `Huazhu did not accept ${room}: ${err.huazhuMessage}${detail}.`;
     }
 };
+/** The same refusal as a reason code, for a stay that failed on its own (`FailedStay`). */
+const refusalCode = (err, rooms) => {
+    switch (err.code) {
+        case 5109:
+        case 5210:
+            return { code: 'sold-out', ...(rooms > 1 ? { args: { rooms } } : {}) };
+        case 5110:
+        case 5214:
+            return { code: 'too-many-rooms', args: { rooms } };
+        case 5111:
+        case 5215:
+            return { code: 'party' };
+        case 5120:
+        case 5233:
+            return { code: 'closed' };
+        case 5114:
+        case 5211:
+        case 5116:
+        case 5213:
+            return { code: 'prepaid-only' };
+        case 5107:
+        case 5207:
+        case 5128:
+        case 5238:
+            return { code: 'too-far' };
+        case 5108:
+        case 5209:
+            return { code: 'price-changed' };
+        default:
+            return { code: 'unavailable' };
+    }
+};
 /** A road named after a place: "南京路", "香港中路", "Hong Kong Middle Road". */
 const ROAD_AFTER = /^\s*(?:[中东西南北]?(?:路|街|大道|大街|道|巷)|(?:east |west |north |south |middle )?(?:road|street|avenue|rd\b|st\b))/i;
 /**
@@ -326,7 +358,9 @@ const deadlineZh = (instant, tz) => {
  * How a fresh price differs from what the guest was shown - or nothing, when
  * it does not. See `ShownQuote`.
  */
-export const movedSince = (shown, q) => {
+export const movedSince = (shown, q, 
+/** Hold the total to the one shown - not when a stay of it has since gone (it is in `failed`). */
+whole = true) => {
     if (!shown)
         return "the guest has not been shown this trip's price yet.";
     const said = [];
@@ -344,7 +378,7 @@ export const movedSince = (shown, q) => {
             said.push(`${name}'s cancellation terms have changed since they were shown.`);
     }
     const total = shown.totals[q.total.currency];
-    if (!said.length && total !== undefined && total !== q.total.minor)
+    if (whole && !said.length && total !== undefined && total !== q.total.minor)
         said.push(`The total is now ${formatMoney(q.total)}, not the ${formatMoney(money(total, q.total.currency))} shown.`);
     return said.length ? said.join(' ') : undefined;
 };
@@ -1294,11 +1328,14 @@ export const createHuazhuHotels = (opts) => {
             now() - Date.parse(b.createdAt) < SAME_TRIP_MS &&
             isLive(b));
         const ref = earlier[0]?.tripRef;
+        const before = ref ? store.intent(ref) : undefined;
+        // What it booked and what it could not - the second asking hears the
+        // first's answer, failed stays and all, and books nothing twice.
         if (ref &&
-            earlier.length === lines.length &&
+            earlier.length + (before?.failed?.length ?? 0) === lines.length &&
             earlier.every((b) => b.tripRef === ref) &&
-            (store.intent(ref)?.done ?? true)) {
-            return earlier.map(publicBooking);
+            (before?.done ?? true)) {
+            return { booked: earlier.map(publicBooking), failed: before?.failed ?? [] };
         }
         // ⚠️ THE LIMITS - see `BookingLimits`. Each is said as what it is, and
         // none suggests a way round itself (another email, another chat).
@@ -1565,32 +1602,70 @@ export const createHuazhuHotels = (opts) => {
     const bookHeld = async (lines, shown, tripKey, email, guest, contact, who, requests, slot) => {
         // Priced afresh, not from the cache: this is the price that will be sent.
         const priced = await quoteLines({ lines }, true);
-        if (priced.dropped?.length || priced.sold.size !== lines.length) {
-            throw new Error(`Nothing was booked. ${(priced.dropped ?? []).map((d) => `${d.title}: ${d.why}`).join(' ')} The trip is as it was - take that out or change it, then ask again.`);
-        }
         // ⚠️ AT THE PRICE AND TERMS THE GUEST SAW, OR NOT AT ALL - see `ShownQuote`.
-        const moved = movedSince(shown, priced);
+        // The whole trip's question, asked before any stay is booked: the guest
+        // has not agreed to a price they were not shown, and the trip is shown to
+        // them again (the tools' `price-changed`) - this is not a stay that
+        // "could not be booked". A stay Huazhu turns down at prebook or booking -
+        // its own price moved there, sold out, refused - is that stay's alone.
+        const moved = movedSince(shown, priced, !priced.dropped?.length);
         if (moved) {
             throw Object.assign(new Error(`Nothing was booked: ${moved} Show the guest the trip at today's price and terms, and book it only if they agree.`), { code: 'price-changed' });
         }
         const clean = cleanRequests(requests);
         const comment = commentOf(clean, guest.notes);
-        const plans = [];
+        // ⚠️ WHAT WAS BOOKED IS KEPT, AND WHAT WAS NOT IS SAID (robin,
+        // 2026-10-14, in place of 2026-09-28's "all of it or none"): a stay that
+        // cannot be booked - gone since it was priced, refused at prebook (its
+        // price moved there, sold out) or at booking, not written down - is in
+        // `failed` with why, and the others are booked. Never a stay in neither
+        // list.
+        const failed = [];
+        const failStay = (line, why, code, args, named) => {
+            const raw = findHotel(line.hotelId);
+            failed.push({
+                hotelId: line.hotelId,
+                hotelName: named?.hotel ?? (raw ? toHotel(raw, view, now()).name : line.hotelId),
+                stay: line.stay,
+                ...(line.hourly ? { hourly: line.hourly } : {}),
+                ...(named?.room ? { roomName: named.room } : {}),
+                why,
+                code,
+                ...(args ? { args } : {}),
+            });
+        };
+        // `quoteLines` keeps a line's order: the sold ones in `lines`, the rest
+        // in `dropped`, one each.
+        const soldAt = [...priced.sold.keys()].sort((x, y) => x - y);
+        const droppedAt = lines.map((_, i) => i).filter((i) => !priced.sold.has(i));
+        if (soldAt.length !== priced.lines.length || droppedAt.length !== (priced.dropped?.length ?? 0))
+            throw new Error('Nothing was booked: the trip changed while it was being priced.');
+        let plans = [];
         for (const [i, line] of lines.entries()) {
-            const sold = priced.sold.get(i);
-            const qline = priced.lines[i];
-            if (line.kind !== 'room' || !sold || !qline)
+            if (line.kind !== 'room')
                 throw new Error('Nothing was booked: the trip changed while it was being priced.');
+            const sold = priced.sold.get(i);
+            if (!sold) {
+                const d = priced.dropped?.[droppedAt.indexOf(i)];
+                failStay(line, d ? `${d.title}: ${d.why}` : 'It cannot be booked now.', 'unavailable');
+                continue;
+            }
+            const qline = priced.lines[soldAt.indexOf(i)];
             plans.push({ i, line, sold, qline });
         }
         // ⚠️ A STAY PAID IN ADVANCE IS BOOKED ON ITS OWN (v1): its money is taken
         // before Huazhu is asked, and a trip half paid and half not - or two paid
         // stays, one refused - has no whole refund to give (总线程, 2026-10-12).
-        if (plans.length > 1 && plans.some((p) => p.sold.res.prepaid))
+        // The whole trip's rule: nothing is booked.
+        if (lines.length > 1 && plans.some((p) => p.sold.res.prepaid))
             throw new Error('Nothing was booked: a stay paid in advance is booked on its own here. Take the other stays out of the trip, book this one, then book the rest.');
+        // Prebook is Huazhu's own check of price, rooms and rules - for each stay
+        // before any is booked, so a stay it turns down is said with the others'
+        // outcome, not after them.
         for (const plan of plans) {
             const s = plan.sold.res;
             const title = `${plan.qline.hotelName} - ${plan.qline.title}`;
+            const named = { hotel: plan.qline.hotelName, room: plan.qline.title };
             try {
                 const out = await client.prebook({
                     hotelId: plan.line.hotelId,
@@ -1612,11 +1687,20 @@ export const createHuazhuHotels = (opts) => {
                 plan.token = out?.preBookToken;
             }
             catch (err) {
-                if (err instanceof HuazhuRefusal)
-                    throw new Error(`Nothing was booked. ${refusalWords(err, title, s.currency)}`);
-                throw new Error(`Nothing was booked: Huazhu could not be reached to check ${title} (${err.message}). Asking again is safe.`);
+                const rooms = plan.qline.quantity ?? 1;
+                if (err instanceof HuazhuRefusal) {
+                    const { code, args } = refusalCode(err, rooms);
+                    failStay(plan.line, refusalWords(err, title, s.currency), code, args, named);
+                }
+                else
+                    failStay(plan.line, `Huazhu could not be reached to check ${title} (${err.message}). Asking again for this stay is safe.`, 'unreachable', undefined, named);
+                plan.token = undefined;
+                plan.out = true;
             }
         }
+        plans = plans.filter((p) => !p.out);
+        if (plans.length === 0)
+            return { booked: [], failed };
         requestsByEmail.add(email);
         requestsByConversation.add(conversationOf(who));
         const tripRef = randomUUID();
@@ -1700,66 +1784,19 @@ export const createHuazhuHotels = (opts) => {
                 store.update(id, { status: 'failed' });
                 throw new Error(`Nothing was booked or charged: the payment page could not be opened (${err.message}). Asking again is safe.`);
             }
-            return [
-                publicBooking(store.update(id, {
-                    prepaid: { ...record, sessionId: opened.sessionId, url: opened.url },
-                }) ?? row),
-            ];
+            return {
+                booked: [
+                    publicBooking(store.update(id, {
+                        prepaid: { ...record, sessionId: opened.sessionId, url: opened.url },
+                    }) ?? row),
+                ],
+                failed,
+            };
         }
         const made = [];
-        /**
-         * Undo what this trip booked, when a later stay of it failed - and say
-         * what actually became of each, not what was meant to (2026-10-05 audit,
-         * e7: "flagged for a person" of a stay nobody had flagged).
-         */
-        const takeBackAll = async () => {
-            const waiting = [];
-            const charged = [];
-            const flagged = [];
-            const retrying = [];
-            for (const b of made) {
-                const row = store.update(b.id, { rollback: true });
-                if (!row || row.status === 'failed' || row.status === 'cancelled')
-                    continue;
-                if (row.pendingSince !== undefined || row.status !== 'confirmed') {
-                    // The reconciler cancels it if it turns up.
-                    waiting.push(named(row));
-                    continue;
-                }
-                await reconciler.takeBack(row);
-                const after = store.get(b.id) ?? row;
-                if (after.status === 'cancelled') {
-                    if (after.cancellationFee && after.cancellationFee.minor > 0)
-                        charged.push(`${named(after)}: ${formatMoney(after.cancellationFee)}`);
-                }
-                else if (after.attention && !after.resolvedAt)
-                    flagged.push(named(after));
-                else
-                    retrying.push(named(after));
-            }
-            const and = (xs) => xs.join(' and ');
-            return [
-                charged.length
-                    ? ` Cancelling again cost a fee under the rate's terms - ${charged.join('; ')}. A person here has been told and will follow it up.`
-                    : '',
-                flagged.length
-                    ? ` ${and(flagged)} could not be cancelled automatically and has been flagged for a person to cancel with the hotel.`
-                    : '',
-                retrying.length
-                    ? ` ${and(retrying)} could not be cancelled yet: it is tried again automatically, and a person is told if that keeps failing.`
-                    : '',
-                waiting.length
-                    ? ` Whether ${and(waiting)} was booked is not known yet; if it turns up in the next few minutes it is cancelled automatically.`
-                    : '',
-            ].join('');
-        };
-        const notWritten = async (title) => {
-            const back = await takeBackAll();
-            throw new Error(`Nothing was booked: ${title} could not be written down here before asking Huazhu, so it was not asked for. A person has been told.${back}`);
-        };
         // ⚠️ THE REQUEST, WRITTEN DOWN BEFORE ITS FIRST STAY IS BOOKED. A
-        // process that dies half way through a trip leaves this open, and the
-        // next one takes back what it booked (`Reconciler.recover`).
+        // process that dies half way through a trip leaves this open; the next
+        // one closes it and keeps what it booked (`Reconciler.recover`).
         try {
             store.open({
                 tripRef,
@@ -1772,12 +1809,13 @@ export const createHuazhuHotels = (opts) => {
         }
         catch (err) {
             if (err instanceof StoreWriteError)
-                return notWritten('the trip');
+                throw new Error('Nothing was booked: the trip could not be written down here before asking Huazhu, so it was not asked for. A person has been told.');
             throw err;
         }
         try {
-            for (const plan of plans) {
+            for (const [k, plan] of plans.entries()) {
                 const s = plan.sold.res;
+                const named = { hotel: plan.qline.hotelName, room: plan.qline.title };
                 const rooms = plan.qline.quantity ?? 1;
                 const qTotal = plan.qline.total.minor;
                 const nightlyMinor = s.after.map((x) => toMinor(x, s.currency));
@@ -1830,9 +1868,15 @@ export const createHuazhuHotels = (opts) => {
                     store.put(row);
                 }
                 catch (err) {
-                    if (err instanceof StoreWriteError)
-                        return notWritten(title);
-                    throw err;
+                    if (!(err instanceof StoreWriteError))
+                        throw err;
+                    // Not written down, not asked for - and nor is any stay after it:
+                    // a disk that took nothing now will not take the next one. What was
+                    // booked before it is kept.
+                    for (const rest of plans.slice(k))
+                        failStay(rest.line, `${rest.qline.hotelName} - ${rest.qline.title} could not be written down here before asking Huazhu, so it was not asked for. A person has been told.`, 'unavailable', undefined, { hotel: rest.qline.hotelName, room: rest.qline.title });
+                    console.error(`[huazhu trip ${tripRef}] ⚠️ NEEDS A PERSON: the booking file could not be written - ${plans.length - k} stay(s) not asked for`);
+                    break;
                 }
                 made.push(row);
                 slot.n -= 1;
@@ -1900,33 +1944,30 @@ export const createHuazhuHotels = (opts) => {
                     continue;
                 }
                 if (refusal) {
-                    // Never made at Huazhu: nothing to follow up, nothing to show.
+                    // Never made at Huazhu: nothing to follow up, nothing to show -
+                    // and the stays booked before it stay booked.
                     store.update(id, { pendingSince: undefined, status: 'failed' });
                     made.pop();
-                    const before = made.length;
-                    const back = await takeBackAll();
-                    throw new Error(`Nothing was booked. ${refusalWords(refusal, title, cur)}${before && !back ? ' The stays booked before it in this trip were cancelled again.' : ''}${back}`);
+                    const { code, args } = refusalCode(refusal, rooms);
+                    failStay(plan.line, refusalWords(refusal, title, cur), code, args, named);
+                    continue;
                 }
                 // Unknown: the eight minutes run from the moment that was known.
                 store.update(id, { pendingSince: now() });
                 const settled = await settle(id);
-                if (settled?.status === 'confirmed' && settled.pendingSince === undefined)
-                    continue;
-                if (plans.length > 1 || settled?.status === 'failed') {
-                    const back = await takeBackAll();
-                    if (settled?.status === 'failed') {
-                        throw new Error(`Nothing was booked: Huazhu did not confirm ${plan.qline.hotelName}.${back}`);
-                    }
-                    throw new Error(`Nothing was booked: Huazhu did not answer in time for ${plan.qline.hotelName}, so the trip was stopped.${back}`);
+                if (settled?.status === 'failed') {
+                    made.pop();
+                    failStay(plan.line, `Huazhu did not confirm ${plan.qline.hotelName}: it was looked for and not found, so it was not booked.`, 'unavailable', undefined, named);
                 }
-                // One stay, outcome still unknown: it is the guest's booking, marked
-                // as waiting, and the reconciler settles it within eight minutes.
+                // Confirmed - or still unknown: then it is the guest's booking, marked
+                // as waiting (`requested`), and the reconciler settles it within eight
+                // minutes from its distributorResId, written down before it was sent.
             }
         }
         finally {
-            store.close(tripRef);
+            store.close(tripRef, failed.length ? { failed } : {});
         }
-        return made.map((b) => publicBooking(store.get(b.id) ?? b));
+        return { booked: made.map((b) => publicBooking(store.get(b.id) ?? b)), failed };
     };
     return {
         brand: opts.brand,