@cuongtran001/kanna 1.2.0 → 1.3.1

package/src/shared/app-settings-types.ts

@@ -0,0 +1,365 @@
+// Application settings domain types.
+// Extracted from types.ts to keep the barrel lean.
+// All external consumers importing from "../shared/types" continue to work unchanged.
+
+import type {
+  AppThemePreference,
+  ChatSoundPreference,
+  ChatSoundId,
+  EditorPreset,
+  DefaultProviderPreference,
+  LlmProviderKind,
+} from "./core-types"
+import type {
+  ChatProviderPreferences,
+  ProviderPreference,
+  ClaudeModelOptions,
+  CodexModelOptions,
+  OpenRouterModelOptions,
+  CustomModelEntry,
+  CustomModelInput,
+  CustomModelPatch,
+  TextSnippet,
+  TextSnippetInput,
+  TextSnippetPatch,
+} from "./provider-model-types"
+import type {
+  McpServerConfig,
+  McpServerInput,
+  McpServerPatch,
+  McpServerTestResult,
+  McpOAuthState,
+} from "./mcp-types"
+import type { Subagent, SubagentInput, SubagentPatch } from "./subagent-types"
+
+// ---------------------------------------------------------------------------
+// Auth
+// ---------------------------------------------------------------------------
+
+export interface AuthSettings {
+  sessionMaxAgeDays: number
+}
+
+export const AUTH_DEFAULTS: AuthSettings = {
+  sessionMaxAgeDays: 30,
+}
+
+export const AUTH_SESSION_MAX_AGE_DAYS_MIN = 1
+export const AUTH_SESSION_MAX_AGE_DAYS_MAX = 365
+
+export type OAuthTokenStatus = "active" | "limited" | "error" | "disabled"
+
+export interface OAuthTokenEntry {
+  id: string
+  label: string
+  token: string
+  status: OAuthTokenStatus
+  limitedUntil: number | null
+  lastUsedAt: number | null
+  lastErrorAt: number | null
+  lastErrorMessage: string | null
+  addedAt: number
+  // Per-token concurrent-chat cap. When omitted, the pool falls back to
+  // ClaudeAuthSettings.concurrencyDefault. Default 1 preserves the
+  // historical 1-token-per-chat invariant. Range
+  // [OAUTH_TOKEN_MAX_CONCURRENT_MIN, OAUTH_TOKEN_MAX_CONCURRENT_MAX].
+  maxConcurrent?: number
+}
+
+export interface ClaudeAuthSettings {
+  tokens: OAuthTokenEntry[]
+  // Pool-wide default applied to tokens whose maxConcurrent is omitted.
+  concurrencyDefault: number
+}
+
+export const OAUTH_TOKEN_MAX_CONCURRENT_MIN = 1
+export const OAUTH_TOKEN_MAX_CONCURRENT_MAX = 5
+export const OAUTH_TOKEN_CONCURRENCY_DEFAULT = 1
+
+export const CLAUDE_AUTH_DEFAULTS: ClaudeAuthSettings = {
+  tokens: [],
+  concurrencyDefault: OAUTH_TOKEN_CONCURRENCY_DEFAULT,
+}
+
+export const OAUTH_TOKEN_LABEL_MAX = 64
+export const OAUTH_TOKEN_VALUE_MAX = 1024
+
+// ---------------------------------------------------------------------------
+// Upload
+// ---------------------------------------------------------------------------
+
+export interface UploadSettings {
+  maxFileSizeMb: number
+}
+
+export const UPLOAD_DEFAULTS: UploadSettings = {
+  maxFileSizeMb: 100,
+}
+
+export const UPLOAD_MAX_FILE_SIZE_MB_MIN = 1
+export const UPLOAD_MAX_FILE_SIZE_MB_MAX = 2048
+
+export const GLOBAL_PROMPT_APPEND_MAX_CHARS = 8_000
+
+// ---------------------------------------------------------------------------
+// Claude driver
+// ---------------------------------------------------------------------------
+
+export type ClaudeDriverPreference = "sdk" | "pty"
+
+export const CLAUDE_DRIVER_VALUES: readonly ClaudeDriverPreference[] = ["sdk", "pty"]
+
+export function isClaudeDriverPreference(value: string | null | undefined): value is ClaudeDriverPreference {
+  return value === "sdk" || value === "pty"
+}
+
+export interface ClaudePtyLifecycleSettings {
+  idleTimeoutMs: number
+  maxConcurrent: number
+}
+
+export const CLAUDE_PTY_LIFECYCLE_DEFAULTS: ClaudePtyLifecycleSettings = {
+  idleTimeoutMs: 600_000,
+  maxConcurrent: 4,
+}
+
+export const CLAUDE_PTY_IDLE_TIMEOUT_MS_MIN = 60_000
+export const CLAUDE_PTY_IDLE_TIMEOUT_MS_MAX = 3_600_000
+export const CLAUDE_PTY_MAX_CONCURRENT_MIN = 1
+export const CLAUDE_PTY_MAX_CONCURRENT_MAX = 16
+
+export interface ClaudeDriverSettings {
+  preference: ClaudeDriverPreference
+  lifecycle: ClaudePtyLifecycleSettings
+}
+
+export const CLAUDE_DRIVER_DEFAULTS: ClaudeDriverSettings = {
+  preference: "sdk",
+  lifecycle: { ...CLAUDE_PTY_LIFECYCLE_DEFAULTS },
+}
+
+export type ClaudeSessionLifecycleStatus = "cold" | "warming" | "active" | "idle" | "cooling"
+
+export interface ChatSessionStateSnapshot {
+  chatId: string
+  state: ClaudeSessionLifecycleStatus
+  updatedAt: number
+}
+
+// ---------------------------------------------------------------------------
+// Cloudflare tunnel
+// ---------------------------------------------------------------------------
+
+export type CloudflareTunnelMode = "always-ask" | "auto-expose"
+
+export interface CloudflareTunnelSettings {
+  enabled: boolean
+  cloudflaredPath: string
+  mode: CloudflareTunnelMode
+}
+
+export const CLOUDFLARE_TUNNEL_DEFAULTS: CloudflareTunnelSettings = {
+  enabled: false,
+  cloudflaredPath: "cloudflared",
+  mode: "always-ask",
+}
+
+export type CloudflareTunnelState = "proposed" | "active" | "stopped" | "failed"
+
+export interface CloudflareTunnelRecord {
+  tunnelId: string
+  chatId: string
+  port: number
+  state: CloudflareTunnelState
+  url: string | null
+  error: string | null
+  proposedAt: number
+  activatedAt: number | null
+  stoppedAt: number | null
+}
+
+// ---------------------------------------------------------------------------
+// Keybindings
+// ---------------------------------------------------------------------------
+
+export type KeybindingAction =
+  | "toggleEmbeddedTerminal"
+  | "toggleRightSidebar"
+  | "openInFinder"
+  | "openInEditor"
+  | "addSplitTerminal"
+  | "jumpToSidebarChat"
+  | "createChatInCurrentProject"
+  | "openAddProject"
+  | "newStack"
+  | "newStackChat"
+  | "jumpToStacks"
+
+export const DEFAULT_KEYBINDINGS: Record<KeybindingAction, string[]> = {
+  toggleEmbeddedTerminal: ["cmd+j", "ctrl+`"],
+  toggleRightSidebar: ["cmd+b", "ctrl+b"],
+  openInFinder: ["cmd+alt+f", "ctrl+alt+f"],
+  openInEditor: ["cmd+shift+o", "ctrl+shift+o"],
+  addSplitTerminal: ["cmd+/", "ctrl+/"],
+  jumpToSidebarChat: ["cmd+alt"],
+  createChatInCurrentProject: ["cmd+alt+n"],
+  openAddProject: ["cmd+alt+o"],
+  newStack: ["cmd+alt+w"],
+  newStackChat: ["cmd+alt+shift+n"],
+  jumpToStacks: ["g s"],
+}
+
+export const KEYBINDING_ACTIONS: readonly KeybindingAction[] = [
+  "toggleEmbeddedTerminal",
+  "toggleRightSidebar",
+  "openInFinder",
+  "openInEditor",
+  "addSplitTerminal",
+  "jumpToSidebarChat",
+  "createChatInCurrentProject",
+  "openAddProject",
+  "newStack",
+  "newStackChat",
+  "jumpToStacks",
+] satisfies KeybindingAction[]
+
+export interface KeybindingsSnapshot {
+  bindings: Record<KeybindingAction, string[]>
+  warning: string | null
+  filePathDisplay: string
+}
+
+// ---------------------------------------------------------------------------
+// App settings snapshot & patch
+// ---------------------------------------------------------------------------
+
+export interface AppSettingsSnapshot {
+  analyticsEnabled: boolean
+  browserSettingsMigrated: boolean
+  theme: AppThemePreference
+  chatSoundPreference: ChatSoundPreference
+  chatSoundId: ChatSoundId
+  terminal: {
+    scrollbackLines: number
+    minColumnWidth: number
+  }
+  editor: {
+    preset: EditorPreset
+    commandTemplate: string
+  }
+  defaultProvider: DefaultProviderPreference
+  providerDefaults: ChatProviderPreferences
+  warning: string | null
+  filePathDisplay: string
+  cloudflareTunnel: CloudflareTunnelSettings
+  auth: AuthSettings
+  claudeAuth: ClaudeAuthSettings
+  uploads: UploadSettings
+  subagents: Subagent[]
+  customMcpServers: McpServerConfig[]
+  customModels: CustomModelEntry[]
+  textSnippets: TextSnippet[]
+  claudeDriver: ClaudeDriverSettings
+  globalPromptAppend: string
+  shareDefaultTtlHours: number
+  subagentRuntime: SubagentRuntimeSettings
+}
+
+/**
+ * Runtime knobs for delegated subagent runs (delegate_subagent) and the
+ * autonomous loop (setup_loop). `runTimeoutMs` is the stall/idle watchdog
+ * window — a run is aborted only after this long with NO streamed activity,
+ * not a total wall-clock cap. `defaultLoopSubagentId` is the subagent
+ * setup_loop delegates to when the caller omits an explicit id.
+ */
+export interface SubagentRuntimeSettings {
+  runTimeoutMs: number
+  defaultLoopSubagentId: string | null
+  /**
+   * Subagent an orchestration run (orch_run) delegates each phase to when the
+   * caller omits an explicit id. Optional: absent = no default (the caller must
+   * pass `subagentId`). Full settings CRUD/UI is a later phase.
+   */
+  defaultOrchSubagentId?: string | null
+}
+
+export interface AppSettingsPatch {
+  analyticsEnabled?: boolean
+  browserSettingsMigrated?: boolean
+  theme?: AppThemePreference
+  chatSoundPreference?: ChatSoundPreference
+  chatSoundId?: ChatSoundId
+  terminal?: Partial<AppSettingsSnapshot["terminal"]>
+  editor?: Partial<AppSettingsSnapshot["editor"]>
+  defaultProvider?: DefaultProviderPreference
+  providerDefaults?: {
+    claude?: Partial<ProviderPreference<ClaudeModelOptions>>
+    codex?: Partial<ProviderPreference<CodexModelOptions>>
+    openrouter?: Partial<ProviderPreference<OpenRouterModelOptions>>
+  }
+  cloudflareTunnel?: Partial<CloudflareTunnelSettings>
+  auth?: Partial<AuthSettings>
+  claudeAuth?: Partial<ClaudeAuthSettings>
+  uploads?: Partial<UploadSettings>
+  subagents?: {
+    create?: SubagentInput
+    update?: { id: string; patch: SubagentPatch }
+    delete?: { id: string }
+  }
+  customMcpServers?: {
+    create?: McpServerInput
+    update?: { id: string; patch: McpServerPatch }
+    delete?: { id: string }
+    setEnabled?: { id: string; enabled: boolean }
+    setTestResult?: { id: string; result: McpServerTestResult }
+    setOAuthState?: { id: string; oauth: McpOAuthState }
+  }
+  customModels?: {
+    create?: CustomModelInput
+    update?: { id: string; patch: CustomModelPatch }
+    delete?: { id: string }
+  }
+  textSnippets?: {
+    create?: TextSnippetInput
+    update?: { id: string; patch: TextSnippetPatch }
+    delete?: { id: string }
+  }
+  claudeDriver?: {
+    preference?: ClaudeDriverPreference
+    lifecycle?: Partial<ClaudePtyLifecycleSettings>
+  }
+  globalPromptAppend?: string
+  shareDefaultTtlHours?: number
+  subagentRuntime?: Partial<SubagentRuntimeSettings>
+}
+
+// ---------------------------------------------------------------------------
+// Type guards
+// ---------------------------------------------------------------------------
+
+export function isEditorPreset(value: string): value is EditorPreset {
+  return value === "cursor" || value === "vscode" || value === "xcode" || value === "windsurf" || value === "custom"
+}
+
+export function isChatSoundPreference(value: string): value is ChatSoundPreference {
+  return value === "never" || value === "unfocused" || value === "always"
+}
+
+export function isChatSoundId(value: string): value is ChatSoundId {
+  return (
+    value === "blow" || value === "bottle" || value === "frog" || value === "funk" ||
+    value === "glass" || value === "ping" || value === "pop" || value === "purr" || value === "tink"
+  )
+}
+
+export function isCloudFlareTunnelMode(value: string): value is CloudflareTunnelMode {
+  return value === "always-ask" || value === "auto-expose"
+}
+
+export function isLlmProviderKind(value: string): value is LlmProviderKind {
+  return value === "openai" || value === "openrouter" || value === "custom"
+}
+
+export function isAppThemePreference(value: string): value is AppThemePreference {
+  return value === "light" || value === "dark" || value === "system"
+}

package/src/shared/core-types.ts

@@ -0,0 +1,27 @@
+// Core primitive types shared across all domain modules.
+// Extracted from types.ts to break circular-import chains between
+// domain-specific type files (e.g. app-settings-types, subagent-types).
+//
+// Do NOT add complex interfaces here — keep this file to simple
+// union types, string-literal unions, and small constants.
+
+export const STORE_VERSION = 3 as const
+export const PROTOCOL_VERSION = 1 as const
+
+export type AgentProvider = "claude" | "codex" | "openrouter"
+export type LlmProviderKind = "openai" | "openrouter" | "custom"
+export type AppThemePreference = "light" | "dark" | "system"
+export type ChatSoundPreference = "never" | "unfocused" | "always"
+export type ChatSoundId = "blow" | "bottle" | "frog" | "funk" | "glass" | "ping" | "pop" | "purr" | "tink"
+export type DefaultProviderPreference = "last_used" | AgentProvider
+export type EditorPreset = "cursor" | "vscode" | "xcode" | "windsurf" | "custom"
+export const DEFAULT_OPENAI_SDK_MODEL = "gpt-5.4-mini"
+
+export type AttachmentKind = "image" | "file" | "mention"
+
+export type KannaStatus =
+  | "idle"
+  | "starting"
+  | "running"
+  | "waiting_for_user"
+  | "failed"

package/src/shared/git-diff-types.ts

@@ -0,0 +1,165 @@
+// Git diff, branch, and worktree types.
+// Extracted from types.ts to keep the barrel lean.
+// All external consumers importing from "../shared/types" continue to work unchanged.
+
+export interface ChatDiffFile {
+  path: string
+  changeType: "added" | "deleted" | "modified" | "renamed"
+  isUntracked: boolean
+  additions: number
+  deletions: number
+  patchDigest: string
+  mimeType?: string
+  size?: number
+}
+
+export interface ChatBranchHistoryEntry {
+  sha: string
+  summary: string
+  description: string
+  authorName?: string
+  authoredAt: string
+  tags: string[]
+  githubUrl?: string
+}
+
+export interface ChatBranchHistorySnapshot {
+  entries: ChatBranchHistoryEntry[]
+}
+
+export type ChatBranchListEntryKind = "local" | "remote" | "pull_request"
+
+export interface ChatBranchListEntry {
+  id: string
+  kind: ChatBranchListEntryKind
+  name: string
+  displayName: string
+  updatedAt?: string
+  description?: string
+  remoteRef?: string
+  prNumber?: number
+  prTitle?: string
+  headRefName?: string
+  headLabel?: string
+  headRepoCloneUrl?: string
+  isCrossRepository?: boolean
+}
+
+export interface ChatBranchListResult {
+  currentBranchName?: string
+  defaultBranchName?: string
+  recent: ChatBranchListEntry[]
+  local: ChatBranchListEntry[]
+  remote: ChatBranchListEntry[]
+  pullRequests: ChatBranchListEntry[]
+  pullRequestsStatus: "available" | "unavailable" | "error"
+  pullRequestsError?: string
+}
+
+export interface GitHubPublishInfo {
+  ghInstalled: boolean
+  authenticated: boolean
+  activeAccountLogin?: string
+  owners: string[]
+  suggestedRepoName: string
+}
+
+export interface GitHubRepoAvailabilityResult {
+  available: boolean
+  message: string
+}
+
+export interface BranchMetadata {
+  branchName?: string
+  defaultBranchName?: string
+  hasOriginRemote?: boolean
+  originRepoSlug?: string
+  hasUpstream?: boolean
+}
+
+export interface UpstreamStatus {
+  aheadCount?: number
+  behindCount?: number
+  lastFetchedAt?: string
+}
+
+export interface ChatDiffSnapshot extends BranchMetadata, UpstreamStatus {
+  status: "unknown" | "ready" | "no_repo"
+  files: ChatDiffFile[]
+  branchHistory?: ChatBranchHistorySnapshot
+}
+
+export interface BranchActionSuccess {
+  ok: true
+  branchName?: string
+  snapshotChanged: boolean
+}
+
+export interface BranchActionFailure {
+  ok: false
+  title: string
+  message: string
+  detail?: string
+  cancelled?: boolean
+  snapshotChanged?: boolean
+}
+
+export type ChatSyncSuccess = BranchActionSuccess & {
+  action: "fetch" | "pull" | "push" | "publish"
+  aheadCount?: number
+  behindCount?: number
+}
+
+export type ChatSyncFailure = BranchActionFailure & {
+  action: "fetch" | "pull" | "push" | "publish"
+}
+
+export type ChatSyncResult = ChatSyncSuccess | ChatSyncFailure
+
+export type DiffCommitMode = "commit_and_push" | "commit_only"
+
+export type ChatCheckoutBranchSuccess = BranchActionSuccess
+export type ChatCheckoutBranchFailure = BranchActionFailure
+export type ChatCheckoutBranchResult = ChatCheckoutBranchSuccess | ChatCheckoutBranchFailure
+
+export type ChatCreateBranchSuccess = BranchActionSuccess & { branchName: string }
+export type ChatCreateBranchFailure = BranchActionFailure
+export type ChatCreateBranchResult = ChatCreateBranchSuccess | ChatCreateBranchFailure
+
+export type ChatMergePreviewStatus = "up_to_date" | "mergeable" | "conflicts" | "error"
+
+export interface ChatMergePreviewResult {
+  currentBranchName?: string
+  targetBranchName: string
+  targetDisplayName: string
+  status: ChatMergePreviewStatus
+  commitCount: number
+  hasConflicts: boolean
+  message: string
+  detail?: string
+}
+
+export type ChatMergeBranchSuccess = BranchActionSuccess
+export type ChatMergeBranchFailure = BranchActionFailure
+export type ChatMergeBranchResult = ChatMergeBranchSuccess | ChatMergeBranchFailure
+
+export type DiffCommitSuccess = BranchActionSuccess & {
+  mode: DiffCommitMode
+  pushed: boolean
+}
+
+export type DiffCommitFailure = BranchActionFailure & {
+  mode: DiffCommitMode
+  phase: "commit" | "push"
+  localCommitCreated?: boolean
+}
+
+export type DiffCommitResult = DiffCommitSuccess | DiffCommitFailure
+
+export interface GitWorktree {
+  path: string                 // absolute
+  branch: string               // e.g. "main", "feat/x", "(detached)"
+  sha: string                  // HEAD commit sha
+  isPrimary: boolean
+  isLocked: boolean            // git has flagged this worktree as locked (pruning inhibited)
+}

package/src/shared/loop-progress.test.ts

@@ -0,0 +1,106 @@
+import { describe, expect, test } from "bun:test"
+import { buildLoopProgress, deriveChunkLabel } from "./loop-progress"
+import type { SubagentRunSnapshot } from "./types"
+
+function run(overrides: Partial<SubagentRunSnapshot>): SubagentRunSnapshot {
+  return {
+    runId: "run-1",
+    chatId: "c1",
+    subagentId: "sa-1",
+    subagentName: "subagent-general",
+    label: null,
+    provider: "claude",
+    model: "claude-sonnet-4-6",
+    status: "running",
+    parentUserMessageId: "m1",
+    parentRunId: null,
+    depth: 0,
+    startedAt: 1_000,
+    finishedAt: null,
+    finalText: null,
+    error: null,
+    usage: null,
+    entries: [],
+    pendingTool: null,
+    ...overrides,
+  }
+}
+
+describe("deriveChunkLabel", () => {
+  test("first non-blank line, trimmed", () => {
+    expect(deriveChunkLabel("\n\n  Migrate useKannaState.ts  \nmore detail")).toBe(
+      "Migrate useKannaState.ts",
+    )
+  })
+
+  test("strips a single leading markdown marker", () => {
+    expect(deriveChunkLabel("- Fix Dockerfiles for Berry")).toBe("Fix Dockerfiles for Berry")
+    expect(deriveChunkLabel("## Build + start full stack")).toBe("Build + start full stack")
+    expect(deriveChunkLabel("3. Verify service health")).toBe("Verify service health")
+    expect(deriveChunkLabel("> quoted chunk")).toBe("quoted chunk")
+  })
+
+  test("does not mistake mid-line content for a marker", () => {
+    expect(deriveChunkLabel("3D rendering pipeline")).toBe("3D rendering pipeline")
+  })
+
+  test("caps overlong labels with an ellipsis", () => {
+    const long = "x".repeat(200)
+    const label = deriveChunkLabel(long)
+    expect(label.length).toBe(80)
+    expect(label.endsWith("…")).toBe(true)
+  })
+
+  test("empty prompt → empty string", () => {
+    expect(deriveChunkLabel("   \n  ")).toBe("")
+  })
+})
+
+describe("buildLoopProgress", () => {
+  test("maps run status → row status and prefers label over subagentName", () => {
+    const snapshot = buildLoopProgress({
+      chatId: "c1",
+      armed: true,
+      loopArmedAt: 0,
+      rateLimit: null,
+      runs: [
+        run({ runId: "r1", status: "completed", label: "chunk one", startedAt: 10, finishedAt: 20 }),
+        run({ runId: "r2", status: "running", label: null, subagentName: "worker", startedAt: 30 }),
+        run({ runId: "r3", status: "failed", label: "chunk three", startedAt: 40 }),
+      ],
+    })
+    expect(snapshot.rows.map((r) => [r.runId, r.status, r.label])).toEqual([
+      ["r3", "failed", "chunk three"],
+      ["r2", "running", "worker"], // label fallback to subagentName
+      ["r1", "done", "chunk one"],
+    ])
+  })
+
+  test("excludes nested sub-spawns and runs started before the loop armed", () => {
+    const snapshot = buildLoopProgress({
+      chatId: "c1",
+      armed: true,
+      loopArmedAt: 100,
+      rateLimit: null,
+      runs: [
+        run({ runId: "pre", startedAt: 50 }), // before arm → excluded
+        run({ runId: "nested", startedAt: 150, depth: 1 }), // sub-spawn → excluded
+        run({ runId: "keep", startedAt: 200 }),
+      ],
+    })
+    expect(snapshot.rows.map((r) => r.runId)).toEqual(["keep"])
+  })
+
+  test("passes rate-limit through and reflects armed flag", () => {
+    const snapshot = buildLoopProgress({
+      chatId: "c1",
+      armed: false,
+      loopArmedAt: null,
+      rateLimit: { scheduleId: "s1", resetAt: 123, tz: "Asia/Saigon", scheduled: false },
+      runs: [],
+    })
+    expect(snapshot.armed).toBe(false)
+    expect(snapshot.rateLimit).toEqual({ scheduleId: "s1", resetAt: 123, tz: "Asia/Saigon", scheduled: false })
+    expect(snapshot.rows).toEqual([])
+  })
+})