@cueloop/schema 0.1.0-alpha.34 → 0.1.0-alpha.36

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/schema",
-  "version": "0.1.0-alpha.34",
+  "version": "0.1.0-alpha.36",
   "description": "The ReviewSession primitive: types, markdown block model, quote-primary anchors, feedback serialization",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {

package/src/herdr.test.ts

@@ -4,7 +4,15 @@ import { detectHerdr, insideHerdr, returnPaneFor } from "./herdr";
 describe("detectHerdr", () => {
   test("null outside herdr, context inside", () => {
     expect(detectHerdr({})).toBeNull();
-    expect(detectHerdr({ HERDR_ENV: "1", HERDR_PANE_ID: "p1" })).toBeNull();
+    // no HERDR_ENV or no pane id means we are not in a usable herdr pane
+    expect(detectHerdr({ HERDR_PANE_ID: "p1" })).toBeNull();
+    expect(detectHerdr({ HERDR_ENV: "1" })).toBeNull();
+    // herdr 0.8.0 sets no HERDR_BIN_PATH: the binary defaults to `herdr` on PATH
+    expect(detectHerdr({ HERDR_ENV: "1", HERDR_PANE_ID: "p1" })).toEqual({
+      paneId: "p1",
+      binPath: "herdr",
+    });
+    // an explicit HERDR_BIN_PATH (tests, or a pinned install) still wins
     expect(
       detectHerdr({ HERDR_ENV: "1", HERDR_PANE_ID: "p1", HERDR_BIN_PATH: "/x/herdr" }),
     ).toEqual({

package/src/herdr.ts

@@ -1,10 +1,12 @@
 /**
  * The herdr ambient env contract, single-sourced. A process running inside a
- * herdr pane sees HERDR_ENV=1 plus the pane id and the herdr binary path.
- * Both the agent-side reporter (adapters) and the reviewer-side return-focus
- * (client) read this contract; decoding it in one place stops the two sides
- * drifting on which vars are required. Pure: no IO, env is only the default
- * argument so callers can pass a fixture.
+ * herdr pane sees HERDR_ENV=1 plus the pane id; the herdr CLI itself reaches
+ * the app over HERDR_SOCKET_PATH (which the spawned `herdr` reads from the
+ * inherited env), so the binary is just `herdr` on PATH. Both the agent-side
+ * reporter (adapters) and the reviewer-side return-focus (client) read this
+ * contract; decoding it in one place stops the two sides drifting on which
+ * vars are required. Pure: no IO, env is only the default argument so callers
+ * can pass a fixture.
  */
 
 export interface HerdrContext {
@@ -21,8 +23,11 @@ export type HerdrEnv = Record<string, string | undefined>;
 export function detectHerdr(env: HerdrEnv = process.env): HerdrContext | null {
   if (env.HERDR_ENV !== "1") return null;
   const paneId = env.HERDR_PANE_ID;
-  const binPath = env.HERDR_BIN_PATH;
-  if (!paneId || !binPath) return null;
+  if (!paneId) return null;
+  // herdr 0.8.0 exposes no HERDR_BIN_PATH; the CLI is `herdr` on PATH and finds
+  // the app over HERDR_SOCKET_PATH from the inherited env. Tests still override
+  // HERDR_BIN_PATH to point the spawn at a stub script.
+  const binPath = env.HERDR_BIN_PATH ?? "herdr";
   return { paneId, binPath };
 }