@cueloop/schema 0.1.0-alpha.14 → 0.1.0-alpha.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/schema",
-  "version": "0.1.0-alpha.14",
+  "version": "0.1.0-alpha.16",
   "license": "Apache-2.0",
   "type": "module",
   "exports": {

package/src/feedback.test.ts

@@ -98,6 +98,25 @@ describe("renderFeedback", () => {
     expect(out).toContain("_No edits or annotations._");
   });
 
+  test("agent notes never come back as feedback items", () => {
+    const note = ann({
+      kind: "note",
+      anchor: { quote: "src/a.ts", prefix: "", suffix: "" },
+      body: "The agent's own explanation of the change.",
+    });
+    const noteOnly = renderFeedback({ verdictKind: "approve", summary: "", artifactContent: PLAN, annotations: [note] });
+    expect(noteOnly).toContain("_No edits or annotations._");
+    expect(noteOnly).not.toContain("The agent's own explanation of the change.");
+    const mixed = renderFeedback({
+      verdictKind: "request_changes",
+      summary: "",
+      artifactContent: PLAN,
+      annotations: [note, ann({ anchor: { quote: "one JSON document", prefix: "written as ", suffix: " per session." } })],
+    });
+    expect(mixed).toContain("## Annotations (1)");
+    expect(mixed).not.toContain("The agent's own explanation of the change.");
+  });
+
   test("anchors resolve against the working copy when present", () => {
     // annotation made on text that only exists in the edited copy
     const working = PLAN.replace("## Storage", "## Persistence");

package/src/feedback.ts

@@ -5,7 +5,7 @@
  * first, then every annotation is addressed, located by quoted text.
  */
 
-import type { Annotation, ReviewSession, VerdictKind } from "./types";
+import { isAgentNote, type Annotation, type ReviewSession, type VerdictKind } from "./types";
 import { parseBlocks, sectionOf } from "./markdown";
 import { resolveAnchor } from "./anchor";
 import { unifiedDiffText } from "./diff";
@@ -26,6 +26,8 @@ const quoteLines = (s: string) => "> " + s.replace(/\n/g, "\n> ");
 
 export function renderFeedback(input: FeedbackInput): string {
   const path = input.planPath ?? "plan.md";
+  // agent notes are the submitter's own context - never echoed back as feedback
+  const annotations = input.annotations.filter((annotation) => !isAgentNote(annotation));
   const blocks = parseBlocks(input.workingCopy ?? input.artifactContent);
   const lines: string[] = [];
   lines.push("# Review: " + input.verdictKind.replace("_", " "));
@@ -49,12 +51,12 @@ export function renderFeedback(input: FeedbackInput): string {
     lines.push("");
   }
 
-  if (input.annotations.length) {
-    lines.push(`## Annotations (${input.annotations.length})`);
+  if (annotations.length) {
+    lines.push(`## Annotations (${annotations.length})`);
     lines.push("");
     lines.push(`Address every item. Locate each one in ${path} by its quoted text.`);
     lines.push("");
-    input.annotations.forEach((a, i) => {
+    annotations.forEach((a, i) => {
       const res = resolveAnchor(a.anchor, blocks);
       const sec = res ? sectionOf(blocks, res.blockIndex) : "";
       const loc = sec ? ` (§ ${sec})` : "";
@@ -77,7 +79,7 @@ export function renderFeedback(input: FeedbackInput): string {
     });
   }
 
-  if (!diff && !input.annotations.length) {
+  if (!diff && !annotations.length) {
     lines.push("_No edits or annotations._");
     lines.push("");
   }

package/src/types.ts

@@ -54,6 +54,16 @@ export interface Anchor {
 /** The annotation kind set is open (map #2); these are the built-ins. */
 export type AnnotationKind = "comment" | "suggestion" | (string & {});
 
+/**
+ * Agent-authored context, not reviewer feedback: the guided walk's per-file
+ * notes (kind "note", anchored by the file path). Excluded from the feedback
+ * document and the reviewer's pending counts - an agent must never receive
+ * its own notes back as items to address.
+ */
+export function isAgentNote(annotation: Pick<Annotation, "kind">): boolean {
+  return annotation.kind === "note";
+}
+
 export interface Annotation {
   id: string;
   kind: AnnotationKind;
@@ -97,6 +107,12 @@ export interface ReviewSession {
    * Undefined = no direct edits.
    */
   workingCopy?: string;
+  /**
+   * File paths the reviewer marked viewed during the guided walk (diff
+   * sessions). Persisting with the session means a resumed review keeps its
+   * progress. Undefined = the walk never started.
+   */
+  viewedPaths?: string[];
   verdict: Verdict | null;
   status: SessionStatus;
   createdAt: string;