@cueloop/daemon 0.1.0-alpha.7 → 0.1.0-alpha.71

package/src/herdr-pane.test.ts

@@ -0,0 +1,240 @@
+/** Creation-side herdr pane opener: a stubbed herdr binary logs its argv, openHerdrPane returns the tab handle, and openHerdrPaneForReview opens+records for a new review, focuses a still-alive recorded tab, and reopens a dead one - collision-free by pane id. */
+
+import { afterAll, describe, expect, test } from "bun:test";
+import { chmodSync, existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import type { Thread } from "@cueloop/schema";
+import { openHerdrPane, openHerdrPaneForReview } from "./herdr-pane";
+import type { HerdrTabPersistence } from "./herdr-pane";
+import type { HerdrTabHandle } from "./herdr-tab-store";
+
+const dir = mkdtempSync(join(tmpdir(), "cueloop-herdr-pane-"));
+
+/**
+ * A stub herdr binary. It logs argv, prints the tab-create result carrying both
+ * pane_id and tab_id (herdr 0.8.2 shape), and answers `pane get` alive or dead
+ * per `paneAlive` so the liveness branch can be exercised.
+ */
+function makeStub(name: string, paneAlive = false) {
+  const logPath = join(dir, `${name}.log`);
+  const binPath = join(dir, `${name}.sh`);
+  const paneGet = paneAlive ? `printf '{"result":{"pane":{"pane_id":"w1:p2"}}}'` : "exit 1";
+
+  writeFileSync(
+    binPath,
+    `#!/bin/sh
+printf '%s\\n' "$*" >> "${logPath}"
+if [ "$1" = "tab" ] && [ "$2" = "create" ]; then
+  printf '{"result":{"root_pane":{"pane_id":"w1:p2","tab_id":"w1:t2"}}}'
+fi
+if [ "$1" = "pane" ] && [ "$2" = "get" ]; then ${paneGet}; fi
+exit 0
+`,
+  );
+  chmodSync(binPath, 0o755);
+
+  return { binPath, logPath };
+}
+
+function readLines(logPath: string): string[] {
+  if (!existsSync(logPath)) return [];
+
+  return readFileSync(logPath, "utf8").split("\n").filter(Boolean);
+}
+
+/** In-memory persistence double: records what openHerdrPaneForReview saves. */
+function fakePersistence(initial: HerdrTabHandle | null = null) {
+  let stored = initial;
+
+  return {
+    persistence: {
+      herdrGetTab: async () => stored,
+      herdrSetTab: async (_sessionId: string, handle: HerdrTabHandle) => {
+        stored = handle;
+      },
+    },
+    saved: () => stored,
+  };
+}
+
+function newSession(overrides: Partial<Thread> = {}): Thread {
+  return {
+    schemaVersion: "1",
+    id: "ses_new1",
+    workspace: { repoRoot: "/repo", branch: "main" },
+    artifact: { type: "plan", content: "# P", meta: { cwd: "/repo/work", title: "Rollout Plan" } },
+    revisions: [{ revision: 1, content: "# P", submittedAt: "now" }],
+    annotations: [],
+    verdict: null,
+    status: "pending",
+    createdAt: "now",
+    ...overrides,
+  };
+}
+
+describe("openHerdrPane", () => {
+  test("creates a focused tab, launches the review, and returns the handle", () => {
+    // Arrange
+    const stub = makeStub("open");
+
+    // Act
+    const handle = openHerdrPane({
+      sessionId: "ses_abc",
+      cwd: "/repo/work",
+      binPath: stub.binPath,
+      label: "Rollout Plan",
+    });
+
+    // Assert
+    expect(handle).toEqual({ tabId: "w1:t2", paneId: "w1:p2" });
+    expect(readLines(stub.logPath)).toEqual([
+      "tab create --cwd /repo/work --label Rollout Plan --focus",
+      "pane send-text w1:p2 cueloop ses_abc",
+      "pane send-keys w1:p2 enter",
+    ]);
+  });
+
+  test("returns null and never throws on a broken binary", () => {
+    expect(
+      openHerdrPane({
+        sessionId: "ses_abc",
+        cwd: "/repo/work",
+        binPath: join(dir, "missing-bin"),
+        label: "x",
+      }),
+    ).toBeNull();
+  });
+
+  test("returns null when tab create yields no ids - no send-text, no send-keys", () => {
+    // Arrange
+    const logPath = join(dir, "nopane.log");
+    const binPath = join(dir, "nopane.sh");
+
+    writeFileSync(
+      binPath,
+      `#!/bin/sh\nprintf '%s\\n' "$*" >> "${logPath}"\nprintf '{"result":{}}'\n`,
+    );
+    chmodSync(binPath, 0o755);
+
+    // Act
+    const handle = openHerdrPane({ sessionId: "ses_abc", cwd: "/repo/work", binPath, label: "x" });
+
+    // Assert
+    expect(handle).toBeNull();
+    expect(readLines(logPath)).toEqual(["tab create --cwd /repo/work --label x --focus"]);
+  });
+});
+
+describe("openHerdrPaneForReview", () => {
+  test("opens and records a tab for a review with no recorded tab", async () => {
+    // Arrange
+    const stub = makeStub("gated-new");
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+    const store = fakePersistence(null);
+
+    // Act
+    await openHerdrPaneForReview(newSession({ id: "ses_xyz" }), store.persistence, env);
+
+    // Assert
+    expect(readLines(stub.logPath)).toEqual([
+      "tab create --cwd /repo/work --label Rollout Plan --focus",
+      "pane send-text w1:p2 cueloop ses_xyz",
+      "pane send-keys w1:p2 enter",
+    ]);
+    expect(store.saved()).toEqual({ tabId: "w1:t2", paneId: "w1:p2" });
+  });
+
+  test("no-op outside herdr - no herdr process is spawned", async () => {
+    // Arrange
+    const stub = makeStub("gated-outside");
+    const store = fakePersistence(null);
+
+    // Act
+    await openHerdrPaneForReview(newSession(), store.persistence, {
+      HERDR_PANE_ID: "w1:p1",
+      HERDR_BIN_PATH: stub.binPath,
+    });
+
+    // Assert
+    expect(existsSync(stub.logPath)).toBeFalse();
+    expect(store.saved()).toBeNull();
+  });
+
+  test("focuses the recorded tab when its pane is still alive, without reopening", async () => {
+    // Arrange
+    const stub = makeStub("gated-alive", true);
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+    const store = fakePersistence({ tabId: "w9:t9", paneId: "w9:p9" });
+
+    // Act
+    await openHerdrPaneForReview(newSession(), store.persistence, env);
+
+    // Assert
+    const lines = readLines(stub.logPath);
+
+    expect(lines).toContain("pane get w9:p9");
+    expect(lines).toContain("tab focus w9:t9");
+    expect(lines.some((line) => line.startsWith("tab create"))).toBeFalse();
+    expect(store.saved()).toEqual({ tabId: "w9:t9", paneId: "w9:p9" });
+  });
+
+  test("a persistence failure never escapes - review creation stays best-effort", async () => {
+    // Arrange - the daemon store rejects; the opener must still resolve quietly
+    const stub = makeStub("gated-persist-fail");
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+    const persistence: HerdrTabPersistence = {
+      herdrGetTab: async () => null,
+      herdrSetTab: async () => {
+        throw new Error("disk full");
+      },
+    };
+
+    // Act & Assert - no throw
+    await openHerdrPaneForReview(newSession(), persistence, env);
+    expect(readLines(stub.logPath).some((line) => line.startsWith("tab create"))).toBeTrue();
+  });
+
+  test("a recall failure (stale daemon) still opens a fresh tab", async () => {
+    // Arrange - a daemon predating the herdr-tab primitives rejects the recall
+    const stub = makeStub("gated-recall-fail");
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+    const persistence: HerdrTabPersistence = {
+      herdrGetTab: async () => {
+        throw new Error("unknown method herdr.getTab");
+      },
+      herdrSetTab: async () => {},
+    };
+
+    // Act
+    await openHerdrPaneForReview(newSession({ id: "ses_stale" }), persistence, env);
+
+    // Assert - the recall throwing must not abort the open
+    expect(readLines(stub.logPath)).toEqual([
+      "tab create --cwd /repo/work --label Rollout Plan --focus",
+      "pane send-text w1:p2 cueloop ses_stale",
+      "pane send-keys w1:p2 enter",
+    ]);
+  });
+
+  test("reopens and re-records when the recorded pane is dead", async () => {
+    // Arrange
+    const stub = makeStub("gated-dead", false);
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+    const store = fakePersistence({ tabId: "old:t", paneId: "old:p" });
+
+    // Act
+    await openHerdrPaneForReview(newSession({ id: "ses_re" }), store.persistence, env);
+
+    // Assert
+    const lines = readLines(stub.logPath);
+
+    expect(lines).toContain("pane get old:p");
+    expect(lines).toContain("tab create --cwd /repo/work --label Rollout Plan --focus");
+    expect(store.saved()).toEqual({ tabId: "w1:t2", paneId: "w1:p2" });
+  });
+});
+
+afterAll(() => {
+  rmSync(dir, { recursive: true, force: true, maxRetries: 3 });
+});

package/src/herdr-pane.ts

@@ -0,0 +1,167 @@
+/**
+ * Opens a herdr tab that renders a review, from the creation sites (the Claude
+ * Code hook and `cueloop session create`) that run inside a herdr pane. On a
+ * resubmit it reopens only when the recorded pane is dead, so a live tab is
+ * focused rather than duplicated. Best-effort: any spawn failure is swallowed
+ * and never blocks review creation; each spawn is bounded by a timeout.
+ */
+
+import { detectHerdr, type HerdrEnv, type Thread } from "@cueloop/schema";
+import * as v from "valibot";
+import type { HerdrTabHandle } from "./herdr-tab-store";
+
+const HERDR_SPAWN_TIMEOUT_MS = 2000;
+const CreatedTabSchema = v.object({
+  result: v.optional(
+    v.object({
+      root_pane: v.optional(
+        v.object({ pane_id: v.optional(v.string()), tab_id: v.optional(v.string()) }),
+      ),
+    }),
+  ),
+});
+const PaneResultSchema = v.object({
+  result: v.optional(v.object({ pane: v.optional(v.unknown()) })),
+});
+
+export interface OpenHerdrPaneOptions {
+  sessionId: string;
+  cwd: string;
+  binPath: string;
+  label: string;
+}
+
+/** The daemon-side handle store, as the two methods this module needs. DaemonClient satisfies it. */
+export interface HerdrTabPersistence {
+  herdrGetTab(sessionId: string): Promise<HerdrTabHandle | null>;
+  herdrSetTab(sessionId: string, handle: HerdrTabHandle): Promise<void>;
+}
+
+/**
+ * Open a focused tab and launch the review in it. `tab create` prints
+ * `{ result: { root_pane: { pane_id, tab_id } } }` (herdr 0.8.2); both ids are
+ * returned so a later resubmit can liveness-check and focus. Null on any
+ * best-effort bail-out.
+ */
+export function openHerdrPane(options: OpenHerdrPaneOptions): HerdrTabHandle | null {
+  const { sessionId, cwd, binPath, label } = options;
+
+  try {
+    const created = Bun.spawnSync(
+      [binPath, "tab", "create", "--cwd", cwd, "--label", label, "--focus"],
+      { stdout: "pipe", stderr: "ignore", timeout: HERDR_SPAWN_TIMEOUT_MS },
+    );
+
+    if (created.exitCode !== 0) return null;
+    const parsed = v.safeParse(CreatedTabSchema, JSON.parse(created.stdout.toString()));
+
+    if (!parsed.success) return null;
+    const paneId = parsed.output.result?.root_pane?.pane_id;
+    const tabId = parsed.output.result?.root_pane?.tab_id;
+
+    if (!paneId || !tabId) return null;
+    // A fresh tab hosts a plain shell, so the review is typed in like a human.
+    const typed = Bun.spawnSync([binPath, "pane", "send-text", paneId, `cueloop ${sessionId}`], {
+      stdout: "ignore",
+      stderr: "ignore",
+      timeout: HERDR_SPAWN_TIMEOUT_MS,
+    });
+
+    if (typed.exitCode !== 0) return null;
+    const entered = Bun.spawnSync([binPath, "pane", "send-keys", paneId, "enter"], {
+      stdout: "ignore",
+      stderr: "ignore",
+      timeout: HERDR_SPAWN_TIMEOUT_MS,
+    });
+
+    return entered.exitCode === 0 ? { tabId, paneId } : null;
+  } catch {
+    return null;
+  }
+}
+
+/** True when the pane still exists (`herdr pane get` returns it). */
+function herdrPaneAlive(binPath: string, paneId: string): boolean {
+  try {
+    const got = Bun.spawnSync([binPath, "pane", "get", paneId], {
+      stdout: "pipe",
+      stderr: "ignore",
+      timeout: HERDR_SPAWN_TIMEOUT_MS,
+    });
+
+    if (got.exitCode !== 0) return false;
+    const parsed = v.safeParse(PaneResultSchema, JSON.parse(got.stdout.toString()));
+
+    return parsed.success && parsed.output.result?.pane != null;
+  } catch {
+    return false;
+  }
+}
+
+/** Bring an existing review tab to the front; best-effort. */
+function focusHerdrTab(binPath: string, tabId: string): void {
+  try {
+    Bun.spawnSync([binPath, "tab", "focus", tabId], {
+      stdout: "ignore",
+      stderr: "ignore",
+      timeout: HERDR_SPAWN_TIMEOUT_MS,
+    });
+  } catch {
+    // best-effort
+  }
+}
+
+/**
+ * Ensure a herdr tab is rendering this review. Inside herdr only: focus the
+ * recorded tab if its pane is still alive, otherwise open a fresh one and record
+ * its handle. No-op outside herdr.
+ */
+export async function openHerdrPaneForReview(
+  session: Thread,
+  persistence: HerdrTabPersistence,
+  env: HerdrEnv = process.env,
+): Promise<void> {
+  const herdr = detectHerdr(env);
+
+  if (!herdr) return;
+  const recorded = await recallHerdrTab(persistence, session.id);
+
+  if (recorded && herdrPaneAlive(herdr.binPath, recorded.paneId)) {
+    focusHerdrTab(herdr.binPath, recorded.tabId);
+
+    return;
+  }
+  const opened = openHerdrPane({
+    sessionId: session.id,
+    cwd: session.artifact.meta.cwd ?? process.cwd(),
+    binPath: herdr.binPath,
+    label: session.artifact.meta.title ?? session.id,
+  });
+
+  if (opened) await rememberHerdrTab(persistence, session.id, opened);
+}
+
+/** The recorded handle, or null on any recall failure - a stale daemon must still open a fresh tab, not abort. */
+async function recallHerdrTab(
+  persistence: HerdrTabPersistence,
+  sessionId: string,
+): Promise<HerdrTabHandle | null> {
+  try {
+    return await persistence.herdrGetTab(sessionId);
+  } catch {
+    return null;
+  }
+}
+
+/** Record the handle for later liveness checks; a store failure loses dedup, never the already-open tab. */
+async function rememberHerdrTab(
+  persistence: HerdrTabPersistence,
+  sessionId: string,
+  handle: HerdrTabHandle,
+): Promise<void> {
+  try {
+    await persistence.herdrSetTab(sessionId, handle);
+  } catch {
+    // stale daemon: the tab is already shown; only the liveness-dedup handle is lost
+  }
+}

package/src/herdr-split.test.ts

@@ -0,0 +1,106 @@
+/** launchHarnessInSplit: a stubbed herdr binary logs its argv, and the launcher splits the current pane, runs the harness in the new pane, and optionally types the plan-context seed - a no-op outside herdr. */
+
+import { afterAll, describe, expect, test } from "bun:test";
+import { chmodSync, existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { launchHarnessInSplit } from "./herdr-split";
+
+const dir = mkdtempSync(join(tmpdir(), "cueloop-herdr-split-"));
+
+/** A stub herdr binary that logs argv and prints the pane-split result (pane_id of the new split). */
+function makeStub(name: string, splitOk = true) {
+  const logPath = join(dir, `${name}.log`);
+  const binPath = join(dir, `${name}.sh`);
+  const splitResult = splitOk
+    ? `printf '{"result":{"pane":{"pane_id":"w1:p9"}}}'`
+    : `printf '{"result":{}}'`;
+
+  writeFileSync(
+    binPath,
+    `#!/bin/sh
+printf '%s\\n' "$*" >> "${logPath}"
+if [ "$1" = "pane" ] && [ "$2" = "split" ]; then ${splitResult}; fi
+exit 0
+`,
+  );
+  chmodSync(binPath, 0o755);
+
+  return { binPath, logPath };
+}
+
+function readLines(logPath: string): string[] {
+  if (!existsSync(logPath)) return [];
+
+  return readFileSync(logPath, "utf8").split("\n").filter(Boolean);
+}
+
+describe("launchHarnessInSplit", () => {
+  test("splits the current pane and runs the harness in the new pane", () => {
+    // Arrange
+    const stub = makeStub("run");
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+
+    // Act
+    const launched = launchHarnessInSplit({ command: "cc", cwd: "/repo/work" }, env);
+
+    // Assert
+    expect(launched).toBeTrue();
+    expect(readLines(stub.logPath)).toEqual([
+      "pane split w1:p1 --direction right --ratio 0.4 --cwd /repo/work",
+      "pane send-text w1:p9 cc",
+      "pane send-keys w1:p9 enter",
+    ]);
+  });
+
+  test("types the plan-context seed into the split after launching", () => {
+    // Arrange
+    const stub = makeStub("seeded");
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+
+    // Act
+    launchHarnessInSplit({ command: "pi", cwd: "/repo", seedText: "read plan ses_1" }, env);
+
+    // Assert
+    expect(readLines(stub.logPath)).toEqual([
+      "pane split w1:p1 --direction right --ratio 0.4 --cwd /repo",
+      "pane send-text w1:p9 pi",
+      "pane send-keys w1:p9 enter",
+      "pane send-text w1:p9 read plan ses_1",
+    ]);
+  });
+
+  test("no-op outside herdr - returns false and spawns nothing", () => {
+    // Arrange
+    const stub = makeStub("outside");
+
+    // Act
+    const launched = launchHarnessInSplit(
+      { command: "cc", cwd: "/repo" },
+      { HERDR_BIN_PATH: stub.binPath },
+    );
+
+    // Assert
+    expect(launched).toBeFalse();
+    expect(existsSync(stub.logPath)).toBeFalse();
+  });
+
+  test("returns false when the split yields no pane id", () => {
+    // Arrange
+    const stub = makeStub("nopane", false);
+    const env = { HERDR_ENV: "1", HERDR_PANE_ID: "w1:p1", HERDR_BIN_PATH: stub.binPath };
+
+    // Act
+    const launched = launchHarnessInSplit({ command: "cc", cwd: "/repo" }, env);
+
+    // Assert - the split ran but no harness was launched into a missing pane
+    expect(launched).toBeFalse();
+    expect(readLines(stub.logPath)).toEqual([
+      "pane split w1:p1 --direction right --ratio 0.4 --cwd /repo",
+    ]);
+  });
+});
+
+afterAll(() => {
+  rmSync(dir, { recursive: true, force: true, maxRetries: 3 });
+});

package/src/herdr-split.ts

@@ -0,0 +1,92 @@
+/**
+ * Launches a bring-your-own review harness (claude code / pi / codex) in a herdr
+ * split beside the current pane - the Agent rail's "run it right here" spawn, so
+ * a reviewer chats with an agent about the plan without leaving the review tab.
+ * Best-effort and herdr-only: a no-op returning false outside herdr or on any
+ * spawn failure, each spawn bounded by a timeout.
+ */
+
+import { detectHerdr, type HerdrEnv } from "@cueloop/schema";
+import * as v from "valibot";
+
+const HERDR_SPAWN_TIMEOUT_MS = 2000;
+const SplitPaneSchema = v.object({
+  result: v.optional(v.object({ pane: v.optional(v.object({ pane_id: v.optional(v.string()) })) })),
+});
+
+/** How much of the current pane the launched harness split takes (herdr --ratio). */
+const HARNESS_SPLIT_RATIO = "0.4";
+
+export interface LaunchHarnessInSplitOptions {
+  /** The harness launch command run in the split, e.g. "cc", "pi", "codex". */
+  command: string;
+  /** Working directory for the split - the reviewed session's cwd. */
+  cwd: string;
+  /**
+   * A plan-context briefing typed into the split after the harness command, left
+   * unsubmitted for the reviewer to send. Best-effort: on a slow harness start it
+   * may reach the shell instead, so the launch never depends on it.
+   */
+  seedText?: string;
+}
+
+/**
+ * Split the current pane and run the harness in it. Returns true when the split
+ * opened, false on any best-effort bail-out. No-op outside herdr.
+ */
+export function launchHarnessInSplit(
+  options: LaunchHarnessInSplitOptions,
+  env: HerdrEnv = process.env,
+): boolean {
+  const herdr = detectHerdr(env);
+
+  if (!herdr) return false;
+  try {
+    const split = Bun.spawnSync(
+      [
+        herdr.binPath,
+        "pane",
+        "split",
+        herdr.paneId,
+        "--direction",
+        "right",
+        "--ratio",
+        HARNESS_SPLIT_RATIO,
+        "--cwd",
+        options.cwd,
+      ],
+      { stdout: "pipe", stderr: "ignore", timeout: HERDR_SPAWN_TIMEOUT_MS },
+    );
+
+    if (split.exitCode !== 0) return false;
+    const parsed = v.safeParse(SplitPaneSchema, JSON.parse(split.stdout.toString()));
+
+    if (!parsed.success) return false;
+    const paneId = parsed.output.result?.pane?.pane_id;
+
+    if (!paneId) return false;
+    sendText(herdr.binPath, paneId, options.command);
+    sendKeys(herdr.binPath, paneId, "enter");
+    if (options.seedText) sendText(herdr.binPath, paneId, options.seedText);
+
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+function sendText(binPath: string, paneId: string, text: string): void {
+  Bun.spawnSync([binPath, "pane", "send-text", paneId, text], {
+    stdout: "ignore",
+    stderr: "ignore",
+    timeout: HERDR_SPAWN_TIMEOUT_MS,
+  });
+}
+
+function sendKeys(binPath: string, paneId: string, keys: string): void {
+  Bun.spawnSync([binPath, "pane", "send-keys", paneId, keys], {
+    stdout: "ignore",
+    stderr: "ignore",
+    timeout: HERDR_SPAWN_TIMEOUT_MS,
+  });
+}

package/src/herdr-tab-store.test.ts

@@ -0,0 +1,96 @@
+/** herdr tab side-store: set/get/delete round-trips, survives a reload from disk, and ignores a corrupt file. */
+
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { HerdrTabStore } from "./herdr-tab-store";
+import { herdrTabsPath } from "./paths";
+
+let home: string;
+
+beforeEach(() => {
+  home = mkdtempSync(join(tmpdir(), "cueloop-herdr-store-"));
+});
+afterEach(() => {
+  rmSync(home, { recursive: true, force: true });
+});
+
+describe("HerdrTabStore", () => {
+  test("set then get returns the handle; get for an unknown session is null", () => {
+    // Arrange
+    const store = new HerdrTabStore(home);
+
+    // Act
+    store.set("ses_1", { tabId: "w1:t2", paneId: "w1:p2" });
+
+    // Assert
+    expect(store.get("ses_1")).toEqual({ tabId: "w1:t2", paneId: "w1:p2" });
+    expect(store.get("ses_missing")).toBeNull();
+  });
+
+  test("handles survive a reload from disk", () => {
+    // Arrange
+    new HerdrTabStore(home).set("ses_1", { tabId: "w1:t2", paneId: "w1:p2" });
+
+    // Act - a fresh store over the same home loads the persisted file
+    const reloaded = new HerdrTabStore(home);
+
+    // Assert
+    expect(reloaded.get("ses_1")).toEqual({ tabId: "w1:t2", paneId: "w1:p2" });
+  });
+
+  test("delete removes the handle", () => {
+    // Arrange
+    const store = new HerdrTabStore(home);
+
+    store.set("ses_1", { tabId: "w1:t2", paneId: "w1:p2" });
+
+    // Act
+    store.delete("ses_1");
+
+    // Assert
+    expect(store.get("ses_1")).toBeNull();
+  });
+
+  test("a corrupt file starts empty instead of throwing", () => {
+    // Arrange
+    writeFileSync(herdrTabsPath(home), "not json");
+
+    // Act
+    const store = new HerdrTabStore(home);
+
+    // Assert
+    expect(store.get("ses_1")).toBeNull();
+  });
+
+  test("malformed entries are dropped, well-formed ones survive", () => {
+    // Arrange - valid JSON, but entries with the wrong shape
+    writeFileSync(
+      herdrTabsPath(home),
+      JSON.stringify({
+        ses_ok: { tabId: "w1:t2", paneId: "w1:p2" },
+        ses_partial: { tabId: "w1:t2" },
+        ses_typed: { tabId: 1, paneId: 2 },
+        ses_null: null,
+      }),
+    );
+
+    // Act
+    const store = new HerdrTabStore(home);
+
+    // Assert
+    expect(store.get("ses_ok")).toEqual({ tabId: "w1:t2", paneId: "w1:p2" });
+    expect(store.get("ses_partial")).toBeNull();
+    expect(store.get("ses_typed")).toBeNull();
+    expect(store.get("ses_null")).toBeNull();
+  });
+
+  test("a non-object top level starts empty", () => {
+    // Arrange
+    writeFileSync(herdrTabsPath(home), JSON.stringify(["not", "a", "map"]));
+
+    // Act & Assert
+    expect(new HerdrTabStore(home).get("ses_1")).toBeNull();
+  });
+});