@cueloop/daemon 0.1.0-alpha.62 → 0.1.0-alpha.63

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/daemon",
-  "version": "0.1.0-alpha.62",
+  "version": "0.1.0-alpha.63",
   "description": "The cueloop session daemon and its client: socket protocol, atomic store, resumable waits",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -33,7 +33,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@cueloop/schema": "0.1.0-alpha.62",
+    "@cueloop/schema": "0.1.0-alpha.63",
     "valibot": "^1.4.2"
   },
   "engines": {

package/src/review.test.ts

@@ -159,6 +159,30 @@ describe("openReview", () => {
     expect(other.id).not.toBe(first.id);
   });
 
+  test("the same agentSessionId with a different type opens a new session, never a type mismatch", async () => {
+    // Arrange - the agent session's plan review is open
+    const plan = await openReview(client, {
+      type: "plan",
+      content: PLAN,
+      cwd: home,
+      agentSessionId: "agent-cross",
+    });
+
+    // Act - the same agent session now submits a reply for review
+    const reply = await openReview(client, {
+      type: "reply",
+      content: "# Findings\n\nThe cache is fine.\n",
+      cwd: home,
+      agentSessionId: "agent-cross",
+    });
+
+    // Assert - a fresh reply session; the plan session keeps its type and history
+    expect(reply.id).not.toBe(plan.id);
+    expect(reply.session.artifact.type).toBe("reply");
+    expect(reply.session.revisions.length).toBe(1);
+    expect((await client.sessionGet(plan.id)).artifact.type).toBe("plan");
+  });
+
   test("per-file notes land as note annotations anchored at the file path", async () => {
     // Act
     const review = await openReview(client, {

package/src/review.ts

@@ -245,10 +245,14 @@ export async function openReview(
   const cwd = options.cwd ?? process.cwd();
   const workspace = options.workspace ?? (await resolveWorkspace(cwd));
 
-  // Resubmits from the same agent session become revisions, not new sessions.
+  // Resubmits from the same agent session become revisions, not new sessions -
+  // but only within the same primitive: a different artifact type is a new
+  // review, never a silent type mismatch on the old session.
   if (options.agentSessionId !== undefined) {
     const existing = (await client.sessionList()).find(
-      (candidate) => candidate.artifact.meta.agentSessionId === options.agentSessionId,
+      (candidate) =>
+        candidate.artifact.meta.agentSessionId === options.agentSessionId &&
+        candidate.artifact.type === options.type,
     );
 
     if (existing !== undefined) {

package/src/validate.test.ts

@@ -19,6 +19,7 @@ import {
   validateSessionRecord,
 } from "./validate";
 import {
+  ARTIFACT_TYPES,
   SCHEMA_VERSION,
   type Anchor,
   type Annotation,
@@ -61,13 +62,15 @@ describe("parseParams", () => {
     }
   });
 
-  test("accepts the reply artifact type", () => {
-    const params = parseParams("session.create", {
-      workspace: { repoRoot: "/repo", branch: "main" },
-      artifact: { type: "reply", content: "# R" },
-    });
+  test("accepts every artifact type in the schema union", () => {
+    for (const type of ARTIFACT_TYPES) {
+      const params = parseParams("session.create", {
+        workspace: { repoRoot: "/repo", branch: "main" },
+        artifact: { type, content: "body" },
+      });
 
-    expect(params.artifact.type).toBe("reply");
+      expect(params.artifact.type).toBe(type);
+    }
   });
 
   test("rejects an unknown artifact type", () => {

package/src/validate.ts

@@ -11,6 +11,7 @@
 
 import * as v from "valibot";
 import {
+  ARTIFACT_TYPES,
   SCHEMA_VERSION,
   type Anchor,
   type Annotation,
@@ -60,7 +61,9 @@ export const DiffFileContentsSchema = v.object({
 } satisfies EntriesOf<DiffFileContents>);
 
 export const ArtifactSchema = v.object({
-  type: v.picklist(["plan", "diff", "prototype", "reply"]),
+  // Derived from the schema's runtime union: a new primitive extends the wire
+  // contract without touching this file.
+  type: v.picklist(ARTIFACT_TYPES),
   content: v.string(),
   meta: v.optional(ArtifactMetaSchema, {}),
   files: v.optional(v.array(DiffFileContentsSchema)),