@cueloop/client 0.1.0-alpha.97 → 0.1.0-alpha.99

package/src/app/App.workbench.test.tsx

@@ -272,6 +272,7 @@ describe("the four-pane workbench", () => {
       workspace: { repoRoot: repo, branch: "main" },
       artifact: { type: "diff", content: "", meta: { title: "live changes", workbench: true } },
     });
+
     writeFileSync(join(repo, "README.md"), "# Edited\n");
     const setup = await renderReadyApp(
       <App home={home} sessionId={liveSession.id} layout={reviewLayout()} />,
@@ -336,6 +337,7 @@ describe("the four-pane workbench", () => {
     const setup = await renderApp();
 
     const frame = setup.captureCharFrame();
+
     expect(frame).toContain("cueloop");
     expect(frame).toContain("Changes");
     expect(frame).toContain("store.ts");
@@ -353,6 +355,7 @@ describe("the four-pane workbench", () => {
     await waitForText(setup, "README.md");
 
     const frame = setup.captureCharFrame();
+
     // the full tree is showing...
     expect(frame).toContain("README.md");
     expect(frame).toContain("src");
@@ -367,10 +370,12 @@ describe("the four-pane workbench", () => {
     await waitForText(setup, "README.md");
 
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
     await waitForText(setup, "Workbench Fixture");
 
     const frame = setup.captureCharFrame();
+
     // the contents tab carries the file's text with no diff markers
     expect(frame).toContain("A tiny tracked repo.");
     expect(frame.split("\n")[HEADER_ROW]!).toContain("README.md");
@@ -382,15 +387,18 @@ describe("the four-pane workbench", () => {
     await setup.mockMouse.click(treeToggleColumn(setup), HEADER_ROW);
     await waitForText(setup, "README.md");
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
     await waitForState(setup, () =>
       setup.captureCharFrame().split("\n")[HEADER_ROW]!.includes("README.md"),
     );
 
     const folder = locateText(setup, "src");
+
     await setup.mockMouse.click(folder.column, folder.row);
     await waitForText(setup, "util.ts");
     const util = locateText(setup, "util.ts");
+
     await setup.mockMouse.click(util.column, util.row);
     await waitForState(setup, () => {
       const header = setup.captureCharFrame().split("\n")[HEADER_ROW]!;
@@ -419,15 +427,18 @@ describe("the four-pane workbench", () => {
     await setup.mockMouse.click(treeToggleColumn(setup), HEADER_ROW);
     await waitForText(setup, "README.md");
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
     await waitForText(setup, "Workbench Fixture");
 
     // the split control appears only on a file tab
     const split = locateText(setup, "split");
+
     await setup.mockMouse.click(split.column, split.row);
     await waitForText(setup, "right");
 
     const menu = setup.captureCharFrame();
+
     expect(menu).toContain("left");
     expect(menu).toContain("right");
     expect(menu).toContain("up");
@@ -450,11 +461,13 @@ describe("the four-pane workbench", () => {
     const setup = await renderApp();
 
     const changes = locateText(setup, "Changes");
+
     // the tab's close box sits just past the label; the ✕ is a hover affordance, the box always clicks
     await setup.mockMouse.click(changes.column + 8, changes.row);
     await waitForState(setup, () => !setup.captureCharFrame().includes("store.ts"));
 
     const frame = setup.captureCharFrame();
+
     // the Changes editor is gone...
     expect(frame).not.toContain("store.ts");
     // ...but the Project sidebar and its toggles remain
@@ -483,11 +496,13 @@ describe("the four-pane workbench", () => {
     // deep-linked into a session, the Threads sidebar starts collapsed: the brand rides in the
     // Thread header and the inbox groups are hidden
     const collapsed = setup.captureCharFrame();
+
     expect(collapsed).toContain("cueloop");
     expect(collapsed).not.toContain("Threads");
 
     // the sidebar toggle sits just left of the brand (one glyph plus its margin)
     const brand = locateText(setup, "cueloop");
+
     await setup.mockMouse.click(brand.column - 3, brand.row);
     await waitForText(setup, "Threads");
 
@@ -496,6 +511,7 @@ describe("the four-pane workbench", () => {
 
     // toggling again collapses it back
     const reopened = locateText(setup, "cueloop");
+
     await setup.mockMouse.click(reopened.column - 3, reopened.row);
     await waitForState(setup, () => !setup.captureCharFrame().includes("Threads"));
     expect(setup.captureCharFrame()).not.toContain("Threads");
@@ -505,10 +521,12 @@ describe("the four-pane workbench", () => {
     const setup = await renderApp();
 
     const zoom = locateText(setup, NERD.zoom);
+
     await setup.mockMouse.click(zoom.column, zoom.row);
     await waitForState(setup, () => !setup.captureCharFrame().includes("Select a thread"));
 
     const frame = setup.captureCharFrame();
+
     // the Thread pane's prompt is gone...
     expect(frame).not.toContain("Select a thread");
     // ...while the Changes editor and Project sidebar stay
@@ -525,9 +543,11 @@ describe("the four-pane workbench", () => {
         height: 20,
       },
     );
+
     await waitForText(setup, "store.ts");
 
     const zoom = locateText(setup, NERD.zoom);
+
     await setup.mockMouse.click(zoom.column, zoom.row);
     await waitForState(
       setup,
@@ -554,20 +574,24 @@ describe("the four-pane workbench", () => {
     // open the collapsed Threads sidebar first (its toggle sits three cells left of the brand); the
     // brand rides the Thread header, which zoom then hides, so it must be reached before zooming
     const brand = locateText(setup, "cueloop");
+
     await setup.mockMouse.click(brand.column - 3, brand.row);
     await waitForText(setup, "Zoomed Plan");
 
     // zoom the diff - the Thread pane hides and the footer rides the Changes pane
     const zoom = locateText(setup, NERD.zoom);
+
     await setup.mockMouse.click(zoom.column, zoom.row);
     await waitForState(setup, () => !setup.captureCharFrame().includes("Select a thread"));
 
     // switch to the plan thread: it has no Changes editor, so a stranded zoom would blank the middle
     const planRow = locateText(setup, "Zoomed Plan");
+
     await setup.mockMouse.click(planRow.column, planRow.row);
     await waitForText(setup, "Review this plan.");
 
     const frame = setup.captureCharFrame();
+
     // the Thread pane is back with the plan, and the diff's Changes editor is gone - never a blank middle
     expect(frame).toContain("Review this plan.");
     expect(frame).not.toContain("store.ts");
@@ -578,6 +602,7 @@ describe("the four-pane workbench", () => {
 
     // zoom the Changes editor - the Thread pane hides
     const zoom = locateText(setup, NERD.zoom);
+
     await setup.mockMouse.click(zoom.column, zoom.row);
     await waitForState(setup, () => !setup.captureCharFrame().includes("Select a thread"));
 
@@ -585,6 +610,7 @@ describe("the four-pane workbench", () => {
     await setup.mockMouse.click(rightToggleColumn(setup), HEADER_ROW);
     await waitForText(setup, "Select a thread");
     const frame = setup.captureCharFrame();
+
     expect(frame).toContain("Select a thread");
     // the right region is collapsed and the Changes editor is gone
     expect(frame).not.toContain("store.ts");
@@ -634,6 +660,7 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} />,
       { width: 180, height: 14 },
     );
+
     await waitForText(setup, "cueloop");
 
     return setup;
@@ -678,11 +705,13 @@ describe("the bare-launch welcome shell", () => {
     await setup.mockMouse.click(treeToggleColumn(setup), HEADER_ROW);
     await waitForText(setup, "README.md");
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
     await waitForText(setup, "edited in the working tree");
 
     // comment on a line - the first note find-or-creates the workbench thread
     const line = "edited in the working tree";
+
     await dragText(setup, line, line, line.length);
     await typeText(setup, "workbench note");
     await pressKey(setup, "RETURN", { meta: true });
@@ -694,6 +723,7 @@ describe("the bare-launch welcome shell", () => {
     const workbench = welcomeServer.core
       .sessionList()
       .find((thread) => thread.artifact.meta.workbench === true)!;
+
     expect(workbench.workspace.rootCommit).toBeTruthy();
     await waitForState(setup, () =>
       welcomeServer.core
@@ -780,6 +810,7 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} layout={reviewLayout()} />,
       { width: 180, height: 14 },
     );
+
     await waitForText(setup, "README.md");
     expect(setup.captureCharFrame()).toContain("README.md");
   });
@@ -789,6 +820,7 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} layout={planLayout()} />,
       { width: 180, height: 14 },
     );
+
     await waitForText(setup, "cueloop");
     // rightSidebar "off": neither the Changes list nor the launch repo's files paint
     expect(setup.captureCharFrame()).not.toContain("README.md");
@@ -806,6 +838,7 @@ describe("the bare-launch welcome shell", () => {
       />,
       { width: 180, height: 14 },
     );
+
     await waitForText(setup, "Select a thread");
     expect(setup.captureCharFrame()).toContain("Select a thread");
   });
@@ -820,6 +853,7 @@ describe("the bare-launch welcome shell", () => {
       />,
       { width: 180, height: 14 },
     );
+
     await waitForText(setup, "README.md");
 
     // close the Changes/Project region; the remembered layout follows it to "off"
@@ -842,11 +876,13 @@ describe("the bare-launch welcome shell", () => {
 
     await waitForText(setup, "README.md");
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
 
     // a diff shows both the removed old line and the added new line; contents would show only the new
     await waitForText(setup, "A tiny tracked repo.");
     const frame = setup.captureCharFrame();
+
     expect(frame).toContain("A tiny tracked repo.");
     expect(frame).toContain("edited in the working tree");
   });
@@ -856,8 +892,10 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} />,
       { width: 160, height: 28 },
     );
+
     await waitForText(setup, "quick brown fox");
     const line = locateText(setup, "quick brown fox");
+
     await setup.mockMouse.click(line.column, line.row);
 
     // esc enters nav; the footer names what this surface can do, not the diff commands
@@ -892,11 +930,14 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} />,
       { width: 160, height: 28 },
     );
+
     await waitForText(setup, "README.md");
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
     await waitForText(setup, "edited in the working tree");
     const line = locateText(setup, "edited in the working tree");
+
     await setup.mockMouse.click(line.column, line.row);
 
     await press(setup, "escape");
@@ -905,6 +946,7 @@ describe("the bare-launch welcome shell", () => {
     await pressKey(setup, "x");
     await waitForText(setup, "● x");
     const frame = setup.captureCharFrame();
+
     expect(frame).toContain("edited in the working tree");
     expect(frame).not.toContain("change rejected");
 
@@ -916,13 +958,16 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} />,
       { width: 160, height: 28 },
     );
+
     await waitForText(setup, "README.md");
     await setup.mockMouse.click(treeToggleColumn(setup), HEADER_ROW);
     await waitForText(setup, "README.md");
     const readme = locateText(setup, "README.md");
+
     await setup.mockMouse.click(readme.column, readme.row);
     await waitForText(setup, "edited in the working tree");
     const line = locateText(setup, "edited in the working tree");
+
     await setup.mockMouse.click(line.column, line.row);
 
     await press(setup, "escape");
@@ -940,6 +985,7 @@ describe("the bare-launch welcome shell", () => {
     // the Welcome playground measures its width before it paints, so wait for its copy
     await waitForText(setup, "Getting started");
     const frame = setup.captureCharFrame();
+
     // the getting-started surface is an editor tab, not the thread pane
     expect(frame.split("\n")[HEADER_ROW]!).toContain("Welcome");
     expect(frame).toContain("Getting started");
@@ -952,6 +998,7 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} />,
       { width: 160, height: 24 },
     );
+
     await waitForText(setup, "Getting started");
 
     // focus starts on the Threads sidebar: a letter drives the inbox, it never drafts in the editor
@@ -960,6 +1007,7 @@ describe("the bare-launch welcome shell", () => {
 
     // clicking a line in the Welcome editor focuses that pane; now typing composes there
     const line = locateText(setup, "quick brown fox");
+
     await setup.mockMouse.click(line.column, line.row);
     await typeText(setup, "note");
     await waitForText(setup, "● note");
@@ -977,6 +1025,7 @@ describe("the bare-launch welcome shell", () => {
       <App home={welcomeHome} sessionId={undefined} cwd={welcomeRepo} />,
       { width: 160, height: 28 },
     );
+
     await waitForText(setup, "quick brown fox");
 
     // open the playground composer, then type letters that are also inbox keys (j, k, d), one at a
@@ -999,6 +1048,7 @@ describe("the bare-launch welcome shell", () => {
     const setup = await renderWelcome();
 
     const welcome = locateText(setup, "Welcome");
+
     // the close box sits just past the label
     await setup.mockMouse.click(welcome.column + 8, welcome.row);
     await waitForState(
@@ -1008,6 +1058,7 @@ describe("the bare-launch welcome shell", () => {
 
     // the Threads sidebar and the Thread empty state remain - never a blank shell
     const frame = setup.captureCharFrame();
+
     expect(frame).toContain("cueloop");
     expect(frame).toContain("Select a thread");
   });
@@ -1085,9 +1136,11 @@ describe("the bare-launch welcome shell", () => {
     const lines = setup.captureCharFrame().split("\n");
     // the reopen toggle's divider sits at the far right; find its column on the header row
     const headerDivider = lines[HEADER_ROW]!.lastIndexOf("│");
+
     expect(headerDivider).toBeGreaterThan(0);
     // that column stays clear below the two-row header - no full-height column rule
     const bodyRows = lines.slice(3).filter((line) => line.length > headerDivider);
+
     expect(bodyRows.length).toBeGreaterThan(0);
     for (const line of bodyRows) {
       expect(line[headerDivider]).not.toBe("│");

package/src/app/app-screens.tsx

@@ -160,6 +160,7 @@ export function NoThreadShell(props: {
   inboxCursor: number;
   /** Open a sidebar thread and move the cursor onto it, so the row shows its selected backdrop at once. */
   onOpenThread: (id: string) => void;
+  onCreateThread?: () => void;
   mode: Mode;
   theme: Theme;
   controller: ReviewController;
@@ -215,6 +216,7 @@ export function NoThreadShell(props: {
   // The bare-launch shell is the same four panes as a thread: the Thread pane waits in its empty state
   // and a disposable Welcome tab rides in the Changes editor until a thread or diff is opened.
   const workbench = useChangesWorkbench({ seed: "welcome", layout });
+
   // the vanilla shell remembers the composition the user leaves it in, for the next bare launch
   useRememberLayout(
     layout,
@@ -291,6 +293,7 @@ export function NoThreadShell(props: {
                 pinnedIds={pinnedIds}
                 width={30}
                 onSelect={onOpenThread}
+                onCreateThread={props.onCreateThread}
                 onRequestDelete={(id, title) =>
                   setMode({ type: "confirmDelete", sessionId: id, title })
                 }

package/src/app/components/AppShell.tsx

@@ -162,6 +162,7 @@ export function AppShell({
 }: AppShellProps): React.ReactNode {
   const { registry, context } = extensionInputs(extensionRegistry, extensionContext);
   const extensionSnapshot = useClientExtensionSnapshot(registry);
+
   useEffect(() => {
     if (extensionSnapshot.lastError) onExtensionError?.(extensionSnapshot.lastError);
   }, [extensionSnapshot.lastError, onExtensionError]);

package/src/app/components/AppShell.zoom.test.tsx

@@ -13,7 +13,7 @@ import { AppShell } from "./AppShell";
 import { EditorGrid } from "../../workbench/components/EditorGrid";
 import { changesTab, makeGroup, splitGroup } from "../../workbench/components/editor-grid";
 import { NERD } from "../../ui/components/primitives/icons";
-import { allowEventLoopUpdates } from "../../testing/test-support";
+import { allowEventLoopUpdates, settle } from "../../testing/test-support";
 
 const grid = makeGroup([changesTab()]);
 
@@ -59,8 +59,9 @@ async function zoomIconColumn(
     { width, height: 8 },
   );
 
-  allowEventLoopUpdates();
-  await setup.waitForVisualIdle();
+  // Split widths commit through React after the frame measurement. Renderer idle alone
+  // can still expose the initial fractional split, before its whole-cell widths land.
+  await settle(setup);
   const column = setup.captureCharFrame().split("\n")[0]!.indexOf(NERD.zoom);
 
   setup.renderer.destroy();

package/src/app/intent-dispatch.test.ts

@@ -62,6 +62,7 @@ const EMPTY_SNAPSHOT: ControllerSnapshot = {
 function baseController(): ReviewController {
   return {
     readOnly: false,
+    createEmptyThread: mock(async () => {}),
     subscribe: mock(() => () => {}),
     getSnapshot: mock(() => EMPTY_SNAPSHOT),
     connect: mock(),

package/src/app/run.ts

@@ -53,6 +53,7 @@ export async function runClient(options: RunClientOptions): Promise<number> {
     renderer.useMouse = false;
     renderer.useMouse = true;
   });
+
   return new Promise<number>((resolve) => {
     let exited = false;
     const shutdown = async (code: number): Promise<void> => {

package/src/diff/components/AnnotatableFileView.test.tsx

@@ -110,6 +110,7 @@ describe("AnnotatableFileView", () => {
     // Assert - the surface built an anchor quoting the file line and handed it up with the body
     expect(onAddComment).toHaveBeenCalled();
     const [anchor, body] = onAddComment.mock.calls[0]!;
+
     expect(anchor.quote).toContain("return a + b");
     expect(body).toContain("why not reduce?");
 
@@ -118,6 +119,7 @@ describe("AnnotatableFileView", () => {
 
   test("a head-side (deleted-line) note never rebinds onto the current file", async () => {
     const session = planSession();
+
     // a note left on the removed side of this file: the worktree view must not show it
     session.annotations = [
       {

package/src/diff/components/AnnotatableFileView.tsx

@@ -34,6 +34,9 @@ export interface AnnotatableFileViewProps {
   onAddComment: (anchor: Anchor, body: string) => void;
   onReply: (rootAnnotationId: string, body: string) => void;
   onUpdateAnnotation: (id: string, body: string) => void;
+  onInvoke?: () => void;
+  annotationAction?: (id: string) => { label: string; run: () => void } | undefined;
+  isAnnotationReadOnly?: (id: string) => boolean;
   resolveAuthorLabel?: (annotation: Annotation) => string | undefined;
   onExit: () => void;
   theme?: Theme;
@@ -49,12 +52,14 @@ export function AnnotatableFileView(props: AnnotatableFileViewProps): React.Reac
   const tokens = useComponentTheme(props.theme);
   const [loaded, setLoaded] = useState<FileLoad | null>(null);
   const loadRef = useRef(props.loadContents);
+
   useEffect(() => {
     loadRef.current = props.loadContents;
   });
 
   useEffect(() => {
     let alive = true;
+
     void loadRef.current(props.path).then(
       (contents) => {
         if (alive)
@@ -126,6 +131,9 @@ export function AnnotatableFileView(props: AnnotatableFileViewProps): React.Reac
       }
       onReply={props.onReply}
       onUpdateAnnotation={props.onUpdateAnnotation}
+      onInvoke={props.onInvoke}
+      isAnnotationReadOnly={props.isAnnotationReadOnly}
+      annotationAction={props.annotationAction}
       resolveAuthorLabel={props.resolveAuthorLabel}
       onExit={props.onExit}
       theme={props.theme}

package/src/diff/components/DiffContentView.scroll.test.tsx

@@ -405,6 +405,7 @@ test("Up keeps the caret on the first screen row while wrapped lines scroll", as
     />,
     { width: 60, height: 12 },
   );
+
   await settle(setup);
   const found = findById(setup.renderer.root, "diff-scroll");
 

package/src/diff/components/DiffContentView.tsx

@@ -98,6 +98,9 @@ export interface DiffContentViewProps {
   onAnnotate: (span: TextSpan, body: string) => void;
   onReply: (rootAnnotationId: string, body: string) => void;
   onUpdateAnnotation: (id: string, body: string) => void;
+  onInvoke?: () => void;
+  annotationAction?: (id: string) => { label: string; run: () => void } | undefined;
+  isAnnotationReadOnly?: (id: string) => boolean;
   /** The author's display name for a comment's hover tooltip. */
   resolveAuthorLabel?: (annotation: Annotation) => string | undefined;
   onNavCommand?: (key: KeyEvent, selection: TextSpan | null) => boolean;
@@ -542,6 +545,9 @@ export function DiffContentView({
   onAnnotate,
   onReply,
   onUpdateAnnotation,
+  onInvoke,
+  isAnnotationReadOnly,
+  annotationAction,
   resolveAuthorLabel,
   onNavCommand,
   onExit,
@@ -610,6 +616,9 @@ export function DiffContentView({
     onAnnotate,
     onReply,
     onUpdateAnnotation,
+    onInvoke,
+    isAnnotationReadOnly,
+    annotationAction,
     dragViewport: () => scrollBoxDragViewport(scrollRef.current),
     resolveAuthorLabel: (annotation) => {
       const label = resolveAuthorLabel?.(annotation);
@@ -804,6 +813,7 @@ export function DiffContentView({
           </>
         );
       }
+
       // stacked: caret bar, old new (each tinted red/green on its side), then the change sign;
       // the numbers sit on the row's soft band, only the changed code carries the brighter backdrop
       return lineIndex === 0 ? (

package/src/diff/diff-intraline.test.ts

@@ -225,6 +225,7 @@ describe("createIntralineResolver", () => {
       // Act - the resolver word-diffs only the one block whose row is asked for
       spy.mockClear();
       const resolver = createIntralineResolver(rows);
+
       resolver.runsForRow(1); // a row in block 0
       const oneBlockCalls = spy.mock.calls.length;
 

package/src/diff/diff-intraline.ts

@@ -159,8 +159,10 @@ function lineWordSetCache(): (text: string) => ReadonlySet<string> {
 
   return (text) => {
     const cached = cache.get(text);
+
     if (cached !== undefined) return cached;
     const words = new Set(text.toLowerCase().split(/\s+/).filter(Boolean));
+
     cache.set(text, words);
 
     return words;

package/src/diff/split-diff.ts

@@ -100,11 +100,13 @@ export function splitDiffRows(rows: DiffRow[]): SplitRow[] {
     if (row.kind === "add") {
       blockFile = row.file;
       pendingAdditions.push({ row, index });
+
       return;
     }
     if (row.kind === "del") {
       blockFile = row.file;
       pendingDeletions.push({ row, index });
+
       return;
     }
     // any non-change row closes the current change block before it renders

package/src/integrations/components/ShareDialog.tsx

@@ -393,6 +393,7 @@ export function ShareDialog({
   const moveWizardFocus = (delta: number): void => {
     const ring = wizardRing();
     const at = Math.max(0, ring.indexOf(wizardFocus));
+
     setWizardFocus(ring[Math.min(ring.length - 1, Math.max(0, at + delta))] ?? "name");
   };