@cueloop/client 0.1.0-alpha.93 → 0.1.0-alpha.94

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.93",
+  "version": "0.1.0-alpha.94",
   "description": "The cueloop review UI: projection renderer, keyboard grammar, review rail",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -27,18 +27,18 @@
     "access": "public"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.93",
-    "@cueloop/extension-api": "0.1.0-alpha.93",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.93",
-    "@cueloop/schema": "0.1.0-alpha.93",
-    "@opentui/core": "^0.5.11",
-    "@opentui/keymap": "0.5.11",
-    "@opentui/react": "^0.5.11",
-    "@opentui/ssh": "0.5.11",
+    "@cueloop/daemon": "0.1.0-alpha.94",
+    "@cueloop/extension-api": "0.1.0-alpha.94",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.94",
+    "@cueloop/schema": "0.1.0-alpha.94",
+    "@opentui/core": "^0.5.12",
+    "@opentui/keymap": "0.5.12",
+    "@opentui/react": "^0.5.12",
+    "@opentui/ssh": "0.5.12",
     "@pierre/diffs": "^1.4.1",
     "@tanstack/virtual-core": "^3.17.11",
     "diff": "^9",
-    "puppeteer-core": "^25.10.0",
+    "puppeteer-core": "^25.11.0",
     "react": "^19.3.0",
     "valibot": "^1.5.0",
     "zustand": "^5.0.15"

package/src/App.tsx

@@ -112,6 +112,10 @@ const TOAST_DISMISS_MS = 2000;
 export interface AppProps {
   home?: string;
   sessionId?: string;
+  /** Review data already captured by the command before the UI mounts. */
+  initialReview?: { session: Thread; diff: { patch: string; files: DiffFileContents[] } };
+  /** An owner connection already opened by the launching command. */
+  initialClient?: ThreadClient;
   /** The launch directory whose git repo backs the no-session welcome tree; defaults to process.cwd(). */
   cwd?: string;
   /**
@@ -151,6 +155,18 @@ export interface AppProps {
   extensionRegistry?: ClientExtensionRegistry;
 }
 
+function initialReviewControllerOptions(initialReview: AppProps["initialReview"]) {
+  const options = { initialSession: initialReview?.session, initialDiff: initialReview?.diff };
+
+  return options;
+}
+
+function initialReviewFiles(initialReview: AppProps["initialReview"], sessionId: string) {
+  const files = initialReview?.session.id === sessionId ? initialReview.diff.files : undefined;
+
+  return files;
+}
+
 function extensionContext(cwd: string | undefined, threadId: string | null): ExtensionUIContext {
   return { workspace: cwd ?? process.cwd(), threadId };
 }
@@ -326,6 +342,7 @@ function authorLabelResolver(
 function ProjectPanelBody(props: {
   mode: ProjectPanelMode;
   loadChanges: () => Promise<readonly DiffFileContents[]>;
+  initialFiles?: readonly DiffFileContents[];
   loadProjectFiles: () => Promise<string[]>;
   diffSourceKey: string;
   liveWorkingTree: boolean;
@@ -340,6 +357,7 @@ function ProjectPanelBody(props: {
     loadChanges: props.loadChanges,
     visible: props.mode === "changes" && props.liveWorkingTree,
     diffSourceKey: props.diffSourceKey,
+    initialFiles: props.initialFiles,
   });
 
   if (props.mode === "changes") {
@@ -531,6 +549,8 @@ export function reconciledFocus(navigable: FocusPane[], focusedPane: FocusPane):
 export function App({
   home,
   sessionId,
+  initialReview,
+  initialClient,
   cwd,
   readOnly = false,
   onExit,
@@ -551,6 +571,8 @@ export function App({
       createReviewController({
         home,
         sessionId,
+        ...initialReviewControllerOptions(initialReview),
+        initialClient,
         cwd,
         readOnly: observer,
         onExit,
@@ -581,6 +603,11 @@ export function App({
   );
   const { session, inbox, status, toast, error, completion, editOrphanCount, walk } =
     useSyncExternalStore(controller.subscribe, controller.getSnapshot, controller.getSnapshot);
+  const initialReviewForFirstMount = useRef(initialReview);
+
+  useEffect(() => {
+    initialReviewForFirstMount.current = undefined;
+  }, []);
 
   // A shared plan you own polls for collaborator notes while it is open; the
   // merge refreshes through the normal event path. Stops on leave.
@@ -1446,6 +1473,10 @@ export function App({
                 <ProjectPanelBody
                   mode={workbench.projectMode}
                   loadChanges={() => controller.repoChanges()}
+                  initialFiles={initialReviewFiles(
+                    initialReviewForFirstMount.current,
+                    activeSession.id,
+                  )}
                   loadProjectFiles={() => controller.repoFiles()}
                   diffSourceKey={activeSession.id}
                   {...projectDiffFiles(activeSession)}

package/src/App.workbench.test.tsx

@@ -112,7 +112,89 @@ const rightToggleColumn = (setup: Setup): number => toggleColumn(setup, NERD.sid
 // the collapsed rail shows the outline (off) variant, mirroring the left toggle's filled/outline states
 const railToggleColumn = (setup: Setup): number => toggleColumn(setup, NERD.sidebarRightOff);
 
+function changedFileVisibleInRightTree(frame: string, file: string): boolean {
+  return frame.split("\n").some((line) => {
+    const divider = line.lastIndexOf("│");
+
+    return divider >= 0 && line.slice(divider + 1).includes(file);
+  });
+}
+
 describe("the four-pane workbench", () => {
+  test("a bootstrapped workbench paints its changed-file list in the first usable frame", async () => {
+    const workbench = server.core.sessionCreate({
+      workspace: { repoRoot: repo, branch: "main" },
+      artifact: { type: "diff", content: "", meta: { title: "Workbench", workbench: true } },
+    });
+    const initialReview = {
+      session: workbench,
+      diff: {
+        patch: PATCH,
+        files: [
+          {
+            path: "src/store.ts",
+            oldContents: "export class Store { private items = []; }\n",
+            newContents: "export class Store { private items = new Map(); }\n",
+            status: "modified" as const,
+          },
+        ],
+      },
+    };
+    const setup = await renderReadyApp(
+      <App
+        home={home}
+        sessionId={workbench.id}
+        initialReview={initialReview}
+        layout={reviewLayout()}
+      />,
+      { width: 160, height: 20 },
+    );
+
+    expect(changedFileVisibleInRightTree(setup.captureCharFrame(), "store.ts")).toBe(true);
+    setup.renderer.destroy();
+  });
+
+  test("reopening Changes does not restore files from the launch snapshot", async () => {
+    const workbench = server.core.sessionCreate({
+      workspace: { repoRoot: repo, branch: "main" },
+      artifact: { type: "diff", content: "", meta: { title: "Workbench", workbench: true } },
+    });
+    const initialReview = {
+      session: workbench,
+      diff: {
+        patch: PATCH,
+        files: [
+          {
+            path: "src/store.ts",
+            oldContents: "before\n",
+            newContents: "after\n",
+            status: "modified" as const,
+          },
+        ],
+      },
+    };
+    const setup = await renderReadyApp(
+      <App
+        home={home}
+        sessionId={workbench.id}
+        initialReview={initialReview}
+        layout={reviewLayout()}
+      />,
+      { width: 160, height: 20 },
+    );
+
+    await waitForState(
+      setup,
+      () => !changedFileVisibleInRightTree(setup.captureCharFrame(), "store.ts"),
+    );
+    await setup.mockMouse.click(rightToggleColumn(setup), HEADER_ROW);
+    await waitForState(setup, () => diffToggleColumn(setup) === -1);
+    await setup.mockMouse.click(railToggleColumn(setup), HEADER_ROW);
+
+    expect(changedFileVisibleInRightTree(setup.captureCharFrame(), "store.ts")).toBe(false);
+    setup.renderer.destroy();
+  });
+
   test("rapid wheel scrolling a large Changes diff keeps the app responsive", async () => {
     const filePatches = Array.from({ length: 40 }, (_, fileIndex) => [
       `diff --git a/file-${fileIndex}.ts b/file-${fileIndex}.ts`,

package/src/run.ts

@@ -6,6 +6,8 @@ import { createRoot } from "@opentui/react";
 import { App } from "./App";
 import { closePrototypeBrowser } from "./prototype-browser";
 import type { Appearance } from "./theme-presets";
+import type { DiffFileContents, Thread } from "@cueloop/schema";
+import type { ThreadClient } from "@cueloop/daemon/client";
 import { loadConfig } from "./config";
 import { perfMark } from "./perf/perf-timings";
 import { reportPerfMarks } from "./perf/perf-report";
@@ -17,6 +19,8 @@ import {
 
 export interface RunClientOptions {
   sessionId?: string;
+  initialReview?: { session: Thread; diff: { patch: string; files: DiffFileContents[] } };
+  initialClient?: ThreadClient;
   home?: string;
   /** The layout a create-command opens in; omit to restore the remembered one, then the default. */
   layout?: LaunchLayout;
@@ -73,6 +77,8 @@ export async function runClient(options: RunClientOptions): Promise<number> {
         React.createElement(App, {
           home: options.home,
           sessionId: options.sessionId,
+          initialReview: options.initialReview,
+          initialClient: options.initialClient,
           appearance,
           layout,
           extensionRegistry,

package/src/thread-controller.live-diff.test.ts

@@ -97,6 +97,36 @@ function fakeClient(session: Thread): ThreadClient {
 const tick = () => new Promise((resolve) => setTimeout(resolve, 0));
 
 describe("live working-tree diff for a non-diff thread", () => {
+  test("a preconnected workbench accepts a comment before its inbox refresh", async () => {
+    const session = planSession();
+    const sent: Annotation[] = [];
+    const client = {
+      ...fakeClient(session),
+      sessionComment: async (_id: string, annotation: Annotation) => {
+        sent.push(annotation);
+
+        return { ...session, annotations: sent };
+      },
+    } satisfies ThreadClient;
+    const controller = createReviewController({
+      sessionId: session.id,
+      initialSession: session,
+      initialDiff: { patch: PATCH, files: FILES },
+      initialClient: client,
+      shareTransport,
+    });
+
+    controller.addComment(
+      { quote: "const a = 2;", prefix: "", suffix: "" },
+      { kind: "file", path: "src/x.ts", rev: "worktree" },
+      "ready frame comment",
+    );
+
+    expect(sent).toHaveLength(1);
+    expect(sent[0]?.body).toBe("ready frame comment");
+    controller.close();
+  });
+
   test("repoChanges carries file contents and rows derive from the patch", async () => {
     const session = planSession();
     const controller = createReviewController({

package/src/thread-controller.ts

@@ -251,6 +251,11 @@ export interface NewShareLink {
 export interface ReviewControllerOptions {
   home?: string;
   sessionId?: string;
+  /** Captured before the UI mounts, so the first review frame has its thread and live diff. */
+  initialSession?: Thread;
+  initialDiff?: { patch: string; files: DiffFileContents[] };
+  /** The owner connection that supplied the first review snapshot. */
+  initialClient?: ThreadClient;
   /** The directory the client launched in; its git repo backs the no-session welcome tree. Defaults to process.cwd(). */
   cwd?: string;
   /** Observer mode: stored for the key reducer's read-only gate. */
@@ -491,6 +496,7 @@ class Controller implements ReviewController {
   private derivedFor: Thread | null = null;
   /** The launch/workspace repo's live working-tree diff, feeding the Changes view for non-diff threads. */
   private liveDiff: LiveWorkingDiff | null = null;
+  private initialDiffAvailable = false;
   private derivedForLiveDiff: LiveWorkingDiff | null = null;
   private derived: DerivedSessionProjection = {
     display: [],
@@ -514,6 +520,12 @@ class Controller implements ReviewController {
   }
 
   constructor(private readonly options: ReviewControllerOptions) {
+    this.client = options.initialClient ?? null;
+    if (options.initialSession?.id === options.sessionId && options.initialDiff) {
+      this.liveDiff = options.initialDiff;
+      this.initialDiffAvailable = true;
+      this.store.setState({ session: options.initialSession });
+    }
     this.readOnly = options.readOnly ?? false;
     this.clock = options.clock ?? new SystemClock();
     this.shareTransport = options.shareTransport ?? DEFAULT_SHARE_TRANSPORT;
@@ -541,7 +553,9 @@ class Controller implements ReviewController {
       try {
         const openClient =
           this.options.openClient ??
-          (() => DaemonClient.connect({ home: this.options.home, autostart: true }));
+          (() =>
+            this.options.initialClient ??
+            DaemonClient.connect({ home: this.options.home, autostart: true }));
         const client = await openClient();
 
         if (this.closed) return void client.close();
@@ -839,6 +853,9 @@ class Controller implements ReviewController {
     // a plain diff review pins its captured snapshot; a workbench thread and every other thread reflect the live working tree
     const session = this.snapshot.session;
     if (readsFrozenDiff(session)) return session!.artifact.files ?? [];
+    const initialFiles = this.consumeInitialDiffFiles(session);
+
+    if (initialFiles !== null) return initialFiles;
     // eager: capture the live working-tree diff so the Changes navigator and its file tabs render a real diff
     if (this.client?.repoDiff !== undefined) {
       const diff = await this.client.repoDiff(
@@ -879,6 +896,13 @@ class Controller implements ReviewController {
     }));
   }
 
+  private consumeInitialDiffFiles(session: Thread | null): readonly DiffFileContents[] | null {
+    if (!this.initialDiffAvailable) return null;
+    this.initialDiffAvailable = false;
+
+    return session?.id === this.options.sessionId ? (this.liveDiff?.files ?? []) : null;
+  }
+
   async refreshDiff(): Promise<void> {
     const session = this.snapshot.session;
 

package/src/use-repo-changes.ts

@@ -8,6 +8,7 @@ interface RepoChangesOptions {
   loadChanges: () => Promise<readonly DiffFileContents[]>;
   visible: boolean;
   diffSourceKey: string;
+  initialFiles?: readonly DiffFileContents[];
   refreshAutomatically?: boolean;
 }
 
@@ -34,9 +35,12 @@ export function useRepoChanges({
   loadChanges,
   visible,
   diffSourceKey,
+  initialFiles,
   refreshAutomatically = true,
 }: RepoChangesOptions): readonly DiffFileContents[] {
-  const [snapshot, setSnapshot] = useState<RepoChangesSnapshot | null>(null);
+  const [snapshot, setSnapshot] = useState<RepoChangesSnapshot | null>(() =>
+    initialFiles ? { diffSourceKey, files: initialFiles } : null,
+  );
   const loadLatestChanges = useEffectEvent(loadChanges);
 
   useEffect(() => {