@cueloop/client 0.1.0-alpha.9 → 0.1.0-alpha.90

package/src/App.rendering.test.tsx

@@ -1,14 +1,14 @@
-/** Plan rendering (#67): code blocks verbatim + contained, spacing never collapses. */
+/** Plan rendering: code blocks verbatim + contained, spacing never collapses. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import React from "react";
-import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
-import type { ReviewSession } from "@cueloop/schema";
+import type { Thread } from "@cueloop/schema";
 import { App } from "./App";
+import { isolateUserConfig, waitForText, renderReadyApp } from "./test-support";
 
 const PLAN = `# Render Plan
 
@@ -29,11 +29,13 @@ Deploys block below the threshold.
 `;
 
 let home: string;
+let restoreUserConfig: () => void;
 let server: DaemonServer;
-let session: ReviewSession;
+let session: Thread;
 
 beforeEach(() => {
   home = mkdtempSync(join(tmpdir(), "cueloop-render-"));
+  restoreUserConfig = isolateUserConfig(home);
   server = new DaemonServer({ home, idleExitMs: 0 });
   server.start();
   session = server.core.sessionCreate({
@@ -42,67 +44,91 @@ beforeEach(() => {
   });
 });
 afterEach(() => {
+  restoreUserConfig();
   server.stop();
   rmSync(home, { recursive: true, force: true });
 });
 
 async function frame(): Promise<string> {
-  const setup = await testRender(<App home={home} sessionId={session.id} />, { width: 120, height: 36 });
-  const deadline = Date.now() + 10_000;
-  while (Date.now() < deadline && !setup.captureCharFrame().includes("Render Plan")) {
-    await Bun.sleep(25);
-    await setup.renderOnce();
-  }
-  // give the async highlighter a beat, then take the final frame
-  await Bun.sleep(150);
-  await setup.renderOnce();
+  const setup = await renderReadyApp(<App home={home} sessionId={session.id} />, {
+    width: 120,
+    height: 36,
+  });
+
+  await waitForText(setup, "Render Plan");
+  // async highlights settle within the visual-idle wait
+  await setup.waitForVisualIdle();
+
   return setup.captureCharFrame();
 }
 
 describe("code blocks", () => {
   test("lines render verbatim: indentation preserved, no word-wrap", async () => {
-    const f = await frame();
-    expect(f).toContain("  const blocked = full < 0.6;");
-    expect(f).toContain('  return <text>{blocked ? "blocked" : "clear"}</text>;');
+    // Arrange
+    const rendered = await frame();
+
+    // Assert
+    expect(rendered).toContain("  const blocked = full < 0.6;");
+    expect(rendered).toContain('  return <text>{blocked ? "blocked" : "clear"}</text>;');
   });
 
   test("the block carries its language tag", async () => {
-    const f = await frame();
-    expect(f).toContain("tsx");
+    // Arrange
+    const rendered = await frame();
+
+    // Assert
+    expect(rendered).toContain("tsx");
   });
 });
 
 describe("block spacing", () => {
+  // the review rail paints box edges on the right, so read the document
+  // column (everything left of the first rail glyph) before asserting spacing
+  const planColumn = (line: string): string => line.split(/[│╭╰]/)[0]!.trimEnd();
+
   test("a code block never glues to the list item above it", async () => {
-    const lines = (await frame()).split("\n").map((l) => l.trimEnd());
-    const li = lines.findIndex((l) => l.includes("wire the duck over MQTT"));
-    const codeHeader = lines.findIndex((l) => l.trim().startsWith("tsx"));
-    expect(li).toBeGreaterThan(-1);
-    expect(codeHeader).toBeGreaterThan(li);
-    expect(lines.slice(li + 1, codeHeader).some((l) => l === "")).toBe(true);
+    // Arrange
+    const lines = (await frame()).split("\n").map(planColumn);
+    const listItemLineIndex = lines.findIndex((line) => line.includes("wire the duck over MQTT"));
+    const codeHeader = lines.findIndex((line) => line.trim().startsWith("tsx"));
+
+    // Assert
+    expect(listItemLineIndex).toBeGreaterThan(-1);
+    expect(codeHeader).toBeGreaterThan(listItemLineIndex);
+    expect(lines.slice(listItemLineIndex + 1, codeHeader).some((line) => line === "")).toBe(true);
   });
 
   test("a heading never sits directly on the previous block", async () => {
-    const lines = (await frame()).split("\n").map((l) => l.trimEnd());
-    const gate = lines.findIndex((l) => l.trim() === "Gate");
+    // Arrange
+    const lines = (await frame()).split("\n").map(planColumn);
+    const gate = lines.findIndex((line) => line.trim() === "Gate");
+
+    // Assert
     expect(gate).toBeGreaterThan(0);
     expect(lines[gate - 1]).toBe("");
   });
 
   test("consecutive list items stay tight", async () => {
+    // Arrange
     const listPlan = "# T\n\n- one\n- two\n";
     const s2 = server.core.sessionCreate({
       workspace: { repoRoot: "/repo", branch: "main" },
       artifact: { type: "plan", content: listPlan, meta: {} },
     });
-    const setup = await testRender(<App home={home} sessionId={s2.id} />, { width: 120, height: 30 });
-    const deadline = Date.now() + 10_000;
-    while (Date.now() < deadline && !setup.captureCharFrame().includes("one")) {
-      await Bun.sleep(25);
-      await setup.renderOnce();
-    }
-    const lines = setup.captureCharFrame().split("\n").map((l) => l.trimEnd());
-    const one = lines.findIndex((l) => l.includes("- one"));
-    expect(lines[one + 1]).toContain("- two");
+    const setup = await renderReadyApp(<App home={home} sessionId={s2.id} />, {
+      width: 120,
+      height: 30,
+    });
+
+    await waitForText(setup, "one");
+
+    // Assert
+    const lines = setup
+      .captureCharFrame()
+      .split("\n")
+      .map((line) => line.trimEnd());
+    const one = lines.findIndex((line) => line.includes("· one"));
+
+    expect(lines[one + 1]).toContain("· two");
   });
 });

package/src/App.share-dialog.test.tsx

@@ -0,0 +1,172 @@
+/** The share shortcut opens the two-column share dialog reachable from any view. */
+
+import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { testRender } from "@opentui/react/test-utils";
+import { DaemonServer } from "@cueloop/daemon";
+import type { Thread } from "@cueloop/schema";
+import { App } from "./App";
+import type { ShareTransport } from "./thread-controller";
+import {
+  isolateUserConfig,
+  press,
+  pressKey,
+  settle,
+  waitForText,
+  waitForTextGone,
+} from "./test-support";
+
+const shareTransport: ShareTransport = {
+  publish: mock(async () => ({ line: "ssh p_share01@cueloop.dev", copied: true })),
+  pull: mock(async () => {
+    throw new Error("Unexpected share pull");
+  }),
+  push: mock(async () => {}),
+  watch: () => () => {},
+  revoke: async () => {},
+  parseShareId: (line) => line.match(/^ssh (\S+)@/)?.[1],
+  formatShareLine: (id: string) => "ssh " + id + "@cueloop.dev",
+  collaboratorAnnotations: () => [],
+  mergeFromShare: () => ({ annotations: [] }),
+};
+
+const PLAN = `# Migration Plan\n\n## Context\n\nThe daemon persists sessions to disk atomically.\n`;
+
+let home: string;
+let restoreUserConfig: () => void;
+let server: DaemonServer;
+let session: Thread;
+
+beforeEach(() => {
+  home = mkdtempSync(join(tmpdir(), "cueloop-share-choice-"));
+  restoreUserConfig = isolateUserConfig(home);
+  server = new DaemonServer({ home, idleExitMs: 0 });
+  server.start();
+  session = server.core.sessionCreate({
+    workspace: { repoRoot: "/repo", branch: "main" },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
+  });
+});
+afterEach(() => {
+  restoreUserConfig();
+  server.stop();
+  rmSync(home, { recursive: true, force: true });
+});
+
+describe("share dialog", () => {
+  test("the shortcut opens the two-column share dialog", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act
+    await pressKey(setup, "s", { ctrl: true });
+
+    // Assert - the nav categories and the empty-state new-link affordance
+    await waitForText(setup, "share externally");
+    await waitForText(setup, "export");
+    await waitForText(setup, "+ new link");
+  });
+
+  test("new link opens the wizard, and require auth reveals the allowlist", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act: open the dialog, step into the body, activate "+ new link"
+    await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "+ new link");
+    await press(setup, "enter");
+    await press(setup, "enter");
+
+    // Assert - the wizard's fields
+    await waitForText(setup, "link name");
+    await waitForText(setup, "require auth");
+
+    // Act: focus the auth row and switch it on (enter toggles the focused row)
+    await press(setup, "down");
+    await press(setup, "enter");
+
+    // Assert - the handles input appears with its grayed placeholder
+    await waitForText(setup, "handle");
+
+    // Act: backspace on the empty allowlist collapses require auth back off
+    await press(setup, "backspace");
+
+    // Assert - the handles section is gone
+    await waitForTextGone(setup, "handle");
+  });
+
+  test("a private link with no handles cannot be created", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act: open the wizard, turn auth on but add no handles, then try to create
+    await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "+ new link");
+    await press(setup, "enter"); // into the body
+    await press(setup, "enter"); // open the wizard
+    await waitForText(setup, "require auth");
+    await press(setup, "down"); // focus the auth row
+    await press(setup, "enter"); // toggle auth on (focus moves to the empty allowlist)
+    await press(setup, "down"); // move to the create action
+    await press(setup, "enter"); // create is blocked while the allowlist is empty
+    await settle(setup);
+
+    // Assert - the wizard is still open (nothing was created and the dialog did not fall back to the list)
+    expect(setup.captureCharFrame()).toContain("require auth");
+  });
+
+  test("right enters the links body and left returns to the nav", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act + Assert: right arrow crosses into the body (its hint appears)
+    await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "+ new link");
+    await press(setup, "right");
+    await waitForText(setup, "h back");
+
+    // Act + Assert: left arrow returns to the nav (its hint returns)
+    await press(setup, "left");
+    await waitForText(setup, "l/enter open");
+  });
+
+  test("escape closes the dialog", async () => {
+    // Arrange
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      { width: 120, height: 32 },
+    );
+    await waitForText(setup, "cueloop");
+
+    // Act
+    await pressKey(setup, "s", { ctrl: true });
+    await waitForText(setup, "share externally");
+    await press(setup, "escape");
+
+    // Assert
+    await waitForTextGone(setup, "share externally");
+  });
+});

package/src/App.submit-confirm.test.tsx

@@ -0,0 +1,264 @@
+/** The send-message confirm: cmd+enter opens a centered overlay with a message selector, summary input, and word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
+
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { testRender } from "@opentui/react/test-utils";
+import { DaemonServer } from "@cueloop/daemon";
+import { makeAnchor, parseBlocks, type Thread } from "@cueloop/schema";
+import { App } from "./App";
+import {
+  isolateUserConfig,
+  press,
+  pressKey,
+  settle,
+  waitForText,
+  waitForTextGone,
+} from "./test-support";
+
+const PLAN = `# Migration Plan
+
+## Context
+
+The daemon persists sessions to disk atomically.
+
+## Steps
+
+- move the store
+- add recovery
+`;
+
+let home: string;
+let restoreUserConfig: () => void;
+let server: DaemonServer;
+let session: Thread;
+
+beforeEach(() => {
+  home = mkdtempSync(join(tmpdir(), "cueloop-confirm-"));
+  restoreUserConfig = isolateUserConfig(home);
+  server = new DaemonServer({ home, idleExitMs: 0 });
+  server.start();
+  session = server.core.sessionCreate({
+    workspace: { repoRoot: "/repo", branch: "main" },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
+  });
+});
+afterEach(() => {
+  restoreUserConfig();
+  server.stop();
+  rmSync(home, { recursive: true, force: true });
+});
+
+async function renderApp(options: { readOnly?: boolean } = {}) {
+  const setup = await testRender(
+    <App home={home} sessionId={session.id} readOnly={options.readOnly ?? false} />,
+    {
+      width: 120,
+      height: 32,
+    },
+  );
+
+  await waitForText(setup, "cueloop");
+
+  return setup;
+}
+
+/** Seed annotations directly through the daemon core (all on one block). */
+function seedAnnotations(count: number): void {
+  const blocks = parseBlocks(PLAN);
+
+  for (let index = 1; index <= count; index++) {
+    server.core.sessionAnnotate(session.id, {
+      id: `a_confirm_${index}`,
+      kind: "comment",
+      anchor: makeAnchor(blocks, 2, 0, 10),
+      body: `note ${String(index).padStart(2, "0")}`,
+    });
+  }
+}
+
+describe("send message confirm", () => {
+  test("cmd+enter opens the send-message confirm overlay with stable message choices", async () => {
+    // Arrange
+    const setup = await renderApp();
+
+    // Assert - the footer carries the send control before the overlay opens
+    expect(setup.captureCharFrame()).toContain("Send message (0)");
+
+    // Act
+    await pressKey(setup, "RETURN", { meta: true });
+
+    // Assert - the overlay: message selector and word-buttons
+    await waitForText(setup, "[approve]"); // nothing pending: approve default
+    const initialFrame = setup.captureCharFrame();
+    const initialSelector = initialFrame
+      .split("\n")
+      .find((row) => row.includes("[comment] [approve] [changes]"));
+
+    expect(initialSelector).toBeDefined();
+    expect(initialFrame).toContain(" send ");
+    expect(initialFrame).toContain(" cancel ");
+
+    // Act - move the active choice across the selector
+    await press(setup, "right");
+    const changesSelector = setup
+      .captureCharFrame()
+      .split("\n")
+      .find((row) => row.includes("[comment] [approve] [changes]"));
+    await press(setup, "right");
+    const commentSelector = setup
+      .captureCharFrame()
+      .split("\n")
+      .find((row) => row.includes("[comment] [approve] [changes]"));
+
+    // Assert - active styling does not move or resize any choice
+    expect(changesSelector).toBe(initialSelector);
+    expect(commentSelector).toBe(initialSelector);
+  });
+
+  test("left/right cycles the message selector in the overlay", async () => {
+    // Arrange
+    const setup = await renderApp();
+
+    await pressKey(setup, "RETURN", { meta: true });
+
+    // Assert
+    await waitForText(setup, "[approve]");
+
+    // Act
+    await press(setup, "right");
+
+    // Assert
+    await waitForText(setup, "[changes]");
+
+    // Act
+    await press(setup, "right");
+
+    // Assert
+    await waitForText(setup, "[comment]");
+
+    // Act
+    await press(setup, "left");
+
+    // Assert
+    await waitForText(setup, "[changes]");
+  });
+
+  test("esc closes the overlay", async () => {
+    // Arrange
+    const setup = await renderApp();
+
+    await pressKey(setup, "RETURN", { meta: true });
+
+    // Assert
+    await waitForText(setup, "[approve]");
+
+    // Act
+    await press(setup, "escape");
+
+    // Assert - a bare ESC settles after the parser's escape-sequence window
+    const frame = await waitForTextGone(setup, "[approve]");
+
+    expect(frame).not.toContain(" cancel ");
+  });
+
+  test("enter in the overlay resolves the session through the controller", async () => {
+    // Arrange
+    seedAnnotations(1);
+    const setup = await renderApp();
+
+    // Act
+    await pressKey(setup, "RETURN", { meta: true });
+
+    // Assert - opens on the default message, then cycle to request changes
+    await waitForText(setup, "[approve]");
+    await press(setup, "right");
+    await waitForText(setup, "[changes]");
+
+    // Act
+    await setup.mockInput.typeText("Tighten the steps.");
+    await pressKey(setup, "RETURN", { meta: true });
+
+    // Assert - the completion flow after submit is unchanged
+    await waitForText(setup, "feedback sent");
+    const stored = server.core.sessionGet(session.id);
+
+    expect(stored.status).toBe("resolved");
+    expect(stored.message!.outcome).toBe("changes_requested");
+  });
+
+  test("Comment sends feedback while leaving the Thread open", async () => {
+    seedAnnotations(1);
+    const setup = await renderApp();
+
+    await pressKey(setup, "RETURN", { meta: true });
+    await waitForText(setup, "[approve]");
+    await press(setup, "left");
+    await waitForText(setup, "[comment]");
+
+    await setup.mockInput.typeText("For now.");
+    await pressKey(setup, "RETURN", { meta: true });
+
+    await waitForText(setup, "comment sent - thread stays open");
+    const stored = server.core.sessionGet(session.id);
+
+    expect(stored.status).toBe("pending");
+    expect(stored.message!.outcome).toBe("comment");
+    expect(stored.message!.annotations?.map((annotation) => annotation.id)).toEqual([
+      "a_confirm_1",
+    ]);
+    expect(setup.captureCharFrame()).not.toContain("feedback sent");
+  });
+
+  test("typing / in the summary opens the skills/actions palette", async () => {
+    // Arrange
+    seedAnnotations(1);
+    const setup = await renderApp();
+    await pressKey(setup, "RETURN", { meta: true });
+    await waitForText(setup, "[approve]");
+
+    // Act
+    await setup.mockInput.typeText("/restate");
+
+    // Assert - the same slash palette the inline composer shows
+    await waitForText(setup, "restate-simplified");
+  });
+
+  test("pasting an image into the summary drops in an [Image #n] placeholder", async () => {
+    // Arrange
+    const setup = await renderApp();
+    await pressKey(setup, "RETURN", { meta: true });
+    await waitForText(setup, "[approve]");
+
+    // Act - a burst of control bytes stands in for the binary an image paste delivers
+    await setup.mockInput.typeText("look at this ");
+    await setup.mockInput.pasteBracketedText("
");
+
+    // Assert - the raw bytes never reach the draft; a numbered placeholder does
+    await waitForText(setup, "[Image #1]");
+    expect(setup.captureCharFrame()).toContain("look at this [Image #1]");
+  });
+
+  test("read-only observers cannot open the confirm overlay", async () => {
+    // Arrange
+    seedAnnotations(1);
+    const setup = await renderApp({ readOnly: true });
+
+    // Act
+    await pressKey(setup, "RETURN", { meta: true });
+    await settle(setup);
+
+    // Assert - no overlay, and the session stays pending
+    const frame = setup.captureCharFrame();
+
+    expect(frame).not.toContain("[approve]");
+    expect(frame).not.toContain(" cancel ");
+    expect(server.core.sessionGet(session.id).status).toBe("pending");
+  });
+});