@cueloop/client 0.1.0-alpha.8 → 0.1.0-alpha.80

package/src/components/MarkdownThreadEditor.test.tsx

@@ -0,0 +1,98 @@
+import { describe, expect, test } from "bun:test";
+import React from "react";
+import { testRender } from "@opentui/react/test-utils";
+import { DARK } from "../theme";
+import { press, settle } from "../test-support";
+import { MarkdownThreadEditor, type MarkdownEditorHandle } from "./MarkdownThreadEditor";
+
+describe("MarkdownThreadEditor", () => {
+  test("opens on the working copy and shows the caret position and save hint", async () => {
+    const setup = await testRender(
+      <MarkdownThreadEditor
+        initialText={"# Title\n\nbody text here\n"}
+        theme={DARK}
+        onExitEditor={() => {}}
+      />,
+      { width: 50, height: 12 },
+    );
+
+    await settle(setup);
+    const frame = setup.captureCharFrame();
+
+    expect(frame).toContain("Title");
+    expect(frame).toContain("body text here");
+    expect(frame).toContain("Ln 1/4");
+    expect(frame).toContain("save & close");
+    setup.renderer.destroy();
+  });
+
+  test("the exit handle saves the current text and leaves (the header toggle's path)", async () => {
+    const handleRef = React.createRef<MarkdownEditorHandle>();
+    let exitedWith = "";
+    const setup = await testRender(
+      <MarkdownThreadEditor
+        ref={handleRef}
+        initialText={"keep this"}
+        theme={DARK}
+        onExitEditor={(text) => {
+          exitedWith = text;
+        }}
+      />,
+      { width: 40, height: 8 },
+    );
+
+    await settle(setup);
+    handleRef.current?.requestExit();
+
+    expect(exitedWith).toBe("keep this");
+    setup.renderer.destroy();
+  });
+
+  test("highlights align to the exact characters across lines (no newline drift)", async () => {
+    const setup = await testRender(
+      <MarkdownThreadEditor
+        initialText={"# Head\n\nrun `code` now\n"}
+        theme={DARK}
+        onExitEditor={() => {}}
+      />,
+      { width: 40, height: 10 },
+    );
+
+    await settle(setup);
+    const spans = setup.captureSpans().lines.flatMap((line) => line.spans);
+    const hexOf = (color: { toInts: () => number[] }): string =>
+      "#" +
+      color
+        .toInts()
+        .slice(0, 3)
+        .map((part) => part.toString(16).padStart(2, "0"))
+        .join("");
+    // the code highlight must cover exactly `code`, not a drifted slice like "ode` "
+    const codeSpan = spans.find((span) => span.text === "`code`");
+
+    expect(codeSpan).toBeDefined();
+    expect(codeSpan?.fg && hexOf(codeSpan.fg)).toBe(DARK.textDim);
+    setup.renderer.destroy();
+  });
+
+  test("escape is a no-op - it never leaves the editor (IDE convention)", async () => {
+    let exits = 0;
+    const setup = await testRender(
+      <MarkdownThreadEditor
+        initialText={"stay put"}
+        theme={DARK}
+        onExitEditor={() => {
+          exits += 1;
+        }}
+      />,
+      { width: 40, height: 8 },
+    );
+
+    await settle(setup);
+    await press(setup, "escape");
+
+    expect(exits).toBe(0);
+    expect(setup.captureCharFrame()).toContain("save & close");
+    setup.renderer.destroy();
+  });
+});

package/src/components/MarkdownThreadEditor.tsx

@@ -0,0 +1,162 @@
+/**
+ * The native inline markdown editor for a thread's body: a full-height text area
+ * over the working copy that lightly marks markdown as you type - a heading's
+ * marker dims and its title bolds, links color, inline and fenced code gray -
+ * and reports the caret line and column, replacing the external-editor hand-off so
+ * editing needs no per-user editor configuration. cmd, meta, or ctrl + enter
+ * saves the working copy and closes (loss-free, like the hand-off it replaces),
+ * as does the header edit/normal toggle; plain enter breaks the line. Escape is
+ * a no-op inside the editor, matching a modeless IDE - you leave by an explicit
+ * action, not by escaping the text. The raw markdown stays visible - a concealed
+ * rendered preview is a later layer.
+ */
+
+import React, { forwardRef, useImperativeHandle, useLayoutEffect, useRef, useState } from "react";
+import type { KeyBinding, TextareaRenderable } from "@opentui/core";
+import { type Theme } from "../theme";
+import { markdownHighlightRanges } from "../markdown-highlight";
+import { markdownEditorStyle } from "../markdown-editor-syntax-style";
+
+export interface MarkdownThreadEditorProps {
+  /** The thread body's working copy; the editor opens on this markdown text. */
+  initialText: string;
+  theme: Theme;
+  /** Called with the edited markdown when the reviewer leaves (cmd/ctrl+enter or the header toggle); both save. */
+  onExitEditor: (text: string) => void;
+}
+
+/** An imperative exit for callers outside the editor (the header edit/normal toggle): save the current text and leave. */
+export interface MarkdownEditorHandle {
+  requestExit: () => void;
+}
+
+// three modifiers cover terminal variance for save-and-close; plain enter is a newline, escape stays unbound
+const MARKDOWN_EDITOR_KEY_BINDINGS: KeyBinding[] = [
+  { name: "return", super: true, action: "submit" },
+  { name: "return", meta: true, action: "submit" },
+  { name: "return", ctrl: true, action: "submit" },
+  { name: "a", super: true, action: "select-all" },
+  { name: "a", meta: true, action: "select-all" },
+  { name: "return", action: "newline" },
+  { name: "return", shift: true, action: "newline" },
+];
+
+/** The caret's 1-based line and column, plus the buffer's total line count, for the status footer. */
+interface MarkdownEditorPosition {
+  line: number;
+  column: number;
+  lineCount: number;
+}
+
+/** For each offset 0..length, the count of newlines before it, mapping a source offset to the buffer's newline-excluded offset. */
+function newlinePrefixCounts(text: string): number[] {
+  const counts = Array.from({ length: text.length + 1 }, () => 0);
+  let seen = 0;
+
+  for (let index = 0; index < text.length; index++) {
+    counts[index] = seen;
+    if (text[index] === "\n") seen += 1;
+  }
+  counts[text.length] = seen;
+
+  return counts;
+}
+
+export const MarkdownThreadEditor = forwardRef<MarkdownEditorHandle, MarkdownThreadEditorProps>(
+  function MarkdownThreadEditor({ initialText, theme, onExitEditor }, handleRef): React.ReactNode {
+    const editorRef = useRef<TextareaRenderable | null>(null);
+    const [position, setPosition] = useState<MarkdownEditorPosition>({
+      line: 1,
+      column: 1,
+      lineCount: initialText.split("\n").length,
+    });
+
+    const exitWithCurrentText = (): void =>
+      onExitEditor(editorRef.current?.plainText ?? initialText);
+
+    useImperativeHandle(handleRef, () => ({ requestExit: exitWithCurrentText }));
+
+    const paintMarkdown = (editor: TextareaRenderable): void => {
+      const { styleIdFor } = markdownEditorStyle(theme);
+      const text = editor.plainText;
+      // addHighlightByCharRange counts offsets with newlines excluded, so map source offsets down by the
+      // newlines before them - otherwise a highlight drifts one cell per preceding line
+      const newlinesBefore = newlinePrefixCounts(text);
+
+      editor.editBuffer.clearAllHighlights();
+      for (const range of markdownHighlightRanges(text)) {
+        editor.editBuffer.addHighlightByCharRange({
+          start: range.start - newlinesBefore[range.start]!,
+          end: range.end - newlinesBefore[range.end]!,
+          styleId: styleIdFor(range.group),
+        });
+      }
+    };
+
+    // paint synchronously at commit so the first frame already shows styled markdown
+    useLayoutEffect(() => {
+      const editor = editorRef.current;
+
+      if (!editor) return;
+      editor.editBuffer.setSyntaxStyle(markdownEditorStyle(theme).style);
+      paintMarkdown(editor);
+      setPosition((prior) => ({ ...prior, lineCount: editor.editBuffer.getLineCount() }));
+      // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
+
+    return (
+      <box style={{ flexDirection: "column", flexGrow: 1, paddingLeft: 2 }}>
+        <textarea
+          ref={editorRef}
+          focused
+          initialValue={initialText}
+          keyBindings={MARKDOWN_EDITOR_KEY_BINDINGS}
+          wrapMode="word"
+          cursorStyle={{ style: "block", blinking: true }}
+          onSubmit={exitWithCurrentText}
+          onCursorChange={(event) =>
+            setPosition((prior) => ({
+              ...prior,
+              line: event.line + 1,
+              column: event.visualColumn + 1,
+            }))
+          }
+          onContentChange={() => {
+            const editor = editorRef.current;
+
+            if (!editor) return;
+            paintMarkdown(editor);
+            setPosition((prior) => ({ ...prior, lineCount: editor.editBuffer.getLineCount() }));
+          }}
+          style={{
+            flexGrow: 1,
+            backgroundColor: "transparent",
+            focusedBackgroundColor: "transparent",
+            textColor: theme.text,
+            focusedTextColor: theme.text,
+          }}
+        />
+        <MarkdownEditorStatus position={position} theme={theme} />
+      </box>
+    );
+  },
+);
+
+/** The one-row footer under the editor: caret line and column, total lines, and the save-and-close hint. */
+function MarkdownEditorStatus({
+  position,
+  theme,
+}: {
+  position: MarkdownEditorPosition;
+  theme: Theme;
+}): React.ReactNode {
+  return (
+    <box style={{ flexDirection: "row", flexShrink: 0 }}>
+      <text
+        fg={theme.textMuted}
+      >{`Ln ${position.line}/${position.lineCount}  Col ${position.column}`}</text>
+      <box style={{ flexGrow: 1 }} />
+      <text fg={theme.textDim}>{"⌃⏎ save & close"}</text>
+    </box>
+  );
+}

package/src/components/MenuBar.stories.tsx

@@ -0,0 +1,28 @@
+import React from "react";
+import { DARK } from "../theme";
+import type { Story, StoryMeta } from "./story";
+import { MenuBar } from "./MenuBar";
+
+export const meta: StoryMeta = { title: "Chrome/MenuBar" };
+
+const callbacks = { onSettings: () => {}, onKeybinds: () => {} };
+
+function BottomFrame({ children }: { children: React.ReactNode }): React.ReactNode {
+  return (
+    <box
+      style={{ flexDirection: "column", width: "100%", height: "100%", justifyContent: "flex-end" }}
+    >
+      {children}
+    </box>
+  );
+}
+
+export const Open: Story = {
+  render: () => (
+    <BottomFrame>
+      <MenuBar open {...callbacks} />
+    </BottomFrame>
+  ),
+  expectedColors: [DARK.text],
+  size: { width: 60, height: 8 },
+};

package/src/components/MenuBar.tsx

@@ -0,0 +1,44 @@
+import React from "react";
+import type { Theme } from "../theme";
+import { useComponentTheme } from "./theme-context";
+import { FRAME_BORDER_STYLE } from "./primitives/frame";
+
+export interface MenuBarProps {
+  open: boolean;
+  onSettings: () => void;
+  onKeybinds: () => void;
+  theme?: Theme;
+}
+
+const DROPDOWN_OPTION_ROWS = 2;
+
+/** The settings gear's drop-down: Settings and Keybinds, below the top-left gear. */
+export function MenuBar({ open, onSettings, onKeybinds, theme }: MenuBarProps): React.ReactNode {
+  const tokens = useComponentTheme(theme);
+  const dropdownHeight = DROPDOWN_OPTION_ROWS + 2;
+
+  if (!open) return null;
+
+  return (
+    <box
+      style={{
+        position: "absolute",
+        left: 1,
+        top: 2,
+        width: 16,
+        height: dropdownHeight,
+        border: true,
+        borderStyle: FRAME_BORDER_STYLE,
+        borderColor: tokens.text,
+        flexDirection: "column",
+      }}
+    >
+      <box onMouseUp={onSettings}>
+        <text fg={tokens.text}> Settings</text>
+      </box>
+      <box onMouseUp={onKeybinds}>
+        <text fg={tokens.text}> Keybinds</text>
+      </box>
+    </box>
+  );
+}

package/src/components/NavModeHint.stories.tsx

@@ -0,0 +1,40 @@
+import React from "react";
+import { DARK } from "../theme";
+import type { Story, StoryMeta } from "./story";
+import { NavModeHint } from "./NavModeHint";
+
+export const meta: StoryMeta = { title: "Chrome/NavModeHint" };
+
+function Frame({ children }: { children: React.ReactNode }): React.ReactNode {
+  return <box style={{ width: "100%", backgroundColor: DARK.panel }}>{children}</box>;
+}
+
+export const ThreadNav: Story = {
+  render: () => (
+    <Frame>
+      <NavModeHint navMode surface="thread" theme={DARK} />
+    </Frame>
+  ),
+  expectedColors: [DARK.textDim],
+  size: { width: 80, height: 1 },
+};
+
+export const DiffNav: Story = {
+  render: () => (
+    <Frame>
+      <NavModeHint navMode surface="diff" theme={DARK} />
+    </Frame>
+  ),
+  expectedColors: [DARK.textDim],
+  size: { width: 80, height: 1 },
+};
+
+export const Composing: Story = {
+  render: () => (
+    <Frame>
+      <NavModeHint navMode={false} surface="thread" theme={DARK} />
+    </Frame>
+  ),
+  expectedColors: [DARK.textDim],
+  size: { width: 80, height: 1 },
+};

package/src/components/NavModeHint.tsx

@@ -0,0 +1,31 @@
+import React from "react";
+import type { Theme } from "../theme";
+
+const DIFF_NAV_HINT = "x reject · c fold · d layout · k walk · ⏎ submit · type to leave";
+const THREAD_NAV_HINT = "c comment · e edit · s share · n/p cards · ⏎ submit · type to leave";
+const BARE_NAV_HINT = "c comment · z fold · type to leave";
+const COMPOSE_HINT = "type to comment · esc for nav mode";
+
+const NAV_HINTS = { thread: THREAD_NAV_HINT, diff: DIFF_NAV_HINT, bare: BARE_NAV_HINT };
+
+export type NavHintSurface = keyof typeof NAV_HINTS;
+
+export function NavModeHint({
+  navMode,
+  surface,
+  theme,
+}: {
+  navMode: boolean;
+  surface: NavHintSurface;
+  theme: Theme;
+}): React.ReactNode {
+  const navHint = NAV_HINTS[surface];
+
+  return (
+    <box style={{ height: 1, flexDirection: "row", paddingLeft: 2 }}>
+      <text selectable={false} fg={theme.textDim}>
+        {navMode ? navHint : COMPOSE_HINT}
+      </text>
+    </box>
+  );
+}

package/src/components/OverlayScrollbar.stories.tsx

@@ -0,0 +1,33 @@
+import React, { useRef } from "react";
+import type { ScrollBoxRenderable } from "@opentui/core";
+import { DARK } from "../theme";
+import { OverlayScrollbar } from "./OverlayScrollbar";
+import type { Story, StoryMeta } from "./story";
+
+export const meta: StoryMeta = { title: "Chrome/OverlayScrollbar" };
+
+function TallSurface(): React.ReactNode {
+  const scrollRef = useRef<ScrollBoxRenderable | null>(null);
+
+  return (
+    <box style={{ width: 24, height: 8, flexDirection: "row", backgroundColor: DARK.background }}>
+      <scrollbox
+        ref={scrollRef}
+        style={{ flexGrow: 1 }}
+        focused={false}
+        verticalScrollbarOptions={{ visible: false }}
+      >
+        {Array.from({ length: 24 }, (_unused, index) => (
+          <text key={index} fg={DARK.textMuted}>{`row ${index + 1}`}</text>
+        ))}
+      </scrollbox>
+      <OverlayScrollbar scrollbox={scrollRef} />
+    </box>
+  );
+}
+
+// At rest the overlay bar is hidden; the thumb only appears while the surface is scrolling.
+export const AtRest: Story = {
+  render: () => <TallSurface />,
+  size: { width: 24, height: 8 },
+};

package/src/components/OverlayScrollbar.test.tsx

@@ -0,0 +1,139 @@
+/**
+ * The mirrored scrollbar: thumb geometry follows the scroll state, and on a surface it
+ * draws as the panel's rightmost column, past the discussion dots - not inside the
+ * scrollbox's own viewport row.
+ */
+
+import { describe, expect, test } from "bun:test";
+import { testRender } from "@opentui/react/test-utils";
+import { ScrollBoxRenderable, type Renderable } from "@opentui/core";
+import React from "react";
+import { DiffContentView } from "./DiffContentView";
+import { diffRows, marksByRows } from "../view-diff";
+import { allowEventLoopUpdates } from "../test-support";
+import { fixtureDiffSession } from "./story-fixtures";
+import { DARK } from "../theme";
+import { thumbGeometry } from "./OverlayScrollbar";
+
+const noop = (): void => {};
+
+function findById(node: Renderable, id: string): Renderable | undefined {
+  if (node.id === id) return node;
+  for (const child of node.getChildren()) {
+    const found = findById(child, id);
+
+    if (found) return found;
+  }
+
+  return undefined;
+}
+
+function hex(color: { toInts(): [number, number, number, number] }): string {
+  const [red, green, blue] = color.toInts();
+
+  return "#" + [red, green, blue].map((part) => part.toString(16).padStart(2, "0")).join("");
+}
+
+describe("thumbGeometry", () => {
+  test("nothing to scroll draws no thumb", () => {
+    // Arrange / Act / Assert - content fits the viewport
+    expect(thumbGeometry({ top: 0, height: 10, viewport: 14 }, 14)).toBeNull();
+  });
+
+  test("the thumb's height is the viewport's share of the content, at least one row", () => {
+    // Act
+    const tall = thumbGeometry({ top: 0, height: 44, viewport: 14 }, 14);
+    const tiny = thumbGeometry({ top: 0, height: 10_000, viewport: 14 }, 14);
+
+    // Assert
+    expect(tall).toEqual({ row: 0, height: 4 });
+    expect(tiny?.height).toBe(1);
+  });
+
+  test("the thumb reaches the track's end at the maximum scroll offset", () => {
+    // Act - scrolled to the bottom
+    const thumb = thumbGeometry({ top: 30, height: 44, viewport: 14 }, 14);
+
+    // Assert - its last row is the track's last row
+    expect(thumb).toEqual({ row: 10, height: 4 });
+  });
+});
+
+describe("the diff sheet's scrollbar", () => {
+  const body = Array.from({ length: 40 }, (_unused, index) => `+line ${index} of the change;`).join(
+    "\n",
+  );
+  const patch = `diff --git a/x.ts b/x.ts\n--- a/x.ts\n+++ b/x.ts\n@@ -0,0 +1,40 @@\n${body}\n`;
+
+  test("draws as the rightmost column, past the discussion dot", async () => {
+    // Arrange - a diff taller than the viewport, with one discussion so the dot rail has a dot
+    const rows = diffRows(patch);
+    const session = fixtureDiffSession({
+      annotations: [
+        {
+          id: "a1",
+          kind: "comment",
+          body: "hm",
+          anchor: { quote: "line 7 of the change;", prefix: "", suffix: "" },
+          createdAt: "2026-01-01T00:00:00Z",
+        },
+      ],
+    });
+    const width = 60;
+    const setup = await testRender(
+      <DiffContentView
+        rows={rows}
+        session={session}
+        marks={marksByRows(session.annotations, rows)}
+        quickActions={[]}
+        observer={false}
+        onAnnotate={noop}
+        onReply={noop}
+        onUpdateAnnotation={noop}
+        onExit={noop}
+      />,
+      { width, height: 14 },
+    );
+
+    allowEventLoopUpdates();
+    await setup.waitForVisualIdle();
+    // the overlay bar hides at rest; a scroll reveals the thumb
+    const scroller = findById(setup.renderer.root, "diff-scroll");
+
+    if (!(scroller instanceof ScrollBoxRenderable))
+      throw new Error("diff-scroll is not a scrollbox");
+    const countThumbRows = (): number =>
+      setup.captureSpans().lines.filter((line) => {
+        let column = 0;
+
+        for (const span of line.spans) {
+          column += span.text.length;
+          if (column >= width) return span.bg !== undefined && hex(span.bg) === DARK.textDim;
+        }
+
+        return false;
+      }).length;
+
+    // the overlay bar reveals on a scroll and hides after an idle delay; alternate the offset to
+    // re-trigger the reveal until the thumb is captured, so a slow CI settle never races the hide
+    let thumbRows = 0;
+
+    for (let attempt = 0; attempt < 20 && thumbRows === 0; attempt++) {
+      scroller.scrollTo(attempt % 2 === 0 ? 4 : 5);
+      await setup.waitForVisualIdle();
+      thumbRows = countThumbRows();
+    }
+    const frame = setup.captureCharFrame().split("\n");
+
+    // Assert - the thumb occupies the last column at the top (scroll offset 0), and the dot sits
+    // to its left in the rail, so the order reads content, dots, scrollbar
+    expect(thumbRows).toBe(4);
+    const dotLine = frame.find((line) => line.includes("○"));
+
+    expect(dotLine).toBeDefined();
+    expect(dotLine!.indexOf("○")).toBeLessThan(width - 1);
+    // let the async highlight settle before the renderer goes away
+    await new Promise((resolve) => setTimeout(resolve, 100));
+    setup.renderer.destroy();
+  });
+});