@cueloop/client 0.1.0-alpha.69 → 0.1.0-alpha.70

package/src/App.tsx

@@ -21,6 +21,8 @@ import {
   type DiffViewMode,
   type QuickAction,
 } from "./config";
+import { loadSkills, SlashSkillsContext } from "./skills";
+import type { SlashItem } from "./slash-palette";
 import {
   composeTheme,
   DEFAULT_THEME_NAME,
@@ -29,7 +31,7 @@ import {
   type ThemeName,
 } from "./theme-presets";
 import type { Theme } from "./theme";
-import { createReviewController, type ShareTransport } from "./session-controller";
+import { createReviewController, type ShareTransport } from "./thread-controller";
 import type { SessionClient } from "@cueloop/daemon/client";
 import { createIntentDispatch, type Mode, type RailTab } from "./intent-dispatch";
 import { reduceKey, type KeyState } from "./keymap";
@@ -64,7 +66,7 @@ import {
 } from "./components/DiffContentView";
 import { commentCountsByFile, fileTargetMarks, marksByRows, type DiffRow } from "./view-diff";
 import { annotationTarget, type Anchor } from "@cueloop/schema";
-import type { DiffFileContents, ReviewSession } from "@cueloop/schema";
+import type { DiffFileContents, Thread } from "@cueloop/schema";
 import { PrototypePixels } from "./prototype-pixels";
 import type { PrototypeElement } from "./prototype-browser";
 import {
@@ -355,8 +357,8 @@ function ProjectPanelBody(props: {
 /** The render tree has left the connecting screen: an error, a session, or the no-thread shell. */
 function usableScreenReached(
   error: string | null,
-  session: ReviewSession | null,
-  inbox: ReviewSession[] | null,
+  session: Thread | null,
+  inbox: Thread[] | null,
 ): boolean {
   return Boolean(error) || session !== null || inbox !== null;
 }
@@ -487,6 +489,7 @@ export function App({
   const [themeOverrides, setThemeOverrides] = useState<Partial<Theme>>({});
   const [authorNames, setAuthorNames] = useState<Record<string, string>>({});
   const [quickActions, setQuickActions] = useState<QuickAction[]>(DEFAULT_QUICK_ACTIONS);
+  const [skills, setSkills] = useState<SlashItem[]>([]);
   // opt-in: render a prototype as a kitty pixel mockup instead of the markdown doc
   const [prototypePixels, setPrototypePixels] = useState(false);
 
@@ -501,6 +504,7 @@ export function App({
     setThemeOverrides(config.themeOverrides);
     setAuthorNames(config.authors);
     setQuickActions(config.actions);
+    setSkills(loadSkills(config.skillsPath));
     setAutoClose(config.ui.autoClose);
     setDiffView(config.ui.diffView);
     setPinnedIds(new Set(config.ui.pins));
@@ -787,23 +791,25 @@ export function App({
   if (error) return <ErrorScreen error={error} theme={theme} />;
   if (!session)
     return inbox ? (
-      <NoThreadShell
-        rows={grouped.rows}
-        inboxCursor={inboxCursor}
-        mode={mode}
-        theme={theme}
-        controller={controller}
-        setMode={setMode}
-        menuChrome={menuChrome}
-        onOpenMenu={() => setMenuDialog("settings")}
-        sidebarOpen={sidebarOpen}
-        onToggleSidebar={() => setSidebarOpen((open) => !open)}
-        pinnedIds={pinnedIds}
-        onPin={togglePin}
-        onRename={(id, title) => setMode({ type: "renameThread", sessionId: id, text: title })}
-        quickActions={quickActions}
-        onWelcomeComposingChange={setWelcomeComposing}
-      />
+      <SlashSkillsContext.Provider value={skills}>
+        <NoThreadShell
+          rows={grouped.rows}
+          inboxCursor={inboxCursor}
+          mode={mode}
+          theme={theme}
+          controller={controller}
+          setMode={setMode}
+          menuChrome={menuChrome}
+          onOpenMenu={() => setMenuDialog("settings")}
+          sidebarOpen={sidebarOpen}
+          onToggleSidebar={() => setSidebarOpen((open) => !open)}
+          pinnedIds={pinnedIds}
+          onPin={togglePin}
+          onRename={(id, title) => setMode({ type: "renameThread", sessionId: id, text: title })}
+          quickActions={quickActions}
+          onWelcomeComposingChange={setWelcomeComposing}
+        />
+      </SlashSkillsContext.Provider>
     ) : (
       <ConnectingScreen theme={theme} />
     );
@@ -873,221 +879,227 @@ export function App({
   };
 
   return (
-    <ThemeProvider theme={theme}>
-      <AppShell
-        sidebarOpen={sidebarOpen}
-        onToggleSidebar={() => setSidebarOpen((open) => !open)}
-        onOpenMenu={() => setMenuDialog("settings")}
-        threadsPanel={
-          <scrollbox style={{ flexGrow: 1 }} focused={false}>
-            <ThreadTree
-              rows={grouped.rows}
-              cursor={inboxCursor}
-              activeId={activeSession.id}
-              pinnedIds={pinnedIds}
-              width={30}
-              onSelect={(id) => controller.open(id)}
-              onPin={togglePin}
-              onRename={(id, title) =>
-                setMode({ type: "renameThread", sessionId: id, text: title })
-              }
-              theme={theme}
-            />
-          </scrollbox>
-        }
-        threadTitle={threadTitle(activeSession)}
-        threadActions={
-          showOwnerActions ? (
-            <Toolbar>
-              <Button onPress={onEditRequest} theme={theme}>
-                {" edit "}
-              </Button>
-              <Button onPress={onShareRequest} theme={theme}>
-                {" share "}
-              </Button>
-            </Toolbar>
-          ) : undefined
-        }
-        threadPanel={
-          <box style={{ flexGrow: 1, flexDirection: "column" }}>
-            <box style={{ flexGrow: 1, flexDirection: "row" }}>
-              {isPixelPrototype ? (
-                <PrototypePixels
-                  prototypePath={prototypePath}
-                  canComment={prototypeCanComment}
-                  onCommentElement={onCommentPrototype}
-                  onComposingChange={setPrototypeComposing}
-                  hidden={chromeHidden}
-                />
-              ) : isDiff ? (
-                <box style={{ flexGrow: 1, paddingLeft: 2, paddingTop: 1 }}>
-                  <text fg={theme.textDim}>review the changes on the right</text>
-                </box>
-              ) : (
-                <ThreadView
-                  session={activeSession}
-                  suspended={threadViewSuspended}
-                  editOrphanCount={editOrphanCount}
-                  onComposingChange={setThreadComposing}
-                  resolved={resolved}
-                  onObserverBlocked={(reason) =>
-                    controller.setStatus(
-                      reason === "observer"
-                        ? "observer - read-only"
-                        : "review submitted - read-only",
-                    )
-                  }
-                  onCursorChange={setCursor}
-                  focusedAnnotationId={focusedAnnotationId}
-                  onFocusAnnotation={setFocusedAnnotationId}
-                  display={display}
-                  marks={marks}
-                  quickActions={quickActions}
-                  observer={observer}
-                  onAnnotate={(span, body) =>
-                    void controller.annotate(
-                      "comment",
-                      span.start.blockIndex,
-                      span.start.char,
-                      span.end.char,
+    <SlashSkillsContext.Provider value={skills}>
+      <ThemeProvider theme={theme}>
+        <AppShell
+          sidebarOpen={sidebarOpen}
+          onToggleSidebar={() => setSidebarOpen((open) => !open)}
+          onOpenMenu={() => setMenuDialog("settings")}
+          threadsPanel={
+            <scrollbox style={{ flexGrow: 1 }} focused={false}>
+              <ThreadTree
+                rows={grouped.rows}
+                cursor={inboxCursor}
+                activeId={activeSession.id}
+                pinnedIds={pinnedIds}
+                width={30}
+                onSelect={(id) => controller.open(id)}
+                onPin={togglePin}
+                onRename={(id, title) =>
+                  setMode({ type: "renameThread", sessionId: id, text: title })
+                }
+                theme={theme}
+              />
+            </scrollbox>
+          }
+          threadTitle={threadTitle(activeSession)}
+          threadActions={
+            showOwnerActions ? (
+              <Toolbar>
+                <Button onPress={onEditRequest} theme={theme}>
+                  {" edit "}
+                </Button>
+                <Button onPress={onShareRequest} theme={theme}>
+                  {" share "}
+                </Button>
+              </Toolbar>
+            ) : undefined
+          }
+          threadPanel={
+            <box style={{ flexGrow: 1, flexDirection: "column" }}>
+              <box style={{ flexGrow: 1, flexDirection: "row" }}>
+                {isPixelPrototype ? (
+                  <PrototypePixels
+                    prototypePath={prototypePath}
+                    canComment={prototypeCanComment}
+                    onCommentElement={onCommentPrototype}
+                    onComposingChange={setPrototypeComposing}
+                    hidden={chromeHidden}
+                  />
+                ) : isDiff ? (
+                  <box style={{ flexGrow: 1, paddingLeft: 2, paddingTop: 1 }}>
+                    <text fg={theme.textDim}>review the changes on the right</text>
+                  </box>
+                ) : (
+                  <ThreadView
+                    session={activeSession}
+                    suspended={threadViewSuspended}
+                    editOrphanCount={editOrphanCount}
+                    onComposingChange={setThreadComposing}
+                    resolved={resolved}
+                    onObserverBlocked={(reason) =>
+                      controller.setStatus(
+                        reason === "observer"
+                          ? "observer - read-only"
+                          : "review submitted - read-only",
+                      )
+                    }
+                    onCursorChange={setCursor}
+                    focusedAnnotationId={focusedAnnotationId}
+                    onFocusAnnotation={setFocusedAnnotationId}
+                    display={display}
+                    marks={marks}
+                    quickActions={quickActions}
+                    observer={observer}
+                    onAnnotate={(span, body) =>
+                      void controller.annotate(
+                        "comment",
+                        span.start.blockIndex,
+                        span.start.char,
+                        span.end.char,
+                        body,
+                        span.end.blockIndex,
+                      )
+                    }
+                    onReply={(rootAnnotationId, body) =>
+                      void controller.reply(rootAnnotationId, body)
+                    }
+                    onUpdateAnnotation={(id, body) => controller.updateAnnotation(id, body)}
+                    onExit={() => onExit?.(0)}
+                  />
+                )}
+              </box>
+              <ThreadFooter
+                repo={projectName(activeSession.workspace)}
+                branch={activeSession.workspace.branch}
+                onSubmit={onSubmitRequest}
+                canSubmit={canSubmitReview(isOwner, resolved, observer)}
+                theme={theme}
+              />
+            </box>
+          }
+          changesOpen={workbench.changesOpen}
+          projectOpen={workbench.projectOpen}
+          onToggleChanges={workbench.toggleChanges}
+          onToggleProject={workbench.toggleProject}
+          onToggleRight={workbench.toggleRight}
+          projectMode={workbench.projectMode}
+          zoomHideThread={workbench.zoomed}
+          changesPanel={
+            <EditorGrid
+              tree={workbench.grid}
+              focusedGroupId={workbench.activeGroup}
+              commentCounts={diffCommentCounts}
+              onFocusGroup={workbench.focusGroup}
+              onActivateTab={workbench.activate}
+              onCloseTab={workbench.close}
+              onSplit={workbench.split}
+              onZoom={workbench.toggleZoom}
+              zoomed={workbench.zoomed}
+              renderTab={(tab, groupFocused) => (
+                <GridTabContent
+                  tab={tab}
+                  rows={rows}
+                  surface={{
+                    session: activeSession,
+                    quickActions,
+                    observer,
+                    commentsEnabled: true,
+                    resolved,
+                    suspended: threadViewSuspended || !groupFocused,
+                    onComposingChange: setThreadComposing,
+                    onObserverBlocked: (reason) =>
+                      controller.setStatus(
+                        reason === "observer"
+                          ? "observer - read-only"
+                          : "review submitted - read-only",
+                      ),
+                    onCursorChange: setCursor,
+                    focusedAnnotationId,
+                    onFocusAnnotation: setFocusedAnnotationId,
+                    // a diff thread's Changes view is the artifact itself; any other thread's is the
+                    // live working-tree diff, so its notes carry a file target and anchor there
+                    onAnnotate: (span, body) =>
+                      void controller.annotate(
+                        "comment",
+                        span.start.blockIndex,
+                        span.start.char,
+                        span.end.char,
+                        body,
+                        span.end.blockIndex,
+                        isDiff ? { kind: "artifact" } : { kind: "file", path: "", rev: "worktree" },
+                      ),
+                    onReply: (rootAnnotationId, body) =>
+                      void controller.reply(rootAnnotationId, body),
+                    onUpdateAnnotation: (id, body) => controller.updateAnnotation(id, body),
+                    onExit: () => onExit?.(0),
+                  }}
+                  rejectedRows={rejectedRows}
+                  fold={diffFold}
+                  fileStats={controller.fileStats()}
+                  split={diffView === "split" && workbench.zoomed}
+                  dimmed={walking}
+                  readFile={(path) => controller.repoReadFile(path)}
+                  onAddFileComment={(path, anchor, body) =>
+                    void controller.addComment(
+                      anchor,
+                      { kind: "file", path, rev: "worktree" },
                       body,
-                      span.end.blockIndex,
                     )
                   }
-                  onReply={(rootAnnotationId, body) =>
-                    void controller.reply(rootAnnotationId, body)
-                  }
-                  onUpdateAnnotation={(id, body) => controller.updateAnnotation(id, body)}
-                  onExit={() => onExit?.(0)}
+                  theme={theme}
                 />
               )}
-            </box>
-            <ThreadFooter
-              repo={projectName(activeSession.workspace)}
-              branch={activeSession.workspace.branch}
-              onSubmit={onSubmitRequest}
-              canSubmit={canSubmitReview(isOwner, resolved, observer)}
               theme={theme}
             />
-          </box>
-        }
-        changesOpen={workbench.changesOpen}
-        projectOpen={workbench.projectOpen}
-        onToggleChanges={workbench.toggleChanges}
-        onToggleProject={workbench.toggleProject}
-        onToggleRight={workbench.toggleRight}
-        projectMode={workbench.projectMode}
-        zoomHideThread={workbench.zoomed}
-        changesPanel={
-          <EditorGrid
-            tree={workbench.grid}
-            focusedGroupId={workbench.activeGroup}
-            commentCounts={diffCommentCounts}
-            onFocusGroup={workbench.focusGroup}
-            onActivateTab={workbench.activate}
-            onCloseTab={workbench.close}
-            onSplit={workbench.split}
-            onZoom={workbench.toggleZoom}
-            zoomed={workbench.zoomed}
-            renderTab={(tab, groupFocused) => (
-              <GridTabContent
-                tab={tab}
-                rows={rows}
-                surface={{
-                  session: activeSession,
-                  quickActions,
-                  observer,
-                  commentsEnabled: true,
-                  resolved,
-                  suspended: threadViewSuspended || !groupFocused,
-                  onComposingChange: setThreadComposing,
-                  onObserverBlocked: (reason) =>
-                    controller.setStatus(
-                      reason === "observer"
-                        ? "observer - read-only"
-                        : "review submitted - read-only",
-                    ),
-                  onCursorChange: setCursor,
-                  focusedAnnotationId,
-                  onFocusAnnotation: setFocusedAnnotationId,
-                  // a diff thread's Changes view is the artifact itself; any other thread's is the
-                  // live working-tree diff, so its notes carry a file target and anchor there
-                  onAnnotate: (span, body) =>
-                    void controller.annotate(
-                      "comment",
-                      span.start.blockIndex,
-                      span.start.char,
-                      span.end.char,
-                      body,
-                      span.end.blockIndex,
-                      isDiff ? { kind: "artifact" } : { kind: "file", path: "", rev: "worktree" },
-                    ),
-                  onReply: (rootAnnotationId, body) =>
-                    void controller.reply(rootAnnotationId, body),
-                  onUpdateAnnotation: (id, body) => controller.updateAnnotation(id, body),
-                  onExit: () => onExit?.(0),
-                }}
-                rejectedRows={rejectedRows}
-                fold={diffFold}
-                fileStats={controller.fileStats()}
-                split={diffView === "split" && workbench.zoomed}
-                dimmed={walking}
-                readFile={(path) => controller.repoReadFile(path)}
-                onAddFileComment={(path, anchor, body) =>
-                  void controller.addComment(anchor, { kind: "file", path, rev: "worktree" }, body)
-                }
-                theme={theme}
-              />
-            )}
-            theme={theme}
-          />
-        }
-        projectPanel={
-          <ProjectPanelBody
-            mode={workbench.projectMode}
-            loadChanges={() => controller.repoChanges()}
-            loadProjectFiles={() => controller.repoFiles()}
-            reloadKey={activeSession.id}
-            // the Changes navigator always opens a changed file as a diff - a diff review shows its
-            // captured snapshot, every other thread the live working-tree diff
-            onOpenChangedFile={(path) => workbench.openFile(path, "diff")}
-            onOpenProjectFile={(path) => workbench.openFile(path, "contents")}
-            commentCounts={diffCommentCounts}
+          }
+          projectPanel={
+            <ProjectPanelBody
+              mode={workbench.projectMode}
+              loadChanges={() => controller.repoChanges()}
+              loadProjectFiles={() => controller.repoFiles()}
+              reloadKey={activeSession.id}
+              // the Changes navigator always opens a changed file as a diff - a diff review shows its
+              // captured snapshot, every other thread the live working-tree diff
+              onOpenChangedFile={(path) => workbench.openFile(path, "diff")}
+              onOpenProjectFile={(path) => workbench.openFile(path, "contents")}
+              commentCounts={diffCommentCounts}
+              theme={theme}
+            />
+          }
+          theme={theme}
+        >
+          <TrailingOverlays
+            walking={walking}
+            walk={walk}
+            walkFileList={walkFileList}
+            viewedPaths={viewedPaths}
+            session={activeSession}
+            terminalWidth={terminalWidth}
             theme={theme}
+            mode={mode}
+            toast={toast}
+            setMode={setMode}
+            dispatch={dispatch}
           />
-        }
-        theme={theme}
-      >
-        <TrailingOverlays
-          walking={walking}
-          walk={walk}
-          walkFileList={walkFileList}
-          viewedPaths={viewedPaths}
-          session={activeSession}
-          terminalWidth={terminalWidth}
-          theme={theme}
-          mode={mode}
-          toast={toast}
-          setMode={setMode}
-          dispatch={dispatch}
-        />
-        {submitConfirmState !== null ? (
-          <box
-            style={{
-              position: "absolute",
-              left: 0,
-              top: 0,
-              width: "100%",
-              height: "100%",
-              justifyContent: "center",
-              alignItems: "center",
-            }}
-          >
-            <ConfirmCard {...submitConfirmState} theme={theme} />
-          </box>
-        ) : null}
-        {menuChrome}
-      </AppShell>
-    </ThemeProvider>
+          {submitConfirmState !== null ? (
+            <box
+              style={{
+                position: "absolute",
+                left: 0,
+                top: 0,
+                width: "100%",
+                height: "100%",
+                justifyContent: "center",
+                alignItems: "center",
+              }}
+            >
+              <ConfirmCard {...submitConfirmState} theme={theme} />
+            </box>
+          ) : null}
+          {menuChrome}
+        </AppShell>
+      </ThemeProvider>
+    </SlashSkillsContext.Provider>
   );
 }

package/src/App.walk.test.tsx

@@ -6,7 +6,7 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 import React from "react";
 import { DaemonServer } from "@cueloop/daemon";
-import type { ReviewSession } from "@cueloop/schema";
+import type { Thread } from "@cueloop/schema";
 import { App } from "./App";
 import { DARK } from "./theme";
 import {
@@ -47,7 +47,7 @@ index 555..666 100644
 let home: string;
 let restoreUserConfig: () => void;
 let server: DaemonServer;
-let session: ReviewSession;
+let session: Thread;
 
 beforeEach(() => {
   home = mkdtempSync(join(tmpdir(), "cueloop-walk-"));

package/src/App.workbench.test.tsx

@@ -13,7 +13,7 @@ import { join } from "node:path";
 import React from "react";
 import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
-import type { ReviewSession } from "@cueloop/schema";
+import type { Thread } from "@cueloop/schema";
 import { App } from "./App";
 import {
   dragText,
@@ -42,7 +42,7 @@ let home: string;
 let repo: string;
 let restoreUserConfig: () => void;
 let server: DaemonServer;
-let session: ReviewSession;
+let session: Thread;
 
 /** A throwaway git repo so the Project tree (git ls-files) and file contents resolve without a real checkout. */
 function makeRepo(): string {

package/src/app-key-state.ts

@@ -1,4 +1,4 @@
-import type { ReviewSession } from "@cueloop/schema";
+import type { Thread } from "@cueloop/schema";
 import type { Mode } from "./intent-dispatch";
 import type { KeyState } from "./keymap";
 import type { DisplayBlock } from "./view-plan";
@@ -10,11 +10,11 @@ export function buildKeyState(params: {
   observer: boolean;
   isOwner: boolean;
   overlay: KeyState["overlay"];
-  session: ReviewSession | null;
+  session: Thread | null;
   isDiff: boolean;
   mode: Mode;
   resolved: boolean;
-  inbox: ReviewSession[] | null;
+  inbox: Thread[] | null;
   focusedAnnotationId: string | undefined;
   walk: { index: number } | null;
   walkFileList: WalkFile[];

package/src/app-screens.tsx

@@ -1,12 +1,12 @@
 import { ScrollArea } from "./components/ScrollArea";
 import React, { useEffect, useState, type Dispatch, type SetStateAction } from "react";
-import type { DiffFileContents, ReviewSession, VerdictKind } from "@cueloop/schema";
+import type { DiffFileContents, Thread, VerdictKind } from "@cueloop/schema";
 import { returnPaneFor } from "@cueloop/schema";
 import type { Theme } from "./theme";
 import type { QuickAction } from "./config";
 import type { Mode, TreeAsk } from "./intent-dispatch";
 import type { Intent } from "./keymap";
-import type { ReviewController, ToastState } from "./session-controller";
+import type { ReviewController, ToastState } from "./thread-controller";
 import { noteForFile } from "./walk";
 import type { WalkFile } from "./walk";
 import type { CheatsheetSection } from "./key-bindings";
@@ -297,7 +297,7 @@ export function NoThreadShell(props: {
 
 export function CompletionScreen(props: {
   theme: Theme;
-  session: ReviewSession;
+  session: Thread;
   verdict: VerdictKind;
   completion: { phase: "prompt" } | { phase: "counting"; remaining: number };
   status: string;
@@ -340,7 +340,7 @@ export function TrailingOverlays(props: {
   walk: { index: number } | null;
   walkFileList: WalkFile[];
   viewedPaths: Set<string>;
-  session: ReviewSession;
+  session: Thread;
   terminalWidth: number;
   theme: Theme;
   mode: Mode;