@cueloop/client 0.1.0-alpha.66 → 0.1.0-alpha.67

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.66",
+  "version": "0.1.0-alpha.67",
   "description": "The cueloop review UI: projection renderer, keyboard grammar, review rail",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -26,15 +26,16 @@
     "access": "public"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.66",
-    "@cueloop/extension-api": "0.1.0-alpha.66",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.66",
-    "@cueloop/schema": "0.1.0-alpha.66",
+    "@cueloop/daemon": "0.1.0-alpha.67",
+    "@cueloop/extension-api": "0.1.0-alpha.67",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.67",
+    "@cueloop/schema": "0.1.0-alpha.67",
     "@opentui/core": "^0.5.8",
     "@opentui/keymap": "0.5.8",
     "@opentui/react": "^0.5.8",
     "@opentui/ssh": "0.5.8",
     "@pierre/diffs": "^1.3.6",
+    "@tanstack/virtual-core": "^3.17.9",
     "diff": "^9",
     "puppeteer-core": "^25.8.0",
     "react": "^19.2.0",

package/src/App.autoclose.test.tsx

@@ -118,8 +118,8 @@ describe("completion overlay", () => {
     // window before it is delivered - the frame wait absorbs it
     await press(setup, "escape");
 
-    // Assert
-    const frame = await waitForText(setup, "resolved: approve");
+    // Assert - the countdown is cancelled and we are back in the (resolved) thread view
+    const frame = await waitForText(setup, "Ship the thing");
 
     expect(frame).not.toContain("closing in");
   });

package/src/App.diff.test.tsx

@@ -1,4 +1,4 @@
-/** Diff-review flow in the virtual terminal (slice 3). */
+/** Diff-review flow in the virtual terminal: the diff sheet annotates like the thread view. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
@@ -9,7 +9,17 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import type { ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
-import { isolateUserConfig, press, waitForText } from "./test-support";
+import { NERD } from "./components/primitives/icons";
+import {
+  clickText,
+  dragText,
+  isolateUserConfig,
+  press,
+  pressKey,
+  typeText,
+  waitForState,
+  waitForText,
+} from "./test-support";
 
 const PATCH = `diff --git a/src/store.ts b/src/store.ts
 index 111..222 100644
@@ -43,13 +53,13 @@ afterEach(() => {
   rmSync(home, { recursive: true, force: true });
 });
 
-async function renderApp() {
-  const setup = await testRender(<App home={home} sessionId={session.id} />, {
+async function renderApp(sessionId = session.id) {
+  const setup = await testRender(<App home={home} sessionId={sessionId} />, {
     width: 120,
     height: 30,
   });
 
-  await waitForText(setup, "cueloop");
+  await waitForText(setup, "new Map()");
 
   return setup;
 }
@@ -62,46 +72,74 @@ describe("diff review", () => {
     // Assert
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("■ src/store.ts");
+    expect(frame).toContain("src/store.ts");
     expect(frame).toContain("@@ -1,4 +1,4 @@");
-    expect(frame).toContain("-  private items = [];");
-    expect(frame).toContain("+  private items = new Map();");
+    expect(frame).toMatch(/- {2,}private items = \[\];/);
+    expect(frame).toMatch(/\+ {2,}private items = new Map\(\);/);
   });
 
-  test("line comment: quote-anchored, lands in feedback with the code line", async () => {
+  test("a drag marks the code, typing comments on it, and the comment lands in feedback", async () => {
     // Arrange
     const setup = await renderApp();
 
-    // Act
-    // rows: file(0), hunk(1), ctx(2), del(3), add(4)
-    for (let i = 0; i < 4; i++) await press(setup, "j");
-    await press(setup, "c");
+    // Act - mark "new Map()" on the added line and just start typing, as in the thread view
+    await dragText(setup, "new Map()", "new Map()", "new Map()".length);
+    await typeText(setup, "Map needs an eviction story.");
+    await waitForText(setup, "● Map needs an eviction story.");
+    await pressKey(setup, "RETURN", { meta: true });
 
-    // Assert
-    await waitForText(setup, 'comment on "');
+    // Assert - the discussion card hangs under the line; the anchor is the marked words
+    await waitForState(setup, () => server.core.sessionGet(session.id).annotations.length === 1);
+    await waitForText(setup, "● Map needs an eviction story.");
+    expect(server.core.sessionGet(session.id).annotations[0]!.anchor.quote).toBe("new Map()");
 
-    // Act
-    await setup.mockInput.typeText("Map needs an eviction story.");
+    // Act - submit with the session chord (cmd+enter, no composer open), confirm request_changes
+    await pressKey(setup, "RETURN", { meta: true });
     await press(setup, "enter");
 
     // Assert
-    // inline annotation card rendered under the line
-    await waitForText(setup, "◆ Map needs an eviction story.");
-    const stored = server.core.sessionGet(session.id);
+    await waitForText(setup, "feedback sent");
+    const resolved = server.core.sessionGet(session.id);
 
-    expect(stored.annotations.length).toBe(1);
-    expect(stored.annotations[0]!.anchor.quote).toContain("new Map()");
+    expect(resolved.verdict!.feedback).toContain("new Map()");
+    expect(resolved.verdict!.feedback).toContain("Map needs an eviction story.");
+  });
+
+  test("a comment reopens with its mark painted on the code", async () => {
+    // Arrange - a stored comment anchored to the added line's words
+    server.core.sessionAnnotate(session.id, {
+      id: "a_existing",
+      kind: "comment",
+      anchor: { quote: "new Map()", prefix: "  private items = ", suffix: ";" },
+      body: "Existing note.",
+    });
 
     // Act
-    await press(setup, "enter"); // submit
-    await press(setup, "enter"); // confirm request_changes
+    const setup = await renderApp();
 
     // Assert
-    await waitForText(setup, "feedback sent");
-    const resolved = server.core.sessionGet(session.id);
+    await waitForText(setup, "● Existing note.");
+  });
 
-    expect(resolved.verdict!.feedback).toContain("new Map()");
-    expect(resolved.verdict!.feedback).toContain("Map needs an eviction story.");
+  test("option+c folds the caret's file to its band; the chevron restores its body", async () => {
+    // Arrange - the caret opens on the file's first code line
+    const setup = await renderApp();
+
+    // Act
+    await pressKey(setup, "c", { meta: true });
+
+    // Assert - the body is gone but the band (with its counts) remains
+    await waitForState(setup, () => !setup.captureCharFrame().includes("new Map()"));
+    const collapsed = setup.captureCharFrame();
+
+    expect(collapsed).toContain("src/store.ts");
+    expect(collapsed).toContain("+1");
+
+    // Act - the band's chevron unfolds it again
+    await clickText(setup, NERD.chevronRight);
+
+    // Assert
+    await waitForText(setup, "new Map()");
   });
 
   test("curation needs full file contents; a legacy diff answers", async () => {
@@ -109,7 +147,7 @@ describe("diff review", () => {
     const setup = await renderApp();
 
     // Act
-    await press(setup, "x");
+    await pressKey(setup, "x", { meta: true });
 
     // Assert
     await waitForText(setup, "hunk curation needs full file contents");
@@ -133,17 +171,11 @@ describe("diff review", () => {
         ],
       },
     });
-    const setup = await testRender(<App home={home} sessionId={withFiles.id} />, {
-      width: 120,
-      height: 30,
-    });
-
-    await waitForText(setup, "cueloop");
+    const setup = await renderApp(withFiles.id);
 
-    // Act - move to the added line and reject its change
-    // rows: file(0), hunk(1), ctx(2), del(3), add(4)
-    for (let i = 0; i < 4; i++) await press(setup, "j");
-    await press(setup, "x");
+    // Act - place the caret on the added line and reject its change
+    await clickText(setup, "new Map()");
+    await pressKey(setup, "x", { meta: true });
 
     // Assert - the single change is gone, so the curated working copy is empty
     await waitForText(setup, "change rejected");

package/src/App.plan-review.test.tsx

@@ -99,14 +99,13 @@ describe("share button", () => {
     const setup = await renderApp();
 
     // Assert
-    // both word-buttons ride the same header row, so Share sits next to Edit
+    // both word-buttons ride the header's thread segment, so share sits next to edit
     const headerLine = setup
       .captureCharFrame()
       .split("\n")
-      .find((line) => line.includes("submitted by"));
+      .find((line) => line.includes("edit"));
 
-    expect(headerLine).toContain("Edit");
-    expect(headerLine).toContain("Share");
+    expect(headerLine).toContain("share");
   });
 
   test("a read-only viewer (a plan shared over ssh) never sees the Share button", async () => {
@@ -119,7 +118,7 @@ describe("share button", () => {
     await waitForText(viewer, "cueloop");
 
     // Assert
-    expect(viewer.captureCharFrame()).not.toContain("Share");
+    expect(viewer.captureCharFrame()).not.toContain(" share ");
   });
 
   test("a resolved plan hides Edit and Share (no re-sharing a finished review)", async () => {
@@ -129,16 +128,13 @@ describe("share button", () => {
     // Act
     const setup = await renderApp();
 
-    await waitForText(setup, "submitted by");
+    await waitForText(setup, "Migration Plan");
 
     // Assert - the owner toolbar is gone once the review is resolved
-    const headerLine = setup
-      .captureCharFrame()
-      .split("\n")
-      .find((line) => line.includes("submitted by"));
+    const frame = setup.captureCharFrame();
 
-    expect(headerLine).not.toContain("Edit");
-    expect(headerLine).not.toContain("Share");
+    expect(frame).not.toContain(" edit ");
+    expect(frame).not.toContain(" share ");
   });
 });
 
@@ -148,7 +144,7 @@ describe("edit affordance", () => {
     const owner = await renderApp();
 
     // Assert
-    expect(owner.captureCharFrame()).toContain("Edit");
+    expect(owner.captureCharFrame()).toContain(" edit ");
   });
 
   test("a read-only viewer (a plan shared over ssh) never sees the Edit button", async () => {
@@ -161,7 +157,7 @@ describe("edit affordance", () => {
     await waitForText(viewer, "cueloop");
 
     // Assert
-    expect(viewer.captureCharFrame()).not.toContain("Edit");
+    expect(viewer.captureCharFrame()).not.toContain(" edit ");
   });
 });
 
@@ -274,17 +270,19 @@ describe("compose newline convention", () => {
 });
 
 describe("sheet header", () => {
-  test("shows the submitting agent, the revision, and the Edit and Share word-buttons", async () => {
+  test("mirrors the thread name and carries the Edit and Share word-buttons", async () => {
     // Arrange
     const setup = await renderApp();
 
-    // Assert
+    // Assert - the minimal header shows the thread title (mirror) plus the owner
+    // actions; the revision and submitter metadata are no longer in the header
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("submitted by agent/worker-3");
-    expect(frame).toContain("rev 1");
-    expect(frame).toContain("Edit");
-    expect(frame).toContain("Share");
+    expect(frame).toContain("Migration Plan");
+    expect(frame).not.toContain("submitted by");
+    expect(frame).not.toContain("rev 1");
+    expect(frame).toContain(" edit ");
+    expect(frame).toContain(" share ");
   });
 });
 
@@ -294,7 +292,8 @@ describe("quick-actions settings editor", () => {
     const setup = await renderApp();
 
     // Act - open Settings from the top-left gear, enter Actions, expand the first action, type
-    await setup.mockMouse.click(1, 1);
+    await setup.mockMouse.click(1, 0);
+    await waitForText(setup, "Keybinds");
     await clickText(setup, "Settings");
     await clickText(setup, "Actions");
     await clickText(setup, "Zoom out, research in depth");

package/src/App.readonly.test.tsx

@@ -81,12 +81,16 @@ function snapshot() {
 }
 
 describe("observer rendering", () => {
-  test("shows the observer badge in the header", async () => {
+  test("the minimal header mirrors the thread name, with no observer badge", async () => {
     // Arrange
     const setup = await renderObserver();
 
-    // Assert
-    expect(setup.captureCharFrame()).toContain("· observer");
+    // Assert - the header shows the thread title only; read-only is enforced by
+    // the blocked primitives below, not a header badge
+    const frame = setup.captureCharFrame();
+
+    expect(frame).toContain("Migration Plan");
+    expect(frame).not.toContain("· observer");
   });
 });
 

package/src/App.test.tsx

@@ -14,6 +14,7 @@ import {
   dragText,
   frameRow,
   isolateUserConfig,
+  locateText,
   press,
   pressKey,
   typeText as type,
@@ -94,7 +95,7 @@ describe("plan rendering", () => {
     const setup = await renderApp();
 
     // Act - open the collapsed Threads sidebar (the mirrored panel toggle by the gear)
-    await setup.mockMouse.click(3, 1);
+    await setup.mockMouse.click(4, 0);
 
     // Assert - the sidebar lists the other pending review, so you can jump to it
     await waitForText(setup, "Other Plan");
@@ -243,19 +244,19 @@ describe("submit", () => {
   });
 });
 
-describe("inbox", () => {
-  test("inbox mode wears the review header and opens a session", async () => {
+describe("no-thread shell", () => {
+  test("opening with nothing selected lands in the shell with a Welcome tab and the Threads sidebar", async () => {
     // Arrange
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
 
     await waitForText(setup, "cueloop");
 
-    // Assert - the same header as review, plus the session row
+    // Assert - the same shell header, the disposable Welcome tab, and the pending thread
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("cueloop · resume");
+    expect(frame).toContain("Welcome to cueloop");
     expect(frame).toContain("Migration Plan");
-    expect(frame).not.toContain("inbox ("); // the old inline header is gone
+    expect(frame).not.toContain("· resume"); // the bespoke inbox header is retired
 
     // Act
     await press(setup, "enter");
@@ -264,20 +265,78 @@ describe("inbox", () => {
     await waitForText(setup, "send message");
   });
 
-  test("the menu opens from the inbox and escape is not a trap", async () => {
+  test("picking a thread from the no-thread shell keeps the Threads sidebar open", async () => {
+    // Arrange - a second pending thread so the sidebar has a row that never shows
+    // in the opened thread's own view
+    server.core.sessionCreate({
+      workspace: { repoRoot: "/repo", branch: "main" },
+      artifact: { type: "plan", content: "# Other Plan\n", meta: { title: "Other Plan" } },
+    });
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+
+    await waitForText(setup, "Welcome to cueloop");
+    await waitForText(setup, "Other Plan"); // the sidebar opens by default here
+
+    // Act - open the thread under the cursor
+    await press(setup, "enter");
+    await waitForText(setup, "send message");
+
+    // Assert - the sidebar stayed open across the swap: both titles are on screen,
+    // and the non-opened one can only come from the still-open sidebar
+    const frame = setup.captureCharFrame();
+
+    expect(frame).toContain("Migration Plan");
+    expect(frame).toContain("Other Plan");
+  });
+
+  test("the row kebab menu pins a thread into a Pinned section", async () => {
+    // Arrange
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+
+    await waitForText(setup, "Migration Plan");
+
+    // Act - hover the row to reveal its kebab, open the menu, and pick Pin
+    const row = locateText(setup, "Migration Plan");
+
+    await setup.mockMouse.moveTo(row.column, row.row);
+    await waitForText(setup, "⋮");
+    await clickText(setup, "⋮");
+    await waitForText(setup, "Pin");
+    await clickText(setup, "Pin");
+
+    // Assert - a Pinned section now holds the thread
+    await waitForText(setup, "Pinned");
+    expect(frameRow(setup, "Migration Plan")).toBeGreaterThan(frameRow(setup, "Pinned"));
+  });
+
+  test("a bare launch shows the Welcome surface with the right region collapsed", async () => {
+    // Arrange
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+
+    await waitForText(setup, "Welcome to cueloop");
+
+    // Assert - Welcome fills the thread pane (not a Changes tab); the right region stays collapsed
+    const frame = setup.captureCharFrame();
+
+    expect(frame).toContain("Welcome to cueloop");
+    expect(frame).not.toContain("Changes"); // the Changes editor is closed on a bare launch
+    expect(frame).toContain("Migration Plan"); // the sidebar lists the pending thread
+  });
+
+  test("the menu opens from the shell gear and escape is not a trap", async () => {
     // Arrange
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
 
-    await waitForText(setup, "cueloop · resume");
+    await waitForText(setup, "Welcome to cueloop");
 
-    // Act - open the drop-down from the top-left settings gear (header content row)
-    await setup.mockMouse.click(1, 1);
+    // Act - open the settings dialog from the top-left gear (the Threads panel header, row 0)
+    await setup.mockMouse.click(1, 0);
 
-    // Assert - the drop-up options appear
+    // Assert - the settings dialog with its Keybinds leaf appears
     await waitForText(setup, "Keybinds");
     expect(setup.captureCharFrame()).toContain("Settings");
 
-    // Act - escape closes the menu (not a trap), and the inbox nav still works
+    // Act - escape closes the menu (not a trap), and the thread nav still works
     await press(setup, "escape");
     await waitForState(setup, () => !setup.captureCharFrame().includes("Keybinds"));
     await press(setup, "enter");
@@ -295,7 +354,7 @@ describe("the thread view and the menu", () => {
     await waitForText(setup, "The daemon persists");
 
     // Act - open the menu from the top-left settings gear, then the keybinds dialog
-    await setup.mockMouse.click(1, 1);
+    await setup.mockMouse.click(1, 0);
     await waitForText(setup, "Keybinds");
     const dropUp = setup.captureCharFrame().split("\n");
     const keybindsRow = dropUp.findIndex((line) => line.includes("Keybinds"));
@@ -324,7 +383,7 @@ describe("the thread view and the menu", () => {
     // Arrange - open the settings dialog from the gear
     const setup = await renderApp();
 
-    await setup.mockMouse.click(1, 1);
+    await setup.mockMouse.click(1, 0);
     await waitForText(setup, "Keybinds");
 
     // the nav folder is the last "Settings" on screen (the first is the dialog title)