@cueloop/client 0.1.0-alpha.65 → 0.1.0-alpha.67

package/src/App.readonly.test.tsx

@@ -9,7 +9,6 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import { makeAnchor, parseBlocks, type ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
-import { DARK } from "./theme";
 import {
   clickText,
   dragText,
@@ -17,7 +16,6 @@ import {
   isolateUserConfig,
   pressKey,
   typeText,
-  waitForState,
   waitForText,
 } from "./test-support";
 
@@ -83,15 +81,16 @@ function snapshot() {
 }
 
 describe("observer rendering", () => {
-  test("shows the observer badge and the bottom menu", async () => {
+  test("the minimal header mirrors the thread name, with no observer badge", async () => {
     // Arrange
     const setup = await renderObserver();
 
-    // Assert
+    // Assert - the header shows the thread title only; read-only is enforced by
+    // the blocked primitives below, not a header badge
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("· observer");
-    expect(frame).toContain("menu");
+    expect(frame).toContain("Migration Plan");
+    expect(frame).not.toContain("· observer");
   });
 });
 
@@ -199,29 +198,12 @@ describe("observer navigation still works", () => {
     });
     const setup = await renderObserver();
 
-    // Act
+    // Act - the observer navigates to the annotation without mutating anything
     await pressKey(setup, "n", { meta: true });
     await setup.renderOnce();
 
-    // Assert - focus shows as the card's blue border (transparent fill); a
-    // comment card is the only blue-bordered box in the frame
-    await waitForText(setup, "COMMENT · me");
-    await waitForState(setup, () => hasBorderColor(setup, DARK.blue));
+    // Assert - the observer reads the controller's comment inline in the thread
+    await waitForText(setup, "From the controller.");
+    expect(snapshot().annotations).toBe(1);
   });
 });
-
-/** Whether any border character (box-drawing) is painted in the given foreground hex. */
-function hasBorderColor(setup: Awaited<ReturnType<typeof renderObserver>>, hex: string): boolean {
-  for (const line of setup.captureSpans().lines) {
-    for (const span of line.spans) {
-      if (!/[╭╮╰╯│─┌┐└┘]/.test(span.text)) continue;
-      const [red, green, blue] = span.fg.toInts();
-      const rendered =
-        "#" + [red, green, blue].map((part) => part.toString(16).padStart(2, "0")).join("");
-
-      if (rendered === hex) return true;
-    }
-  }
-
-  return false;
-}

package/src/App.submit-confirm.test.tsx

@@ -1,4 +1,4 @@
-/** The rail submit confirm (tier 2): pressing submit expands the rail's Submit button into a bordered confirm card - counts, verdict selector, summary input, word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
+/** The send-message confirm: cmd+enter opens a centered overlay with a verdict selector, summary input, and word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
@@ -83,29 +83,27 @@ function seedAnnotations(count: number): void {
   }
 }
 
-describe("rail submit confirm", () => {
-  test("submit expands the Submit button into the confirm card", async () => {
+describe("send message confirm", () => {
+  test("cmd+enter opens the send-message confirm overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
-    // Assert
-    expect(setup.captureCharFrame()).toContain("Submit review");
+    // Assert - the footer carries the send control before the overlay opens
+    expect(setup.captureCharFrame()).toContain("send message");
 
     // Act
     await pressKey(setup, "RETURN", { meta: true });
 
-    // Assert
-    await waitForText(setup, "submit review");
+    // Assert - the overlay: verdict selector and word-buttons
+    await waitForText(setup, "[Approve]"); // nothing pending: approve default
     const frame = setup.captureCharFrame();
 
-    // the card: title, verdict selector, word-buttons
-    expect(frame).toContain("submit review");
-    expect(frame).toContain("[Approve]"); // nothing pending: approve default
-    expect(frame).toContain(" Submit ");
+    expect(frame).toContain("[Approve]");
+    expect(frame).toContain(" send message ");
     expect(frame).toContain(" Cancel ");
   });
 
-  test("left/right cycles the verdict selector in the card", async () => {
+  test("left/right cycles the verdict selector in the overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
@@ -133,7 +131,7 @@ describe("rail submit confirm", () => {
     await waitForText(setup, "[Changes]");
   });
 
-  test("esc cancels the card and restores the plain Submit button", async () => {
+  test("esc closes the overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
@@ -145,15 +143,13 @@ describe("rail submit confirm", () => {
     // Act
     await press(setup, "escape");
 
-    // Assert
-    // a bare ESC settles after the parser's escape-sequence window
+    // Assert - a bare ESC settles after the parser's escape-sequence window
     const frame = await waitForTextGone(setup, "[Approve]");
 
-    expect(frame).not.toContain("submit review");
-    expect(frame).toContain("Submit review");
+    expect(frame).not.toContain(" Cancel ");
   });
 
-  test("enter in the card resolves the session through the controller", async () => {
+  test("enter in the overlay resolves the session through the controller", async () => {
     // Arrange
     seedAnnotations(1);
     const setup = await renderApp();
@@ -163,16 +159,12 @@ describe("rail submit confirm", () => {
 
     // Assert
     await waitForText(setup, "[Changes]"); // pending items: request changes default
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("submit review");
 
     // Act
     await setup.mockInput.typeText("Tighten the steps.");
     await press(setup, "enter");
 
-    // Assert
-    // the completion flow after submit is unchanged
+    // Assert - the completion flow after submit is unchanged
     await waitForText(setup, "feedback sent");
     const stored = server.core.sessionGet(session.id);
 
@@ -180,65 +172,20 @@ describe("rail submit confirm", () => {
     expect(stored.verdict!.kind).toBe("request_changes");
   });
 
-  /** The rail's columns of the frame, so document text never leaks into a rail assertion. */
-  function railText(frame: string): string {
-    const rows = frame.split("\n");
-    const railColumn = rows.find((row) => row.includes("Review  Tree  Agent"))!.indexOf("│");
-
-    return rows.map((row) => row.slice(railColumn)).join("\n");
-  }
-
-  test("the annotation stack stays scrollable while the card is open", async () => {
-    // Arrange
-    seedAnnotations(12);
-    const setup = await renderApp();
-
-    // Act
-    // walk card focus to the last one: the rail scrolls it into view
-    for (let index = 0; index < 12; index++) await pressKey(setup, "n", { meta: true });
-
-    // Assert
-    await waitForText(setup, "note 12");
-    expect(railText(setup.captureCharFrame())).not.toContain("note 01");
-
-    // Act
-    await pressKey(setup, "RETURN", { meta: true });
-
-    // Assert
-    await waitForText(setup, "[Changes]");
-    // the card is pinned outside the scrollbox; the stack stays scrolled off the top
-    expect(railText(setup.captureCharFrame())).not.toContain("note 01");
-
-    // Act
-    // the stack still scrolls with the card open: wheel over the rail
-    // brings the last card back into view while the confirm card stays put
-    for (let turn = 0; turn < 12; turn++) await setup.mockMouse.scroll(100, 10, "down");
-    await settle(setup);
-
-    // Assert
-    await waitForText(setup, "note 12");
-    const scrolledWithCard = railText(setup.captureCharFrame());
-
-    expect(scrolledWithCard).toContain("submit review");
-    expect(scrolledWithCard).not.toContain("note 01");
-  });
-
-  test("read-only observers never see the confirm card", async () => {
+  test("read-only observers cannot open the confirm overlay", async () => {
     // Arrange
     seedAnnotations(1);
     const setup = await renderApp({ readOnly: true });
 
     // Act
     await pressKey(setup, "RETURN", { meta: true });
+    await settle(setup);
 
-    // Assert
-    await waitForText(setup, "observer - read-only");
+    // Assert - no overlay, and the session stays pending
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("observer - read-only");
-    expect(frame).not.toContain("1 annotations");
     expect(frame).not.toContain("[Changes]");
-    expect(setup.captureCharFrame()).not.toContain("verdict ←/→");
+    expect(frame).not.toContain(" Cancel ");
     expect(server.core.sessionGet(session.id).status).toBe("pending");
   });
 });

package/src/App.test.tsx

@@ -14,6 +14,7 @@ import {
   dragText,
   frameRow,
   isolateUserConfig,
+  locateText,
   press,
   pressKey,
   typeText as type,
@@ -71,7 +72,7 @@ async function renderApp(sessionId?: string) {
 }
 
 describe("plan rendering", () => {
-  test("renders the plan with headings, list markers, and the rail", async () => {
+  test("renders the plan with headings, list markers, and the footer", async () => {
     // Arrange
     const setup = await renderApp();
 
@@ -82,8 +83,22 @@ describe("plan rendering", () => {
     expect(frame).toContain("Context");
     expect(frame).toContain("persists sessions to disk atomically");
     expect(frame).toContain("· move the store");
-    expect(frame).toContain("Review");
-    expect(frame).toContain("Submit review");
+    expect(frame).toContain("send message");
+  });
+
+  test("a direct open still populates the Threads sidebar with other pending reviews", async () => {
+    // Arrange - a second pending review exists alongside the one opened directly
+    server.core.sessionCreate({
+      workspace: { repoRoot: "/repo", branch: "main" },
+      artifact: { type: "plan", content: "# Other Plan\n", meta: { title: "Other Plan" } },
+    });
+    const setup = await renderApp();
+
+    // Act - open the collapsed Threads sidebar (the mirrored panel toggle by the gear)
+    await setup.mockMouse.click(4, 0);
+
+    // Assert - the sidebar lists the other pending review, so you can jump to it
+    await waitForText(setup, "Other Plan");
   });
 });
 
@@ -113,7 +128,7 @@ describe("thread view grammar", () => {
     await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
-    await waitForText(setup, "COMMENT");
+    await waitForState(setup, () => server.core.sessionGet(session.id).annotations.length === 1);
     const stored = server.core.sessionGet(session.id);
 
     expect(stored.annotations.length).toBe(1);
@@ -144,9 +159,11 @@ describe("thread view grammar", () => {
     // Act
     await pressKey(setup, "x", { meta: true });
 
-    // Assert - the rail shows the cut as a removal card titled CUT · me
-    await waitForText(setup, "CUT · me");
-    expect(server.core.sessionGet(session.id).workingCopy).not.toContain("move the store");
+    // Assert - the cut lands in the working copy
+    await waitForState(
+      setup,
+      () => !(server.core.sessionGet(session.id).workingCopy ?? "").includes("move the store"),
+    );
 
     // Act
     await pressKey(setup, "x", { meta: true });
@@ -227,51 +244,105 @@ describe("submit", () => {
   });
 });
 
-describe("inbox", () => {
-  test("inbox mode wears the review chrome (header + menu bar) and opens a session", async () => {
+describe("no-thread shell", () => {
+  test("opening with nothing selected lands in the shell with a Welcome tab and the Threads sidebar", async () => {
     // Arrange
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
 
     await waitForText(setup, "cueloop");
 
-    // Assert - the same header/menu chrome as review, plus the session row
+    // Assert - the same shell header, the disposable Welcome tab, and the pending thread
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("cueloop · resume");
+    expect(frame).toContain("Welcome to cueloop");
     expect(frame).toContain("Migration Plan");
-    expect(frame).toContain("menu"); // the shared MenuBar sits at the bottom
-    expect(frame).not.toContain("inbox ("); // the old inline header is gone
+    expect(frame).not.toContain("· resume"); // the bespoke inbox header is retired
 
     // Act
     await press(setup, "enter");
 
     // Assert
-    await waitForText(setup, "Submit review");
+    await waitForText(setup, "send message");
+  });
+
+  test("picking a thread from the no-thread shell keeps the Threads sidebar open", async () => {
+    // Arrange - a second pending thread so the sidebar has a row that never shows
+    // in the opened thread's own view
+    server.core.sessionCreate({
+      workspace: { repoRoot: "/repo", branch: "main" },
+      artifact: { type: "plan", content: "# Other Plan\n", meta: { title: "Other Plan" } },
+    });
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+
+    await waitForText(setup, "Welcome to cueloop");
+    await waitForText(setup, "Other Plan"); // the sidebar opens by default here
+
+    // Act - open the thread under the cursor
+    await press(setup, "enter");
+    await waitForText(setup, "send message");
+
+    // Assert - the sidebar stayed open across the swap: both titles are on screen,
+    // and the non-opened one can only come from the still-open sidebar
+    const frame = setup.captureCharFrame();
+
+    expect(frame).toContain("Migration Plan");
+    expect(frame).toContain("Other Plan");
   });
 
-  test("the menu opens from the inbox and escape is not a trap", async () => {
+  test("the row kebab menu pins a thread into a Pinned section", async () => {
     // Arrange
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
 
-    await waitForText(setup, "cueloop · resume");
-    const lines = setup.captureCharFrame().split("\n");
-    const menuRow = lines.findIndex((line) => line.includes("menu"));
-    const menuColumn = lines[menuRow]!.indexOf("menu");
+    await waitForText(setup, "Migration Plan");
 
-    // Act - open the drop-up from the shared menu bar
-    await setup.mockMouse.click(menuColumn + 1, menuRow);
+    // Act - hover the row to reveal its kebab, open the menu, and pick Pin
+    const row = locateText(setup, "Migration Plan");
 
-    // Assert - the drop-up options appear
+    await setup.mockMouse.moveTo(row.column, row.row);
+    await waitForText(setup, "⋮");
+    await clickText(setup, "⋮");
+    await waitForText(setup, "Pin");
+    await clickText(setup, "Pin");
+
+    // Assert - a Pinned section now holds the thread
+    await waitForText(setup, "Pinned");
+    expect(frameRow(setup, "Migration Plan")).toBeGreaterThan(frameRow(setup, "Pinned"));
+  });
+
+  test("a bare launch shows the Welcome surface with the right region collapsed", async () => {
+    // Arrange
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+
+    await waitForText(setup, "Welcome to cueloop");
+
+    // Assert - Welcome fills the thread pane (not a Changes tab); the right region stays collapsed
+    const frame = setup.captureCharFrame();
+
+    expect(frame).toContain("Welcome to cueloop");
+    expect(frame).not.toContain("Changes"); // the Changes editor is closed on a bare launch
+    expect(frame).toContain("Migration Plan"); // the sidebar lists the pending thread
+  });
+
+  test("the menu opens from the shell gear and escape is not a trap", async () => {
+    // Arrange
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+
+    await waitForText(setup, "Welcome to cueloop");
+
+    // Act - open the settings dialog from the top-left gear (the Threads panel header, row 0)
+    await setup.mockMouse.click(1, 0);
+
+    // Assert - the settings dialog with its Keybinds leaf appears
     await waitForText(setup, "Keybinds");
     expect(setup.captureCharFrame()).toContain("Settings");
 
-    // Act - escape closes the menu (not a trap), and the inbox nav still works
+    // Act - escape closes the menu (not a trap), and the thread nav still works
     await press(setup, "escape");
     await waitForState(setup, () => !setup.captureCharFrame().includes("Keybinds"));
     await press(setup, "enter");
 
     // Assert
-    await waitForText(setup, "Submit review");
+    await waitForText(setup, "send message");
   });
 });
 
@@ -281,12 +352,9 @@ describe("the thread view and the menu", () => {
     const setup = await renderApp();
 
     await waitForText(setup, "The daemon persists");
-    const lines = setup.captureCharFrame().split("\n");
-    const menuRow = lines.findIndex((line) => line.includes("menu"));
-    const menuColumn = lines[menuRow]!.indexOf("menu");
 
-    // Act - open the menu, then the keybinds dialog
-    await setup.mockMouse.click(menuColumn + 1, menuRow);
+    // Act - open the menu from the top-left settings gear, then the keybinds dialog
+    await setup.mockMouse.click(1, 0);
     await waitForText(setup, "Keybinds");
     const dropUp = setup.captureCharFrame().split("\n");
     const keybindsRow = dropUp.findIndex((line) => line.includes("Keybinds"));
@@ -298,7 +366,7 @@ describe("the thread view and the menu", () => {
     const dialog = setup.captureCharFrame();
 
     expect(dialog).toContain("⌘⌥m");
-    expect(dialog).toContain("dismiss an empty draft");
+    expect(dialog).toContain("place the caret");
     expect(dialog).not.toContain("grow/shrink");
 
     // Act - a printable behind the dialog must not open a comment; escape closes it
@@ -307,7 +375,44 @@ describe("the thread view and the menu", () => {
     await press(setup, "escape");
 
     // Assert
-    await waitForState(setup, () => !setup.captureCharFrame().includes("dismiss an empty draft"));
+    await waitForState(setup, () => !setup.captureCharFrame().includes("mark text, across blocks"));
     expect(setup.captureCharFrame()).not.toContain("● x");
   });
+
+  test("clicking the Settings nav group is inert and never corrupts the active category", async () => {
+    // Arrange - open the settings dialog from the gear
+    const setup = await renderApp();
+
+    await setup.mockMouse.click(1, 0);
+    await waitForText(setup, "Keybinds");
+
+    // the nav folder is the last "Settings" on screen (the first is the dialog title)
+    const lines = setup.captureCharFrame().split("\n");
+    let folderRow = -1;
+    let folderColumn = -1;
+
+    lines.forEach((line, row) => {
+      const column = line.indexOf("Settings");
+
+      if (column !== -1) {
+        folderColumn = column;
+        folderRow = row;
+      }
+    });
+
+    // Act - click the synthetic Settings group folder, then press a nav key. The
+    // key handler dereferences the active category, so a corrupt id would throw
+    // (the global key handler swallows the throw into console.error).
+    const keyHandlerErrors: string[] = [];
+    const originalConsoleError = console.error;
+
+    console.error = (...args: unknown[]) => keyHandlerErrors.push(args.map(String).join(" "));
+    await setup.mockMouse.click(folderColumn + 1, folderRow);
+    await pressKey(setup, "ARROW_DOWN");
+    console.error = originalConsoleError;
+
+    // Assert - no key-handler crash, and the dialog is still up
+    expect(keyHandlerErrors.filter((line) => line.includes("keypress handler"))).toEqual([]);
+    expect(setup.captureCharFrame()).toContain("Keybinds");
+  });
 });