@cueloop/client 0.1.0-alpha.64 → 0.1.0-alpha.66

package/src/App.readonly.test.tsx

@@ -1,4 +1,4 @@
-/** Observer mode (tier 2): the App with readOnly renders and navigates like the controller's, but every mutating verb answers "observer - read-only" and leaves daemon state untouched. */
+/** Observer mode (tier 2): the App with readOnly renders and navigates like the controller's, but every mutating primitive answers "observer - read-only" and leaves daemon state untouched. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
@@ -9,8 +9,15 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import { makeAnchor, parseBlocks, type ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
-import { DARK } from "./theme";
-import { isolateUserConfig, press, waitForState, waitForText } from "./test-support";
+import {
+  clickText,
+  dragText,
+  frameRow,
+  isolateUserConfig,
+  pressKey,
+  typeText,
+  waitForText,
+} from "./test-support";
 
 const PLAN = `# Migration Plan
 
@@ -60,7 +67,9 @@ async function renderObserver() {
   return setup;
 }
 
-/** Session state that any mutating verb would change. */
+type Setup = Awaited<ReturnType<typeof renderObserver>>;
+
+/** Session state that any mutating primitive would change. */
 function snapshot() {
   const stored = server.core.sessionGet(session.id);
 
@@ -72,79 +81,110 @@ function snapshot() {
 }
 
 describe("observer rendering", () => {
-  test("shows the observer badge and the bottom menu", async () => {
+  test("shows the observer badge in the header", async () => {
     // Arrange
     const setup = await renderObserver();
 
     // Assert
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("· observer");
-    expect(frame).toContain("menu");
+    expect(setup.captureCharFrame()).toContain("· observer");
   });
 });
 
-describe("observer verbs are blocked", () => {
-  for (const [key, verb] of [
-    ["c", "comment"],
-    ["x", "cut"],
-    ["e", "edit"],
-    ["enter", "submit"],
-  ] as const) {
-    test(`${verb} (${key}) answers observer - read-only and mutates nothing`, async () => {
+describe("observer primitives are blocked", () => {
+  const attempts: Array<[string, (setup: Setup) => Promise<void>]> = [
+    ["comment (typing)", (setup) => typeText(setup, "c")],
+    ["cut (option+x)", (setup) => pressKey(setup, "x", { meta: true })],
+    ["edit (ctrl+e)", (setup) => pressKey(setup, "e", { ctrl: true })],
+    ["submit (cmd+enter)", (setup) => pressKey(setup, "RETURN", { meta: true })],
+  ];
+
+  for (const [primitive, attempt] of attempts) {
+    test(`${primitive} answers observer - read-only and mutates nothing`, async () => {
       const setup = await renderObserver();
       const before = snapshot();
 
-      await press(setup, "j");
-      await press(setup, "j");
-      await press(setup, key);
+      await clickText(setup, "daemon");
+      await attempt(setup);
       const frame = await waitForText(setup, "observer - read-only");
 
-      // no overlay opened: compose/submit bars never appear
-      expect(frame).not.toContain('comment on "');
-      expect(frame).not.toContain("verdict ←/→");
+      // no draft card and no submit card ever appear
+      expect(frame).not.toContain("● c");
+      expect(frame).not.toContain("[Approve]");
       expect(snapshot()).toEqual(before);
     });
   }
 
-  test("span mode c is blocked too", async () => {
+  test("typing over a marked span is blocked too", async () => {
     // Arrange
     const setup = await renderObserver();
 
     // Act
-    await press(setup, "j");
-    await press(setup, "j");
-    await press(setup, "v");
-    await press(setup, "c");
-    await setup.renderOnce();
+    await dragText(setup, "The daemon", "daemon persists", "daemon".length);
+    await typeText(setup, "c");
 
     // Assert
-    const frame = setup.captureCharFrame();
+    const frame = await waitForText(setup, "observer - read-only");
 
-    expect(frame).toContain("observer - read-only");
-    expect(frame).not.toContain('comment on "');
+    expect(frame).not.toContain("● c");
     expect(snapshot().annotations).toBe(0);
   });
 });
 
+describe("a resolved review is read-only for its owner too", () => {
+  test("typing, deleting a card, and editing answer review submitted - read-only", async () => {
+    // Arrange: a comment exists and the verdict is in
+    server.core.sessionAnnotate(session.id, {
+      id: "a_done",
+      kind: "comment",
+      anchor: makeAnchor(parseBlocks(PLAN), 2, 0, 10),
+      body: "settled",
+    });
+    server.core.sessionResolve(session.id, "approve", "");
+    const setup = await testRender(<App home={home} sessionId={session.id} />, {
+      width: 120,
+      height: 32,
+    });
+
+    await waitForText(setup, "settled");
+    const before = snapshot();
+
+    // Act + Assert: a draft never opens
+    await clickText(setup, "daemon");
+    await typeText(setup, "c");
+    await waitForText(setup, "review submitted - read-only");
+    expect(setup.captureCharFrame()).not.toContain("● c");
+
+    // Act + Assert: the focused card cannot be deleted or edited
+    await pressKey(setup, "n", { meta: true });
+    await pressKey(setup, "BACKSPACE", { meta: true });
+    await pressKey(setup, "e", { meta: true });
+    await pressKey(setup, "x", { meta: true });
+    expect(snapshot()).toEqual(before);
+    expect(server.core.sessionGet(session.id).annotations).toHaveLength(1);
+  });
+});
+
 describe("observer navigation still works", () => {
-  test("j/k moves the cursor between blocks", async () => {
+  test("↓ moves the caret between blocks", async () => {
     // Arrange
     const setup = await renderObserver();
 
     // Act
-    await press(setup, "j");
-    await press(setup, "j");
+    await pressKey(setup, "ARROW_DOWN");
+    await pressKey(setup, "ARROW_DOWN");
     await setup.renderOnce();
 
-    // Assert
-    const lines = setup.captureCharFrame().split("\n");
-    const cursorLine = lines.find((line) => line.includes("▎"))!;
+    // Assert: the caret cell is painted on the paragraph's row
+    const caretRow = setup
+      .captureSpans()
+      .lines.findIndex((line) =>
+        line.spans.some((span) => span.bg.toInts().slice(0, 3).join() === "86,91,104"),
+      );
 
-    expect(cursorLine).toContain("persists sessions");
+    expect(caretRow).toBe(frameRow(setup, "persists sessions"));
   });
 
-  test("n focuses annotations made by the controller", async () => {
+  test("option+n focuses annotations made by the controller", async () => {
     // Arrange
     server.core.sessionAnnotate(session.id, {
       id: "a_obs1",
@@ -154,29 +194,12 @@ describe("observer navigation still works", () => {
     });
     const setup = await renderObserver();
 
-    // Act
-    await press(setup, "n");
+    // Act - the observer navigates to the annotation without mutating anything
+    await pressKey(setup, "n", { meta: true });
     await setup.renderOnce();
 
-    // Assert - focus shows as the card's blue border (transparent fill); a
-    // comment card is the only blue-bordered box in the frame
-    await waitForText(setup, "COMMENT · me");
-    await waitForState(setup, () => hasBorderColor(setup, DARK.blue));
+    // Assert - the observer reads the controller's comment inline in the thread
+    await waitForText(setup, "From the controller.");
+    expect(snapshot().annotations).toBe(1);
   });
 });
-
-/** Whether any border character (box-drawing) is painted in the given foreground hex. */
-function hasBorderColor(setup: Awaited<ReturnType<typeof renderObserver>>, hex: string): boolean {
-  for (const line of setup.captureSpans().lines) {
-    for (const span of line.spans) {
-      if (!/[╭╮╰╯│─┌┐└┘]/.test(span.text)) continue;
-      const [red, green, blue] = span.fg.toInts();
-      const rendered =
-        "#" + [red, green, blue].map((part) => part.toString(16).padStart(2, "0")).join("");
-
-      if (rendered === hex) return true;
-    }
-  }
-
-  return false;
-}

package/src/App.rendering.test.tsx

@@ -83,10 +83,9 @@ describe("code blocks", () => {
 });
 
 describe("block spacing", () => {
-  // the review panel's full-height divider paints a `│` on every row, so read
-  // the plan column (everything left of the divider) before asserting spacing
-  // the plan body is framed: content sits between the left border and the next │
-  const planColumn = (line: string): string => line.split("│")[1]?.trimEnd() ?? "";
+  // the review rail paints box edges on the right, so read the document
+  // column (everything left of the first rail glyph) before asserting spacing
+  const planColumn = (line: string): string => line.split(/[│╭╰]/)[0]!.trimEnd();
 
   test("a code block never glues to the list item above it", async () => {
     // Arrange
@@ -129,8 +128,8 @@ describe("block spacing", () => {
       .captureCharFrame()
       .split("\n")
       .map((line) => line.trimEnd());
-    const one = lines.findIndex((line) => line.includes("- one"));
+    const one = lines.findIndex((line) => line.includes("· one"));
 
-    expect(lines[one + 1]).toContain("- two");
+    expect(lines[one + 1]).toContain("· two");
   });
 });

package/src/App.submit-confirm.test.tsx

@@ -1,4 +1,4 @@
-/** The rail submit confirm (tier 2): pressing submit expands the rail's Submit button into a bordered confirm card - counts, verdict selector, summary input, word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
+/** The send-message confirm: cmd+enter opens a centered overlay with a verdict selector, summary input, and word-buttons. Char-frame assertions over the real App and an in-process daemon, like App.test.tsx. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
@@ -9,7 +9,14 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import { makeAnchor, parseBlocks, type ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
-import { isolateUserConfig, press, settle, waitForText, waitForTextGone } from "./test-support";
+import {
+  isolateUserConfig,
+  press,
+  pressKey,
+  settle,
+  waitForText,
+  waitForTextGone,
+} from "./test-support";
 
 const PLAN = `# Migration Plan
 
@@ -76,33 +83,31 @@ function seedAnnotations(count: number): void {
   }
 }
 
-describe("rail submit confirm", () => {
-  test("submit expands the Submit button into the confirm card", async () => {
+describe("send message confirm", () => {
+  test("cmd+enter opens the send-message confirm overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
-    // Assert
-    expect(setup.captureCharFrame()).toContain("Submit review");
+    // Assert - the footer carries the send control before the overlay opens
+    expect(setup.captureCharFrame()).toContain("send message");
 
     // Act
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
-    // Assert
-    await waitForText(setup, "submit review");
+    // Assert - the overlay: verdict selector and word-buttons
+    await waitForText(setup, "[Approve]"); // nothing pending: approve default
     const frame = setup.captureCharFrame();
 
-    // the card: title, verdict selector, word-buttons
-    expect(frame).toContain("submit review");
-    expect(frame).toContain("[Approve]"); // nothing pending: approve default
-    expect(frame).toContain(" Submit ");
+    expect(frame).toContain("[Approve]");
+    expect(frame).toContain(" send message ");
     expect(frame).toContain(" Cancel ");
   });
 
-  test("left/right cycles the verdict selector in the card", async () => {
+  test("left/right cycles the verdict selector in the overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForText(setup, "[Approve]");
@@ -126,11 +131,11 @@ describe("rail submit confirm", () => {
     await waitForText(setup, "[Changes]");
   });
 
-  test("esc cancels the card and restores the plain Submit button", async () => {
+  test("esc closes the overlay", async () => {
     // Arrange
     const setup = await renderApp();
 
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForText(setup, "[Approve]");
@@ -138,34 +143,28 @@ describe("rail submit confirm", () => {
     // Act
     await press(setup, "escape");
 
-    // Assert
-    // a bare ESC settles after the parser's escape-sequence window
+    // Assert - a bare ESC settles after the parser's escape-sequence window
     const frame = await waitForTextGone(setup, "[Approve]");
 
-    expect(frame).not.toContain("submit review");
-    expect(frame).toContain("Submit review");
+    expect(frame).not.toContain(" Cancel ");
   });
 
-  test("enter in the card resolves the session through the controller", async () => {
+  test("enter in the overlay resolves the session through the controller", async () => {
     // Arrange
     seedAnnotations(1);
     const setup = await renderApp();
 
     // Act
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
 
     // Assert
     await waitForText(setup, "[Changes]"); // pending items: request changes default
-    const frame = setup.captureCharFrame();
-
-    expect(frame).toContain("submit review");
 
     // Act
     await setup.mockInput.typeText("Tighten the steps.");
     await press(setup, "enter");
 
-    // Assert
-    // the completion flow after submit is unchanged
+    // Assert - the completion flow after submit is unchanged
     await waitForText(setup, "feedback sent");
     const stored = server.core.sessionGet(session.id);
 
@@ -173,57 +172,20 @@ describe("rail submit confirm", () => {
     expect(stored.verdict!.kind).toBe("request_changes");
   });
 
-  test("the annotation stack stays scrollable while the card is open", async () => {
-    // Arrange
-    seedAnnotations(12);
-    const setup = await renderApp();
-
-    // Act
-    // walk annotation focus to the last card: the rail scrolls it into view
-    for (let index = 0; index < 12; index++) await press(setup, "n");
-
-    // Assert
-    await waitForText(setup, "note 12");
-    expect(setup.captureCharFrame()).not.toContain("note 01");
-
-    // Act
-    await press(setup, "enter");
-
-    // Assert
-    await waitForText(setup, "[Changes]");
-    // the card is pinned outside the scrollbox; the stack stays scrolled off the top
-    expect(setup.captureCharFrame()).not.toContain("note 01");
-
-    // Act
-    // the stack still scrolls with the card open: wheel over the rail
-    // brings the last card back into view while the confirm card stays put
-    for (let turn = 0; turn < 12; turn++) await setup.mockMouse.scroll(100, 10, "down");
-    await settle(setup);
-
-    // Assert
-    await waitForText(setup, "note 12");
-    const scrolledWithCard = setup.captureCharFrame();
-
-    expect(scrolledWithCard).toContain("submit review");
-    expect(scrolledWithCard).not.toContain("note 01");
-  });
-
-  test("read-only observers never see the confirm card", async () => {
+  test("read-only observers cannot open the confirm overlay", async () => {
     // Arrange
     seedAnnotations(1);
     const setup = await renderApp({ readOnly: true });
 
     // Act
-    await press(setup, "enter");
+    await pressKey(setup, "RETURN", { meta: true });
+    await settle(setup);
 
-    // Assert
-    await waitForText(setup, "observer - read-only");
+    // Assert - no overlay, and the session stays pending
     const frame = setup.captureCharFrame();
 
-    expect(frame).toContain("observer - read-only");
-    expect(frame).not.toContain("1 annotations");
     expect(frame).not.toContain("[Changes]");
-    expect(setup.captureCharFrame()).not.toContain("verdict ←/→");
+    expect(frame).not.toContain(" Cancel ");
     expect(server.core.sessionGet(session.id).status).toBe("pending");
   });
 });