@cueloop/client 0.1.0-alpha.63 → 0.1.0-alpha.64

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.63",
+  "version": "0.1.0-alpha.64",
   "description": "The cueloop review UI: projection renderer, keyboard grammar, review rail",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -26,10 +26,10 @@
     "access": "public"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.63",
-    "@cueloop/extension-api": "0.1.0-alpha.63",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.63",
-    "@cueloop/schema": "0.1.0-alpha.63",
+    "@cueloop/daemon": "0.1.0-alpha.64",
+    "@cueloop/extension-api": "0.1.0-alpha.64",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.64",
+    "@cueloop/schema": "0.1.0-alpha.64",
     "@opentui/core": "^0.5.8",
     "@opentui/keymap": "0.5.8",
     "@opentui/react": "^0.5.8",
@@ -37,7 +37,8 @@
     "@pierre/diffs": "^1.3.6",
     "diff": "^9",
     "puppeteer-core": "^25.8.0",
-    "react": "^19.2.0"
+    "react": "^19.2.0",
+    "valibot": "^1.4.2"
   },
   "devDependencies": {
     "@types/react": "^19.2.0",

package/src/App.toast.test.tsx

@@ -8,20 +8,20 @@ import React from "react";
 import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import type { ReviewSession } from "@cueloop/schema";
+import { App } from "./App";
+import type { ShareTransport } from "./session-controller";
+import { isolateUserConfig, press, waitForText, waitForTextGone } from "./test-support";
 
-// the controller reaches the gateway through "./share"; stub it so `S` yields a toast
 const publishShare = mock(async () => ({ line: "ssh p_share01@cueloop.dev", copied: true }));
-
-mock.module("./share", () => ({
-  publishShare,
-  pullShare: mock(async () => null),
-  pushShare: mock(async () => {}),
-  shareIdFromLine: (line: string) => line.match(/^ssh (\S+)@/)?.[1],
+const shareTransport: ShareTransport = {
+  publish: publishShare,
+  pull: mock(async () => {
+    throw new Error("Unexpected share pull");
+  }),
+  push: mock(async () => {}),
+  parseShareId: (line) => line.match(/^ssh (\S+)@/)?.[1],
   collaboratorAnnotations: () => [],
-}));
-
-const { App } = await import("./App");
-const { isolateUserConfig, press, waitForText, waitForTextGone } = await import("./test-support");
+};
 
 const PLAN = `# Migration Plan\n\n## Context\n\nThe daemon persists sessions to disk atomically.\n`;
 
@@ -53,10 +53,13 @@ afterEach(() => {
 describe("share toast", () => {
   test("escape cancels an open composer even while the toast is up", async () => {
     // Arrange
-    const setup = await testRender(<App home={home} sessionId={session.id} />, {
-      width: 120,
-      height: 32,
-    });
+    const setup = await testRender(
+      <App home={home} sessionId={session.id} shareTransport={shareTransport} />,
+      {
+        width: 120,
+        height: 32,
+      },
+    );
 
     await waitForText(setup, "cueloop");
 

package/src/App.tsx

@@ -37,7 +37,7 @@ import {
   type ThemeName,
 } from "./theme-presets";
 import type { Theme } from "./theme";
-import { createReviewController } from "./session-controller";
+import { createReviewController, type ShareTransport } from "./session-controller";
 import type { SessionClient } from "@cueloop/daemon/client";
 import { launchHarnessInSplit } from "@cueloop/daemon/herdr-split";
 import { activeSpanState, createIntentDispatch, type Mode } from "./intent-dispatch";
@@ -105,6 +105,7 @@ export interface AppProps {
   clock?: Clock;
   /** Session source; the sharing gateway injects a blob-backed client. */
   openClient?: () => Promise<SessionClient>;
+  shareTransport?: ShareTransport;
   /**
    * Who is at the keyboard. `owner` is the local planner (default). `observer`
    * is a passive `cueloop serve` watcher (read-only). `collaborator` is a share
@@ -131,6 +132,7 @@ export function App({
   onExit,
   clock,
   openClient,
+  shareTransport,
   role = "owner",
   selfAuthor,
   appearance = "dark",
@@ -138,7 +140,15 @@ export function App({
   const { observer, isOwner } = computeRoleCapabilities(readOnly, role);
   const controller = useMemo(
     () =>
-      createReviewController({ home, sessionId, readOnly: observer, onExit, clock, openClient }),
+      createReviewController({
+        home,
+        sessionId,
+        readOnly: observer,
+        onExit,
+        clock,
+        openClient,
+        shareTransport,
+      }),
     // eslint-disable-next-line react-hooks/exhaustive-deps
     [home, sessionId],
   );
@@ -305,7 +315,8 @@ export function App({
     if (!session) return positions;
     if (isDiff) {
       for (const annotation of session.annotations) {
-        const blockIndex = (annotation.anchor as { blockIndex?: number }).blockIndex;
+        const blockIndex =
+          "blockIndex" in annotation.anchor ? annotation.anchor.blockIndex : undefined;
 
         if (blockIndex !== undefined) positions.set(annotation.id, blockIndex);
       }

package/src/app-view-model.ts

@@ -18,17 +18,13 @@ import { REVIEW_COMPACT_WIDTH, resolveReviewWidth, type ReviewPanelMode } from "
 export function computeRoleCapabilities(
   readOnly: boolean,
   role: "owner" | "observer" | "collaborator",
-): { observer: boolean; isOwner: boolean } {
+) {
   const observer = readOnly || role === "observer";
 
   return { observer, isOwner: !observer && role === "owner" };
 }
 
-export function deriveReviewFlags(session: ReviewSession | null): {
-  isDiff: boolean;
-  isPrototype: boolean;
-  resolved: boolean;
-} {
+export function deriveReviewFlags(session: ReviewSession | null) {
   return {
     isDiff: session?.artifact.type === "diff",
     isPrototype: session?.artifact.type === "prototype",
@@ -121,13 +117,7 @@ export function buildRenderFlags(params: {
   menuOpen: boolean;
   menuDialog: "keybinds" | "settings" | null;
   resolvedIds: Set<string>;
-}): {
-  showOwnerActions: boolean;
-  prototypeCanComment: boolean;
-  chromeHidden: boolean;
-  prototypePath: string;
-  railResolvedIds: Set<string> | null;
-} {
+}) {
   const { session, isOwner, isDiff, isPrototype, resolved, menuOpen, menuDialog, resolvedIds } =
     params;
 

package/src/components/DiffSheet.scroll.test.tsx

@@ -4,7 +4,7 @@ import { expect, test } from "bun:test";
 import React, { useState } from "react";
 import { testRender } from "@opentui/react/test-utils";
 import { useKeyboard } from "@opentui/react";
-import type { Renderable, ScrollBoxRenderable } from "@opentui/core";
+import { ScrollBoxRenderable, type Renderable } from "@opentui/core";
 import type { Annotation } from "@cueloop/schema";
 import { DiffSheet } from "./DiffSheet";
 import { diffRows, type DiffRow } from "../view-diff";
@@ -82,7 +82,10 @@ test("scrolling down past wrapped annotation cards keeps the cursor pinned and t
   });
 
   await setup.waitForVisualIdle();
-  const scrollbox = findById(setup.renderer.root, "diff-scroll") as ScrollBoxRenderable;
+  const found = findById(setup.renderer.root, "diff-scroll");
+
+  if (!(found instanceof ScrollBoxRenderable)) throw new Error("diff-scroll is not a scrollbox");
+  const scrollbox = found;
 
   // the cursor row is the one painted with the cursor background
   const cursorScreenRow = (): number => {

package/src/components/DiffSheet.tsx

@@ -60,12 +60,7 @@ export interface DiffSheetProps {
 }
 
 /** The sign, base color, and background a row draws with. */
-function rowStyle(
-  row: DiffRow,
-  isCursorRow: boolean,
-  isAnnotatedRow: boolean,
-  tokens: Theme,
-): { sign: string; baseColor: string; background: string | undefined } {
+function rowStyle(row: DiffRow, isCursorRow: boolean, isAnnotatedRow: boolean, tokens: Theme) {
   const sign = row.kind === "add" ? "+" : row.kind === "del" ? "-" : " ";
   const baseColor =
     row.kind === "add"

package/src/components/PlanSheet.tsx

@@ -94,10 +94,7 @@ interface BlockRef {
 }
 
 /** Screen position of a rendered-text offset inside a wrapped text. */
-function positionOfRenderedOffset(
-  renderable: TextRenderable,
-  renderedOffset: number,
-): { x: number; y: number } {
+function positionOfRenderedOffset(renderable: TextRenderable, renderedOffset: number) {
   const info = renderable.lineInfo;
   let lineIndex = 0;
 

package/src/components/PrototypeSheet.tsx

@@ -10,6 +10,7 @@
 
 import React, { useEffect, useRef, useState } from "react";
 import type { BoxRenderable } from "@opentui/core";
+import * as v from "valibot";
 import { useKeyboard, useRenderer } from "@opentui/react";
 import type { Theme } from "../theme";
 import { quickActionBody, type QuickAction } from "../config";
@@ -95,10 +96,7 @@ type CaptureRenderer = {
  * raster and fewer bytes). Without a resolution report, fall back to a fixed
  * width at 2x and derive the height from the cell aspect.
  */
-function captureConfig(
-  region: CellRegion,
-  renderer: CaptureRenderer,
-): { viewport: PrototypeViewport; deviceScaleFactor: number } {
+function captureConfig(region: CellRegion, renderer: CaptureRenderer) {
   const resolution = renderer.resolution;
 
   if (resolution && renderer.terminalWidth >= 1 && renderer.terminalHeight >= 1) {
@@ -174,11 +172,9 @@ function PrototypeSheetImpl({
   // harness), but the launch trigger still runs.
   useEffect(() => {
     if (!renderer) return;
-    // writeOut is the renderer's raw output channel, ordered against its frame
-    // bytes; it is private, so reach it through one narrow cast
-    const rawWrite = (renderer as unknown as { writeOut?: (data: string) => void }).writeOut;
-    const write =
-      typeof rawWrite === "function" ? (chunk: string) => rawWrite.call(renderer, chunk) : null;
+    const rendererOutput = v.safeParse(v.object({ writeOut: v.function() }), renderer);
+    const rawWrite = rendererOutput.success ? rendererOutput.output.writeOut : null;
+    const write = rawWrite ? (chunk: string) => rawWrite.call(renderer, chunk) : null;
     const medium = resolveTransmitMedium();
     const paint = (): void => {
       if (!write) return;

package/src/components/ReviewRail.tsx

@@ -187,7 +187,9 @@ export const ReviewRail = forwardRef<ReviewRailHandle, ReviewRailProps>(function
     >
       <Tabs
         selectedKey={railTab}
-        onSelectionChange={(key) => onTabChange(key as RailTab)}
+        onSelectionChange={(key) => {
+          if (key === "review" || key === "agent") onTabChange(key);
+        }}
         theme={theme}
       >
         <TabList>

package/src/components/plan-sheet-run-style.ts

@@ -44,11 +44,13 @@ function blockBaseStyle(block: DisplayBlock, tokens: Theme): BlockBaseStyle {
   return { baseFg, baseAttributes };
 }
 
-function inlineRoleStyle(
-  run: StyleRun,
-  base: BlockBaseStyle,
-  tokens: Theme,
-): { fg?: string; bg?: string; attributes?: number } {
+interface PlanSheetRunStyle {
+  fg?: string;
+  bg?: string;
+  attributes?: number;
+}
+
+function inlineRoleStyle(run: StyleRun, base: BlockBaseStyle, tokens: Theme): PlanSheetRunStyle {
   const { baseFg, baseAttributes } = base;
   const withBase = (roleAttributes: number): number => baseAttributes | roleAttributes;
 
@@ -78,11 +80,7 @@ function inlineRoleStyle(
   }
 }
 
-export function runStyle(
-  run: StyleRun,
-  block: DisplayBlock,
-  tokens: Theme,
-): { fg?: string; bg?: string; attributes?: number } {
+export function runStyle(run: StyleRun, block: DisplayBlock, tokens: Theme): PlanSheetRunStyle {
   // a cut block reads as removed: every run struck through and grayed, never red
   if (block.type === "del") return { fg: tokens.textDim, attributes: CUT_ATTRIBUTES };
 

package/src/components/primitives/Tabs.tsx

@@ -65,7 +65,7 @@ export function TabList({ children }: TabListProps): React.ReactNode {
   const items: { id: string; label: string }[] = [];
 
   React.Children.forEach(children, (child) => {
-    if (React.isValidElement<TabProps>(child) && typeof child.props.id === "string") {
+    if (React.isValidElement<TabProps>(child)) {
       items.push({ id: child.props.id, label: child.props.children });
     }
   });

package/src/components/story-fixtures.ts

@@ -63,9 +63,11 @@ export function fixturePlanSession(overrides: Partial<ReviewSession> = {}): Revi
     },
     revisions: [{ revision: 1, content: FIXTURE_PLAN, submittedAt: "2026-01-01T00:00:00Z" }],
     annotations: FIXTURE_ANNOTATIONS,
+    verdict: null,
     status: "pending",
+    createdAt: "2026-01-01T00:00:00Z",
     ...overrides,
-  } as ReviewSession;
+  };
 }
 
 export function fixtureDiffSession(overrides: Partial<ReviewSession> = {}): ReviewSession {
@@ -80,9 +82,11 @@ export function fixtureDiffSession(overrides: Partial<ReviewSession> = {}): Revi
     },
     revisions: [{ revision: 1, content: FIXTURE_PATCH, submittedAt: "2026-01-01T00:00:00Z" }],
     annotations: [],
+    verdict: null,
     status: "pending",
+    createdAt: "2026-01-01T00:00:00Z",
     ...overrides,
-  } as ReviewSession;
+  };
 }
 
 export function fixtureDisplay() {

package/src/components/story.ts

@@ -32,7 +32,19 @@ export interface LoadedStory {
 
 export function isStory(value: unknown): value is Story {
   return (
-    typeof value === "object" && value !== null && typeof (value as Story).render === "function"
+    typeof value === "object" &&
+    value !== null &&
+    "render" in value &&
+    typeof value.render === "function"
+  );
+}
+
+function isStoryMeta(value: unknown): value is StoryMeta {
+  return (
+    typeof value === "object" &&
+    value !== null &&
+    "title" in value &&
+    typeof value.title === "string"
   );
 }
 
@@ -43,9 +55,9 @@ export async function loadStories(): Promise<LoadedStory[]> {
   const loaded: LoadedStory[] = [];
 
   for (const file of files) {
-    const moduleExports = (await import(`${import.meta.dir}/${file}`)) as Record<string, unknown>;
-    const meta = moduleExports["meta"] as StoryMeta | undefined;
-    const moduleTitle = meta?.title ?? file.replace(/\.stories\.tsx$/, "");
+    const moduleExports = await import(`${import.meta.dir}/${file}`);
+    const meta = moduleExports["meta"];
+    const moduleTitle = isStoryMeta(meta) ? meta.title : file.replace(/\.stories\.tsx$/, "");
 
     for (const [exportName, exported] of Object.entries(moduleExports)) {
       if (exportName === "meta" || !isStory(exported)) continue;

package/src/components/syntax-highlight.ts

@@ -19,7 +19,7 @@ export function filetypeFor(language?: string): string | undefined {
   const info = (language ?? "").toLowerCase();
 
   if (!info) return undefined;
-  const aliases: Record<string, string> = {
+  const aliases: SyntaxAliases = {
     ts: "typescript",
     js: "javascript",
     py: "python",
@@ -47,13 +47,21 @@ export function filetypeForPath(path: string): string | undefined {
   return extensionToFiletype.get(basename.slice(dotIndex + 1).toLowerCase());
 }
 
+interface SyntaxAliases {
+  [alias: string]: string;
+}
+
 interface SyntaxGroupStyle {
   fg: string;
   italic?: boolean;
 }
 
+interface SyntaxGroupStyles {
+  [group: string]: SyntaxGroupStyle;
+}
+
 /** The one group -> style map, keyed by tree-sitter capture name. */
-function syntaxGroupStyles(theme: Theme): Record<string, SyntaxGroupStyle> {
+function syntaxGroupStyles(theme: Theme): SyntaxGroupStyles {
   return {
     default: { fg: theme.textMuted },
     comment: { fg: theme.textDim, italic: true },

package/src/components/terminal-pane.test.tsx

@@ -34,7 +34,7 @@ describe("TerminalPaneRenderable", () => {
 
   test("exposes availability + the renderable class", () => {
     // Assert - the module loads and reports platform support honestly
-    expect(typeof embeddedTerminalAvailable()).toBe("boolean");
+    expect([true, false]).toContain(embeddedTerminalAvailable());
     expect(TerminalPaneRenderable).toBeDefined();
   });
 });

package/src/components/terminal-pane.ts

@@ -47,6 +47,12 @@ export interface TerminalPaneOptions extends RenderableOptions {
   onExit?: (exitCode: number) => void;
 }
 
+function terminalEnvironment(env: NodeJS.ProcessEnv) {
+  return Object.fromEntries(
+    Object.entries(env).filter((entry): entry is [string, string] => entry[1] !== undefined),
+  );
+}
+
 const encoder = new TextEncoder();
 const DEFAULT_FG = RGBA.fromInts(208, 208, 208, 255);
 const TRANSPARENT = RGBA.fromValues(0, 0, 0, 0);
@@ -87,7 +93,7 @@ export class TerminalPaneRenderable extends Renderable {
       cols,
       rows,
       cwd: this.opts.cwd ?? process.cwd(),
-      env: (this.opts.env ?? process.env) as Record<string, string>,
+      env: this.opts.env ?? terminalEnvironment(process.env),
     });
     this.pty.onData((data) => {
       // the shim streams a UTF-8-decoded string (split multibyte is handled); a