@cueloop/client 0.1.0-alpha.4 → 0.1.0-alpha.41

package/src/App.export.test.tsx

@@ -1,11 +1,15 @@
-/**
- * Tier-2 wiring test for the notes-vault export: with [integrations.obsidian]
- * configured to export on resolve, submitting a review writes the note into
- * the vault and surfaces the path in the status line.
- */
+/** Tier-2 wiring for the notes-vault export: with [integrations.obsidian] set to export on resolve, submitting a review writes the note into the vault and surfaces the path in the status line. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { existsSync, mkdirSync, mkdtempSync, readFileSync, readdirSync, rmSync, writeFileSync } from "node:fs";
+import {
+  existsSync,
+  mkdirSync,
+  mkdtempSync,
+  readFileSync,
+  readdirSync,
+  rmSync,
+  writeFileSync,
+} from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import React from "react";
@@ -13,6 +17,7 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import type { ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
+import { isolateUserConfig, press, waitForState, waitForText } from "./test-support";
 
 const PLAN = `# Migration Plan
 
@@ -23,57 +28,59 @@ let home: string;
 let vault: string;
 let server: DaemonServer;
 let session: ReviewSession;
-let savedConfigEnv: string | undefined;
+let restoreUserConfig: () => void;
 
 beforeEach(() => {
   home = mkdtempSync(join(tmpdir(), "cueloop-app-export-"));
   vault = join(home, "vault");
   mkdirSync(vault);
   const configPath = join(home, "config.toml");
-  writeFileSync(configPath, `[integrations.obsidian]\nvault = ${JSON.stringify(vault)}\nexportOn = "resolve"\n`);
-  savedConfigEnv = process.env.CUELOOP_CONFIG;
-  process.env.CUELOOP_CONFIG = configPath;
+  writeFileSync(
+    configPath,
+    `[integrations.obsidian]\nvault = ${JSON.stringify(vault)}\nexportOn = "resolve"\n`,
+  );
+  restoreUserConfig = isolateUserConfig(home, "config.toml");
   server = new DaemonServer({ home, idleExitMs: 0 });
   server.start();
   session = server.core.sessionCreate({
     workspace: { repoRoot: "/repo", branch: "main" },
-    artifact: { type: "plan", content: PLAN, meta: { title: "Migration Plan", planPath: "plan.md" } },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
   });
 });
 afterEach(() => {
-  if (savedConfigEnv === undefined) delete process.env.CUELOOP_CONFIG;
-  else process.env.CUELOOP_CONFIG = savedConfigEnv;
+  restoreUserConfig();
   server.stop();
   rmSync(home, { recursive: true, force: true });
 });
 
 describe("obsidian export on resolve", () => {
   test("submitting a review writes the plan into the vault and shows the path", async () => {
-    const setup = await testRender(<App home={home} sessionId={session.id} />, { width: 120, height: 32 });
-    for (let i = 0; i < 40 && !setup.captureCharFrame().includes("cueloop"); i++) {
-      await Bun.sleep(25);
-      await setup.renderOnce();
-    }
-    // open the submit overlay, keep the default verdict (approve), submit
-    setup.mockInput.pressKey("RETURN");
-    await Bun.sleep(15);
-    await setup.renderOnce();
-    expect(setup.captureCharFrame()).toContain("verdict");
-    setup.mockInput.pressKey("RETURN");
-    // wall-clock deadlines: the export is an async round-trip after resolve,
-    // and an iteration count times out on a loaded runner
+    // Arrange
+    const setup = await testRender(<App home={home} sessionId={session.id} />, {
+      width: 120,
+      height: 32,
+    });
+    await waitForText(setup, "cueloop");
+
+    // Act
+    await press(setup, "enter"); // open the submit overlay, keep the default verdict (approve)
+
+    // Assert
+    await waitForText(setup, "[Approve]");
+
+    // Act
+    await press(setup, "enter"); // submit
+
+    // Assert
+    // the export is an async round-trip after resolve; the status line lands
+    // on a later render than the file write
     const dir = join(vault, "cueloop");
-    const fileDeadline = Date.now() + 30_000;
-    while (Date.now() < fileDeadline && !existsSync(dir)) {
-      await Bun.sleep(25);
-      await setup.renderOnce();
-    }
-    // the status line lands on a later render than the file write
-    const statusDeadline = Date.now() + 30_000;
-    while (Date.now() < statusDeadline && !setup.captureCharFrame().includes("exported to")) {
-      await Bun.sleep(25);
-      await setup.renderOnce();
-    }
+    await waitForState(setup, () => existsSync(dir));
+    await waitForText(setup, "exported to");
 
     const notes = readdirSync(dir);
     expect(notes.length).toBe(1);