@cueloop/client 0.1.0-alpha.33 → 0.1.0-alpha.35

package/src/App.rendering.test.tsx

@@ -51,7 +51,10 @@ afterEach(() => {
 });
 
 async function frame(): Promise<string> {
-  const setup = await testRender(<App home={home} sessionId={session.id} />, { width: 120, height: 36 });
+  const setup = await testRender(<App home={home} sessionId={session.id} />, {
+    width: 120,
+    height: 36,
+  });
   await waitForText(setup, "Render Plan");
   // async highlights settle within the visual-idle wait
   await setup.waitForVisualIdle();
@@ -112,11 +115,17 @@ describe("block spacing", () => {
       workspace: { repoRoot: "/repo", branch: "main" },
       artifact: { type: "plan", content: listPlan, meta: {} },
     });
-    const setup = await testRender(<App home={home} sessionId={s2.id} />, { width: 120, height: 30 });
+    const setup = await testRender(<App home={home} sessionId={s2.id} />, {
+      width: 120,
+      height: 30,
+    });
     await waitForText(setup, "one");
 
     // Assert
-    const lines = setup.captureCharFrame().split("\n").map((line) => line.trimEnd());
+    const lines = setup
+      .captureCharFrame()
+      .split("\n")
+      .map((line) => line.trimEnd());
     const one = lines.findIndex((line) => line.includes("- one"));
     expect(lines[one + 1]).toContain("- two");
   });

package/src/App.review-panel.test.tsx

@@ -1,7 +1,7 @@
 /** The review panel end to end: the b key cycles expanded -> compact -> hidden -> expanded on the live App, and the collapse mode persists to the user config so it survives a restart. Rendering details are locked by the ReviewPanel stories; this suite proves the App wiring and the persistence. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { mkdtempSync, readFileSync, rmSync } from "node:fs";
+import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import React from "react";
@@ -38,7 +38,10 @@ afterEach(() => {
 });
 
 async function renderApp() {
-  const setup = await testRender(<App home={home} sessionId={session.id} />, { width: 120, height: 30 });
+  const setup = await testRender(<App home={home} sessionId={session.id} />, {
+    width: 120,
+    height: 30,
+  });
   await waitForText(setup, "Review");
   return setup;
 }
@@ -49,7 +52,12 @@ describe("review panel", () => {
     const setup = await renderApp();
     // the plan frame widens as the rail shrinks: expanded < compact < hidden.
     // its width is the column of its top-right corner (the first ╮ on the row).
-    const planWidth = () => setup.captureCharFrame().split("\n").find((line) => line.includes("╮"))?.indexOf("╮") ?? 0;
+    const planWidth = () =>
+      setup
+        .captureCharFrame()
+        .split("\n")
+        .find((line) => line.includes("╮"))
+        ?.indexOf("╮") ?? 0;
 
     // Assert: expanded shows the submit button and leaves room for the rail
     expect(setup.captureCharFrame()).toContain("Submit review");

package/src/App.submit-confirm.test.tsx

@@ -35,7 +35,11 @@ beforeEach(() => {
   server.start();
   session = server.core.sessionCreate({
     workspace: { repoRoot: "/repo", branch: "main" },
-    artifact: { type: "plan", content: PLAN, meta: { title: "Migration Plan", planPath: "plan.md" } },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
   });
 });
 afterEach(() => {
@@ -45,16 +49,17 @@ afterEach(() => {
 });
 
 async function renderApp(options: { readOnly?: boolean } = {}) {
-  const setup = await testRender(<App home={home} sessionId={session.id} readOnly={options.readOnly ?? false} />, {
-    width: 120,
-    height: 32,
-  });
+  const setup = await testRender(
+    <App home={home} sessionId={session.id} readOnly={options.readOnly ?? false} />,
+    {
+      width: 120,
+      height: 32,
+    },
+  );
   await waitForText(setup, "cueloop");
   return setup;
 }
 
-type Setup = Awaited<ReturnType<typeof renderApp>>;
-
 /** Seed annotations directly through the daemon core (all on one block). */
 function seedAnnotations(count: number): void {
   const blocks = parseBlocks(PLAN);

package/src/App.test.tsx

@@ -9,7 +9,13 @@ import { testRender } from "@opentui/react/test-utils";
 import { DaemonServer } from "@cueloop/daemon";
 import type { ReviewSession } from "@cueloop/schema";
 import { App } from "./App";
-import { isolateUserConfig, press, typeText as type, waitForState, waitForText } from "./test-support";
+import {
+  isolateUserConfig,
+  press,
+  typeText as type,
+  waitForState,
+  waitForText,
+} from "./test-support";
 
 const PLAN = `# Migration Plan
 
@@ -35,7 +41,11 @@ beforeEach(() => {
   server.start();
   session = server.core.sessionCreate({
     workspace: { repoRoot: "/repo", branch: "main" },
-    artifact: { type: "plan", content: PLAN, meta: { title: "Migration Plan", planPath: "plan.md" } },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
   });
 });
 afterEach(() => {
@@ -138,8 +148,8 @@ describe("keyboard grammar", () => {
     // Act
     await press(setup, "x");
 
-    // Assert
-    await waitForText(setup, "[cut]");
+    // Assert - the rail shows the cut as a removal card titled CUT · me
+    await waitForText(setup, "CUT · me");
     expect(server.core.sessionGet(session.id).workingCopy).not.toContain("move the store");
 
     // Act
@@ -221,14 +231,17 @@ describe("submit", () => {
 });
 
 describe("inbox", () => {
-  test("inbox mode renders and opens a session", async () => {
+  test("inbox mode wears the review chrome (header + menu bar) and opens a session", async () => {
     // Arrange
     const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
-    await waitForText(setup, "inbox");
+    await waitForText(setup, "cueloop");
 
-    // Assert
-    expect(setup.captureCharFrame()).toContain("inbox (1 pending)");
-    expect(setup.captureCharFrame()).toContain("Migration Plan");
+    // Assert - the same header/menu chrome as review, plus the session row
+    const frame = setup.captureCharFrame();
+    expect(frame).toContain("cueloop · resume");
+    expect(frame).toContain("Migration Plan");
+    expect(frame).toContain("menu"); // the shared MenuBar sits at the bottom
+    expect(frame).not.toContain("inbox ("); // the old inline header is gone
 
     // Act
     await press(setup, "enter");
@@ -236,4 +249,28 @@ describe("inbox", () => {
     // Assert
     await waitForText(setup, "Submit review");
   });
+
+  test("the menu opens from the inbox and escape is not a trap", async () => {
+    // Arrange
+    const setup = await testRender(<App home={home} />, { width: 120, height: 32 });
+    await waitForText(setup, "cueloop · resume");
+    const lines = setup.captureCharFrame().split("\n");
+    const menuRow = lines.findIndex((line) => line.includes("menu"));
+    const menuColumn = lines[menuRow]!.indexOf("menu");
+
+    // Act - open the drop-up from the shared menu bar
+    await setup.mockMouse.click(menuColumn + 1, menuRow);
+
+    // Assert - the drop-up options appear
+    await waitForText(setup, "Keybinds");
+    expect(setup.captureCharFrame()).toContain("Settings");
+
+    // Act - escape closes the menu (not a trap), and the inbox nav still works
+    await press(setup, "escape");
+    await waitForState(setup, () => !setup.captureCharFrame().includes("Keybinds"));
+    await press(setup, "enter");
+
+    // Assert
+    await waitForText(setup, "Submit review");
+  });
 });

package/src/App.toast.test.tsx

@@ -1,6 +1,6 @@
 /** The share toast is non-modal: while it is up, escape still cancels an open overlay. */
 
-import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
+import { afterEach, beforeEach, describe, mock, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
@@ -36,7 +36,11 @@ beforeEach(() => {
   server.start();
   session = server.core.sessionCreate({
     workspace: { repoRoot: "/repo", branch: "main" },
-    artifact: { type: "plan", content: PLAN, meta: { title: "Migration Plan", planPath: "plan.md" } },
+    artifact: {
+      type: "plan",
+      content: PLAN,
+      meta: { title: "Migration Plan", planPath: "plan.md" },
+    },
   });
 });
 afterEach(() => {
@@ -48,7 +52,10 @@ afterEach(() => {
 describe("share toast", () => {
   test("escape cancels an open composer even while the toast is up", async () => {
     // Arrange
-    const setup = await testRender(<App home={home} sessionId={session.id} />, { width: 120, height: 32 });
+    const setup = await testRender(<App home={home} sessionId={session.id} />, {
+      width: 120,
+      height: 32,
+    });
     await waitForText(setup, "cueloop");
 
     // Act: share raises the toast, then open a composer under it