@cueloop/client 0.1.0-alpha.22 → 0.1.0-alpha.23

package/package.json

@@ -1,16 +1,16 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.22",
+  "version": "0.1.0-alpha.23",
   "license": "Apache-2.0",
   "type": "module",
   "exports": {
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.22",
-    "@cueloop/extension-api": "0.1.0-alpha.22",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.22",
-    "@cueloop/schema": "0.1.0-alpha.22",
+    "@cueloop/daemon": "0.1.0-alpha.23",
+    "@cueloop/extension-api": "0.1.0-alpha.23",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.23",
+    "@cueloop/schema": "0.1.0-alpha.23",
     "@opentui/core": "^0.5.1",
     "@opentui/keymap": "0.5.1",
     "@opentui/react": "^0.5.1",

package/src/App.plan-review.test.tsx

@@ -85,6 +85,25 @@ describe("share button", () => {
   });
 });
 
+describe("edit affordance", () => {
+  test("the owner sees the Edit button", async () => {
+    // Arrange / Act
+    const owner = await renderApp();
+
+    // Assert
+    expect(owner.captureCharFrame()).toContain("Edit");
+  });
+
+  test("a read-only viewer (a plan shared over ssh) never sees the Edit button", async () => {
+    // Arrange / Act
+    const viewer = await testRender(<App home={home} sessionId={session.id} readOnly />, { width: 120, height: 32 });
+    await waitForText(viewer, "cueloop");
+
+    // Assert
+    expect(viewer.captureCharFrame()).not.toContain("Edit");
+  });
+});
+
 describe("selection feeds the annotation quote", () => {
   test("v anchors, l extends, c composes with the char-precise quote", async () => {
     // Arrange

package/src/App.tsx

@@ -74,9 +74,10 @@ export function App({ home, sessionId, readOnly = false, onExit, clock, openClie
   // the plan or a verdict. `observer` is what the controller and every write
   // gate key off; the two capability flags carve out the collaborator's middle.
   const observer = readOnly || role === "observer";
-  const canEditPlan = !observer && role !== "collaborator";
-  const canSubmitVerdict = !observer && role !== "collaborator";
-  const canShare = !observer && role === "owner";
+  // Editing the plan, submitting a verdict, and sharing are all the owner's
+  // alone - a collaborator annotates, an observer only reads. One predicate
+  // feeds all three; split it the day a collaborator earns one of them.
+  const isOwner = !observer && role === "owner";
   const controller = useMemo(
     () => createReviewController({ home, sessionId, readOnly: observer, onExit, clock, openClient }),
     // eslint-disable-next-line react-hooks/exhaustive-deps
@@ -263,9 +264,9 @@ export function App({ home, sessionId, readOnly = false, onExit, clock, openClie
     const state: KeyState = {
       keys: keysRef.current,
       readOnly: observer,
-      canEditPlan,
-      canSubmitVerdict,
-      canShare,
+      canEditPlan: isOwner,
+      canSubmitVerdict: isOwner,
+      canShare: isOwner,
       overlay,
       view: !session ? "inbox" : isDiff ? "diff" : "plan",
       spanMode: mode.type === "span",
@@ -358,22 +359,23 @@ export function App({ home, sessionId, readOnly = false, onExit, clock, openClie
   };
 
   const onEditRequest = (): void => {
-    if (observer) return controller.setStatus("observer - read-only");
-    if (!canEditPlan) return controller.setStatus("shared plan - edit it in your own copy");
+    // A share viewer/observer has no Edit affordance (the button is hidden), so
+    // this is owner-only; stay silent rather than nag if it is ever reached.
+    if (!isOwner) return;
     if (resolved) return controller.setStatus("review submitted - read-only");
     runEditorHandOff();
   };
 
   // clicking the rail Share button: publish the plan, copy the ssh line
   const onShareRequest = (): void => {
-    if (!canShare) return controller.setStatus("only the plan owner can share");
+    if (!isOwner) return controller.setStatus("only the plan owner can share");
     controller.share();
   };
 
   // clicking the rail Submit button: same read-only answer as the submit key
   const onSubmitRequest = (): void => {
     if (observer) return controller.setStatus("observer - read-only");
-    if (!canSubmitVerdict) return controller.setStatus("shared view - your notes save as you go");
+    if (!isOwner) return controller.setStatus("shared view - your notes save as you go");
     if (resolved) return;
     dispatch({ type: "openSubmit" });
   };
@@ -448,7 +450,9 @@ export function App({ home, sessionId, readOnly = false, onExit, clock, openClie
             ? "walk"
             : focusedAnnotationId !== undefined
               ? "card"
-              : "normal";
+              : role === "collaborator"
+                ? "collaborator"
+                : "normal";
 
   return (
     <ThemeProvider theme={theme}>
@@ -489,6 +493,7 @@ export function App({ home, sessionId, readOnly = false, onExit, clock, openClie
               editOrphanCount={editOrphanCount}
               onLineActivate={onLineActivate}
               onEditRequest={onEditRequest}
+              canEdit={isOwner}
             />
           )}
           <ReviewPanel
@@ -511,7 +516,7 @@ export function App({ home, sessionId, readOnly = false, onExit, clock, openClie
               onSelectCard: selectCardFromRail,
               onActivateCard: openCardEdit,
               onSubmitRequest,
-              onShareRequest: canShare ? onShareRequest : undefined,
+              onShareRequest: isOwner ? onShareRequest : undefined,
             }}
           />
         </box>

package/src/components/PlanSheet.stories.tsx

@@ -6,7 +6,7 @@ import { fixtureDisplay, fixtureMarks, fixturePlanSession } from "./story-fixtur
 
 export const meta: StoryMeta = { title: "PlanSheet" };
 
-const callbacks = { onLineActivate: () => {}, onEditRequest: () => {} };
+const callbacks = { onLineActivate: () => {}, onEditRequest: () => {}, canEdit: true };
 
 export const AnnotatedPlan: Story = {
   render: () => (

package/src/components/PlanSheet.tsx

@@ -64,6 +64,8 @@ export interface PlanSheetProps {
   editOrphanCount: number;
   onLineActivate: (displayIndex: number) => void;
   onEditRequest: () => void;
+  /** Owner-only: show the Edit affordance. A share viewer never sees it. */
+  canEdit: boolean;
   theme?: Theme;
 }
 
@@ -97,6 +99,7 @@ export const PlanSheet = forwardRef<PlanSheetHandle, PlanSheetProps>(function Pl
     editOrphanCount,
     onLineActivate,
     onEditRequest,
+    canEdit,
     theme,
   }: PlanSheetProps,
   handleRef,
@@ -215,7 +218,7 @@ export const PlanSheet = forwardRef<PlanSheetHandle, PlanSheetProps>(function Pl
 
   return (
     <box style={{ flexGrow: 1, flexDirection: "column" }}>
-      <SheetHeader session={session} onEditRequest={onEditRequest} theme={theme} />
+      <SheetHeader session={session} onEditRequest={onEditRequest} canEdit={canEdit} theme={theme} />
       {editOrphanCount > 0 ? (
         <box style={{ height: 1, backgroundColor: tokens.markCommentBg, paddingLeft: 2 }}>
           <text fg={tokens.red}>
@@ -234,10 +237,12 @@ export const PlanSheet = forwardRef<PlanSheetHandle, PlanSheetProps>(function Pl
 function SheetHeader({
   session,
   onEditRequest,
+  canEdit,
   theme,
 }: {
   session: ReviewSession;
   onEditRequest: () => void;
+  canEdit: boolean;
   theme?: Theme;
 }): React.ReactNode {
   const tokens = useComponentTheme(theme);
@@ -255,11 +260,13 @@ function SheetHeader({
         ) : null}
       </text>
       <box style={{ flexGrow: 1 }} />
-      <Toolbar>
-        <Button onPress={onEditRequest} theme={theme}>
-          {" Edit "}
-        </Button>
-      </Toolbar>
+      {canEdit ? (
+        <Toolbar>
+          <Button onPress={onEditRequest} theme={theme}>
+            {" Edit "}
+          </Button>
+        </Toolbar>
+      ) : null}
     </box>
   );
 }

package/src/key-bindings.test.ts

@@ -118,6 +118,17 @@ describe("getActiveKeys-generated status hints", () => {
     expect(bindings().statusHint("read-only")).toBe("observer - read-only · j/k move · n/p annotations · q quit");
   });
 
+  test("collaborator hint annotates but shows no plan edit or submit", () => {
+    // Arrange / Act
+    const hint = bindings().statusHint("collaborator");
+
+    // Assert
+    expect(hint).toBe("j/k move · v span · drag selects · c comment · s suggest · n/p annotations · q quit");
+    expect(hint).not.toContain("cut");
+    expect(hint).not.toContain("edit");
+    expect(hint).not.toContain("submit");
+  });
+
   test("a rebound key shows its real binding in the hint", () => {
     // Arrange
     const resolver = new KeyBindings({ ...DEFAULT_KEYS, comment: ["m"] });

package/src/key-bindings.ts

@@ -24,7 +24,7 @@ export interface KeyLayerContext {
 }
 
 /** Hint templates keyed by the same view states the status line shows. */
-export type HintMode = "normal" | "card" | "span" | "compose" | "submit" | "walk" | "read-only";
+export type HintMode = "normal" | "collaborator" | "card" | "span" | "compose" | "submit" | "walk" | "read-only";
 
 type HintEntry =
   | { text: string }
@@ -43,6 +43,16 @@ const HINT_TEMPLATES: Record<HintMode, HintEntry[]> = {
     { commands: ["submit"], label: "submit" },
     { commands: ["quit"], label: "quit" },
   ],
+  // A share viewer: annotate and navigate, no plan edit / verdict submit.
+  collaborator: [
+    { commands: ["down", "up"], label: "move" },
+    { commands: ["span"], label: "span" },
+    { text: "drag selects" },
+    { commands: ["comment"], label: "comment" },
+    { commands: ["suggest"], label: "suggest" },
+    { commands: ["next_annotation", "prev_annotation"], label: "annotations" },
+    { commands: ["quit"], label: "quit" },
+  ],
   card: [
     { text: "card" },
     { commands: ["edit"], label: "edit" },

package/src/keymap.test.ts

@@ -144,13 +144,13 @@ describe("collaborator (share) capabilities", () => {
     expect(reduceKey(collab, key("e"), "edit")).toEqual([{ type: "editCard" }]);
   });
 
-  test("cannot edit the plan: cut/edit with no card is refused", () => {
+  test("cannot edit the plan: cut/edit with no card is silent (no nag, no button)", () => {
     // Arrange
     const collab = state({ canEditPlan: false, hasFocusedAnnotation: false });
 
     // Act / Assert
-    expect(reduceKey(collab, key("e"), "edit")).toEqual([{ type: "status", message: "shared plan - edit it in your own copy" }]);
-    expect(reduceKey(collab, key("c"), "cut")).toEqual([{ type: "status", message: "shared plan - edit it in your own copy" }]);
+    expect(reduceKey(collab, key("e"), "edit")).toEqual([]);
+    expect(reduceKey(collab, key("c"), "cut")).toEqual([]);
   });
 
   test("cannot submit a verdict: there is no agent on a share", () => {

package/src/keymap.ts

@@ -217,8 +217,9 @@ function planGrammar(state: KeyState, action: string | undefined, name: string):
     // the document selects, the rail edits: with a card selected, Cut deletes
     // the annotation and edit rewrites the card body in place
     if (state.hasFocusedAnnotation) return [action === "cut" ? { type: "removeAnnotation" } : { type: "editCard" }];
-    // editing the plan itself is the owner's verb - a collaborator only annotates
-    if (state.canEditPlan === false) return status("shared plan - edit it in your own copy");
+    // editing the plan itself is the owner's verb; a share viewer only annotates,
+    // and has no edit affordance, so the key is silent rather than a nag
+    if (state.canEditPlan === false) return [];
     return [{ type: action }];
   }
   return annotationCluster(state, action) ?? [];