@cueloop/client 0.1.0-alpha.18 → 0.1.0-alpha.19

package/package.json

@@ -1,16 +1,16 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.18",
+  "version": "0.1.0-alpha.19",
   "license": "Apache-2.0",
   "type": "module",
   "exports": {
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.18",
-    "@cueloop/extension-api": "0.1.0-alpha.18",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.18",
-    "@cueloop/schema": "0.1.0-alpha.18",
+    "@cueloop/daemon": "0.1.0-alpha.19",
+    "@cueloop/extension-api": "0.1.0-alpha.19",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.19",
+    "@cueloop/schema": "0.1.0-alpha.19",
     "@opentui/core": "^0.5.1",
     "@opentui/keymap": "0.5.1",
     "@opentui/react": "^0.5.1",

package/src/integrations.test.ts

@@ -0,0 +1,29 @@
+import { describe, expect, test } from "bun:test";
+import { OBSIDIAN_DEFAULTS } from "@cueloop/integration-obsidian";
+import { loadBundledExporters } from "./integrations";
+import type { IntegrationsConfig } from "./config";
+
+function integrations(overrides: Partial<typeof OBSIDIAN_DEFAULTS> = {}): IntegrationsConfig {
+  return { obsidian: { ...OBSIDIAN_DEFAULTS, ...overrides } };
+}
+
+describe("loadBundledExporters", () => {
+  test("composes the obsidian integration into one named exporter", async () => {
+    const exporters = await loadBundledExporters(integrations());
+    expect(exporters.map((exporter) => exporter.name)).toEqual(["obsidian"]);
+  });
+
+  test("runsOn mirrors the configured export policy", async () => {
+    const onApprove = (await loadBundledExporters(integrations({ exportOn: "approve" })))[0]!;
+    expect(onApprove.runsOn("approve")).toBeTrue();
+    expect(onApprove.runsOn("request_changes")).toBeFalse();
+
+    const onResolve = (await loadBundledExporters(integrations({ exportOn: "resolve" })))[0]!;
+    expect(onResolve.runsOn("approve")).toBeTrue();
+    expect(onResolve.runsOn("request_changes")).toBeTrue();
+
+    const manual = (await loadBundledExporters(integrations({ exportOn: "manual" })))[0]!;
+    expect(manual.runsOn("approve")).toBeFalse();
+    expect(manual.runsOn("request_changes")).toBeFalse();
+  });
+});

package/src/integrations.ts

@@ -0,0 +1,28 @@
+/**
+ * Bundled integration wiring: composes the configured integrations into
+ * generic exporters plus their run policy, so the session controller depends
+ * only on the extension seam, never on an integration's own config type. This
+ * and config.ts are the only client modules that name a concrete integration.
+ */
+
+import { Registry, type Exporter } from "@cueloop/extension-api";
+import { createObsidianExtension, shouldExport } from "@cueloop/integration-obsidian";
+import type { VerdictKind } from "@cueloop/schema";
+import type { IntegrationsConfig } from "./config";
+
+/** An exporter plus the policy deciding which verdicts trigger it. */
+export interface BundledExporter {
+  name: string;
+  run: Exporter;
+  runsOn(verdict: VerdictKind): boolean;
+}
+
+/** Load the bundled integrations from config as generic exporters. */
+export async function loadBundledExporters(integrations: IntegrationsConfig): Promise<BundledExporter[]> {
+  const registry = new Registry();
+  const obsidian = integrations.obsidian;
+  const record = await registry.load("obsidian", createObsidianExtension(obsidian));
+  const run = record.exporters.get("obsidian");
+  if (!run) return [];
+  return [{ name: "obsidian", run, runsOn: (verdict) => shouldExport(obsidian.exportOn, verdict) }];
+}

package/src/session-controller.ts

@@ -22,8 +22,7 @@ import {
   type ReviewSession,
   type VerdictKind,
 } from "@cueloop/schema";
-import { Registry, type Exporter } from "@cueloop/extension-api";
-import { createObsidianExtension, shouldExport, type ObsidianConfig } from "@cueloop/integration-obsidian";
+import { loadBundledExporters, type BundledExporter } from "./integrations";
 import { buildDisplay, nextWorkBlock, type DisplayBlock } from "./view-plan";
 import { diffRowAnchor, diffRows, type DiffRow } from "./view-diff";
 import { firstUnviewedIndex, walkFiles, type WalkFile } from "./walk";
@@ -141,8 +140,7 @@ class Controller implements ReviewController {
   };
   private listeners = new Set<() => void>();
   private autoClose: AutoClose = "off";
-  private obsidian: ObsidianConfig | null = null;
-  private exporters = new Map<string, Exporter>();
+  private exporters: BundledExporter[] = [];
   private readonly clock: Clock;
   private countdown: TimerHandle | undefined;
   /** Projections keyed by session identity so renders reuse one computation. */
@@ -207,11 +205,8 @@ class Controller implements ReviewController {
 
   applyConfig(config: CueloopConfig): void {
     this.autoClose = config.ui.autoClose;
-    this.obsidian = config.integrations.obsidian;
-    // bundled integrations register through the public extension API
-    const registry = new Registry();
-    void registry.load("obsidian", createObsidianExtension(config.integrations.obsidian)).then((record) => {
-      this.exporters = record.exporters;
+    void loadBundledExporters(config.integrations).then((exporters) => {
+      this.exporters = exporters;
     });
   }
 
@@ -448,11 +443,10 @@ class Controller implements ReviewController {
         // The completion overlay heading already states the verdict, so the
         // status line stays empty here - only export/error messages fill it.
         this.update({ session: resolved, status: "" });
-        // notes-vault export: guarded by config, default is manual (no-op)
-        const obsidian = this.obsidian;
-        const exporter = this.exporters.get("obsidian");
-        if (obsidian && exporter && shouldExport(obsidian.exportOn, verdict)) {
-          void exporter(resolved).then((exportResult) => {
+        // notes-vault export: guarded by each exporter's policy (default manual = no-op)
+        for (const exporter of this.exporters) {
+          if (!exporter.runsOn(verdict)) continue;
+          void exporter.run(resolved).then((exportResult) => {
             this.setStatus(exportResult.success && exportResult.path ? `exported to ${exportResult.path}` : `export failed: ${exportResult.error ?? "unknown"}`);
           });
         }