@cueloop/client 0.1.0-alpha.14 → 0.1.0-alpha.15

package/package.json

@@ -1,16 +1,16 @@
 {
   "name": "@cueloop/client",
-  "version": "0.1.0-alpha.14",
+  "version": "0.1.0-alpha.15",
   "license": "Apache-2.0",
   "type": "module",
   "exports": {
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@cueloop/daemon": "0.1.0-alpha.14",
-    "@cueloop/extension-api": "0.1.0-alpha.14",
-    "@cueloop/integration-obsidian": "0.1.0-alpha.14",
-    "@cueloop/schema": "0.1.0-alpha.14",
+    "@cueloop/daemon": "0.1.0-alpha.15",
+    "@cueloop/extension-api": "0.1.0-alpha.15",
+    "@cueloop/integration-obsidian": "0.1.0-alpha.15",
+    "@cueloop/schema": "0.1.0-alpha.15",
     "@opentui/core": "^0.5.1",
     "@opentui/keymap": "0.5.1",
     "@opentui/react": "^0.5.1",

package/src/App.autoclose.test.tsx

@@ -60,37 +60,39 @@ async function submitApprove(setup: Setup): Promise<void> {
 }
 
 describe("completion overlay", () => {
-  test("submit with auto-close off shows the prompt; ⏎ exits", async () => {
+  test("submit with auto-close off counts down from 5; ⏎ exits now", async () => {
     let exited = -1;
     const setup = await renderApp((code) => (exited = code));
     await submitApprove(setup);
-    const frame = setup.captureCharFrame();
-    expect(frame).toContain("✓ review approved");
-    expect(frame).toContain("a always close after submit");
+    const frame = await waitForText(setup, "closing in 5s");
+    expect(frame).toContain("review approved");
+    expect(frame).toContain("close [return]");
+    expect(frame).toContain("return to plan [esc]");
     await press(setup, "enter");
     expect(exited).toBe(0);
   });
 
-  test("a opts in: persists the config and starts the countdown", async () => {
+  test("a remembers the countdown as the persisted default", async () => {
     const setup = await renderApp();
     await submitApprove(setup);
+    await waitForText(setup, "closing in 5s");
     await press(setup, "a");
-    await waitForText(setup, "closing in 3s");
     expect(existsSync(configPath)).toBe(true);
-    expect(readFileSync(configPath, "utf8")).toContain("auto_close = 3");
-    // each countdown second is one manual-clock tick, not wall time
+    expect(readFileSync(configPath, "utf8")).toContain("auto_close = 5");
+    // the countdown keeps running; each second is one manual-clock tick
     clock.advance(1000);
-    await waitForText(setup, "closing in 2s");
+    await waitForText(setup, "closing in 4s");
   });
 
   test("esc dismisses to the resolved read-only view", async () => {
     const setup = await renderApp();
     await submitApprove(setup);
+    await waitForText(setup, "closing in 5s");
     // a bare ESC sits in the input parser's escape-sequence disambiguation
     // window before it is delivered - the frame wait absorbs it
     await press(setup, "escape");
     const frame = await waitForText(setup, "resolved: approve");
-    expect(frame).not.toContain("always close after submit");
+    expect(frame).not.toContain("closing in");
   });
 
   test("configured auto_close counts down and exits without interaction", async () => {

package/src/App.diff.test.tsx

@@ -72,7 +72,7 @@ describe("diff review", () => {
 
     await press(setup, "enter"); // submit
     await press(setup, "enter"); // confirm request_changes
-    await waitForText(setup, "✎ feedback sent");
+    await waitForText(setup, "feedback sent");
     const resolved = server.core.sessionGet(session.id);
     expect(resolved.verdict!.feedback).toContain("new Map()");
     expect(resolved.verdict!.feedback).toContain("Map needs an eviction story.");

package/src/App.submit-confirm.test.tsx

@@ -121,7 +121,7 @@ describe("rail submit confirm", () => {
     await setup.mockInput.typeText("Tighten the steps.");
     await press(setup, "enter");
     // the completion flow after submit is unchanged
-    await waitForText(setup, "✎ feedback sent");
+    await waitForText(setup, "feedback sent");
     const stored = server.core.sessionGet(session.id);
     expect(stored.status).toBe("resolved");
     expect(stored.verdict!.kind).toBe("request_changes");

package/src/App.test.tsx

@@ -148,13 +148,13 @@ describe("submit", () => {
     expect(setup.captureCharFrame()).toContain("[Changes]");
     await type(setup, "Expand the steps.");
     await press(setup, "enter");
-    await waitForText(setup, "✎ feedback sent");
+    await waitForText(setup, "feedback sent");
     const stored = server.core.sessionGet(session.id);
     expect(stored.status).toBe("resolved");
     expect(stored.verdict!.kind).toBe("request_changes");
     expect(stored.verdict!.feedback).toContain("Needs a phase list.");
     // submit hands the reviewer back to the agent via the completion overlay
-    expect(setup.captureCharFrame()).toContain("✎ feedback sent");
+    expect(setup.captureCharFrame()).toContain("feedback sent");
   });
 
   test("approve via ←/→ verdict cycling", async () => {

package/src/components/CompletionOverlay.tsx

@@ -33,18 +33,17 @@ export function CompletionOverlay({ verdict, completion, status, returnsTo, them
         alignItems: "center",
       }}
     >
-      <text fg={approved ? tokens.green : tokens.accent}>{approved ? "✓ review approved" : "✎ feedback sent"}</text>
+      <text fg={approved ? tokens.green : tokens.accent}>{approved ? "review approved" : "feedback sent"}</text>
       <text> </text>
       <text fg={tokens.text}>The agent has your {approved ? "approval" : "feedback"} and is unblocked.</text>
+      {returnsTo ? <text fg={tokens.textDim}>returning to {returnsTo} on close</text> : null}
       {status ? <text fg={tokens.textDim}>{status}</text> : null}
       <text> </text>
-      {completion.phase === "counting" ? (
-        <text fg={tokens.textDim}>
-          closing in {completion.remaining}s{returnsTo ? ` - returning to ${returnsTo}` : ""} · ⏎ now · esc stay
-        </text>
-      ) : (
-        <text fg={tokens.textDim}>⏎ close · a always close after submit (3s) · esc stay</text>
-      )}
+      <text fg={tokens.textDim}>
+        close [return]
+        {completion.phase === "counting" ? ` · closing in ${completion.remaining}s` : ""}
+        {" · return to plan [esc] · always [a]"}
+      </text>
     </box>
   );
 }

package/src/components/__snapshots__/stories.test.tsx.snap

@@ -262,11 +262,11 @@ exports[`stories catalog CompletionOverlay/ApprovedPrompt renders, snapshots, an
                                                                                 
                                                                                 
                                                                                 
-                               ✓ review approved                                
+                                review approved                                 
                                                                                 
                  The agent has your approval and is unblocked.                  
                                                                                 
-             ⏎ close · a always close after submit (3s) · esc stay              
+               close [return] · return to plan [esc] · always [a]               
                                                                                 
                                                                                 
                                                                                 
@@ -289,13 +289,13 @@ exports[`stories catalog CompletionOverlay/FeedbackCounting renders, snapshots,
                                                                                 
                                                                                 
                                                                                 
-                                                                                
-                                ✎ feedback sent                                 
+                                 feedback sent                                  
                                                                                 
                  The agent has your feedback and is unblocked.                  
+                      returning to agent/worker-3 on close                      
                        exported to vault/cueloop/plan.md                        
                                                                                 
-         closing in 3s - returning to agent/worker-3 · ⏎ now · esc stay         
+       close [return] · closing in 3s · return to plan [esc] · always [a]       
                                                                                 
                                                                                 
                                                                                 

package/src/keymap.test.ts

@@ -76,7 +76,7 @@ describe("completion overlay", () => {
     [prompt, "j", []],
     [counting, "return", [{ t: "finishReview" }]],
     [counting, "q", [{ t: "finishReview" }]],
-    [counting, "a", []],
+    [counting, "a", [{ t: "optInAutoClose" }]],
     [counting, "escape", [{ t: "dismissCompletion" }]],
   ];
   for (const [s, name, expected] of table) {

package/src/keymap.ts

@@ -86,7 +86,7 @@ export function reduceKey(state: KeyState, key: KeyInput, resolvedAction?: strin
   }
   if (state.overlay === "completion-prompt" || state.overlay === "completion-counting") {
     if (name === "return" || name === "enter" || name === "q") return [{ t: "finishReview" }];
-    if (name === "a" && state.overlay === "completion-prompt") return [{ t: "optInAutoClose" }];
+    if (name === "a") return [{ t: "optInAutoClose" }];
     if (name === "escape") return [{ t: "dismissCompletion" }];
     return [];
   }

package/src/session-controller.ts

@@ -30,8 +30,8 @@ import { persistAutoClose, type AutoClose, type CueloopConfig } from "./config";
 
 /**
  * Post-submit lifecycle (a review pane should hand you back to the agent,
- * not linger): idle → prompt (auto-close off: offer the choice) or
- * counting (configured delay) → exit. esc dismisses to the resolved view.
+ * not linger): idle → counting (a visible countdown, the default) → exit.
+ * esc dismisses to the resolved view; a remembers the countdown as default.
  */
 export type Completion =
   | { phase: "idle" }
@@ -39,6 +39,9 @@ export type Completion =
   | { phase: "counting"; remaining: number }
   | { phase: "dismissed" };
 
+/** Seconds the completion overlay counts down before it hands back. */
+export const DEFAULT_AUTO_CLOSE = 5;
+
 export interface ControllerSnapshot {
   session: ReviewSession | null;
   inbox: ReviewSession[] | null;
@@ -366,7 +369,9 @@ class Controller implements ReviewController {
     if (!session) return;
     this.client!.sessionResolve(session.id, verdict, summary)
       .then((resolved) => {
-        this.update({ session: resolved, status: `review submitted - ${verdict.replace("_", " ")}` });
+        // The completion overlay heading already states the verdict, so the
+        // status line stays empty here - only export/error messages fill it.
+        this.update({ session: resolved, status: "" });
         // notes-vault export: guarded by config, default is manual (no-op)
         const obsidian = this.obsidian;
         const exporter = this.exporters.get("obsidian");
@@ -375,14 +380,13 @@ class Controller implements ReviewController {
             this.setStatus(r.success && r.path ? `exported to ${r.path}` : `export failed: ${r.error ?? "unknown"}`);
           });
         }
-        // hand the reviewer back to the agent: prompt or count down per config;
-        // inside herdr with a known return pane, closing is the default
+        // Hand the reviewer back to the agent. The default is a visible
+        // countdown from DEFAULT_AUTO_CLOSE that closes on its own; esc stays,
+        // a remembers the choice. A configured delay overrides; 0 closes now.
         const delay = this.autoClose;
-        const returns = returnPaneFor(resolved.artifact.meta.herdrPane) !== undefined;
         if (delay === 0) this.finishReview();
         else if (typeof delay === "number") this.startCounting(delay);
-        else if (returns) this.startCounting(3);
-        else this.update({ completion: { phase: "prompt" } });
+        else this.startCounting(DEFAULT_AUTO_CLOSE);
       })
       .catch((e: unknown) => this.setStatus(String(e instanceof Error ? e.message : e)));
   }
@@ -407,13 +411,13 @@ class Controller implements ReviewController {
   }
 
   optInAutoClose(): void {
-    // opt in: close in 3s from now on, persisted to the user config
+    // Remember the default countdown for future submits, persisted to the user
+    // config. The countdown is already running; this only makes it the default.
     try {
-      persistAutoClose(3);
+      persistAutoClose(DEFAULT_AUTO_CLOSE);
     } catch {
       // a read-only config dir must not block closing the review
     }
-    this.autoClose = 3;
-    this.startCounting(3);
+    this.autoClose = DEFAULT_AUTO_CLOSE;
   }
 }