@cueloop/client 0.1.0-alpha.102 → 0.1.0-alpha.103

package/src/app/App.deleted-scroll.test.tsx

@@ -73,9 +73,11 @@ test("deleted file caret scrolls one row and stays at the file boundaries", asyn
     const box = findScrollbox(setup.renderer.root);
 
     if (!box) throw new Error("file diff scrollbox missing");
+
     for (let offset = 0; offset < 1000; offset += 20) {
       box.scrollTo({ x: 0, y: offset });
       await settle(setup);
+
       if (setup.captureCharFrame().includes("row 130")) break;
     }
     const target = locateText(setup, "row 130");
@@ -127,6 +129,7 @@ test("deleted file caret scrolls one row and stays at the file boundaries", asyn
         .findIndex((line) => line.includes("▎"));
 
       if (marker === box.viewport.screenY) anchored = true;
+
       if (anchored && box.scrollTop > 0) expect(marker).toBe(box.viewport.screenY);
     }
     expect(anchored).toBe(true);

package/src/app/App.harness-settings.test.tsx

@@ -0,0 +1,77 @@
+import { expect, test } from "bun:test";
+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { DaemonServer } from "@cueloop/daemon";
+import type { ThreadAgentState } from "@cueloop/schema";
+import { App } from "./App";
+import {
+  clickText,
+  isolateUserConfig,
+  isolatedUserConfigPath,
+  renderReadyApp,
+  waitForText,
+  waitForTextGone,
+} from "../testing/test-support";
+
+test("repeated harness toggle failures show feedback without losing the controller binding", async () => {
+  const home = mkdtempSync(join(tmpdir(), "cueloop-harness-settings-"));
+  const restore = isolateUserConfig(home);
+  const server = new DaemonServer({ home, idleExitMs: 0 });
+
+  writeFileSync(isolatedUserConfigPath(home), "[experimental]\nthread_agent = true\n");
+  server.start();
+  const thread = server.core.sessionCreate({
+    workspace: { repoRoot: home, branch: "main" },
+    artifact: { type: "plan", content: "# Switching review", meta: { title: "Switching review" } },
+  });
+  const state: ThreadAgentState = {
+    threadId: thread.id,
+    phase: { kind: "idle" },
+    messages: [],
+    comments: [],
+    tools: [],
+  };
+  let switches = 0;
+  const setup = await renderReadyApp(
+    <App
+      home={home}
+      sessionId={thread.id}
+      agentClient={{
+        agentGet: async () => state,
+        agentPrompt: async () => state,
+        agentCancel: async () => state,
+        agentComment: async () => state,
+        agentPermission: async () => state,
+        agentConfigure: async (params) => {
+          if (!params.configId) return state;
+
+          switches++;
+          throw new Error(`Switch failure ${switches}`);
+        },
+      }}
+    />,
+    { width: 120, height: 32 },
+  );
+
+  try {
+    await setup.mockMouse.click(1, 0);
+    await waitForText(setup, "settings");
+    await clickText(setup, "settings");
+    await waitForText(setup, "General");
+    await clickText(setup, "Thread ");
+    await waitForText(setup, "Harness");
+    await clickText(setup, "Harness");
+    await waitForText(setup, "Switch failure 1");
+    await waitForTextGone(setup, "Switch failure 1");
+    await clickText(setup, "Harness");
+    await waitForText(setup, "Switch failure 2");
+    expect(switches).toBe(2);
+  } finally {
+    setup.renderer.destroy();
+    server.stop();
+    restore();
+    rmSync(home, { recursive: true, force: true });
+  }
+});

package/src/app/App.plan-render.test.tsx

@@ -91,6 +91,7 @@ function foregroundsOf(setup: Setup, needle: string): string[] {
   for (const line of setup.captureSpans().lines) {
     for (const span of line.spans) {
       if (span.fg === undefined || !span.text.includes(needle)) continue;
+
       const [red, green, blue] = span.fg.toInts();
 
       foregrounds.push(
@@ -109,6 +110,7 @@ function backgroundsOf(setup: Setup, needle: string): string[] {
   for (const line of setup.captureSpans().lines) {
     for (const span of line.spans) {
       if (!span.text.includes(needle)) continue;
+
       const [red, green, blue] = span.bg.toInts();
 
       backgrounds.push(

package/src/app/App.plan-review.test.tsx

@@ -84,6 +84,7 @@ function backgroundsOf(setup: Setup, needle: string): string[] {
   for (const line of setup.captureSpans().lines) {
     for (const span of line.spans) {
       if (!span.text.includes(needle)) continue;
+
       const [red, green, blue] = span.bg.toInts();
 
       backgrounds.push(

package/src/app/App.test.tsx

@@ -78,6 +78,7 @@ function foregroundsOf(setup: Setup, needle: string): string[] {
   for (const line of setup.captureSpans().lines) {
     for (const span of line.spans) {
       if (!span.text.includes(needle)) continue;
+
       const [red, green, blue] = span.fg.toInts();
 
       foregrounds.push(

package/src/app/App.tsx

@@ -1,3 +1,4 @@
+import { useThreadHarnessSetting } from "../settings/use-thread-harness-setting";
 import React, {
   useCallback,
   useEffect,
@@ -203,6 +204,7 @@ export function quitKeyHandled(
   onExit?: (code: number) => void,
 ): boolean {
   if (!key.ctrl || key.name !== "q") return false;
+
   onExit?.(0);
 
   return true;
@@ -214,6 +216,7 @@ function menuModalHandled(
   key: { name: string },
 ): boolean {
   if (menuControl.openMenuId === null) return false;
+
   if (key.name === "escape") menuControl.closeMenu();
 
   return true;
@@ -300,7 +303,9 @@ function chooseThreadBody(choice: {
   threadView: React.ReactNode;
 }): React.ReactNode {
   if (choice.isPixelPrototype) return choice.prototype;
+
   if (choice.isDiff) return choice.diffPlaceholder;
+
   if (choice.editingBody) return choice.editor;
 
   return choice.threadView;
@@ -453,16 +458,19 @@ export function threadsNavHandled(params: {
   const { focusedPane, quiet, key, count } = params;
 
   if (focusedPane !== "threads" || !quiet || count === 0) return false;
+
   if (key.name === "j" || key.name === "down") {
     params.setInboxCursor((cursor) => Math.min(cursor + 1, count - 1));
 
     return true;
   }
+
   if (key.name === "k" || key.name === "up") {
     params.setInboxCursor((cursor) => Math.max(cursor - 1, 0));
 
     return true;
   }
+
   if (key.name === "return" || key.name === "enter") {
     params.openSession();
 
@@ -490,8 +498,11 @@ export function visiblePanes(
   const panes: FocusPane[] = [];
 
   if (sidebarOpen) panes.push("threads");
+
   if (threadShown) panes.push("thread");
+
   if (changesOpen) panes.push("changes");
+
   if (projectOpen) panes.push("project");
 
   return panes;
@@ -503,6 +514,7 @@ export function nextFocusPane(
   backward: boolean,
 ): FocusPane {
   if (panes.length === 0) return current;
+
   const index = panes.indexOf(current);
   const step = backward ? -1 : 1;
 
@@ -617,6 +629,7 @@ export function App({
 
       if (next.has(id)) next.delete(id);
       else next.add(id);
+
       persistPins([...next]);
 
       return next;
@@ -688,6 +701,7 @@ export function App({
 
     setPrototypePixels(config.experimental.prototypePixels);
     setThreadAgentEnabled(config.experimental.threadAgent);
+    setThreadHarness(config.thread.harness);
     keysRef.current = config.keys;
     keyBindings.setKeys(config.keys);
     setTheme(composeTheme(config.ui.theme, config.themeOverrides, appearance));
@@ -714,6 +728,7 @@ export function App({
 
   useEffect(() => {
     if (!toast) return;
+
     const timer = setTimeout(() => controller.dismissToast(), TOAST_DISMISS_MS);
 
     return () => clearTimeout(timer);
@@ -725,6 +740,7 @@ export function App({
 
   useEffect(() => {
     if (promptedSelfRef.current || role !== "collaborator" || !selfAuthor || !session) return;
+
     promptedSelfRef.current = true;
     const known = session.participants?.find((participant) => participant.id === selfAuthor)?.name;
 
@@ -747,13 +763,31 @@ export function App({
 
     void resolveGithubIdentity().then((github) => {
       if (identityGenerationRef.current !== generation) return;
+
       if (!github) return controller.setStatus("GitHub not connected - run gh auth login");
+
       const name = github.name?.trim() || github.login;
 
       applyIdentity({ name, provider: "github" });
     });
   };
 
+  const [agentState, setAgentState] = useState<import("@cueloop/schema").ThreadAgentState>();
+  const [threadHarness, setThreadHarness] = useState<"pi" | "fx">("pi");
+
+  const harnessSetting = useThreadHarnessSetting({
+    home,
+    thread: session,
+    enabled: threadAgentEnabled,
+    owner: isOwner,
+    state: agentState,
+    preferred: threadHarness,
+    client: agentClient,
+    onState: setAgentState,
+    onPreferred: setThreadHarness,
+    onError: (message) => controller.setStatus(message),
+  });
+
   // ── settings dialog: config-backed model, navigation, persistence ──
   const {
     settingsNav,
@@ -787,6 +821,9 @@ export function App({
     reviewSkill,
     reviewWorkspace,
     setReviewWorkspace,
+    canSwitchHarness: harnessSetting.enabled,
+    threadHarness: harnessSetting.harness,
+    onSwitchHarness: harnessSetting.switchHarness,
   });
 
   // ── derived view model ──────────────────────
@@ -843,7 +880,6 @@ export function App({
     () => undefined,
   );
   const agentInvoke = useRef<((commentId?: string) => void) | undefined>(undefined);
-  const [agentState, setAgentState] = useState<import("@cueloop/schema").ThreadAgentState>();
   const [prototypeComposing, setPrototypeComposing] = useState(false);
   const [welcomeComposing, setWelcomeComposing] = useState(false);
   // inline body edit: the markdown editor owns the thread pane and all keys while open
@@ -868,9 +904,11 @@ export function App({
 
   const openCardEdit = (annotationId: string): void => {
     if (observer) return controller.setStatus("observer - read-only");
+
     const annotation = session?.annotations.find((candidate) => candidate.id === annotationId);
 
     if (!annotation) return;
+
     // a collaborator's note is theirs to word: activating it (click or e) renames
     // the author rather than editing the body the planner does not own
     if (annotation.author) {
@@ -882,7 +920,9 @@ export function App({
         text: authorNames[annotation.author] ?? "",
       });
     }
+
     if (resolved) return controller.setStatus("review submitted - read-only");
+
     liveInput.current = annotation.body;
     setMode({ type: "railEdit", id: annotation.id, text: annotation.body });
   };
@@ -894,6 +934,7 @@ export function App({
 
       return;
     }
+
     renderer?.suspend();
     try {
       controller.edit();
@@ -949,6 +990,7 @@ export function App({
     },
     openShareDialog: () => {
       if (!isOwner) return controller.setStatus("only the plan owner can share");
+
       shareDialogStore.getState().reset();
       setShareDialogOpen(true);
     },
@@ -974,6 +1016,7 @@ export function App({
   useEffect(() => {
     // the bare shell drives its panes from its own workbench, so only reconcile against this one
     if (!session) return;
+
     const next = reconciledFocus(navigablePanes, focusedPane);
 
     if (next) setFocusedPane(next);
@@ -995,6 +1038,7 @@ export function App({
     });
 
     if (!intent) return false;
+
     if (intent.type === "cut" && selection) {
       controller.cut(
         selection.start.blockIndex,
@@ -1010,9 +1054,11 @@ export function App({
   const openThread = (id: string): void => {
     // save the open editor into the leaving thread's working copy before the switch, so a click away never drops edits
     if (bodyEditing.editing) bodyEditing.requestExit();
+
     const index = grouped.ordered.findIndex((thread) => thread.id === id);
 
     if (index >= 0) setInboxCursor(() => index);
+
     controller.open(id);
   };
 
@@ -1038,7 +1084,9 @@ export function App({
       !key.super
     )
       return true;
+
     if (!threadViewActive || threadViewSuspended) return false;
+
     if (!threadComposing) {
       const chord = resolveSessionChord(key, { isOwner, resolved });
 
@@ -1050,14 +1098,19 @@ export function App({
 
   useKeyboard((key) => {
     if (quitKeyHandled(key, onExit)) return;
+
     // the inline body editor owns the pane and every key while open
     if (bodyEditing.editing) return;
+
     // the share dialog owns its own keys while open; the shell grammar stands down
     if (shareDialogOpen) return;
+
     if (menuModalHandled(menuControl, key)) return;
+
     if (paneCycleRequested(key, overlay, menuOwnsKeyboard, threadComposing)) {
       return cyclePanes(Boolean(key.shift));
     }
+
     if (
       threadsNavHandled({
         focusedPane,
@@ -1069,17 +1122,24 @@ export function App({
       })
     )
       return;
+
     if (threadSurfaceHandledKey(key)) return;
+
     // A compose textarea owns the keyboard while open: let it receive the typed note instead of the
     // global keymap acting on each letter (the prototype, and the bare-shell welcome playground).
     if (prototypeComposing || welcomeComposing) return;
+
     if (menuDialog === "settings") return void handleSettingsKey(key.name);
+
     if (menuDialog) return void (key.name === "escape" && setMenuDialog(null));
+
     // the toast is non-modal: escape only dismisses it when nothing else owns
     // escape, so an open overlay (compose, submit, prompt, walk) still cancels
     if (toastDismissRequested(toast !== null, key, overlay, mode.type === "span"))
       return controller.dismissToast();
+
     if (bareShellDefersKeys(session === null, overlay === "none", focusedPane)) return;
+
     const state = buildKeyState({
       keys: keysRef.current,
       observer,
@@ -1136,6 +1196,7 @@ export function App({
 
   // ── render ──────────────────────────────────
   if (error) return <ErrorScreen error={error} theme={theme} />;
+
   if (!session)
     return inbox ? (
       <SlashSkillsContext.Provider value={skills}>
@@ -1229,15 +1290,20 @@ export function App({
     // A share viewer/observer has no Edit affordance (the button is hidden), so
     // this is owner-only; stay silent rather than nag if it is ever reached.
     if (!isOwner) return;
+
     if (resolved) return controller.setStatus("review submitted - read-only");
+
     openBodyEditor();
   };
 
   // clicking the rail Submit button: same read-only answer as the submit key
   const onSubmitRequest = (): void => {
     if (observer) return controller.setStatus("observer - read-only");
+
     if (!isOwner) return controller.setStatus("shared view - your notes save as you go");
+
     if (resolved) return;
+
     dispatch({ type: "openSubmit" });
   };
 

package/src/app/App.visual.test.tsx

@@ -32,6 +32,7 @@ function hasSpanColor(
   for (const line of setup.captureSpans().lines) {
     for (const span of line.spans) {
       if (!span.text.includes(needle) || !span.fg) continue;
+
       const [red, green, blue] = span.fg.toInts();
 
       if (red === color[0] && green === color[1] && blue === color[2]) return true;

package/src/app/App.walk.test.tsx

@@ -88,6 +88,7 @@ function foregroundsOf(setup: Setup, needle: string): string[] {
   for (const line of setup.captureSpans().lines) {
     for (const span of line.spans) {
       if (!span.text.includes(needle)) continue;
+
       const [red, green, blue] = span.fg.toInts();
 
       foregrounds.push(

package/src/app/App.workbench.test.tsx

@@ -244,6 +244,7 @@ describe("the four-pane workbench", () => {
     for (const [index, direction] of Array.from({ length: 500 }, () => "down" as const).entries()) {
       // eslint-disable-next-line no-await-in-loop
       await setup.mockMouse.scroll(75, 10, direction);
+
       if (index % 25 === 0) {
         // eslint-disable-next-line no-await-in-loop
         await setup.waitForVisualIdle();

package/src/app/app-screens.tsx

@@ -395,6 +395,7 @@ export function NoThreadShell(props: {
             message={confirming ? `Delete "${confirming.title}"? This removes the thread.` : ""}
             onConfirm={() => {
               if (confirming) controller.deleteSession(confirming.sessionId);
+
               setMode({ type: "normal" });
             }}
             onCancel={() => setMode({ type: "normal" })}

package/src/app/app-view-model.ts

@@ -49,8 +49,11 @@ export function resolveOverlay(
   walking: boolean,
 ): KeyState["overlay"] {
   if (mode.type === "compose" || mode.type === "railEdit") return "compose";
+
   if (mode.type === "submit") return "submit";
+
   if (mode.type === "confirmDelete") return "confirm";
+
   if (
     mode.type === "rename" ||
     mode.type === "renameThread" ||
@@ -58,9 +61,13 @@ export function resolveOverlay(
     mode.type === "treePrompt"
   )
     return "prompt";
+
   if (mode.type === "spanActions") return "spanActions";
+
   if (completionPhase === "prompt") return "completion-prompt";
+
   if (completionPhase === "counting") return "completion-counting";
+
   if (walking) return "walk";
 
   return "none";

package/src/app/components/WorkspacePanels.tsx

@@ -53,6 +53,7 @@ export function WorkspacePanels(props: {
 
   useKeyboard((key) => {
     if (!props.focused || (key.name !== "[" && key.name !== "]")) return;
+
     const choices = [null, ...views];
     const current = selected ? views.indexOf(selected) + 1 : 0;
     const step = key.name === "]" ? 1 : -1;

package/src/app/intent-dispatch.test.ts

@@ -194,6 +194,7 @@ describe("move", () => {
     const advance = setCursor.mock.calls[0]![0];
 
     if (!isUpdater(advance)) throw new Error("expected setCursor to receive an updater");
+
     expect(advance(2)).toBe(2); // already at the end, stays
     expect(advance(0)).toBe(1);
   });

package/src/app/intent-dispatch.ts

@@ -125,7 +125,9 @@ function isLandableRow(rows: DiffRow[], index: number): boolean {
   const row = rows[index];
 
   if (isCodeRow(row)) return true;
+
   if (row?.kind !== "file") return false;
+
   const next = rows[index + 1];
 
   return next === undefined || next.kind === "file";
@@ -138,6 +140,7 @@ function nextCodeRowIndex(rows: DiffRow[], from: number, to: IntentOfType<"move"
 
     return from;
   }
+
   if (to === "bottom") {
     for (let index = rows.length - 1; index >= 0; index--) {
       if (isLandableRow(rows, index)) return index;
@@ -145,6 +148,7 @@ function nextCodeRowIndex(rows: DiffRow[], from: number, to: IntentOfType<"move"
 
     return from;
   }
+
   const step = to === "down" ? 1 : -1;
 
   for (let index = from + step; index >= 0 && index < rows.length; index += step) {
@@ -160,6 +164,7 @@ function handleMove(intent: IntentOfType<"move">, deps: IntentDispatchDeps): voi
 
     return;
   }
+
   const navigableCount = deps.display.length;
 
   if (intent.to === "down") deps.setCursor((current) => Math.min(navigableCount - 1, current + 1));
@@ -206,6 +211,7 @@ function handleOpenRename(_intent: IntentOfType<"openRename">, deps: IntentDispa
 
     return;
   }
+
   deps.setMode({
     type: "rename",
     authorId: focused.author,
@@ -225,6 +231,7 @@ function handleConfirmDialog(
   else if (mode.type === "nameSelf") controller.setSelfName(mode.text.trim());
   else if (mode.type === "renameSelf") deps.setLocalIdentityName(mode.text.trim());
   else if (mode.type === "treePrompt") confirmTreePrompt(mode, deps);
+
   deps.setMode({ type: "normal" });
 }
 
@@ -232,6 +239,7 @@ function handleStartSpan(_intent: IntentOfType<"startSpan">, deps: IntentDispatc
   const block = deps.display[deps.cursor];
 
   if (!block?.work) return;
+
   const span = startSpan(deps.cursor, displayText(block));
 
   if (span) deps.setMode({ type: "span", span });
@@ -301,6 +309,7 @@ function handlePickSpanAction(
   const { mode, session, controller } = deps;
 
   if (mode.type !== "spanActions") return;
+
   const action = deps.quickActions[intent.index ?? mode.index];
 
   if (session && action) {
@@ -315,6 +324,7 @@ function handlePickSpanAction(
 
     if (annotationId) deps.setFocusedAnnotationId(annotationId);
   }
+
   deps.setMode({ type: "normal" });
 }
 
@@ -322,6 +332,7 @@ function handleOpenCompose(intent: IntentOfType<"openCompose">, deps: IntentDisp
   const { mode } = deps;
 
   deps.liveInput.current = "";
+
   if (intent.from === "span" && mode.type === "span") {
     deps.setMode({
       type: "compose",
@@ -362,6 +373,7 @@ function handleOpenSubmit(_intent: IntentOfType<"openSubmit">, deps: IntentDispa
   const { session } = deps;
 
   if (!session) return;
+
   deps.liveInput.current = "";
   deps.setMode({ type: "submit", message: deps.defaultMessage, summary: "" });
 }
@@ -387,6 +399,7 @@ function handleFoldFile(_intent: IntentOfType<"foldFile">, deps: IntentDispatchD
   const file = deps.rows[deps.cursor]?.file;
 
   if (!file || deps.controller.isFileCollapsed(file)) return;
+
   deps.controller.setFileCollapsed(file, true);
   // the file band is unchanged in index by its own collapse, so land the cursor on it
   const headerIndex = deps.controller
@@ -400,6 +413,7 @@ function handleUnfoldFile(_intent: IntentOfType<"unfoldFile">, deps: IntentDispa
   const file = deps.rows[deps.cursor]?.file;
 
   if (!file || !deps.controller.isFileCollapsed(file)) return;
+
   deps.controller.setFileCollapsed(file, false);
   // drop the cursor onto the file's first code line now that its body is back
   const firstCode = deps.controller.rows().findIndex((row) => row.file === file && isCodeRow(row));
@@ -423,6 +437,7 @@ function handleRestoreCuration(
   const items = deps.controller.curationItems();
 
   if (!items.length) return;
+
   const targetId = deps.selectedCurationId ?? items[items.length - 1]!.id;
 
   deps.controller.restoreCuration(targetId);
@@ -447,6 +462,7 @@ function handleAnnotationCycle(
   );
 
   if (!annotations.length) return;
+
   const focusedIndex = annotations.findIndex(
     (annotation) => annotation.id === deps.focusedAnnotationId,
   );
@@ -500,11 +516,14 @@ function handleSaveCompose(_intent: IntentOfType<"saveCompose">, deps: IntentDis
 
   if (mode.type === "railEdit") {
     if (session && body) controller.updateAnnotation(mode.id, body);
+
     deps.setMode({ type: "normal" });
 
     return;
   }
+
   if (mode.type !== "compose") return;
+
   if (session && body) {
     const annotationId = controller.annotate(
       mode.kind,
@@ -516,6 +535,7 @@ function handleSaveCompose(_intent: IntentOfType<"saveCompose">, deps: IntentDis
 
     if (annotationId) deps.setFocusedAnnotationId(annotationId);
   }
+
   deps.setMode({ type: "normal" });
 }
 
@@ -526,6 +546,7 @@ function handleSubmitMessage(
   const { mode } = deps;
 
   if (mode.type === "submit") deps.controller.submit(mode.message, deps.liveInput.current);
+
   deps.setMode({ type: "normal" });
 }
 
@@ -533,6 +554,7 @@ function handleCycleMessage(intent: IntentOfType<"cycleMessage">, deps: IntentDi
   const { mode } = deps;
 
   if (mode.type !== "submit") return;
+
   const messageIndex =
     (MESSAGE_OUTCOMES.indexOf(mode.message) + intent.direction + MESSAGE_OUTCOMES.length) %
     MESSAGE_OUTCOMES.length;
@@ -582,6 +604,7 @@ function handleTreeMove(intent: IntentOfType<"treeMove">, deps: IntentDispatchDe
   const rows = deps.controller.treeRows();
 
   if (rows.length === 0) return;
+
   const current = selectedTreeIndex(deps, rows);
   const next = Math.min(rows.length - 1, Math.max(0, current + intent.direction));
 
@@ -593,9 +616,12 @@ function handleTreeGo(_intent: IntentOfType<"treeGo">, deps: IntentDispatchDeps)
   const row = rows[selectedTreeIndex(deps, rows)];
 
   if (!row) return deps.controller.setStatus("select an entry in the tree first");
+
   if (row.isCurrentTip) return deps.controller.setStatus("already at the tip");
+
   // a switch needs no summary; a move back may leave one, so it asks
   if (row.tips.length > 0) return deps.controller.goToEntry(row.entryId);
+
   deps.setMode({ type: "treePrompt", ask: "navigate", entryId: row.entryId, text: "" });
 }