@cueloop/client 0.1.0-alpha.10 → 0.1.0-alpha.101

package/src/app/App.appearance.test.tsx

@@ -0,0 +1,53 @@
+/** The App renders in a light virtual terminal: passing appearance="light" threads the light branded theme through the provider without breaking the mount (the char frame is color-blind, so this covers propagation and wiring, not the pixel colors). */
+
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { DaemonServer } from "@cueloop/daemon";
+import type { Thread } from "@cueloop/schema";
+import { App } from "./App";
+import { isolateUserConfig, settle, waitForText, renderReadyApp } from "../testing/test-support";
+
+const PLAN = "# Sync Plan\n\n## Steps\n\n- flush the queue\n";
+
+let home: string;
+let server: DaemonServer;
+let session: Thread;
+let restoreUserConfig: () => void;
+
+beforeEach(() => {
+  home = mkdtempSync(join(tmpdir(), "cueloop-appearance-"));
+  restoreUserConfig = isolateUserConfig(home);
+  server = new DaemonServer({ home, idleExitMs: 0 });
+  server.start();
+  session = server.core.sessionCreate({
+    workspace: { repoRoot: "/repo", branch: "main" },
+    artifact: { type: "plan", content: PLAN, meta: { title: "Sync Plan", planPath: "plan.md" } },
+  });
+});
+afterEach(() => {
+  restoreUserConfig();
+  server.stop();
+  rmSync(home, { recursive: true, force: true });
+});
+
+describe("appearance", () => {
+  test("renders the review on a light terminal", async () => {
+    // Arrange + Act
+    const setup = await renderReadyApp(
+      <App home={home} sessionId={session.id} appearance="light" />,
+      {
+        width: 120,
+        height: 32,
+      },
+    );
+
+    // Assert
+    await waitForText(setup, "cueloop");
+    await waitForText(setup, "Sync Plan");
+    await settle(setup);
+    expect(setup.captureCharFrame()).toContain("flush the queue");
+  });
+});

package/src/{App.autoclose.test.tsx → app/App.autoclose.test.tsx}

@@ -1,4 +1,4 @@
-/** Post-submit completion overlay: prompt, opt-in persistence, countdown, dismissal. */
+/** Post-submit completion overlay: prompt, opt-in persistence, countdown, dismissal. Countdown seconds tick on an injected ManualClock, so tests advance time instead of waiting it out. */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
@@ -6,113 +6,139 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 import React from "react";
 import { testRender } from "@opentui/react/test-utils";
+import { ManualClock } from "@opentui/core/testing";
 import { DaemonServer } from "@cueloop/daemon";
-import type { ReviewSession } from "@cueloop/schema";
+import type { Thread } from "@cueloop/schema";
 import { App } from "./App";
+import { isolateUserConfig, press, settle, waitForText, pressKey } from "../testing/test-support";
 
 const PLAN = "# Plan\n\nShip the thing.\n";
 
 let home: string;
 let server: DaemonServer;
-let session: ReviewSession;
+let session: Thread;
 let configPath: string;
+let restoreUserConfig: () => void;
+let clock: ManualClock;
 
 beforeEach(() => {
   home = mkdtempSync(join(tmpdir(), "cueloop-close-"));
   configPath = join(home, "config.toml");
-  process.env.CUELOOP_CONFIG = configPath;
+  restoreUserConfig = isolateUserConfig(home, "config.toml");
   server = new DaemonServer({ home, idleExitMs: 0 });
   server.start();
   session = server.core.sessionCreate({
     workspace: { repoRoot: "/repo", branch: "main" },
     artifact: { type: "plan", content: PLAN, meta: { title: "Plan" } },
   });
+  clock = new ManualClock();
 });
 afterEach(() => {
-  delete process.env.CUELOOP_CONFIG;
+  restoreUserConfig();
   server.stop();
   rmSync(home, { recursive: true, force: true });
 });
 
 async function renderApp(onExit?: (code: number) => void) {
-  const setup = await testRender(<App home={home} sessionId={session.id} onExit={onExit} />, {
-    width: 120,
-    height: 30,
-  });
-  for (let i = 0; i < 40 && !setup.captureCharFrame().includes("cueloop"); i++) {
-    await Bun.sleep(25);
-    await setup.renderOnce();
-  }
+  const setup = await testRender(
+    <App home={home} sessionId={session.id} onExit={onExit} clock={clock} />,
+    {
+      width: 120,
+      height: 30,
+    },
+  );
+
+  await waitForText(setup, "cueloop");
+
   return setup;
 }
 
 type Setup = Awaited<ReturnType<typeof renderApp>>;
-async function press(setup: Setup, k: string): Promise<void> {
-  if (k === "enter") setup.mockInput.pressKey("RETURN");
-  else if (k === "escape") setup.mockInput.pressKey("ESCAPE");
-  else await setup.mockInput.typeText(k);
-  await Bun.sleep(15);
-  await setup.renderOnce();
-}
 
 async function submitApprove(setup: Setup): Promise<void> {
-  await press(setup, "enter"); // open submit (approve default: no pending items)
-  await press(setup, "enter"); // confirm
-  const deadline = Date.now() + 10_000;
-  while (Date.now() < deadline && !setup.captureCharFrame().includes("review approved")) {
-    await Bun.sleep(25);
-    await setup.renderOnce();
-  }
+  await pressKey(setup, "RETURN", { meta: true }); // open submit (approve default: no pending items)
+  await pressKey(setup, "RETURN", { meta: true }); // confirm
+  await waitForText(setup, "review approved");
 }
 
 describe("completion overlay", () => {
-  test("submit with auto-close off shows the prompt; ⏎ exits", async () => {
+  test("submit with auto-close off counts down from 5; ⏎ exits now", async () => {
+    // Arrange
     let exited = -1;
     const setup = await renderApp((code) => (exited = code));
+
+    // Act
     await submitApprove(setup);
-    const frame = setup.captureCharFrame();
-    expect(frame).toContain("✓ review approved");
-    expect(frame).toContain("a always close after submit");
+
+    // Assert
+    const frame = await waitForText(setup, "closing in 5s");
+
+    expect(frame).toContain("review approved");
+    expect(frame).toContain("close");
+    expect(frame).toContain("back to plan");
+
+    // Act
     await press(setup, "enter");
+
+    // Assert
     expect(exited).toBe(0);
   });
 
-  test("a opts in: persists the config and starts the countdown", async () => {
+  test("a remembers the countdown as the persisted default", async () => {
+    // Arrange
     const setup = await renderApp();
+
     await submitApprove(setup);
+    await waitForText(setup, "closing in 5s");
+
+    // Act
     await press(setup, "a");
-    expect(setup.captureCharFrame()).toContain("closing in 3s");
+
+    // Assert
     expect(existsSync(configPath)).toBe(true);
-    expect(readFileSync(configPath, "utf8")).toContain("auto_close = 3");
+    expect(readFileSync(configPath, "utf8")).toContain("auto_close = 5");
+
+    // Act
+    // the countdown keeps running; each second is one manual-clock tick
+    clock.advance(1000);
+
+    // Assert
+    await waitForText(setup, "closing in 4s");
   });
 
   test("esc dismisses to the resolved read-only view", async () => {
+    // Arrange
     const setup = await renderApp();
+
     await submitApprove(setup);
-    await press(setup, "escape");
+    await waitForText(setup, "closing in 5s");
+
+    // Act
     // a bare ESC sits in the input parser's escape-sequence disambiguation
-    // window before it is delivered - poll for the dismissal
-    const deadline = Date.now() + 5_000;
-    while (Date.now() < deadline && !setup.captureCharFrame().includes("resolved: approve")) {
-      await Bun.sleep(50);
-      await setup.renderOnce();
-    }
-    const frame = setup.captureCharFrame();
-    expect(frame).toContain("resolved: approve");
-    expect(frame).not.toContain("always close after submit");
+    // window before it is delivered - the frame wait absorbs it
+    await press(setup, "escape");
+
+    // Assert - the countdown is cancelled and we are back in the (resolved) thread view
+    const frame = await waitForText(setup, "Ship the thing");
+
+    expect(frame).not.toContain("closing in");
   });
 
   test("configured auto_close counts down and exits without interaction", async () => {
+    // Arrange
     writeFileSync(configPath, "[ui]\nauto_close = 1\n");
     let exited = -1;
     const setup = await renderApp((code) => (exited = code));
+
     await submitApprove(setup);
-    expect(setup.captureCharFrame()).toContain("closing in 1s");
-    const deadline = Date.now() + 10_000;
-    while (Date.now() < deadline && exited === -1) {
-      await Bun.sleep(100);
-      await setup.renderOnce();
-    }
+    await waitForText(setup, "closing in 1s");
+    expect(exited).toBe(-1);
+
+    // Act
+    clock.advance(1000);
+    await settle(setup);
+
+    // Assert
     expect(exited).toBe(0);
-  }, 20_000);
+  });
 });

package/src/app/App.deleted-scroll.test.tsx

@@ -0,0 +1,187 @@
+/** Keyboard scrolling in a changed-file tab uses caret navigation, even when the file was deleted. */
+
+import { expect, test } from "bun:test";
+import { mkdtempSync, rmSync, unlinkSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { ScrollBoxRenderable, type Renderable } from "@opentui/core";
+import { DaemonServer } from "@cueloop/daemon";
+import { App } from "./App";
+import { annotationPaletteFor } from "../annotations/annotation-palette";
+import { DARK } from "../appearance/theme";
+import {
+  isolateUserConfig,
+  locateText,
+  press,
+  renderReadyApp,
+  settle,
+  waitForText,
+} from "../testing/test-support";
+
+function findScrollbox(node: Renderable): ScrollBoxRenderable | null {
+  if (node.id === "diff-scroll" && node instanceof ScrollBoxRenderable) return node;
+
+  for (const child of node.getChildren()) {
+    const found = findScrollbox(child);
+
+    if (found) return found;
+  }
+
+  return null;
+}
+
+function hex(color: { toInts(): [number, number, number, number] }): string {
+  const [red, green, blue] = color.toInts();
+
+  return "#" + [red, green, blue].map((part) => part.toString(16).padStart(2, "0")).join("");
+}
+
+test("deleted file caret scrolls one row and stays at the file boundaries", async () => {
+  const home = mkdtempSync(join(tmpdir(), "cueloop-scroll-home-"));
+  const repo = mkdtempSync(join(tmpdir(), "cueloop-scroll-repo-"));
+  const restoreConfig = isolateUserConfig(home);
+  const server = new DaemonServer({ home, idleExitMs: 0 });
+  let setup: Awaited<ReturnType<typeof renderReadyApp>> | undefined;
+
+  try {
+    const file = join(repo, "long.md");
+    const lines = Array.from({ length: 180 }, (_, index) =>
+      index === 113
+        ? "[nodejs/node#36005](https://github.com/nodejs/node/issues/36005)."
+        : `row ${String(index).padStart(3, "0")} ${"a paragraph with wrapped text and a link [source](https://example.test/page) ".repeat((index % 3) + 1)}`,
+    );
+    const git = (args: string[]) => Bun.spawnSync(["git", "-C", repo, ...args]);
+
+    writeFileSync(file, lines.join("\n") + "\n");
+    git(["init", "-q"]);
+    git(["config", "user.email", "fixture@example.com"]);
+    git(["config", "user.name", "Fixture"]);
+    git(["add", "-A"]);
+    git(["commit", "-q", "-m", "seed"]);
+    unlinkSync(file);
+    server.start();
+    setup = await renderReadyApp(<App home={home} sessionId={undefined} cwd={repo} />, {
+      width: 180,
+      height: 48,
+    });
+    await waitForText(setup, "long.md");
+    const treeFile = locateText(setup, "long.md");
+
+    await setup.mockMouse.click(treeFile.column, treeFile.row);
+    await waitForText(setup, "row 00");
+    const box = findScrollbox(setup.renderer.root);
+
+    if (!box) throw new Error("file diff scrollbox missing");
+    for (let offset = 0; offset < 1000; offset += 20) {
+      box.scrollTo({ x: 0, y: offset });
+      await settle(setup);
+      if (setup.captureCharFrame().includes("row 130")) break;
+    }
+    const target = locateText(setup, "row 130");
+
+    await setup.mockMouse.click(target.column, target.row);
+    await press(setup, "escape");
+
+    const steps: number[] = [];
+    const caretCell = annotationPaletteFor(DARK).caretCell;
+    const frameTrace: Array<{ markers: number[]; caret: number }> = [];
+    const captureFrame = () => {
+      const lines = setup!.captureCharFrame().split("\n");
+      const markers = lines.flatMap((line, row) => (line.includes("▎") ? [row] : []));
+      const caret = setup!
+        .captureSpans()
+        .lines.findIndex((line) => line.spans.some((span) => hex(span.bg) === caretCell));
+
+      frameTrace.push({ markers, caret });
+    };
+
+    setup.renderer.on("frame", captureFrame);
+
+    for (let index = 0; index < 12; index++) {
+      const before = box.scrollTop;
+
+      await press(setup, "down");
+      steps.push(box.scrollTop - before);
+      const caretRow = setup
+        .captureSpans()
+        .lines.findIndex((line) => line.spans.some((span) => hex(span.bg) === caretCell));
+      const markerRows = setup
+        .captureCharFrame()
+        .split("\n")
+        .flatMap((line, row) => (line.includes("▎") ? [row] : []));
+
+      expect(caretRow).toBeGreaterThanOrEqual(0);
+      expect(markerRows).toEqual([caretRow]);
+    }
+
+    expect(Math.max(...steps)).toBeLessThanOrEqual(1);
+    expect(Math.min(...steps)).toBeGreaterThanOrEqual(0);
+    let anchored = false;
+
+    for (let index = 0; index < 80; index++) {
+      await press(setup, "up");
+      const marker = setup
+        .captureCharFrame()
+        .split("\n")
+        .findIndex((line) => line.includes("▎"));
+
+      if (marker === box.viewport.screenY) anchored = true;
+      if (anchored && box.scrollTop > 0) expect(marker).toBe(box.viewport.screenY);
+    }
+    expect(anchored).toBe(true);
+    box.scrollTo({ x: 0, y: 100000 });
+    await settle(setup);
+    const last = locateText(setup, "row 179");
+
+    await setup.mockMouse.click(last.column, last.row);
+    await press(setup, "escape");
+    let lastMarker = -1;
+
+    for (let index = 0; index < 12; index++) {
+      const traceStart = frameTrace.length;
+      const before = box.scrollTop;
+
+      await press(setup, "down");
+      const states = frameTrace.slice(traceStart);
+
+      expect(box.scrollTop).toBe(before);
+      expect(states.length).toBeGreaterThan(0);
+      for (const state of states) {
+        expect(state.markers).toEqual([state.caret]);
+        expect(state.caret).toBeGreaterThanOrEqual(lastMarker);
+        lastMarker = state.caret;
+      }
+    }
+    box.scrollTo({ x: 0, y: 0 });
+    await settle(setup);
+    const first = locateText(setup, "row 000");
+
+    await setup.mockMouse.click(first.column, first.row);
+    await press(setup, "escape");
+    let firstMarker = Number.POSITIVE_INFINITY;
+
+    for (let index = 0; index < 12; index++) {
+      const traceStart = frameTrace.length;
+      const before = box.scrollTop;
+
+      await press(setup, "up");
+      const states = frameTrace.slice(traceStart);
+
+      expect(box.scrollTop).toBe(before);
+      expect(states.length).toBeGreaterThan(0);
+      for (const state of states) {
+        expect(state.markers).toEqual([state.caret]);
+        expect(state.caret).toBeLessThanOrEqual(firstMarker);
+        firstMarker = state.caret;
+      }
+    }
+    setup.renderer.off("frame", captureFrame);
+  } finally {
+    setup?.renderer.destroy();
+    server.stop();
+    restoreConfig();
+    rmSync(home, { recursive: true, force: true });
+    rmSync(repo, { recursive: true, force: true });
+  }
+}, 30000);