@cubejs-backend/server-core 0.24.1 → 0.24.2

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.24.2](https://github.com/cube-js/cube.js/compare/v0.24.1...v0.24.2) (2020-11-27)
+
+
+### Bug Fixes
+
+* **@cubejs-backend/server-core:** Allow to pass unknown options (such as http) ([f1e9402](https://github.com/cube-js/cube.js/commit/f1e9402ee5c1fa6695d44f8750602d0a2ccedd5f))
+
+
+### Features
+
+* **@cubejs-backend/query-orchestrator:** Initial move to TypeScript ([#1462](https://github.com/cube-js/cube.js/issues/1462)) ([101e8dc](https://github.com/cube-js/cube.js/commit/101e8dc90d4b1266c0327adb86cab3e3caa8d4d0))
+
+
+
+
+
 ## [0.24.1](https://github.com/cube-js/cube.js/compare/v0.24.0...v0.24.1) (2020-11-27)
 
 **Note:** Version bump only for package @cubejs-backend/server-core

package/core/OrchestratorApi.js

@@ -1,7 +1,6 @@
 /* eslint-disable no-throw-literal */
 const pt = require('promise-timeout');
-const QueryOrchestrator = require('@cubejs-backend/query-orchestrator/orchestrator/QueryOrchestrator');
-const ContinueWaitError = require('@cubejs-backend/query-orchestrator/orchestrator/ContinueWaitError');
+const { QueryOrchestrator, ContinueWaitError } = require('@cubejs-backend/query-orchestrator');
 
 class OrchestratorApi {
   constructor(driverFactory, logger, options) {

package/core/index.test.js

@@ -26,13 +26,6 @@ describe('index.test', () => {
       .toThrowError(/"dbType" must be one of/);
   });
 
-  test('Should throw error, unknown options property', () => {
-    const options = { dbType: 'mysql', unknown: 'some-value' };
-
-    expect(() => { new CubejsServerCore(options); })
-      .toThrowError(/"unknown" is not allowed/);
-  });
-
   test('Should throw error, invalid options', () => {
     const options = {
       dbType: 'mysql',

package/core/optionsValidate.js

@@ -72,6 +72,12 @@ const schemaOptions = Joi.object().keys({
 });
 
 module.exports = (options) => {
-  const { error } = Joi.validate(options, schemaOptions, { abortEarly: false });
-  if (error) throw new Error(`Invalid cube-server-core options: ${error.message || error.toString()}`);
+  const { error } = Joi.validate(options, schemaOptions, {
+    abortEarly: false,
+    // http configuration from server is not a part of server-core, we dont needed to get an error
+    allowUnknown: true,
+  });
+  if (error) {
+    throw new Error(`Invalid cube-server-core options: ${error.message || error.toString()}`);
+  }
 };

package/package.json

@@ -2,7 +2,7 @@
   "name": "@cubejs-backend/server-core",
   "description": "Cube.js base component to wire all backend components together",
   "author": "Cube Dev, Inc.",
-  "version": "0.24.1",
+  "version": "0.24.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/cube-js/cube.js.git",
@@ -26,7 +26,7 @@
   },
   "dependencies": {
     "@cubejs-backend/api-gateway": "^0.24.0",
-    "@cubejs-backend/query-orchestrator": "^0.24.0",
+    "@cubejs-backend/query-orchestrator": "^0.24.2",
     "@cubejs-backend/schema-compiler": "^0.24.1",
     "@hapi/joi": "^15.1.1",
     "codesandbox-import-utils": "^2.1.12",
@@ -49,6 +49,7 @@
     "uuid": "^3.3.3"
   },
   "devDependencies": {
+    "@types/hapi__joi": "^15.0.4",
     "eslint": "^6.8.0",
     "eslint-config-airbnb-base": "^13.1.0",
     "eslint-plugin-import": "^2.16.0",
@@ -58,5 +59,5 @@
     "should": "^13.2.3"
   },
   "license": "Apache-2.0",
-  "gitHead": "0479050307f08ca69f4fdaee2d08d3e4f39453e6"
+  "gitHead": "20a2c50c07d1b7602c0958fd3d5a69f310a415f1"
 }