@cubejs-backend/oracle-driver 0.31.63 → 0.31.65

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.31.65](https://github.com/cube-js/cube.js/compare/v0.31.64...v0.31.65) (2023-02-23)
+
+
+### Bug Fixes
+
+* **oracle-driver:**  Release connection after query execution ([#5469](https://github.com/cube-js/cube.js/issues/5469)) ([ff1af78](https://github.com/cube-js/cube.js/commit/ff1af789c6326e25b3a341c4bae1829da95c36c1))
+
+
+
+
+
 ## [0.31.63](https://github.com/cube-js/cube.js/compare/v0.31.62...v0.31.63) (2023-02-20)
 
 **Note:** Version bump only for package @cubejs-backend/oracle-driver

package/driver/OracleDriver.js

@@ -69,7 +69,7 @@ class OracleDriver extends BaseDriver {
     this.db.partRows = 100000;
     this.db.maxRows = 100000;
     this.db.prefetchRows = 500;
-    this.config = config || {
+    this.config = {
       user: getEnv('dbUser', { dataSource }),
       password: getEnv('dbPass', { dataSource }),
       db: getEnv('dbName', { dataSource }),
@@ -80,11 +80,9 @@ class OracleDriver extends BaseDriver {
         config.maxPoolSize ||
         getEnv('dbMaxPoolSize', { dataSource }) ||
         50,
+      ...config
     };
-
-    if (!this.config.connectionString) {
-      this.config.connectionString = `${this.config.host}/${this.config.db}`
-    }
+    this.config.connectionString = this.config.connectionString || `${this.config.host}:${this.config.port}/${this.config.db}`;
   }
 
   async tablesSchema() {
@@ -113,22 +111,28 @@ class OracleDriver extends BaseDriver {
     if (!this.pool) {
       this.pool = await this.db.createPool(this.config);
     }
+
     return this.pool.getConnection()
   }
 
   async testConnection() {
-    return (
-      await this.getConnectionFromPool()
-    ).execute('SELECT 1 FROM DUAL');
+    await this.query('SELECT 1 FROM DUAL', {});
   }
 
   async query(query, values) {
     const conn = await this.getConnectionFromPool();
+
     try {
       const res = await conn.execute(query, values || {});
       return res && res.rows;
     } catch (e) {
       throw (e);
+    } finally {
+      try {
+        await conn.close();
+      } catch (e) {
+        throw e;
+      }
     }
   }
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "@cubejs-backend/oracle-driver",
   "description": "Cube.js oracle database driver",
   "author": "Trikoz I.",
-  "version": "0.31.63",
+  "version": "0.31.65",
   "repository": {
     "type": "git",
     "url": "https://github.com/cube-js/cube.js.git",
@@ -13,7 +13,7 @@
   },
   "main": "driver/OracleDriver.js",
   "dependencies": {
-    "@cubejs-backend/base-driver": "^0.31.63",
+    "@cubejs-backend/base-driver": "^0.31.65",
     "ramda": "^0.27.0"
   },
   "optionalDependencies": {
@@ -23,5 +23,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "30a19b5f0ef293048561783d614c77b6e3f3d231"
+  "gitHead": "2572ea30accf8e84e2dec7da7916da171cbca1ba"
 }