@ctrl-spc/cs 0.7.7 → 0.7.8

package/dist/workflows.js

@@ -1,4 +1,53 @@
 import { absolutePathToken } from './local-paths.js';
+import { listSteps } from './steps.js';
+import { assertAgentToolMentions, toolMentions, validateToolMentions } from './workflow-tool-mentions.js';
+export { WORKFLOW_TOOL_TEACHING, assertAgentToolMentions } from './workflow-tool-mentions.js';
+/** Resolve permission from the current stage's saved document, never agent
+ * prose or a supplied boolean. Both harnesses use the same stage resolver. */
+export async function workflowToolPermission(client, workItemId, tool, instance) {
+    if (!workItemId) {
+        if (instance)
+            throw new Error('A workflow tool mention requires its work item. Nothing was written.');
+        return null;
+    }
+    const { data: next, error } = await client.rpc('cliv2_steps_up_next', { p_work_item_id: workItemId });
+    if (error)
+        throw new Error(`Could not read the active workflow stage: ${error.message}`);
+    let stageId = next?.stage_id;
+    // Up-next has no runnable step when a stage is blocked. Its permissions
+    // still apply while the agent creates or revises the work needed to unblock it.
+    if (!stageId) {
+        const spine = await listSteps(client, workItemId);
+        stageId = spine.stages.find(stage => !stage.steps.length || stage.steps.some(step => step.status !== 'done'))?.id;
+    }
+    if (!stageId) {
+        if (instance)
+            throw new Error('There is no active workflow stage for this mention. Nothing was written.');
+        return null;
+    }
+    const stages = await read(client.from('cliv2_stages').select('source_ref, source_workflow_ref')
+        .eq('id', stageId).eq('work_item_id', workItemId), 'the active workflow stage');
+    const stage = stages[0];
+    if (!stage?.source_ref || !stage.source_workflow_ref) {
+        if (instance)
+            throw new Error('The current stage does not own that workflow tool mention. Nothing was written.');
+        return null;
+    }
+    const documents = await read(client.from('cliv2_workflow_stages').select('body').eq('id', stage.source_ref), 'the workflow stage document');
+    if (!documents[0])
+        throw new Error('The active workflow stage document is unavailable. Nothing was written.');
+    validateToolMentions(documents[0].body);
+    const mentions = toolMentions(documents[0].body);
+    if (!instance && !mentions.some(mention => mention.tool === tool))
+        return null;
+    if (!instance)
+        throw new Error('Pass workflow_tool_instance from the current stage for this use of the tool. Read the stage document; do not omit its approval setting.');
+    const matching = mentions.filter(mention => mention.id === instance);
+    if (matching.length !== 1 || matching[0].tool !== tool) {
+        throw new Error('This tool instance is missing, duplicated, belongs to another tool, or is outside the current stage. Nothing was written.');
+    }
+    return matching[0];
+}
 async function read(query, subject) {
     const { data, error } = await query;
     if (error)
@@ -91,6 +140,7 @@ export async function readWorkflow(client, workflowId) {
 export async function buildWorkflow(client, input) {
     const prose = [['name', input.name], ['description', input.description]];
     input.stages.forEach((stage, i) => {
+        assertAgentToolMentions(stage.body);
         prose.push([`stage ${i + 1} name`, stage.name], [`stage ${i + 1} description`, stage.description], [`stage ${i + 1} body`, stage.body]);
     });
     input.exits.forEach((exit, i) => prose.push([`exit ${i + 1} condition`, exit.condition]));
@@ -147,6 +197,15 @@ export async function rewordStage(client, input) {
                 + 'repo-relative. Nothing was written.');
         }
     }
+    if (input.body !== undefined) {
+        const previous = await read(client.from('cliv2_workflow_stages').select('body').eq('id', input.stageId), 'the saved stage permissions');
+        if (!previous[0])
+            throw new Error('The stage is unavailable. Nothing was written.');
+        if (toolMentions(previous[0].body).length && input.body !== previous[0].body) {
+            throw new Error('Only the user can change a stage containing tool permissions. Ask them to edit it in Workflows.');
+        }
+        assertAgentToolMentions(input.body, previous[0].body);
+    }
     const patch = {};
     if (input.name !== undefined)
         patch.name = input.name;
@@ -194,6 +253,7 @@ export async function editWorkflow(client, input) {
     input.stages.forEach((stage, i) => {
         if ('stage_id' in stage)
             return;
+        assertAgentToolMentions(stage.body);
         prose.push([`stage ${i + 1} name`, stage.name], [`stage ${i + 1} description`, stage.description], [`stage ${i + 1} body`, stage.body]);
     });
     input.exits.forEach((exit, i) => prose.push([`exit ${i + 1} condition`, exit.condition]));
@@ -254,3 +314,42 @@ export async function duplicateWorkflow(client, input) {
     }
     return data;
 }
+/** A stage grant is scoped to its work item and project, even when a planning
+ * action creates or organizes another item in that same project. */
+export async function validateWorkflowToolTarget(client, workItemId, tool, args) {
+    const targetId = args.work_item_id ?? args.task_id ?? (tool === 'update_task' ? args.id : undefined);
+    if (tool === 'create_artifact' || tool === 'attach_screenshot' || tool === 'record_context_exploration'
+        || tool === 'present_mocks' || tool === 'present_wireframes' || tool === 'propose_scope_change') {
+        if (targetId && targetId !== workItemId)
+            throw new Error('The tool mention belongs to the current workflow work item. Nothing was written.');
+    }
+    if (tool === 'update_artifact') {
+        const artifacts = await read(client.from('artifacts').select('task_id')
+            .eq('id', args.artifact_id ?? args.id), 'the artifact work item');
+        if (artifacts.length !== 1 || artifacts[0].task_id !== workItemId)
+            throw new Error('This artifact is outside the workflow work item. Nothing was written.');
+    }
+    if (tool === 'create_step') {
+        const stages = await read(client.from('cliv2_stages').select('work_item_id')
+            .eq('id', args.stage_id), 'the execution stage');
+        if (stages.length !== 1 || stages[0].work_item_id !== workItemId)
+            throw new Error('This execution stage is outside the workflow work item. Nothing was written.');
+    }
+    if (tool === 'resolve_feedback') {
+        const ids = args.feedback_ids;
+        const feedback = await read(client.from('artifact_feedback').select('id, task_id')
+            .in('id', ids), 'the feedback work items');
+        if (new Set(feedback.map(row => row.id)).size !== new Set(ids).size || feedback.some(row => row.task_id !== workItemId)) {
+            throw new Error('Feedback is missing or outside the workflow work item. Nothing was written.');
+        }
+    }
+    if (args.project_id || (targetId && targetId !== workItemId)) {
+        const items = await read(client.from('tasks').select('id, project_id')
+            .in('id', [...new Set([workItemId, ...(targetId ? [String(targetId)] : [])])]), 'the workflow project');
+        const source = items.find(item => item.id === workItemId);
+        if (!source || (args.project_id && args.project_id !== source.project_id)
+            || (targetId && !items.some(item => item.id === targetId && item.project_id === source.project_id))) {
+            throw new Error('This action is outside the workflow project. Nothing was written.');
+        }
+    }
+}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ctrl-spc/cs",
-  "version": "0.7.7",
-  "description": "CTRL+SPC \u2014 minimal, reliable per-machine agent presence. Sign-in, auto-start, agent detection, heartbeat presence, and ping acknowledgement.",
+  "version": "0.7.8",
+  "description": "CTRL+SPC — minimal, reliable per-machine agent presence. Sign-in, auto-start, agent detection, heartbeat presence, and ping acknowledgement.",
   "engines": {
     "node": ">=22"
   },