@cto.af/eslint-config 4.0.2 → 4.1.2

package/ava.js

@@ -3,12 +3,12 @@
 const {rules} = require('./rules/ava.js');
 module.exports = [{
   files: [
-    'test/**.test.*',
-    'test/**.ava.*',
-    'test/**.spec.*',
-    'ava/**.test.*',
-    'ava/**.ava.*',
-    'ava/**.spec.*',
+    '**/test/**.test.*',
+    '**/test/**.ava.*',
+    '**/test/**.spec.*',
+    '**/ava/**.test.*',
+    '**/ava/**.ava.*',
+    '**/ava/**.spec.*',
   ],
   plugins: {
     ava: require('eslint-plugin-ava'),

package/eslint.config.mjs

@@ -0,0 +1,33 @@
+import all from './all.js';
+import ava from 'eslint-plugin-ava';
+import jsdoc from 'eslint-plugin-jsdoc';
+import meta from '@cto.af/eslint-plugin-meta';
+import n from 'eslint-plugin-n';
+import {plugin} from 'typescript-eslint';
+import stylistic from '@stylistic/eslint-plugin';
+
+export default [
+  {
+    ignores: [
+      'test/**',
+    ],
+  },
+  ...all,
+  {
+    files: [
+      'rules/*.js',
+    ],
+    settings: {
+      meta: {
+        libs: {
+          ava,
+          jsdoc,
+          n,
+          '@stylistic': stylistic,
+          '@typescript-eslint': plugin,
+        },
+      },
+    },
+    ...meta.configs.all,
+  },
+];

package/mocha.js

@@ -0,0 +1,36 @@
+'use strict';
+
+const globals = require('globals');
+const mocha = require('eslint-plugin-mocha');
+
+module.exports = [{
+  files: [
+    'test/**/*.spec.js',
+    'test/**/*.spec.ts',
+    'test/**/*.spec.cjs',
+    'test/**/*.spec.mjs',
+    'tests/**/*.spec.js',
+    'tests/**/*.spec.ts',
+    'tests/**/*.spec.cjs',
+    'tests/**/*.spec.mjs',
+    'test/**/*.test.js',
+    'test/**/*.test.ts',
+    'test/**/*.test.cjs',
+    'test/**/*.test.mjs',
+    'tests/**/*.test.js',
+    'tests/**/*.test.ts',
+    'tests/**/*.test.cjs',
+    'tests/**/*.test.mjs',
+
+  ],
+  languageOptions: {
+    globals: globals.mocha,
+  },
+  plugins: {
+    mocha,
+  },
+  rules: {
+    ...mocha.configs.recommended.rules,
+    'mocha/no-mocha-arrows': 'off',
+  },
+}];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cto.af/eslint-config",
-  "version": "4.0.2",
+  "version": "4.1.2",
   "description": "hildjj's lint rules",
   "main": "index.js",
   "scripts": {
@@ -15,22 +15,31 @@
   "license": "MIT",
   "repository": "cto-af/eslint-config",
   "dependencies": {
-    "@stylistic/eslint-plugin": "1.7.0",
-    "eslint-plugin-n": "16.6.2",
-    "globals": "15.0.0"
+    "@stylistic/eslint-plugin": "2.3.0",
+    "eslint-plugin-n": "17.9.0",
+    "globals": "15.6.0"
   },
   "devDependencies": {
-    "@hildjj/sort-rules": "link:sort-rules",
-    "eslint": "^8.57.0",
-    "eslint-find-rules": "^4.1.0",
-    "eslint-plugin-ava": "^14.0.0",
-    "eslint-plugin-jsdoc": "^48.2.2",
-    "eslint-plugin-markdown": "^4.0.1",
-    "npm-check-updates": "^16.14.18",
-    "typescript": "^5.4.3",
-    "typescript-eslint": "^7.5.0"
+    "@cto.af/eslint-plugin-meta": "github:cto-af/eslint-plugin-meta",
+    "eslint": "^9.5.0",
+    "eslint-plugin-ava": "^15.0.1",
+    "eslint-plugin-jsdoc": "^48.5.0",
+    "eslint-plugin-markdown": "^5.0.0",
+    "eslint-plugin-mocha": "10.4.3",
+    "typescript": "5.5.2",
+    "typescript-eslint": "^8.0.0-alpha.34"
   },
-  "packageManager": "pnpm@8.15.6",
+  "overrides": {
+    "@typescript-eslint/utils": "8.0.0-alpha.34",
+    "@typescript-eslint/parser": "8.0.0-alpha.34"
+  },
+  "pnpm": {
+    "overrides": {
+      "@typescript-eslint/utils": "8.0.0-alpha.34",
+      "@typescript-eslint/parser": "8.0.0-alpha.34"
+    }
+  },
+  "packageManager": "pnpm@9.4.0",
   "engines": {
     "node": ">=18"
   }

package/rules/ava.js

@@ -1,9 +1,9 @@
 'use strict';
 
+/* eslint meta/no-unused-rules: ["error", {ignore: ["n"]}] */
+
 module.exports = {
   rules: {
-    // Check: ava
-
     // [ava](https://github.com/avajs/eslint-plugin-ava?tab=readme-ov-file#rules)
     'ava/assertion-arguments': 'error',
     'ava/hooks-order': 'error',

package/rules/js.js

@@ -2,8 +2,6 @@
 
 module.exports = {
   rules: {
-    // Check: @, @stylistic, n
-
     // [Possible Problems](https://eslint.org/docs/rules/#possible-problems)
     'array-callback-return': ['error', {allowImplicit: true}],
     'constructor-super': 'error',
@@ -38,7 +36,6 @@ module.exports = {
     'no-loss-of-precision': 'error',
     'no-misleading-character-class': 'error',
     'no-new-native-nonconstructor': 'error',
-    'no-new-symbol': 'error',
     'no-obj-calls': 'error',
     'no-promise-executor-return': 'error',
     'no-prototype-builtins': 'error',
@@ -67,6 +64,9 @@ module.exports = {
       },
     ],
     'no-use-before-define': 'error',
+    // Doesn't account for try blocks
+    // See https://github.com/eslint/eslint/issues/17579
+    'no-useless-assignment': 'off',
     'no-useless-backreference': 'error',
     'require-atomic-updates': 'error',
     'use-isnan': 'error',
@@ -102,7 +102,6 @@ module.exports = {
     'id-length': 'off', // Not needed
     'id-match': 'off', // Not needed
     'init-declarations': 'error',
-    'line-comment-position': 'off', // I'm all over the place on these
     'logical-assignment-operators': 'off', // No.
     'max-classes-per-file': 'off', // No.
     'max-depth': 'off', // No.
@@ -111,7 +110,6 @@ module.exports = {
     'max-nested-callbacks': 'off', // No.
     'max-params': ['error', 4],
     'max-statements': 'off', // No.
-    'multiline-comment-style': ['error', 'separate-lines'],
     'new-cap': 'error',
     'no-alert': 'error',
     'no-array-constructor': 'error',
@@ -259,7 +257,7 @@ module.exports = {
     '@stylistic/jsx-curly-spacing': 'off', // Not needed
     '@stylistic/jsx-equals-spacing': 'off', // Not needed
     '@stylistic/jsx-first-prop-new-line': 'off', // Not needed
-    '@stylistic/jsx-indent': 'off', // Not needed
+    '@stylistic/jsx-function-call-newline': 'off', // Not needed
     '@stylistic/jsx-indent-props': 'off', // Not needed
     '@stylistic/jsx-max-props-per-line': 'off', // Not needed
     '@stylistic/jsx-newline': 'off', // Not needed
@@ -274,6 +272,7 @@ module.exports = {
 
     '@stylistic/key-spacing': 'error',
     '@stylistic/keyword-spacing': 'error',
+    '@stylistic/line-comment-position': 'off', // Too hard to change
     '@stylistic/linebreak-style': 'error',
     '@stylistic/lines-around-comment': ['error', {
       allowArrayStart: true,
@@ -295,6 +294,7 @@ module.exports = {
     }],
     '@stylistic/max-statements-per-line': 'off',
     '@stylistic/member-delimiter-style': 'off',
+    '@stylistic/multiline-comment-style': 'off', // Not important
     '@stylistic/multiline-ternary': ['error', 'always-multiline'],
     '@stylistic/new-parens': 'error',
     '@stylistic/newline-per-chained-call': 'error',
@@ -359,7 +359,6 @@ module.exports = {
     'n/no-unsupported-features/es-syntax': 'error',
     'n/no-unsupported-features/node-builtins': 'error',
     'n/process-exit-as-throw': 'error',
-    'n/shebang': 'off', // This always seems to be wrong
 
     // [Best Practices](https://github.com/eslint-community/eslint-plugin-n#best-practices)
     'n/no-deprecated-api': 'error',
@@ -370,21 +369,20 @@ module.exports = {
     // Doesn't work for `import 'regenerator-runtime/runtime'`
     'n/file-extension-in-import': 'error',
     'n/global-require': 'off',
+    'n/hashbang': 'off', // Try turning this on sometime
     'n/no-mixed-requires': 'error',
-    // No
-    'n/no-process-env': 'off',
+    'n/no-process-env': 'off', // No
     'n/no-restricted-import': 'off',
     'n/no-restricted-require': 'off',
     'n/no-sync': 'off',
-
     'n/prefer-global/buffer': ['error', 'never'],
-    // Hopefully only used in tests and cli
-    'n/prefer-global/console': 'off',
+    'n/prefer-global/console': 'off', // Hopefully only used in tests and cli
     'n/prefer-global/process': 'off',
     'n/prefer-global/text-decoder': ['error', 'always'],
     'n/prefer-global/text-encoder': ['error', 'always'],
     'n/prefer-global/url': ['error', 'always'],
     'n/prefer-global/url-search-params': ['error', 'always'],
+    'n/prefer-node-protocol': 'error', // Turn off when needed
     // Not yet
     'n/prefer-promises/dns': 'off',
     'n/prefer-promises/fs': 'off',

package/rules/ts.js

@@ -1,56 +1,24 @@
-/* eslint-disable capitalized-comments */
 'use strict';
 
+const {builtinRules} = require('eslint/use-at-your-own-risk');
+const ts = require('typescript-eslint');
+
+const originalDisabled = {};
+builtinRules.forEach((_, r) => {
+  if (ts.plugin.rules[r]) {
+    originalDisabled[r] = 'off';
+  }
+});
+
+/* eslint meta/no-unused-rules: ["error", {ignore: ["@stylistic"]}] */
+
 module.exports = {
   rules: {
-    // Check: @typescript-eslint
+    // [original disabled for extension](https://typescript-eslint.io/rules/?=extension#extension-rules)
+    ...originalDisabled,
 
     // [@typescript-eslint/eslint-recommended](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/eslint-recommended-raw.ts)
-    'constructor-super': 'off', // ts(2335) & ts(2377)
-    'getter-return': 'off', // ts(2378)
-    'no-const-assign': 'off', // ts(2588)
-    'no-dupe-args': 'off', // ts(2300)
-    'no-dupe-class-members': 'off', // ts(2393) & ts(2300)
-    'no-dupe-keys': 'off', // ts(1117)
-    'no-func-assign': 'off', // ts(2630)
-    'no-import-assign': 'off', // ts(2632) & ts(2540)
-    'no-new-symbol': 'off', // ts(7009)
-    'no-obj-calls': 'off', // ts(2349)
-    'no-redeclare': 'off', // ts(2451)
-    'no-setter-return': 'off', // ts(2408)
-    'no-this-before-super': 'off', // ts(2376) & ts(17009)
-    'no-undef': 'off', // ts(2304) & ts(2552)
-    'no-unreachable': 'off', // ts(7027)
-    'no-unsafe-negation': 'off', // ts(2365) & ts(2322) & ts(2358)
-    'no-var': 'error', // ts transpiles let/const to var, so no need for vars any more
-    'prefer-const': 'error', // ts provides better types with const
-    'prefer-rest-params': 'error', // ts provides better types with rest args over arguments
-    'prefer-spread': 'error', // ts transpiles spread to apply, so no need for manual apply
-
-    // [original disabled for extension](https://typescript-eslint.io/rules/?=extension#extension-rules)
-    'class-methods-use-this': 'off',
-    'consistent-return': 'off',
-    'default-param-last': 'off',
-    'dot-notation': 'off',
-    'init-declarations': 'off',
-    'max-params': 'off',
-    'no-array-constructor': 'off',
-    // 'no-dupe-class-members': 'off',
-    'no-empty-function': 'off',
-    'no-implied-eval': 'off',
-    'no-invalid-this': 'off',
-    'no-loop-func': 'off',
-    'no-loss-of-precision': 'off',
-    // 'no-magic-numbers': 'off',
-    'no-shadow': 'off',
-    'no-throw-literal': 'off',
-    'no-unused-expressions': 'off',
-    'no-unused-vars': 'off',
-    'no-use-before-define': 'off',
-    'no-useless-constructor': 'off',
-    'prefer-destructuring': 'off',
-    'prefer-promise-reject-errors': 'off',
-    'require-await': 'off',
+    ...ts.configs.eslintRecommended.rules,
 
     // [typescript-eslint](https://typescript-eslint.io/rules/)
     '@typescript-eslint/adjacent-overload-signatures': 'error',
@@ -58,9 +26,12 @@ module.exports = {
     '@typescript-eslint/await-thenable': 'off', // Can't config
     '@typescript-eslint/ban-ts-comment': ['error', {
       'ts-expect-error': 'allow-with-description',
+      'ts-ignore': true,
+      'ts-nocheck': true,
+      'ts-check': false,
+      'minimumDescriptionLength': 3,
     }],
     '@typescript-eslint/ban-tslint-comment': 'error',
-    '@typescript-eslint/ban-types': 'off', // Not needed
     '@typescript-eslint/class-literal-property-style': ['error', 'getters'],
     '@typescript-eslint/class-methods-use-this': 'error',
     '@typescript-eslint/consistent-generic-constructors': [
@@ -101,7 +72,7 @@ module.exports = {
     '@typescript-eslint/no-duplicate-type-constituents': 'error',
     '@typescript-eslint/no-dynamic-delete': 'error',
     '@typescript-eslint/no-empty-function': 'error',
-    '@typescript-eslint/no-empty-interface': 'error',
+    '@typescript-eslint/no-empty-object-type': 'error',
     '@typescript-eslint/no-explicit-any': 'off', // Too hard
     '@typescript-eslint/no-extra-non-null-assertion': 'error',
     '@typescript-eslint/no-extraneous-class': 'error',
@@ -113,7 +84,6 @@ module.exports = {
     '@typescript-eslint/no-invalid-this': 'error',
     '@typescript-eslint/no-invalid-void-type': 'error',
     '@typescript-eslint/no-loop-func': 'error',
-    '@typescript-eslint/no-loss-of-precision': 'error',
     '@typescript-eslint/no-magic-numbers': 'off', // Too late
     '@typescript-eslint/no-meaningless-void-operator': 'off', // Can't config
     '@typescript-eslint/no-misused-new': 'error',
@@ -127,19 +97,23 @@ module.exports = {
     '@typescript-eslint/no-redundant-type-constituents': 'off', // Can't config
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/no-restricted-imports': 'off', // Not needed
+    '@typescript-eslint/no-restricted-types': 'off', // Not needed
     '@typescript-eslint/no-shadow': 'error',
     '@typescript-eslint/no-this-alias': 'error',
     '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off', // Can't config
     '@typescript-eslint/no-unnecessary-condition': 'off', // Can't config
     '@typescript-eslint/no-unnecessary-qualifier': 'off', // Can't config
+    '@typescript-eslint/no-unnecessary-template-expression': 'error',
     '@typescript-eslint/no-unnecessary-type-arguments': 'off', // Can't config
     '@typescript-eslint/no-unnecessary-type-assertion': 'off', // Can't config
     '@typescript-eslint/no-unnecessary-type-constraint': 'error',
+    '@typescript-eslint/no-unnecessary-type-parameters': 'error', // Warning: preliminary
     '@typescript-eslint/no-unsafe-argument': 'off', // Can't config
     '@typescript-eslint/no-unsafe-assignment': 'off', // Can't config
     '@typescript-eslint/no-unsafe-call': 'off', // Can't config
     '@typescript-eslint/no-unsafe-declaration-merging': 'error',
     '@typescript-eslint/no-unsafe-enum-comparison': 'error',
+    '@typescript-eslint/no-unsafe-function-type': 'error',
     '@typescript-eslint/no-unsafe-member-access': 'off', // Can't config
     '@typescript-eslint/no-unsafe-return': 'off', // Can't config
     '@typescript-eslint/no-unsafe-unary-minus': 'error',
@@ -156,8 +130,7 @@ module.exports = {
     '@typescript-eslint/no-use-before-define': 'error',
     '@typescript-eslint/no-useless-constructor': 'error',
     '@typescript-eslint/no-useless-empty-export': 'error',
-    '@typescript-eslint/no-useless-template-literals': 'error',
-    '@typescript-eslint/no-var-requires': 'error',
+    '@typescript-eslint/no-wrapper-object-types': 'error', // Turn off in cbor projects
     '@typescript-eslint/non-nullable-type-assertion-style': 'off', // Can't config
     '@typescript-eslint/only-throw-error': 'error',
     '@typescript-eslint/parameter-properties': 'error',
@@ -179,14 +152,12 @@ module.exports = {
     '@typescript-eslint/prefer-regexp-exec': 'off', // Can't config
     '@typescript-eslint/prefer-return-this-type': 'off', // Can't config
     '@typescript-eslint/prefer-string-starts-ends-with': 'off', // Can't config
-    '@typescript-eslint/prefer-ts-expect-error': 'error',
     '@typescript-eslint/promise-function-async': 'off', // Can't config
     '@typescript-eslint/require-array-sort-compare': 'off', // Can't config
     '@typescript-eslint/require-await': 'error',
     '@typescript-eslint/restrict-plus-operands': 'off', // Can't config
     '@typescript-eslint/restrict-template-expressions': 'off', // Can't config
     '@typescript-eslint/return-await': 'error',
-    '@typescript-eslint/sort-type-constituents': 'error',
     '@typescript-eslint/strict-boolean-expressions': 'off', // Can't config
     '@typescript-eslint/switch-exhaustiveness-check': 'off', // Can't config
     '@typescript-eslint/triple-slash-reference': 'error',
@@ -197,7 +168,7 @@ module.exports = {
 
     // These are the stylistic rules that require TS.  All of the
     // others from the JS rules should work as-is.
-    // [Stylistc](https://eslint.style/packages/default)
+    // [Stylistc](https://eslint.style/packages/ts#rules)
     '@stylistic/member-delimiter-style': 'error',
     '@stylistic/type-annotation-spacing': 'error',
     '@stylistic/type-generic-spacing': 'error',