@cspeach/cli 1.1.56 → 1.1.57

package/dist/tools/sap-write.js

@@ -34,7 +34,7 @@ import { teamFixOffers, cspeachWritesThisSession } from '../register/offer.js';
 import { appendPending, finalizeToolCall } from '../session/pending.js';
 import { checkTransportFit, checkTransportNeeded, reusedRequestRefusal, noteTransportNeededAsked, takeTransportNeededAsked, } from './transport-fit-check.js';
 import { typeCode } from '../approvals/risk-floor.js';
-import { auditLog, SapError, hasClassicParameterBlock } from '@cspeach/sap-client';
+import { auditLog, SapError, hasClassicParameterBlock, documentWriteHint } from '@cspeach/sap-client';
 import { ERR } from '../errors/codes.js';
 import { interceptUpdateMethod, CancelledByUserError, } from './update-method-intercept.js';
 // F-L2-1: statusline-only wire — records the transport a write ACTUALLY
@@ -50,13 +50,39 @@ import { snapshotChainState, writtenWithSyntaxErrors, chainActivation, journeyWo
  */
 const FUNC_CLASSIC_BLOCK_TEXT = 'A function module\'s signature goes in the FUNCTION statement (IMPORTING / EXPORTING / CHANGING / TABLES / EXCEPTIONS), '
     + 'not in a *" comment block. Rewrite the header and try again.';
+/**
+ * F15 review (2026-11-02): sap-client's document-type sentence names client
+ * methods (createDomain, maintainMessages, …); this names the CLI tool the
+ * model can actually call. Keyed by the bare upper-case type code.
+ */
+const DOCUMENT_TYPE_TOOL = {
+    DOMA: 'sap_create_domain',
+    DTEL: 'sap_create_data_element',
+    MSAG: 'sap_message_maintain',
+    TTYP: 'sap_create_table_type',
+    DEVC: 'sap_create_object',
+    SRVB: 'sap_create_object, then sap_service_binding_publish',
+    ENHO: 'sap_create_badi_implementation',
+    ENHS: 'no CLI tool yet (create the spot in ADT)',
+};
 const SET_SOURCE_SPEC = {
     tool: 'sap_set_source',
     // Part 2c D16 (review I-4): a function module's classic *" block is refused
     // before the approval is spent, the snapshot is read or the WAL is opened.
-    beforeApproval: (a) => (typeCode(a.type) === 'FUNC' && hasClassicParameterBlock(String(a.source ?? ''))
-        ? { error: 'classic_parameter_block', detail: FUNC_CLASSIC_BLOCK_TEXT }
-        : undefined),
+    // F15 (2026-11-02): an ADT document type (DOMA, DTEL, MSAG, DEVC, SRVB, …) is
+    // refused at the same point, before the approval is spent, the snapshot is
+    // read or the WAL is opened — with sap-client's own sentence.
+    beforeApproval: (a) => {
+        if (typeCode(a.type) === 'FUNC' && hasClassicParameterBlock(String(a.source ?? ''))) {
+            return { error: 'classic_parameter_block', detail: FUNC_CLASSIC_BLOCK_TEXT };
+        }
+        const hint = documentWriteHint(a.type);
+        if (hint !== undefined) {
+            const useTool = DOCUMENT_TYPE_TOOL[typeCode(a.type)] ?? 'the tool for its kind';
+            return { error: 'not_a_source_object', detail: `${hint} CLI tool: ${useTool}.`, use_tool: useTool };
+        }
+        return undefined;
+    },
     // Rule 7a in code (2026-10-22): on an existing class, a rewrite whose only
     // change is inside method bodies is refused — sap_update_method per method.
     methodOnlyGuard: (a) => ({ type: a.type, name: a.name, source: String(a.source ?? '') }),
@@ -123,7 +149,9 @@ registerTool({
         + 'Use for class-definition changes, new methods, or any change not confined to '
         + 'a single method body. For method-body-only edits use sap_update_method (Rule 7a). '
         + 'The transport auto-resolves to the owning request if the object is already locked. '
-        + 'Types FUNC (function module), FINC (function-group include, e.g. L<GROUP>TOP), INCL (program include) and TTYP (table type) are supported; give the bare name — CSPeach finds the group.',
+        + 'Types FUNC (function module), FINC (function-group include, e.g. L<GROUP>TOP) and INCL (program include) are supported; give the bare name — CSPeach finds the group. '
+        + 'For a number range object (NROB) the source is SAP\'s nrob-v1 JSON document (formatVersion "1"; header.description, header.originalLanguage; interval.numberLengthDomain, percentWarning, subType, untilYear, rolling, prefix; configuration.buffering mainBuffer|parallel|none, bufferedNumbers), sent as application/json. '
+        + 'Domains, data elements, message classes, packages, bindings and table types have no source text: use their own tools.',
     isMutating: true,
     requiresSap: true,
     input_schema: {
@@ -1379,14 +1407,15 @@ registerTool({
 });
 // ── sap_number_range_intervals (STUB) ─────────────────────────────────────────
 //
-// STUB — NROB interval write requires NR-object XML format not yet implemented
-// in @cspeach/sap-client.
+// STUB — number range intervals (SNRO) are not an ADT resource: discovery lists
+// no intervals collection (probe docs/research/2026-11-02-nrob-adt-probe.md).
 registerTool({
     name: 'sap_number_range_intervals',
     requires: 'nrob',
-    description: 'STUB — not currently implemented; do not call. '
-        + 'Writing NROB number-range intervals via ADT requires NR-object XML format '
-        + 'not yet implemented in @cspeach/sap-client.',
+    description: 'Not available: number range intervals (SNRO) are not an ADT resource on the systems we run against — '
+        + 'the discovery document lists no intervals collection. '
+        + 'Create the number range object with sap_create_object and sap_set_source (nrob-v1 JSON); '
+        + 'the developer maintains its intervals in SNRO.',
     isMutating: true,
     requiresSap: true,
     input_schema: {
@@ -1406,7 +1435,7 @@ registerTool({
         return {
             content: JSON.stringify({
                 error: 'not_implemented',
-                detail: 'NROB interval write via ADT requires NR-object XML format not yet implemented in @cspeach/sap-client',
+                detail: 'number range intervals are maintained in SNRO; ADT exposes the object, not its intervals',
             }),
             is_error: true,
         };

package/live-check-2026-10-17-1343.txt

@@ -0,0 +1,41 @@
+CSPeach live check: system S4H, package ZTEST_LAS, run 2BUS
+Transport S4HK903771 (given with --transport)
+
+PASS  CLI: sap_run and sap_transport_read (pipeline; D3, D18 refusals, one-shot run approval, dump window, spill; never a release) 90.6 s
+    PASS  temp home            0.0 s  alias S4H copied; write_mode approval-gated; safety cards off
+      covers: approval id + claims, Rule 9 transport, Rule 7 snapshot, WAL, Rule 10 verify, chain; not: Rule 8 (dispatchTool), the cards
+    PASS  card input           0.0 s  risk high (code_run); this runs code on the SAP system
+    PASS  sap_create_object + sap_set_source CLAS 7.1 s  ZCL_ZCSPLC2BUS_CR created and written; activated by the write and verified
+      info: object locked in S4HK903771 — writing under owning transport
+      info: snapshot ✓ CLAS ZCL_ZCSPLC2BUS_CR 2026-10-17T17-42-31-537Z
+      ① snapshot ✓  ② written ✓  ③ syntax ✓  ④ activate pending
+      audit: 2026-10-17T17:42:34.691Z | setSource | CLAS | ZCL_ZCSPLC2BUS_CR | success | 3146ms
+      audit: 2026-10-17T17:42:34.976Z | setSource | CLAS | ZCL_ZCSPLC2BUS_CR | success | 4539ms
+    PASS  sap_run standard class refused 0.0 s  run_refused before any request: CSPeach runs only your own classes and programs (names starting with Z or Y). CL_ABAP_UNIT_ASSERT is not one of them.
+    PASS  sap_lock             0.3 s  ZCL_ZCSPLC2BUS_CR locked through sap_lock (a manual lock is held)
+    PASS  sap_run under a manual lock 0.0 s  manual_lock_held before any request: A lock you took with sap_lock is still held. Unlock it (sap_unlock) first, then ask for the run again.
+    PASS  sap_unlock           0.7 s  ZCL_ZCSPLC2BUS_CR unlocked; no manual lock held
+    PASS  sap_run CLAS         0.3 s  the same approval id ran it once: {"ran":true,"type":"CLAS","name":"ZCL_ZCSPLC2BUS_CR","lines":9,"chars":107,"elapsed_ms":287,"session_ended":false}
+      info: run CLAS ZCL_ZCSPLC2BUS_CR · ran · 287 ms
+    PASS  sap_run again with the same id 0.0 s  APPROVAL_INVALID nonce_spent; no request
+    PASS  sap_run PROG         4.2 s  ran: {"ran":true,"type":"PROG","name":"ZCSPLC2BUS_CRP","lines":6,"chars":255,"elapsed_ms":291,"session_ended":false}
+    PASS  sap_run CLAS dump    4.7 s  run_dumped: "Division by zero", dump_window 20261018034313–20261018034713; next_step: sap_short_dump with fromDate and toDate = dump_window (SAP system time), then operation detail on the newest du...
+    PASS  sap_short_dump in the dump window 1.5 s  listed: ZCL_ZCSPLC2BUS_CRX============CP (20261018034513vhcals4hci_S4H_00%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20S.LAEEQ%20%20%20%20%20100%20%20%20%20%20%20%2012); 1 dump(s) in the window
+    PASS  sap_run CLAS long output 17.9 s  the content carries the pointer line; the spill file holds 20001 lines (the facts line and 20 000 output lines); {"ran":true,"type":"CLAS","name":"ZCL_ZCSPLC2BUS_CRB","lines":20001,"chars":1328895,...
+    PASS  sap_transport_read request 12.9 s  S4HK903771 status D, 1 task(s), object_count 691, can_release true
+    PASS  sap_transport_read task 7.2 s  S4HK903772: kind task of S4HK903771; note: S4HK903772 is a task of S4HK903771.
+    PASS  release card input (never used) 13.2 s  risk high (transport_release); no approval minted, never sent
+      Request S4HK903771 "CSPeach live check 2026-10-14" · owner S.LAEEQ · target CL5
+      1 task: S4HK903772 · 691 objects
+      Cannot be undone. Once released, the request can move to the other systems on the transport route.
+      CSPeach reads SAP's verdict after each step and checks the request afterwards. Check the transport in SE09 after the release.
+    PASS  sap_delete_object CLAS ZCL_ZCSPLC2BUS_CRB 5.7 s  deleted; a search finds nothing
+    PASS  sap_delete_object CLAS ZCL_ZCSPLC2BUS_CRX 5.5 s  deleted; a search finds nothing
+    PASS  sap_delete_object PROG ZCSPLC2BUS_CRP 3.7 s  deleted; a search finds nothing
+    PASS  sap_delete_object CLAS ZCL_ZCSPLC2BUS_CR 5.6 s  deleted; a search finds nothing
+PASS  Cleanup                            0.0 s
+
+2 passed, 0 failed
+Transport: S4HK903771
+The transport is NOT released. Delete or release it in SE09.
+Leftover objects: none.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cspeach/cli",
-  "version": "1.1.56",
+  "version": "1.1.57",
   "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, signed skills, safety gates.",
   "keywords": [
     "abap",
@@ -54,7 +54,7 @@
     "@anthropic-ai/sdk": "^0.90.0",
     "@azure/msal-node": "6.0.1",
     "@cspeach/register-core": "0.4.2",
-    "@cspeach/sap-client": "0.1.31",
+    "@cspeach/sap-client": "0.1.32",
     "@iarna/toml": "^2.2.5",
     "@inkjs/ui": "^2.0.0",
     "@inquirer/prompts": "^7.0.0",