@cspeach/cli 1.1.49 → 1.1.50

package/dist/tools/_filesystem-shared.js

@@ -45,6 +45,13 @@ export const BLOCKED_BASENAME_RE = /^\.env(\.|$)/i;
  * (skill detail files) — only the rest of `.cspeach/` is blocked.
  */
 export const DENYLIST_DESCRIPTION = [...BLOCKED_PREFIXES, '.env*'].join(', ');
+/**
+ * The paging trailer of file_read and read_document (also refused in SAP
+ * writes: tools/cut-markers.ts).
+ */
+export function rereadTrailer(more, nextOffset) {
+    return `... (truncated, ${more} more lines — re-read with offset=${nextOffset})`;
+}
 /**
  * Executable / script file extensions the filesystem write tools refuse to
  * create. Defense-in-depth: shell_exec / background_run only run a safelisted

package/dist/tools/cut-markers.js

@@ -0,0 +1,47 @@
+/**
+ * Cut-note guard for SAP writes (2026-10-22, owner go).
+ *
+ * Large tool results reach the model shortened, each with a note of ours:
+ *  - agent/oversized-results.ts — "[result cut: N more chars …]" and
+ *    "[removed: this result was too large to send …]";
+ *  - agent/cold-prune.ts — "[result elided at cold start — N chars]";
+ *  - tools/result-spill.ts — the spill preview: the pointer line ("… full
+ *    output saved to …; read slices with tool_output_read(…)"), the omitted
+ *    line ("[… lines A–B omitted …]" / "[… N lines omitted — tool_output_read
+ *    offset=K …]") and a clipped line ("… [+N chars]");
+ *  - the paging trailers (tool_output_read, file_read, read_document) and the
+ *    @file attachment note "... [truncated, file exceeds 64 KB]".
+ * A model that writes back what it saw would write those notes into SAP in
+ * place of the real code. The write pipeline refuses any write whose
+ * arguments carry one of them, before the approval is spent or SAP is
+ * called. Only our own notes: "[image N]" and other bracket text can be
+ * legitimate ABAP and are never refused. A write without them is untouched.
+ */
+export const CUT_NOTE_REFUSAL = 'This source still contains a note that part of an earlier read was cut or moved to a file. Read the full source first (in parts if needed), then write the complete text.';
+const CUT_NOTE_RES = [
+    /\[result cut: \d+ more chars\./,
+    /\[removed: this result was too large to send — \d+ chars\./,
+    /\[result elided at cold start — \d+ chars\]/,
+    /full output saved to .*; read slices with tool_output_read\(path, offset, limit\)\]/,
+    /\[… lines \d+–\d+ omitted …\]/,
+    /\[… \d+ lines omitted — tool_output_read offset=\d+ …\]/,
+    /… \[\+\d+ chars\]/,
+    // tool-output-read.ts sliceTrailer; _filesystem-shared.ts rereadTrailer
+    // (file_read, read_document); workspace.ts ATTACHMENT_TRUNCATED_NOTE (@file).
+    /\.\.\. \(\d+ more lines — next offset=\d+\)/,
+    /\.\.\. \(truncated, \d+ more lines — re-read with offset=\d+\)/,
+    /\.\.\. \[truncated, file exceeds 64 KB\]/,
+];
+/** True when `text` carries one of our cut / removed / spill notes. */
+export function hasCutNote(text) {
+    return CUT_NOTE_RES.some((re) => re.test(text));
+}
+/** True when any string anywhere in `value` (objects, arrays) carries a cut note. */
+export function argsHaveCutNote(value, depth = 0) {
+    if (typeof value === 'string')
+        return hasCutNote(value);
+    if (depth > 8 || value === null || typeof value !== 'object')
+        return false;
+    const items = Array.isArray(value) ? value : Object.values(value);
+    return items.some((v) => argsHaveCutNote(v, depth + 1));
+}

package/dist/tools/filesystem/extract-document.js

@@ -50,11 +50,59 @@ async function extractPdf(buffer, maxPages) {
     }).join('\n\n');
     return { text: body, pages: total, warnings: hasText ? [] : [NO_TEXT_WARNING] };
 }
+/**
+ * Longest line a document read hands to the model. A longer one is split
+ * into consecutive lines, so paging by line reaches every character; a real
+ * line (a dense PDF page is a few thousand chars) fits well inside it.
+ */
+export const DOC_MAX_LINE_CHARS = 10_000;
+/** Longest picture description kept in an `[image N: …]` marker. */
+const IMAGE_ALT_MAX_CHARS = 120;
+// 2026-10-22 customer bug — mammoth's default inlines every picture as a
+// base64 data: URI (a 1.5 MB picture ≈ 670k tokens on ONE line), and the
+// prompt was then too long for every later turn. Pictures never become text:
+// mammoth gets an img converter that never reads the bytes, and turndown
+// writes each <img> as a short numbered marker.
+const NO_IMAGE_DATA = mammoth.images.imgElement(async () => ({ src: '' }));
+/** Remove any data: URI left in the text (a linked or pasted picture). */
+export function stripDataUris(text) {
+    return text.replace(/data:[a-z0-9.+\/-]*(?:;[a-z0-9=._-]+)*;base64,[a-z0-9+\/=]*/gi, '');
+}
+/**
+ * Split every line longer than `maxLineChars` into consecutive lines of at
+ * most `maxLineChars`, so nothing is lost. Text whose lines all fit is
+ * returned unchanged (the same string).
+ */
+export function splitLongLines(text, maxLineChars) {
+    const lines = text.split('\n');
+    if (!lines.some((l) => l.length > maxLineChars))
+        return text;
+    const out = [];
+    for (const l of lines) {
+        if (l.length <= maxLineChars) {
+            out.push(l);
+            continue;
+        }
+        for (let i = 0; i < l.length; i += maxLineChars)
+            out.push(l.slice(i, i + maxLineChars));
+    }
+    return out.join('\n');
+}
 async function extractDocx(buffer) {
     // Fix 2: esModuleInterop:true makes the default import correct — no interop guard needed.
-    const { value: html } = await mammoth.convertToHtml({ buffer });
+    const { value: html } = await mammoth.convertToHtml({ buffer }, { convertImage: NO_IMAGE_DATA });
     const td = new TurndownService({ headingStyle: 'atx', bulletListMarker: '-' });
-    const raw = td.turndown(html).trim();
+    let images = 0;
+    td.addRule('pictureMarker', {
+        filter: 'img',
+        replacement: (_content, node) => {
+            images++;
+            const alt = (node.getAttribute('alt') ?? '')
+                .replace(/\s+/g, ' ').trim().slice(0, IMAGE_ALT_MAX_CHARS).trim();
+            return alt ? `[image ${images}: ${alt}]` : `[image ${images}]`;
+        },
+    });
+    const raw = stripDataUris(td.turndown(html)).trim();
     // Turndown emits "-   text" (3 spaces) for bullet items; collapse to "- text".
     // The regex anchors on a line-leading "-" so mid-line double spaces (e.g. "Col A  Col B")
     // and indented nested bullets (leading whitespace is captured in $1) are both preserved.

package/dist/tools/filesystem/file-read.js

@@ -10,7 +10,7 @@
  */
 import { promises as fs } from 'node:fs';
 import { registerTool } from '../index.js';
-import { resolveSafePath, assertRealPathContained, PathOutsideRootError, DENYLIST_DESCRIPTION, isDenylistedPath, isReadOnlyProjectFile } from '../_filesystem-shared.js';
+import { resolveSafePath, assertRealPathContained, PathOutsideRootError, DENYLIST_DESCRIPTION, isDenylistedPath, isReadOnlyProjectFile, rereadTrailer } from '../_filesystem-shared.js';
 import { teamReadTarget } from '../_team-work-path.js';
 import { spillToolResult, isUnderSpillRoot } from '../result-spill.js';
 import { basename } from 'node:path';
@@ -74,7 +74,7 @@ export async function fileReadHandler(args, ctx) {
     const numbered = window.map((line, i) => `${offset + i + 1}\t${line}`).join('\n');
     const truncated = allLines.length > offset + window.length;
     const trailer = truncated
-        ? `\n... (truncated, ${allLines.length - (offset + window.length)} more lines — re-read with offset=${offset + window.length})`
+        ? `\n${rereadTrailer(allLines.length - (offset + window.length), offset + window.length)}`
         : '';
     // Task 17 (spec D12) — a window above 8 000 chars is saved to the session
     // spill file and previewed; today's trailer stays last, byte-identical. A

package/dist/tools/filesystem/read-document.js

@@ -7,10 +7,15 @@
 import { promises as fs } from 'node:fs';
 import * as path from 'node:path';
 import { registerTool } from '../index.js';
-import { resolveSafePath, assertRealPathContained, PathOutsideRootError, DENYLIST_DESCRIPTION, isDenylistedPath, } from '../_filesystem-shared.js';
+import { resolveSafePath, assertRealPathContained, PathOutsideRootError, DENYLIST_DESCRIPTION, isDenylistedPath, rereadTrailer, } from '../_filesystem-shared.js';
 import { teamWorkTarget } from '../_team-work-path.js';
-import { extractDocument, DocumentTooLargeError } from './extract-document.js';
+import { extractDocument, DocumentTooLargeError, splitLongLines, DOC_MAX_LINE_CHARS, } from './extract-document.js';
 const MAX_LINES = 2000;
+// 2026-10-22 customer bug — one read returned ~2.3M tokens and every later
+// turn of the session failed. A read now has a hard size: long lines are split
+// (DOC_MAX_LINE_CHARS) and one call returns at most DOC_MAX_CHARS_PER_READ
+// chars (about 60k tokens); the offset trailer says where to read on.
+export const DOC_MAX_CHARS_PER_READ = 200_000;
 const MAX_BYTES = 50 * 1024 * 1024; // 50 MB
 const MAX_PAGES = 150;
 const SUPPORTED = new Set(['.pdf', '.docx', '.xlsx']);
@@ -89,14 +94,25 @@ export async function readDocumentHandler(args, ctx) {
             : 'document';
     const header = `${args.path} — ${scale}`;
     const warnLines = result.warnings.map((w) => `[warning] ${w}`);
-    const allLines = result.text.replace(/\n$/, '').split('\n');
+    const allLines = splitLongLines(result.text.replace(/\n$/, ''), DOC_MAX_LINE_CHARS).split('\n');
     const offset = Math.max(0, args.offset ?? 0);
     const limit = Math.min(args.limit ?? MAX_LINES, MAX_LINES);
     const window = allLines.slice(offset, offset + limit);
+    // Total cap: stop before the line that would pass it (always keep one line).
+    let used = 0;
+    let fit = 0;
+    for (const line of window) {
+        const cost = `${offset + fit + 1}\t${line}`.length + 1;
+        if (fit > 0 && used + cost > DOC_MAX_CHARS_PER_READ)
+            break;
+        used += cost;
+        fit++;
+    }
+    window.length = fit;
     const numbered = window.map((line, i) => `${offset + i + 1}\t${line}`).join('\n');
     const truncated = allLines.length > offset + window.length;
     const trailer = truncated
-        ? `\n... (truncated, ${allLines.length - (offset + window.length)} more lines — re-read with offset=${offset + window.length})`
+        ? `\n${rereadTrailer(allLines.length - (offset + window.length), offset + window.length)}`
         : '';
     return { content: [header, ...warnLines, numbered].join('\n') + trailer };
 }

package/dist/tools/tool-output-read.js

@@ -95,7 +95,11 @@ export async function toolOutputReadHandler(args, ctx) {
         next = i + 1;
     }
     const rest = all.length - next;
-    return { content: out.join('\n') + (rest > 0 ? `\n... (${rest} more lines — next offset=${next})` : '') };
+    return { content: out.join('\n') + (rest > 0 ? `\n${sliceTrailer(rest, next)}` : '') };
+}
+/** The slice trailer (also refused in SAP writes: tools/cut-markers.ts). */
+export function sliceTrailer(rest, next) {
+    return `... (${rest} more lines — next offset=${next})`;
 }
 registerTool({
     name: 'tool_output_read',

package/dist/tools/write-pipeline.js

@@ -44,6 +44,7 @@ import { resolveWriteTransport } from './transport-resolution.js';
 import { noteWriteTransport } from '../repl/current-transport.js';
 import { presentSafetyConfirmation } from '../repl/safety-confirm.js';
 import { isSafetyConfirmEnabled } from '../repl/safety-mode-state.js';
+import { argsHaveCutNote, CUT_NOTE_REFUSAL } from './cut-markers.js';
 // ── Transcript visibility helpers (D16-display + tour slide-7, 2026-06-12) ──
 //
 // Rule 7 auto-snapshots always fired but the transcript never said so
@@ -334,6 +335,10 @@ function auditOutcome(syntax, stillExists, postCheckError) {
  */
 export async function runWritePipeline(args, ctx, spec) {
     const raw = args;
+    // ── 2026-10-22 — never write our own cut / spill notes into SAP ────────────
+    // First, before the approval is spent or SAP is called (cut-markers.ts).
+    if (argsHaveCutNote(args))
+        return refuse({ error: 'source_has_cut_note', detail: CUT_NOTE_REFUSAL });
     // ── Before the approval is spent (input / capability checks) ──────────────
     if (spec.beforeApproval) {
         const refusal = spec.beforeApproval(args, ctx);

package/package.json

@@ -1,121 +1,121 @@
-{
-  "name": "@cspeach/cli",
-  "version": "1.1.49",
-  "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, signed skills, safety gates.",
-  "keywords": [
-    "abap",
-    "sap",
-    "ai",
-    "cli",
-    "ai-assisted-development",
-    "s4hana",
-    "abap-development",
-    "claude",
-    "anthropic"
-  ],
-  "homepage": "https://cspeach.dev",
-  "bugs": {
-    "email": "laeeq.siddique@cremencing.com"
-  },
-  "author": "Laeeq Siddique (Cremencing Solutions)",
-  "license": "SEE LICENSE IN LICENSE",
-  "private": false,
-  "publishConfig": {
-    "access": "public"
-  },
-  "type": "module",
-  "bin": {
-    "cspeach": "dist/index.js"
-  },
-  "scripts": {
-    "dev": "tsx src/index.ts",
-    "prebuild": "tsx scripts/prebuild.ts",
-    "build": "tsc && node scripts/make-bin-executable.js",
-    "install:global": "tsx scripts/install-global.ts",
-    "pretest": "tsx scripts/sync-signing-key.ts || node -e \"console.warn('WARN: sync-signing-key skipped — using stub')\"",
-    "start": "node dist/index.js",
-    "typecheck": "tsc --noEmit",
-    "test": "vitest run",
-    "test:watch": "vitest",
-    "test:smoke-e2e": "vitest run --config vitest.smoke-e2e.config.ts",
-    "adt:smoke": "tsx scripts/adt-smoke.ts",
-    "smoke:all": "pnpm adt:smoke",
-    "bench:models": "tsx scripts/bench-models.ts",
-    "bench:audit": "tsx scripts/bench-audit-task.ts",
-    "bench:replay": "tsx bench/replay/run.ts",
-    "fiori": "tsx src/tools/fiori/bin.ts",
-    "prepare": "husky",
-    "prepublishOnly": "node -e \"const deps=require('./package.json').dependencies||{}; for (const n of ['@cspeach/sap-client','@cspeach/register-core']) { const d=deps[n]||''; if(d.startsWith('file:')||d.startsWith('link:')){console.error('publish blocked: '+n+' is a local link ('+d+') — point it at the published version before npm publish'); process.exit(1)} }\""
-  },
-  "engines": {
-    "node": ">=20.0.0"
-  },
-  "dependencies": {
-    "@anthropic-ai/sdk": "^0.90.0",
-    "@azure/msal-node": "6.0.1",
-    "@cspeach/register-core": "0.4.2",
-    "@cspeach/sap-client": "0.1.29",
-    "@iarna/toml": "^2.2.5",
-    "@inkjs/ui": "^2.0.0",
-    "@inquirer/prompts": "^7.0.0",
-    "@napi-rs/keyring": "2.1.0",
-    "@noble/ed25519": "2.1.0",
-    "@noble/hashes": "1.4.0",
-    "@sap-ux/annotation-converter": "0.10.21",
-    "@sap-ux/edmx-parser": "0.10.0",
-    "@sap-ux/fe-fpm-writer": "0.43.7",
-    "@sap-ux/fiori-elements-writer": "^3.0.39",
-    "@sap-ux/fiori-freestyle-writer": "3.0.12",
-    "@sap-ux/vocabularies-types": "0.15.0",
-    "adm-zip": "0.5.17",
-    "chalk": "^5.3.0",
-    "cli-highlight": "^2.1.11",
-    "cli-table3": "^0.6.5",
-    "clipboardy": "^5.3.1",
-    "cross-spawn": "^7.0.6",
-    "diff": "^9.0.0",
-    "docx": "^9.0.2",
-    "ejs": "3.1.10",
-    "fuse.js": "^7.0.0",
-    "ink": "^5.0.0",
-    "ink-text-input": "^6.0.0",
-    "jose": "^5.9.0",
-    "mammoth": "^1.8.0",
-    "marked": "^11.2.0",
-    "marked-terminal": "^6.2.0",
-    "mem-fs": "2.1.0",
-    "mem-fs-editor": "9.4.0",
-    "node-machine-id": "^1.1.12",
-    "openai": "^6.49.0",
-    "puppeteer-core": "24.10.2",
-    "react": "^18.3.0",
-    "string-width": "^7.2.0",
-    "turndown": "^7.2.0",
-    "unpdf": "1.7.0",
-    "zod": "^3.23.0"
-  },
-  "devDependencies": {
-    "@sap-ux/ui5-middleware-fe-mockserver": "2.4.17",
-    "@types/adm-zip": "0.5.8",
-    "@types/cross-spawn": "^6.0.6",
-    "@types/diff": "^7.0.2",
-    "@types/ejs": "^3.1.5",
-    "@types/node": "^20.17.0",
-    "@types/react": "^18.3.0",
-    "@types/turndown": "^5.0.5",
-    "@ui5/builder": "4.3.2",
-    "@ui5/fs": "4.0.6",
-    "husky": "^9.1.7",
-    "ink-testing-library": "^4.0.0",
-    "pdf-lib": "^1.17.1",
-    "strip-ansi": "6.0.1",
-    "tsx": "^4.19.0",
-    "typescript": "^5.7.0",
-    "vitest": "^2.1.0"
-  },
-  "pnpm": {
-    "onlyBuiltDependencies": [
-      "esbuild"
-    ]
-  }
-}
+{
+  "name": "@cspeach/cli",
+  "version": "1.1.50",
+  "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, signed skills, safety gates.",
+  "keywords": [
+    "abap",
+    "sap",
+    "ai",
+    "cli",
+    "ai-assisted-development",
+    "s4hana",
+    "abap-development",
+    "claude",
+    "anthropic"
+  ],
+  "homepage": "https://cspeach.dev",
+  "bugs": {
+    "email": "laeeq.siddique@cremencing.com"
+  },
+  "author": "Laeeq Siddique (Cremencing Solutions)",
+  "license": "SEE LICENSE IN LICENSE",
+  "private": false,
+  "publishConfig": {
+    "access": "public"
+  },
+  "type": "module",
+  "bin": {
+    "cspeach": "dist/index.js"
+  },
+  "scripts": {
+    "dev": "tsx src/index.ts",
+    "prebuild": "tsx scripts/prebuild.ts",
+    "build": "tsc && node scripts/make-bin-executable.js",
+    "install:global": "tsx scripts/install-global.ts",
+    "pretest": "tsx scripts/sync-signing-key.ts || node -e \"console.warn('WARN: sync-signing-key skipped — using stub')\"",
+    "start": "node dist/index.js",
+    "typecheck": "tsc --noEmit",
+    "test": "vitest run",
+    "test:watch": "vitest",
+    "test:smoke-e2e": "vitest run --config vitest.smoke-e2e.config.ts",
+    "adt:smoke": "tsx scripts/adt-smoke.ts",
+    "smoke:all": "pnpm adt:smoke",
+    "bench:models": "tsx scripts/bench-models.ts",
+    "bench:audit": "tsx scripts/bench-audit-task.ts",
+    "bench:replay": "tsx bench/replay/run.ts",
+    "fiori": "tsx src/tools/fiori/bin.ts",
+    "prepare": "husky",
+    "prepublishOnly": "node -e \"const deps=require('./package.json').dependencies||{}; for (const n of ['@cspeach/sap-client','@cspeach/register-core']) { const d=deps[n]||''; if(d.startsWith('file:')||d.startsWith('link:')){console.error('publish blocked: '+n+' is a local link ('+d+') — point it at the published version before npm publish'); process.exit(1)} }\""
+  },
+  "engines": {
+    "node": ">=20.0.0"
+  },
+  "dependencies": {
+    "@anthropic-ai/sdk": "^0.90.0",
+    "@azure/msal-node": "6.0.1",
+    "@cspeach/register-core": "0.4.2",
+    "@cspeach/sap-client": "0.1.30",
+    "@iarna/toml": "^2.2.5",
+    "@inkjs/ui": "^2.0.0",
+    "@inquirer/prompts": "^7.0.0",
+    "@napi-rs/keyring": "2.1.0",
+    "@noble/ed25519": "2.1.0",
+    "@noble/hashes": "1.4.0",
+    "@sap-ux/annotation-converter": "0.10.21",
+    "@sap-ux/edmx-parser": "0.10.0",
+    "@sap-ux/fe-fpm-writer": "0.43.7",
+    "@sap-ux/fiori-elements-writer": "^3.0.39",
+    "@sap-ux/fiori-freestyle-writer": "3.0.12",
+    "@sap-ux/vocabularies-types": "0.15.0",
+    "adm-zip": "0.5.17",
+    "chalk": "^5.3.0",
+    "cli-highlight": "^2.1.11",
+    "cli-table3": "^0.6.5",
+    "clipboardy": "^5.3.1",
+    "cross-spawn": "^7.0.6",
+    "diff": "^9.0.0",
+    "docx": "^9.0.2",
+    "ejs": "3.1.10",
+    "fuse.js": "^7.0.0",
+    "ink": "^5.0.0",
+    "ink-text-input": "^6.0.0",
+    "jose": "^5.9.0",
+    "mammoth": "^1.8.0",
+    "marked": "^11.2.0",
+    "marked-terminal": "^6.2.0",
+    "mem-fs": "2.1.0",
+    "mem-fs-editor": "9.4.0",
+    "node-machine-id": "^1.1.12",
+    "openai": "^6.49.0",
+    "puppeteer-core": "24.10.2",
+    "react": "^18.3.0",
+    "string-width": "^7.2.0",
+    "turndown": "^7.2.0",
+    "unpdf": "1.7.0",
+    "zod": "^3.23.0"
+  },
+  "devDependencies": {
+    "@sap-ux/ui5-middleware-fe-mockserver": "2.4.17",
+    "@types/adm-zip": "0.5.8",
+    "@types/cross-spawn": "^6.0.6",
+    "@types/diff": "^7.0.2",
+    "@types/ejs": "^3.1.5",
+    "@types/node": "^20.17.0",
+    "@types/react": "^18.3.0",
+    "@types/turndown": "^5.0.5",
+    "@ui5/builder": "4.3.2",
+    "@ui5/fs": "4.0.6",
+    "husky": "^9.1.7",
+    "ink-testing-library": "^4.0.0",
+    "pdf-lib": "^1.17.1",
+    "strip-ansi": "6.0.1",
+    "tsx": "^4.19.0",
+    "typescript": "^5.7.0",
+    "vitest": "^2.1.0"
+  },
+  "pnpm": {
+    "onlyBuiltDependencies": [
+      "esbuild"
+    ]
+  }
+}