@cspeach/cli 1.1.48 → 1.1.50

package/dist/projects/merge-cca.js

@@ -1,311 +0,0 @@
-/**
- * Deterministic merge of N parallel /abap-cca assessment slices into ONE
- * consolidated cca-assessment (the /abap-cca-merge skill's engine).
- *
- * WHY CODE, NOT PROSE: battery scenario S4 (docs/research/battery/
- * s4-cca-scorecard.md, defects D6/D7) proved the model cannot keep
- * manifest counts consistent with manifest rows when reconciling by
- * hand — `retire: 0` next to 7 retire rows, 27/104 rows silently
- * dropped. This module does the arithmetic; the model presents the
- * result and adds judgment commentary, nothing else.
- *
- * Rules implemented (mirrors .claude/skills/abap-cca-merge/SKILL.md):
- *   - identity: same projectId across inputs, or opts.allowCrossProject
- *   - atcVariant must match across inputs (hard error — classifications
- *     produced under different ATC variants are not comparable)
- *   - scope-overlap detection: intersecting scope patterns AND duplicate
- *     object names across inputs both produce warnings
- *   - per-object union keyed by objectName|objectType (item ids are
- *     PER-INPUT local — item-001 exists in every slice — so ids cannot
- *     be the union key; merged rows are re-numbered)
- *   - conflict rule: most-restrictive wins (retire > redesign > fix >
- *     keep), recorded BOTH as a warning AND on the merged row
- *     (`conflict: { values: {label: cls}, rule: 'most-restrictive' }`)
- *   - counts RECOMPUTED from merged rows — never trusted from inputs
- *   - truncation-aware: an input marked classificationsTruncated yields
- *     a warning that the merge covers manifest rows only and the detail
- *     file must be consulted for full coverage
- */
-import { OUTPUT_ROOT } from './output-paths.js';
-import { isWindowsReservedName } from '../tools/_filesystem-shared.js';
-/** Higher = more restrictive. Conflict resolution picks the max. */
-const RESTRICTIVENESS = {
-    retire: 3,
-    redesign: 2,
-    fix: 1,
-    keep: 0,
-};
-/**
- * Manifest row-priority sort (matches abap-cca SKILL.md: "redesign first,
- * then fix, then retire, then keep, ordered by confidence DESC within
- * each group"). This is WORK priority, not restrictiveness.
- */
-const ROW_PRIORITY = {
-    redesign: 0,
-    fix: 1,
-    retire: 2,
-    keep: 3,
-};
-const CONFIDENCE_RANK = {
-    high: 0,
-    medium: 1,
-    low: 2,
-};
-/* ── scope expression helpers ───────────────────────────────────────────── */
-/**
- * Split a scope expression like "ZFI* + ZSD*" or "ZFI*, ZSD*" into
- * individual patterns. Exported for tests.
- */
-export function parseScopePatterns(scope) {
-    return scope
-        .split(/[+,]/)
-        .map((s) => s.trim())
-        .filter((s) => s.length > 0);
-}
-/**
- * Conservative intersection check for the prefix-glob patterns the
- * --scope flag accepts (`ZFI*`, exact names). Two prefix globs intersect
- * when one stem is a prefix of the other (`ZF*` ⊇ `ZFI*`). Patterns we
- * cannot reason about (internal `*`) only match when identical —
- * deliberately under-reports rather than spamming false overlaps.
- * Exported for tests.
- */
-export function scopePatternsIntersect(a, b) {
-    const A = a.trim().toUpperCase();
-    const B = b.trim().toUpperCase();
-    if (A === B)
-        return true;
-    const aStar = A.endsWith('*') && !A.slice(0, -1).includes('*');
-    const bStar = B.endsWith('*') && !B.slice(0, -1).includes('*');
-    const aStem = aStar ? A.slice(0, -1) : A;
-    const bStem = bStar ? B.slice(0, -1) : B;
-    if (A.includes('*') && !aStar)
-        return false; // unparseable — identical-only
-    if (B.includes('*') && !bStar)
-        return false;
-    if (aStar && bStar)
-        return aStem.startsWith(bStem) || bStem.startsWith(aStem);
-    if (aStar)
-        return B.startsWith(aStem);
-    if (bStar)
-        return A.startsWith(bStem);
-    return false; // two distinct exact names
-}
-/* ── merge ──────────────────────────────────────────────────────────────── */
-function todayUtc() {
-    return new Date().toISOString().slice(0, 10);
-}
-/** A folder/file-name slug: `^[A-Za-z0-9._-]+$`, no `..`, not `.`, no device name. */
-export function assertMergeSlug(label, value) {
-    const ok = typeof value === 'string'
-        && value.length > 0 && value.length <= 100
-        && /^[A-Za-z0-9._-]+$/.test(value)
-        && !value.includes('..') && value !== '.'
-        && !/[. ]$/.test(value)
-        && !isWindowsReservedName(value);
-    if (!ok) {
-        throw new Error(`${label} ${JSON.stringify(value)} cannot name a folder — use letters, digits, ".", "_" and "-" only `
-            + '(no "..", no device names such as CON or NUL).');
-    }
-}
-export function mergeCcaAssessments(inputs, opts = {}) {
-    if (inputs.length < 2) {
-        throw new Error(`cca merge requires at least 2 inputs (got ${inputs.length}) — a single assessment needs no merge`);
-    }
-    const warnings = [];
-    const first = inputs[0];
-    // ── identity validation ──
-    for (const inp of inputs.slice(1)) {
-        if (inp.content.projectId !== first.content.projectId && !opts.allowCrossProject) {
-            throw new Error(`projectId mismatch: '${inp.label}' is project '${inp.content.projectId}' but '${first.label}' is '${first.content.projectId}'. `
-                + `Merging different projects silently corrupts the estate view — pass allowCrossProject only for disjoint-scope slices of the same system.`);
-        }
-    }
-    for (const inp of inputs.slice(1)) {
-        if (inp.content.atcVariant !== first.content.atcVariant) {
-            throw new Error(`atcVariant mismatch: '${inp.label}' was classified under '${inp.content.atcVariant}' but '${first.label}' under '${first.content.atcVariant}'. `
-                + `Classifications from different ATC variants are not comparable — re-run one slice with the matching variant.`);
-        }
-    }
-    // ── scope-overlap detection (warning, not blocker) ──
-    for (let i = 0; i < inputs.length; i++) {
-        for (let j = i + 1; j < inputs.length; j++) {
-            const a = inputs[i];
-            const b = inputs[j];
-            for (const pa of parseScopePatterns(a.content.scope)) {
-                for (const pb of parseScopePatterns(b.content.scope)) {
-                    if (scopePatternsIntersect(pa, pb)) {
-                        warnings.push(`SCOPE OVERLAP: '${a.label}' scope '${pa}' intersects '${b.label}' scope '${pb}' — slices were not disjoint; duplicate objects are reconciled most-restrictive.`);
-                    }
-                }
-            }
-        }
-    }
-    // ── truncation awareness ──
-    for (const inp of inputs) {
-        if (inp.content.classificationsTruncated) {
-            const shown = inp.content.classificationsShown ?? inp.content.classifications.length;
-            const total = inp.content.classificationsTotal ?? '?';
-            warnings.push(`TRUNCATED INPUT: '${inp.label}' manifest carries only ${shown} of ${total} classifications — `
-                + `this merge covers the manifest rows only. For full coverage merge from the detail file at ${inp.content.detailPath}.`);
-        }
-    }
-    // ── per-object union (key: objectName|objectType) ──
-    const byKey = new Map();
-    const keyOrder = [];
-    for (const inp of inputs) {
-        for (const row of inp.content.classifications) {
-            const key = `${row.objectName.toUpperCase()}|${row.objectType.toUpperCase()}`;
-            if (!byKey.has(key)) {
-                byKey.set(key, []);
-                keyOrder.push(key);
-            }
-            byKey.get(key).push({
-                label: inp.label,
-                classification: row.classification,
-                confidence: row.confidence,
-                objectName: row.objectName,
-                objectType: row.objectType,
-            });
-        }
-    }
-    const mergedRows = [];
-    for (const key of keyOrder) {
-        const sources = byKey.get(key);
-        const base = sources[0];
-        const distinct = new Set(sources.map((s) => s.classification));
-        if (sources.length > 1 && distinct.size === 1) {
-            warnings.push(`DUPLICATE OBJECT: ${base.objectName} (${base.objectType}) appears in ${sources.length} inputs `
-                + `(${sources.map((s) => s.label).join(', ')}) with the same classification '${base.classification}' — overlapping slices, merged into one row.`);
-        }
-        if (distinct.size > 1) {
-            // conflict — most-restrictive wins
-            const winner = sources.reduce((best, s) => RESTRICTIVENESS[s.classification] > RESTRICTIVENESS[best.classification] ? s : best);
-            const values = {};
-            for (const s of sources)
-                values[s.label] = s.classification;
-            warnings.push(`CLASSIFICATION CONFLICT: ${base.objectName} (${base.objectType}) — `
-                + sources.map((s) => `${s.label}: ${s.classification} [${s.confidence}]`).join('; ')
-                + ` → resolved: ${winner.classification} (most-restrictive rule). Review with the consultants who classified before remediation planning.`);
-            mergedRows.push({
-                id: '', // re-numbered after sort
-                objectName: base.objectName,
-                objectType: base.objectType,
-                classification: winner.classification,
-                confidence: winner.confidence,
-                conflict: { values, rule: 'most-restrictive' },
-            });
-        }
-        else {
-            mergedRows.push({
-                id: '',
-                objectName: base.objectName,
-                objectType: base.objectType,
-                classification: base.classification,
-                confidence: base.confidence,
-            });
-        }
-    }
-    // ── manifest row-priority sort + re-number ──
-    mergedRows.sort((a, b) => {
-        const p = ROW_PRIORITY[a.classification] - ROW_PRIORITY[b.classification];
-        if (p !== 0)
-            return p;
-        const c = CONFIDENCE_RANK[a.confidence] - CONFIDENCE_RANK[b.confidence];
-        if (c !== 0)
-            return c;
-        return a.objectName.localeCompare(b.objectName);
-    });
-    mergedRows.forEach((row, i) => {
-        row.id = `item-${String(i + 1).padStart(3, '0')}`;
-    });
-    // ── counts RECOMPUTED from rows — never trusted from inputs ──
-    const tally = { keep: 0, fix: 0, retire: 0, redesign: 0 };
-    for (const row of mergedRows)
-        tally[row.classification]++;
-    // uncategorized objects have no classification rows, so they cannot be
-    // recomputed — summed across inputs (slices are disjoint by contract;
-    // overlap is already warned about above).
-    const uncategorized = inputs.reduce((sum, inp) => sum + (inp.content.summary.uncategorized || 0), 0);
-    const date = opts.mergedDate ?? todayUtc();
-    // SEC (review round 2): projectId comes from INSIDE an envelope (model-
-    // writable) and becomes a folder name under .cspeach/cca/projects/. Only a
-    // plain slug may do that — never `../`, a drive, a stream or a device name.
-    assertMergeSlug('projectId', first.content.projectId);
-    assertMergeSlug('merged date', date);
-    const mergedProjectId = `${first.content.projectId}_merged_${date}`;
-    const scopes = [];
-    for (const inp of inputs) {
-        const s = inp.content.scope.trim();
-        if (s.length > 0 && !scopes.includes(s))
-            scopes.push(s);
-    }
-    const merged = {
-        detailPath: `${OUTPUT_ROOT}/cca/projects/${mergedProjectId}/project.json`,
-        projectId: mergedProjectId,
-        scope: scopes.join(', '),
-        atcVariant: first.content.atcVariant,
-        summary: {
-            totalObjects: mergedRows.length + uncategorized,
-            keep: tally.keep,
-            fix: tally.fix,
-            retire: tally.retire,
-            redesign: tally.redesign,
-            uncategorized,
-        },
-        classifications: mergedRows,
-    };
-    return { merged, warnings };
-}
-/* ── manifest rendering ─────────────────────────────────────────────────── */
-/** Manifest table cap — full rows live in the merged detail data. */
-export const CCA_MANIFEST_ROW_CAP = 50;
-function renderConflictCell(conflict) {
-    const pairs = Object.entries(conflict.values)
-        .map(([label, cls]) => `${label.replace(/[|;:]/g, '_')}:${cls}`)
-        .join(';');
-    return `conflict=${pairs}`;
-}
-/**
- * Render the EXACT `<!-- csforge:cca-manifest ... -->` block for a merged
- * assessment. The model must paste this VERBATIM — every number is
- * computed here, and extract-cca.ts re-validates counts-vs-rows on save,
- * so a hand-edited block fails loudly instead of saving silently wrong.
- *
- * `omitDetailPath` is for the detail-write-failed path in cca_merge:
- * a manifest must never point at a file that does not exist, so the
- * line is dropped (the extractor then refuses the save loudly).
- */
-export function renderCcaMergeManifest(merged, title, opts = {}) {
-    const rows = merged.classifications.slice(0, CCA_MANIFEST_ROW_CAP);
-    const truncated = merged.classifications.length > CCA_MANIFEST_ROW_CAP;
-    const lines = [
-        '<!-- csforge:cca-manifest',
-        'artefact: cca-assessment',
-        `title: ${title}`,
-        ...(opts.omitDetailPath ? [] : [`detail_path: ${merged.detailPath}`]),
-        `project_id: ${merged.projectId}`,
-        `scope: ${merged.scope}`,
-        `atc_variant: ${merged.atcVariant}`,
-        `total_objects: ${merged.summary.totalObjects}`,
-        `keep: ${merged.summary.keep}`,
-        `fix: ${merged.summary.fix}`,
-        `retire: ${merged.summary.retire}`,
-        `redesign: ${merged.summary.redesign}`,
-        `uncategorized: ${merged.summary.uncategorized}`,
-    ];
-    if (truncated) {
-        lines.push('classifications_truncated: true');
-        lines.push(`classifications_shown: ${rows.length}`);
-        lines.push(`classifications_total: ${merged.classifications.length}`);
-    }
-    lines.push('classifications:');
-    for (const row of rows) {
-        const cells = [row.id, row.objectName, row.objectType, row.classification, row.confidence];
-        if (row.conflict)
-            cells.push(renderConflictCell(row.conflict));
-        lines.push(`  ${cells.join(' | ')}`);
-    }
-    lines.push('-->');
-    return lines.join('\n');
-}

package/dist/tools/project/cca_merge.js

@@ -1,174 +0,0 @@
-/**
- * cca_merge — deterministic reconciliation of N parallel /abap-cca
- * assessment envelopes (the /abap-cca-merge skill's execution seam).
- *
- * DESIGN (2026-06-12, team-chain): the skill used to ask the MODEL to
- * reconcile envelopes by hand; battery S4 (D6/D7) proved models can't
- * keep counts consistent with rows. This tool runs
- * src/projects/merge-cca.ts and returns the merged content, warnings,
- * AND a pre-rendered manifest block the model pastes VERBATIM. The
- * normal save hook then persists the envelope — persistence
- * deliberately stays on the one existing save path (confirm prompt,
- * workspace resolution, validation, version semantics) instead of the
- * tool minting envelopes through a second door. A merge is a NEW
- * artefact superseding its inputs (new identity is correct — there is
- * no prior chain to extend, unlike the plan-revision case in
- * save-command.ts), and the extractor's counts-vs-rows validation acts
- * as a tamper backstop if the model edits the pasted block.
- *
- * NOT flag-gated: the abap-cca-merge skill depends on this tool; gating
- * it off would silently break the multi-consultant chain.
- *
- * Stays isMutating: false despite writing the merged detail file: the
- * write is the merge's own local artifact under .cspeach/ (derived
- * purely from envelopes the user supplied), the same trust level as the
- * save hook persisting the envelope — no SAP or user-file mutation.
- */
-import { mkdirSync, writeFileSync } from 'node:fs';
-import { dirname, isAbsolute, join } from 'node:path';
-import { registerTool } from '../index.js';
-import { mergeCcaAssessments, renderCcaMergeManifest, } from '../../projects/merge-cca.js';
-import { loadEnvelope, MANIFEST_PASTE_INSTRUCTIONS } from './_merge-shared.js';
-import { assertWritable } from '../_filesystem-shared.js';
-import { pointsIntoSharedCspeach, SHARED_CSPEACH_REFUSAL, teamWorkTarget } from '../_team-work-path.js';
-export async function ccaMergeHandler(args, ctx) {
-    if (!Array.isArray(args.inputs) || args.inputs.some((i) => typeof i !== 'string')) {
-        return { content: 'error: inputs must be an array of envelope paths / @-tokens.', is_error: true };
-    }
-    const tokens = args.inputs;
-    if (tokens.length === 1) {
-        return {
-            content: 'error: only one input supplied — a single assessment needs no merge. Use the file directly.',
-            is_error: true,
-        };
-    }
-    if (tokens.length < 2) {
-        return { content: 'error: at least 2 input envelopes are required.', is_error: true };
-    }
-    if (args.allow_cross_project !== undefined && typeof args.allow_cross_project !== 'boolean') {
-        return { content: 'error: allow_cross_project must be a boolean.', is_error: true };
-    }
-    // load + type-check every input before merging — fail with the precise file
-    const inputs = [];
-    const perInput = [];
-    for (const token of tokens) {
-        let resolved;
-        try {
-            resolved = await loadEnvelope(token, ctx.cwd, 'cca-assessment');
-        }
-        catch (e) {
-            return { content: `error: ${e instanceof Error ? e.message : String(e)}`, is_error: true };
-        }
-        const content = resolved.envelope.content;
-        inputs.push({ label: resolved.label, content });
-        perInput.push({
-            file: resolved.path,
-            label: resolved.label,
-            project_id: content.projectId,
-            scope: content.scope,
-            total_objects: content.summary.totalObjects,
-            keep: content.summary.keep,
-            fix: content.summary.fix,
-            retire: content.summary.retire,
-            redesign: content.summary.redesign,
-            uncategorized: content.summary.uncategorized,
-            truncated: content.classificationsTruncated === true,
-        });
-    }
-    let merged;
-    let warnings;
-    try {
-        ({ merged, warnings } = mergeCcaAssessments(inputs, {
-            allowCrossProject: args.allow_cross_project === true,
-        }));
-    }
-    catch (e) {
-        return { content: `error: ${e instanceof Error ? e.message : String(e)}`, is_error: true };
-    }
-    const title = `${inputs[0].content.projectId} — Merged (${inputs.length} slices)`;
-    // ── write the merged detail file BEFORE emitting the manifest ──────────
-    // The manifest's detail_path must point at a REAL file (the rule this
-    // branch added for /abap-cca emitters applies to the merge too). The
-    // manifest table caps at 50 rows; this file always carries every merged
-    // row. Minimal documented shape (a merge supersedes its inputs, so this
-    // is a fresh consolidated detail, not a phase-state project.json):
-    //   {
-    //     generatedAt:  ISO timestamp of the merge
-    //     projectId / scope / atcVariant / summary: as in the manifest
-    //     objects:      ALL merged classification rows (uncapped)
-    //     mergedFrom:   the input envelopes [{ file, label }]
-    //   }
-    let detailWritten = true;
-    // Task 15 — in a team folder the detail file is a working file: the seat's.
-    const t = teamWorkTarget(ctx.cwd, merged.detailPath);
-    const detailAbs = isAbsolute(t.path) ? t.path : join(t.root, t.path);
-    try {
-        // SEC (review round 2): the real landing path must stay in the project and
-        // not be protected (a junctioned .cspeach/<domain> -> .git is refused).
-        const realDetail = await assertWritable(detailAbs, t.root);
-        // Final fix wave, item 3 — never into the shared .cspeach of a team folder.
-        if (pointsIntoSharedCspeach(ctx.cwd, realDetail))
-            throw new Error(SHARED_CSPEACH_REFUSAL);
-        mkdirSync(dirname(detailAbs), { recursive: true });
-        writeFileSync(detailAbs, JSON.stringify({
-            generatedAt: new Date().toISOString(),
-            projectId: merged.projectId,
-            scope: merged.scope,
-            atcVariant: merged.atcVariant,
-            summary: merged.summary,
-            objects: merged.classifications,
-            mergedFrom: perInput.map((p) => ({ file: p.file, label: p.label })),
-        }, null, 2), 'utf8');
-    }
-    catch (e) {
-        detailWritten = false;
-        warnings.push(`DETAIL WRITE FAILED: could not write the merged detail file '${merged.detailPath}' `
-            + `(${e instanceof Error ? e.message : String(e)}). The manifest block omits detail_path — `
-            + `a manifest must never point at a file that does not exist — so the save will refuse it. `
-            + `Fix the path/permissions and re-run the merge.`);
-    }
-    const manifestBlock = renderCcaMergeManifest(merged, title, { omitDetailPath: !detailWritten });
-    return {
-        content: JSON.stringify({
-            merged_summary: merged.summary,
-            merged_project_id: merged.projectId,
-            merged_scope: merged.scope,
-            atc_variant: merged.atcVariant,
-            ...(detailWritten ? { detail_path: merged.detailPath } : {}),
-            per_input: perInput,
-            warnings,
-            // full merged rows — the manifest block caps at 50; nothing is lost
-            // from the transcript even for large estates.
-            merged_classifications: merged.classifications,
-            manifest_block: manifestBlock,
-            instructions: MANIFEST_PASTE_INSTRUCTIONS,
-        }, null, 2),
-    };
-}
-registerTool({
-    name: 'cca_merge',
-    description: 'Deterministically merge 2+ parallel /abap-cca assessment envelopes (.cspeach.json) into one consolidated '
-        + 'cca-assessment. Validates project identity and ATC variant, detects scope overlaps and classification '
-        + 'conflicts (most-restrictive wins: retire > redesign > fix > keep), recomputes all counts from the merged '
-        + 'rows, writes the full merged rows to a new detail file under .cspeach/cca/projects/, and returns warnings '
-        + 'plus a ready-made csforge:cca-manifest block to paste verbatim. '
-        + 'Inputs accept absolute/relative paths or bare workspace @-tokens.',
-    isMutating: false,
-    category: 'project',
-    input_schema: {
-        type: 'object',
-        properties: {
-            inputs: {
-                type: 'array',
-                items: { type: 'string' },
-                description: '2+ cca-assessment envelope references (path or @-token), one per consultant slice.',
-            },
-            allow_cross_project: {
-                type: 'boolean',
-                description: 'Accept inputs with different projectId (disjoint --scope slices of the same system). Default false.',
-            },
-        },
-        required: ['inputs'],
-    },
-    handler: (args, ctx) => ccaMergeHandler(args, ctx),
-});

package/test-harness/fe-draft/app.ts

@@ -1,188 +0,0 @@
-// cspeach-cli/test-harness/fe-draft/app.ts
-//
-// L1-2b — the apps the offline harness serves, built with the PRODUCT's own
-// tools (fiori_scaffold_fe, fiori_fe_extend handlers) so a scaffold regression
-// shows up here, not in a sitting.
-//
-//   good    — an LROP app over the captured draft service, exactly as
-//             fiori_scaffold_fe writes it, plus one harmless custom table
-//             action ("Ping") so the good app has something to press.
-//   broken  — the same app whose custom table action ("Boom") is wired to a
-//             handler that THROWS. A smoke that runs the press exercise must
-//             fail `exercises` on it.
-//   brokenPress — the same app with the custom action exactly as
-//             fiori_fe_extend writes it when asked for `eventHandler: true`:
-//             `"press": ""`. Pressing it makes UI5 try to load "/.js".
-import { readFile, writeFile, mkdir } from 'node:fs/promises';
-import * as path from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { fioriScaffoldFeHandler, feExtendHandler } from '../../src/tools/fiori/tools.js';
-import type { ToolContext } from '../../src/tools/index.js';
-import { openUrlFromStartScript } from './routes.js';
-
-const HERE = path.dirname(fileURLToPath(import.meta.url));
-
-/** The captured draft service (ZUI_LAS_INSPECTIONLOG_O4) — read in place by the mockserver. */
-export const DRAFT_METADATA = path.resolve(
-  HERE,
-  '../../src/tools/fiori/__tests__/fixtures/metadata/v4-draft-main.xml',
-);
-export const DRAFT_SERVICE_PATH =
-  '/sap/opu/odata4/sap/zui_las_inspectionlog_o4/srvd/sap/zui_las_inspectionlog_o4/0001/';
-export const DRAFT_MAIN_ENTITY = 'InspectionLog';
-/** Fully-qualified draft actions, as `SAP__common.DraftRoot` names them in the capture. */
-export const DRAFT_NS = 'com.sap.gateway.srvd.zui_las_inspectionlog_o4.v0001';
-
-/** The action button id suffix FE V4 renders for a manifest custom action. */
-export const customActionSelector = (name: string): string => `[id$="::CustomAction::${name}"]`;
-
-/**
- * Fixed active rows for the draft root. Invented values, US sample names; user
- * fields are MJOHNSON (the fixture convention). Status / Severity are the raw
- * one-letter codes the captured service really carries with no text — the shape
- * L1-3's no-raw-codes check has to catch.
- */
-const row = (n: number, equipment: string, inspector: string, severity: string, status: string) => ({
-  InspectionUUID: `00000000-0000-4000-8000-00000000000${n}`,
-  EquipmentName: equipment,
-  InspectionDate: '2026-09-0' + n,
-  Inspector: inspector,
-  Severity: severity,
-  SeverityCriticality: severity === 'H' ? 1 : severity === 'M' ? 2 : 3,
-  Status: status,
-  Note: '',
-  CreatedBy: 'MJOHNSON',
-  LocalLastChangedBy: 'MJOHNSON',
-  IsActiveEntity: true,
-  HasActiveEntity: false,
-  HasDraftEntity: false,
-});
-export const INSPECTION_ROWS = [
-  row(1, 'Pump P-100', 'Mike Johnson', 'H', 'O'),
-  row(2, 'Valve V-200', 'Sarah Davis', 'M', 'C'),
-  row(3, 'Motor M-300', 'David Carter', 'L', 'O'),
-];
-export const HARNESS_MOCK_ROWS = { [DRAFT_MAIN_ENTITY]: INSPECTION_ROWS };
-
-export const BROKEN_MARKER = 'CSP-HARNESS-BROKEN: the Boom handler threw';
-
-function ctxFor(root: string): ToolContext {
-  return {
-    adt: {} as ToolContext['adt'],
-    sapAlias: 'HARNESS',
-    session: {} as ToolContext['session'],
-    cwd: root,
-  };
-}
-
-async function must(r: { content: string; is_error?: boolean }, what: string): Promise<void> {
-  if (r.is_error) throw new Error(`${what} failed: ${r.content}`);
-}
-
-export interface HarnessApp {
-  /** Absolute app dir (holds webapp/). */
-  dir: string;
-  appId: string;
-  /** The page the scaffold's `npm start` opens (FLP sandbox + intent), app-relative. */
-  startEntry: string;
-}
-
-/** The FLP sandbox entry `npm start` opens for this app. */
-export const flpEntry = (app: HarnessApp): string => app.startEntry;
-
-/** Scaffold the LROP app through the fiori_scaffold_fe handler. `ui5Version` undefined = the product default. */
-async function scaffold(root: string, rel: string, appId: string, ui5Version?: string): Promise<HarnessApp> {
-  await must(
-    await fioriScaffoldFeHandler(
-      {
-        basePath: rel,
-        appId,
-        appTitle: 'Inspection Log (harness)',
-        template: 'lrop',
-        serviceUrl: 'http://localhost',
-        servicePath: DRAFT_SERVICE_PATH,
-        mainEntity: DRAFT_MAIN_ENTITY,
-        ...(ui5Version ? { ui5Version } : {}),
-      },
-      ctxFor(root),
-    ),
-    'fiori_scaffold_fe',
-  );
-  const dir = path.join(root, rel);
-  const pkg = JSON.parse(await readFile(path.join(dir, 'package.json'), 'utf8'));
-  return { dir, appId, startEntry: openUrlFromStartScript(pkg.scripts.start) };
-}
-
-/** Add a custom table action through the fiori_fe_extend handler. */
-async function addTableAction(root: string, rel: string, name: string, settings: Record<string, unknown>): Promise<void> {
-  await must(
-    await feExtendHandler(
-      {
-        basePath: rel,
-        op: 'custom-action',
-        params: {
-          name,
-          target: { page: `${DRAFT_MAIN_ENTITY}List`, control: '@com.sap.vocabularies.UI.v1.LineItem' },
-          settings: { text: name, ...settings },
-        },
-      },
-      ctxFor(root),
-    ),
-    'fiori_fe_extend custom-action',
-  );
-}
-
-/**
- * Point a custom action's `press` at `ext/<Name>.js#onPress` and write that
- * module with a known body (the good app's harmless handler, the broken app's
- * throwing one), replacing the stub fiori_fe_extend generated.
- */
-async function wireHandler(app: HarnessApp, name: string, body: string): Promise<void> {
-  const manifestPath = path.join(app.dir, 'webapp', 'manifest.json');
-  const manifest = JSON.parse(await readFile(manifestPath, 'utf8'));
-  const action =
-    manifest['sap.ui5'].routing.targets[`${DRAFT_MAIN_ENTITY}List`].options.settings.controlConfiguration[
-      '@com.sap.vocabularies.UI.v1.LineItem'
-    ].actions[name];
-  action.press = `${app.appId}.ext.${name}.onPress`;
-  await writeFile(manifestPath, JSON.stringify(manifest, null, 2));
-  await mkdir(path.join(app.dir, 'webapp', 'ext'), { recursive: true });
-  await writeFile(
-    path.join(app.dir, 'webapp', 'ext', `${name}.js`),
-    `sap.ui.define([], function () {\n  'use strict';\n  return { onPress: function () { ${body} } };\n});\n`,
-  );
-}
-
-/** The good app: scaffold as the product writes it, plus a harmless "Ping" action. */
-export async function buildGoodApp(root: string, ui5Version?: string): Promise<HarnessApp> {
-  const app = await scaffold(root, 'good', 'z.harness.good', ui5Version);
-  await addTableAction(root, 'good', 'Ping', {});
-  await wireHandler(app, 'Ping', 'return;');
-  return app;
-}
-
-/** The broken app: the "Boom" action's handler throws. */
-export async function buildBrokenApp(root: string, ui5Version?: string): Promise<HarnessApp> {
-  const app = await scaffold(root, 'broken', 'z.harness.broken', ui5Version);
-  await addTableAction(root, 'broken', 'Boom', {});
-  await wireHandler(app, 'Boom', `throw new Error(${JSON.stringify(BROKEN_MARKER)});`);
-  return app;
-}
-
-/**
- * The broken-press app: a custom action whose press names a handler module that
- * does not exist (a renamed or deleted ext file). fiori_fe_extend no longer
- * writes an empty press — it always generates a handler — so the realistic
- * broken case is a dangling reference.
- */
-export async function buildBrokenPressApp(root: string, ui5Version?: string): Promise<HarnessApp> {
-  const app = await scaffold(root, 'broken-press', 'z.harness.brokenpress', ui5Version);
-  await addTableAction(root, 'broken-press', 'Boom', {});
-  const manifestPath = path.join(app.dir, 'webapp', 'manifest.json');
-  const manifest = JSON.parse(await readFile(manifestPath, 'utf8'));
-  manifest['sap.ui5'].routing.targets[`${DRAFT_MAIN_ENTITY}List`].options.settings.controlConfiguration[
-    '@com.sap.vocabularies.UI.v1.LineItem'
-  ].actions.Boom.press = `${app.appId}.ext.missing.Missing.onPress`;
-  await writeFile(manifestPath, JSON.stringify(manifest, null, 2));
-  return app;
-}