@cspeach/cli 1.1.37 → 1.1.39

package/dist/tools/sap-read.js

@@ -394,8 +394,29 @@ registerTool({
     handler: async (args, ctx) => {
         // atcRun(type, name, variant?) — type first
         // Review fix round 1, M-3: Esc / Ctrl+C stops a long ATC run.
-        const result = await ctx.adt.atcRun(args.type, args.name, args.variant ?? 'DEFAULT', ctx.signal ? { signal: ctx.signal } : {});
-        return { content: JSON.stringify(result, null, 2) };
+        const variant = args.variant ?? 'DEFAULT';
+        const result = await ctx.adt.atcRun(args.type, args.name, variant, ctx.signal ? { signal: ctx.signal } : {});
+        // Fable review 2026-10-15, I-1: a finished run whose worklist never named
+        // the object did not check it (the variant has no check for that type).
+        // Say so plainly; "0 findings" there is not a measurement. Every other
+        // result is the same JSON as before (the coverage key is not added).
+        const { coverage, ...shown } = result;
+        if (coverage === 'absent' && result.totalFindings === 0) {
+            const objectName = `${String(args.type).toUpperCase()} ${String(args.name).toUpperCase()}`;
+            return {
+                content: [
+                    `ATC did not check ${objectName}.`,
+                    'SAP finished the run, but its worklist never listed this object.',
+                    'This is not a measurement. Do not report it as 0 findings or as clean.',
+                    'Likely causes:',
+                    `- the ${String(variant).toUpperCase()} check variant may have no check for this object type (seen on S4H for DDLS, DDLX, SRVD, DOMA);`,
+                    '- the name may be wrong, or the object may not exist or not be active.',
+                    'Use sap_search_object to confirm the object exists.',
+                    `(ATC worklist ${result.worklistId || 'unknown'})`,
+                ].join('\n'),
+            };
+        }
+        return { content: JSON.stringify(shown, null, 2) };
     },
 });
 // -----------------------------------------------------------------------

package/dist/tools/verify.js

@@ -12,6 +12,7 @@
  */
 import { recordSyntaxCheck } from './syntax-state.js';
 import { toObjectUrl, xmlParser } from '@cspeach/sap-client';
+import * as sapClient from '@cspeach/sap-client';
 /** Line for display: the parsed line, else the `#start=L,C` fragment of the
  *  checkruns uri (sap-client <= 0.1.14 left line at 0 for checkruns). */
 function lineOf(m) {
@@ -90,15 +91,35 @@ export function normaliseSyntaxResult(res) {
  * TABL is NOT retried here (live-check finding 3, 2026-10-14): sap-client
  * checks tables itself with an explicit chkrun:version ("inactive", then one
  * "active" retry on notProcessed), so its "did not run" is already final.
- * BDEF, DDLX and SRVD keep this retry until sap-client covers them too.
+ * STRU is not retried either (FINDINGS item 20, proved live 2026-10-15), nor
+ * BDEF, DDLX, SRVD (fix/active-only-checks, proved live 2026-10-15).
+ *
+ * The list is sap-client's own export (VERSIONED_CHECK_TYPES), so the two
+ * cannot drift. An older sap-client without the export checks only TABL
+ * itself (0.1.22), so the fallback is TABL: the CLI then keeps retrying every
+ * other type, as before. Still retried here today: DTEL, SRVB, DOMA.
  */
-const SAP_CLIENT_VERSIONED_TYPES = new Set(['TABL']);
+export function versionedTypesFrom(mod) {
+    let list;
+    try {
+        list = mod['VERSIONED_CHECK_TYPES'];
+    }
+    catch {
+        list = undefined;
+    } // a test mock without the export throws
+    if (!Array.isArray(list) || !list.every((t) => typeof t === 'string'))
+        return new Set(['TABL']);
+    return new Set(list.map((t) => t.toUpperCase()));
+}
+export function sapClientVersionedTypes() {
+    return versionedTypesFrom(sapClient);
+}
 export async function checkSyntax(adt, type, name) {
     try {
         return await adt.syntaxCheck(type, name);
     }
     catch (err) {
-        if (SAP_CLIENT_VERSIONED_TYPES.has(type.toUpperCase()))
+        if (sapClientVersionedTypes().has(type.toUpperCase()))
             throw err;
         if (!/did not run \(status notProcessed\)/i.test(String(err?.message ?? err)))
             throw err;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cspeach/cli",
-  "version": "1.1.37",
+  "version": "1.1.39",
   "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, signed skills, safety gates.",
   "keywords": [
     "abap",
@@ -54,7 +54,7 @@
     "@anthropic-ai/sdk": "^0.90.0",
     "@azure/msal-node": "6.0.1",
     "@cspeach/register-core": "0.4.0",
-    "@cspeach/sap-client": "0.1.22",
+    "@cspeach/sap-client": "0.1.24",
     "@iarna/toml": "^2.2.5",
     "@inkjs/ui": "^2.0.0",
     "@inquirer/prompts": "^7.0.0",