@cspeach/cli 1.1.36 → 1.1.38

package/dist/rewind/restore.js

@@ -28,6 +28,7 @@ import { effectiveRisk } from '../approvals/risk-floor.js';
 import { verifySyntax, verifyActive } from '../tools/verify.js';
 import { renderDiff } from '../repl/diff-display.js';
 import { parseIncludeSnapshotType } from '../tools/include-snapshot.js';
+import { hasManualLocks } from '../sap/session-end.js';
 /** Compact single-line failure text for receipts / error envelopes. */
 function shortError(err) {
     const msg = err instanceof Error ? err.message : String(err);
@@ -148,7 +149,8 @@ export async function restoreSnapshot(c, deps) {
     if (currentSource === null) {
         let created;
         try {
-            created = await deps.adt.createObject(c.objType, c.object, c.package ?? '', 'Restored via CSPeach rewind', deps.transport);
+            // Review fix round 1, I-1: keep the stateful session while a sap_lock is held.
+            created = await deps.adt.createObject(c.objType, c.object, c.package ?? '', 'Restored via CSPeach rewind', deps.transport, { keepSession: hasManualLocks() });
         }
         catch (err) {
             record('② written ✗');

package/dist/sap/session-end.js

@@ -26,6 +26,11 @@ export function noteManualLock() {
 export function noteManualUnlock() {
     manualLocks = Math.max(0, manualLocks - 1);
 }
+/** True while a `sap_lock` handle is held (review fix round 1, I-1): sap-client's
+ *  createObject must then keep the stateful session (extras.keepSession). */
+export function hasManualLocks() {
+    return manualLocks > 0;
+}
 export function __resetManualLocksForTests() {
     manualLocks = 0;
 }

package/dist/tools/sap-read.js

@@ -393,7 +393,8 @@ registerTool({
     },
     handler: async (args, ctx) => {
         // atcRun(type, name, variant?) — type first
-        const result = await ctx.adt.atcRun(args.type, args.name, args.variant ?? 'DEFAULT');
+        // Review fix round 1, M-3: Esc / Ctrl+C stops a long ATC run.
+        const result = await ctx.adt.atcRun(args.type, args.name, args.variant ?? 'DEFAULT', ctx.signal ? { signal: ctx.signal } : {});
         return { content: JSON.stringify(result, null, 2) };
     },
 });

package/dist/tools/sap-write.js

@@ -49,7 +49,7 @@ import { noteWriteTransport, setCurrentTransport } from '../repl/current-transpo
 import { markTransportCreatedThisSession } from './transport.js';
 import { presentSafetyConfirmation } from '../repl/safety-confirm.js';
 import { isSafetyConfirmEnabled } from '../repl/safety-mode-state.js';
-import { noteManualLock, noteManualUnlock } from '../sap/session-end.js';
+import { hasManualLocks, noteManualLock, noteManualUnlock } from '../sap/session-end.js';
 // ── Transcript visibility helpers (D16-display + tour slide-7, 2026-06-12) ──
 //
 // Rule 7 auto-snapshots always fired but the transcript never said so
@@ -825,6 +825,9 @@ registerTool({
                 bindingType: args.bindingType,
                 bindingVersion: args.bindingVersion,
                 ...devcExtras,
+                // Review fix round 1, I-1: a sap_lock handle lives in the stateful
+                // session; sap-client ends that session before a create unless told.
+                keepSession: hasManualLocks(),
             });
             await auditLog('createObject', args.type, args.name, 'success', Date.now() - startedAt);
         }

package/dist/tools/verify.js

@@ -12,6 +12,7 @@
  */
 import { recordSyntaxCheck } from './syntax-state.js';
 import { toObjectUrl, xmlParser } from '@cspeach/sap-client';
+import * as sapClient from '@cspeach/sap-client';
 /** Line for display: the parsed line, else the `#start=L,C` fragment of the
  *  checkruns uri (sap-client <= 0.1.14 left line at 0 for checkruns). */
 function lineOf(m) {
@@ -86,12 +87,40 @@ export function normaliseSyntaxResult(res) {
  * check once more with version="active" and require a processed report.
  * Anything else — an inactive version exists, the list is unreadable, the
  * retry is not processed — rethrows the original error (fail closed).
+ *
+ * TABL is NOT retried here (live-check finding 3, 2026-10-14): sap-client
+ * checks tables itself with an explicit chkrun:version ("inactive", then one
+ * "active" retry on notProcessed), so its "did not run" is already final.
+ * STRU is not retried either (FINDINGS item 20, proved live 2026-10-15), nor
+ * BDEF, DDLX, SRVD (fix/active-only-checks, proved live 2026-10-15).
+ *
+ * The list is sap-client's own export (VERSIONED_CHECK_TYPES), so the two
+ * cannot drift. An older sap-client without the export checks only TABL
+ * itself (0.1.22), so the fallback is TABL: the CLI then keeps retrying every
+ * other type, as before. Still retried here today: DTEL, SRVB, DOMA.
  */
+export function versionedTypesFrom(mod) {
+    let list;
+    try {
+        list = mod['VERSIONED_CHECK_TYPES'];
+    }
+    catch {
+        list = undefined;
+    } // a test mock without the export throws
+    if (!Array.isArray(list) || !list.every((t) => typeof t === 'string'))
+        return new Set(['TABL']);
+    return new Set(list.map((t) => t.toUpperCase()));
+}
+export function sapClientVersionedTypes() {
+    return versionedTypesFrom(sapClient);
+}
 export async function checkSyntax(adt, type, name) {
     try {
         return await adt.syntaxCheck(type, name);
     }
     catch (err) {
+        if (sapClientVersionedTypes().has(type.toUpperCase()))
+            throw err;
         if (!/did not run \(status notProcessed\)/i.test(String(err?.message ?? err)))
             throw err;
         const retried = await checkActiveVersion(adt, type, name).catch(() => undefined);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cspeach/cli",
-  "version": "1.1.36",
+  "version": "1.1.38",
   "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, signed skills, safety gates.",
   "keywords": [
     "abap",
@@ -54,7 +54,7 @@
     "@anthropic-ai/sdk": "^0.90.0",
     "@azure/msal-node": "6.0.1",
     "@cspeach/register-core": "0.4.0",
-    "@cspeach/sap-client": "0.1.21",
+    "@cspeach/sap-client": "0.1.23",
     "@iarna/toml": "^2.2.5",
     "@inkjs/ui": "^2.0.0",
     "@inquirer/prompts": "^7.0.0",