@cspeach/cli 1.1.18 → 1.1.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cspeach/cli",
-  "version": "1.1.18",
+  "version": "1.1.19",
   "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, 34 skills, safety gates.",
   "keywords": [
     "abap",
@@ -37,6 +37,7 @@
     "typecheck": "tsc --noEmit",
     "test": "vitest run",
     "test:watch": "vitest",
+    "test:smoke-e2e": "vitest run --config vitest.smoke-e2e.config.ts",
     "adt:smoke": "tsx scripts/adt-smoke.ts",
     "smoke:all": "pnpm zcspeach:smoke && pnpm adt:smoke",
     "zcspeach:smoke": "tsx scripts/zcspeach-smoke.ts",
@@ -52,16 +53,19 @@
   "dependencies": {
     "@anthropic-ai/sdk": "^0.90.0",
     "@cspeach/register-core": "0.1.0",
-    "@cspeach/sap-client": "0.1.13",
+    "@cspeach/sap-client": "0.1.15",
     "@iarna/toml": "^2.2.5",
     "@inkjs/ui": "^2.0.0",
     "@inquirer/prompts": "^7.0.0",
     "@napi-rs/keyring": "2.1.0",
     "@noble/ed25519": "2.1.0",
     "@noble/hashes": "1.4.0",
+    "@sap-ux/annotation-converter": "0.10.21",
+    "@sap-ux/edmx-parser": "0.10.0",
     "@sap-ux/fe-fpm-writer": "0.43.7",
     "@sap-ux/fiori-elements-writer": "^3.0.39",
     "@sap-ux/fiori-freestyle-writer": "3.0.12",
+    "@sap-ux/vocabularies-types": "0.15.0",
     "adm-zip": "0.5.17",
     "chalk": "^5.3.0",
     "cli-highlight": "^2.1.11",
@@ -83,11 +87,13 @@
     "openai": "^6.49.0",
     "puppeteer-core": "24.10.2",
     "react": "^18.3.0",
+    "string-width": "^7.2.0",
     "turndown": "^7.2.0",
     "unpdf": "1.7.0",
     "zod": "^3.23.0"
   },
   "devDependencies": {
+    "@sap-ux/ui5-middleware-fe-mockserver": "2.4.17",
     "@types/adm-zip": "0.5.8",
     "@types/cross-spawn": "^6.0.6",
     "@types/diff": "^7.0.2",
@@ -95,10 +101,13 @@
     "@types/node": "^20.17.0",
     "@types/react": "^18.3.0",
     "@types/turndown": "^5.0.5",
+    "@ui5/builder": "4.3.2",
+    "@ui5/fs": "4.0.6",
     "docx": "^9.0.2",
     "husky": "^9.1.7",
     "ink-testing-library": "^4.0.0",
     "pdf-lib": "^1.17.1",
+    "strip-ansi": "6.0.1",
     "tsx": "^4.19.0",
     "typescript": "^5.7.0",
     "vitest": "^2.1.0"

package/test-harness/fe-draft/app.ts

@@ -0,0 +1,188 @@
+// cspeach-cli/test-harness/fe-draft/app.ts
+//
+// L1-2b — the apps the offline harness serves, built with the PRODUCT's own
+// tools (fiori_scaffold_fe, fiori_fe_extend handlers) so a scaffold regression
+// shows up here, not in a sitting.
+//
+//   good    — an LROP app over the captured draft service, exactly as
+//             fiori_scaffold_fe writes it, plus one harmless custom table
+//             action ("Ping") so the good app has something to press.
+//   broken  — the same app whose custom table action ("Boom") is wired to a
+//             handler that THROWS. A smoke that runs the press exercise must
+//             fail `exercises` on it.
+//   brokenPress — the same app with the custom action exactly as
+//             fiori_fe_extend writes it when asked for `eventHandler: true`:
+//             `"press": ""`. Pressing it makes UI5 try to load "/.js".
+import { readFile, writeFile, mkdir } from 'node:fs/promises';
+import * as path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { fioriScaffoldFeHandler, feExtendHandler } from '../../src/tools/fiori/tools.js';
+import type { ToolContext } from '../../src/tools/index.js';
+import { openUrlFromStartScript } from './routes.js';
+
+const HERE = path.dirname(fileURLToPath(import.meta.url));
+
+/** The captured draft service (ZUI_LAS_INSPECTIONLOG_O4) — read in place by the mockserver. */
+export const DRAFT_METADATA = path.resolve(
+  HERE,
+  '../../src/tools/fiori/__tests__/fixtures/metadata/v4-draft-main.xml',
+);
+export const DRAFT_SERVICE_PATH =
+  '/sap/opu/odata4/sap/zui_las_inspectionlog_o4/srvd/sap/zui_las_inspectionlog_o4/0001/';
+export const DRAFT_MAIN_ENTITY = 'InspectionLog';
+/** Fully-qualified draft actions, as `SAP__common.DraftRoot` names them in the capture. */
+export const DRAFT_NS = 'com.sap.gateway.srvd.zui_las_inspectionlog_o4.v0001';
+
+/** The action button id suffix FE V4 renders for a manifest custom action. */
+export const customActionSelector = (name: string): string => `[id$="::CustomAction::${name}"]`;
+
+/**
+ * Fixed active rows for the draft root. Invented values, US sample names; user
+ * fields are MJOHNSON (the fixture convention). Status / Severity are the raw
+ * one-letter codes the captured service really carries with no text — the shape
+ * L1-3's no-raw-codes check has to catch.
+ */
+const row = (n: number, equipment: string, inspector: string, severity: string, status: string) => ({
+  InspectionUUID: `00000000-0000-4000-8000-00000000000${n}`,
+  EquipmentName: equipment,
+  InspectionDate: '2026-09-0' + n,
+  Inspector: inspector,
+  Severity: severity,
+  SeverityCriticality: severity === 'H' ? 1 : severity === 'M' ? 2 : 3,
+  Status: status,
+  Note: '',
+  CreatedBy: 'MJOHNSON',
+  LocalLastChangedBy: 'MJOHNSON',
+  IsActiveEntity: true,
+  HasActiveEntity: false,
+  HasDraftEntity: false,
+});
+export const INSPECTION_ROWS = [
+  row(1, 'Pump P-100', 'Mike Johnson', 'H', 'O'),
+  row(2, 'Valve V-200', 'Sarah Davis', 'M', 'C'),
+  row(3, 'Motor M-300', 'David Carter', 'L', 'O'),
+];
+export const HARNESS_MOCK_ROWS = { [DRAFT_MAIN_ENTITY]: INSPECTION_ROWS };
+
+export const BROKEN_MARKER = 'CSP-HARNESS-BROKEN: the Boom handler threw';
+
+function ctxFor(root: string): ToolContext {
+  return {
+    adt: {} as ToolContext['adt'],
+    sapAlias: 'HARNESS',
+    session: {} as ToolContext['session'],
+    cwd: root,
+  };
+}
+
+async function must(r: { content: string; is_error?: boolean }, what: string): Promise<void> {
+  if (r.is_error) throw new Error(`${what} failed: ${r.content}`);
+}
+
+export interface HarnessApp {
+  /** Absolute app dir (holds webapp/). */
+  dir: string;
+  appId: string;
+  /** The page the scaffold's `npm start` opens (FLP sandbox + intent), app-relative. */
+  startEntry: string;
+}
+
+/** The FLP sandbox entry `npm start` opens for this app. */
+export const flpEntry = (app: HarnessApp): string => app.startEntry;
+
+/** Scaffold the LROP app through the fiori_scaffold_fe handler. `ui5Version` undefined = the product default. */
+async function scaffold(root: string, rel: string, appId: string, ui5Version?: string): Promise<HarnessApp> {
+  await must(
+    await fioriScaffoldFeHandler(
+      {
+        basePath: rel,
+        appId,
+        appTitle: 'Inspection Log (harness)',
+        template: 'lrop',
+        serviceUrl: 'http://localhost',
+        servicePath: DRAFT_SERVICE_PATH,
+        mainEntity: DRAFT_MAIN_ENTITY,
+        ...(ui5Version ? { ui5Version } : {}),
+      },
+      ctxFor(root),
+    ),
+    'fiori_scaffold_fe',
+  );
+  const dir = path.join(root, rel);
+  const pkg = JSON.parse(await readFile(path.join(dir, 'package.json'), 'utf8'));
+  return { dir, appId, startEntry: openUrlFromStartScript(pkg.scripts.start) };
+}
+
+/** Add a custom table action through the fiori_fe_extend handler. */
+async function addTableAction(root: string, rel: string, name: string, settings: Record<string, unknown>): Promise<void> {
+  await must(
+    await feExtendHandler(
+      {
+        basePath: rel,
+        op: 'custom-action',
+        params: {
+          name,
+          target: { page: `${DRAFT_MAIN_ENTITY}List`, control: '@com.sap.vocabularies.UI.v1.LineItem' },
+          settings: { text: name, ...settings },
+        },
+      },
+      ctxFor(root),
+    ),
+    'fiori_fe_extend custom-action',
+  );
+}
+
+/**
+ * Point a custom action's `press` at `ext/<Name>.js#onPress` and write that
+ * module with a known body (the good app's harmless handler, the broken app's
+ * throwing one), replacing the stub fiori_fe_extend generated.
+ */
+async function wireHandler(app: HarnessApp, name: string, body: string): Promise<void> {
+  const manifestPath = path.join(app.dir, 'webapp', 'manifest.json');
+  const manifest = JSON.parse(await readFile(manifestPath, 'utf8'));
+  const action =
+    manifest['sap.ui5'].routing.targets[`${DRAFT_MAIN_ENTITY}List`].options.settings.controlConfiguration[
+      '@com.sap.vocabularies.UI.v1.LineItem'
+    ].actions[name];
+  action.press = `${app.appId}.ext.${name}.onPress`;
+  await writeFile(manifestPath, JSON.stringify(manifest, null, 2));
+  await mkdir(path.join(app.dir, 'webapp', 'ext'), { recursive: true });
+  await writeFile(
+    path.join(app.dir, 'webapp', 'ext', `${name}.js`),
+    `sap.ui.define([], function () {\n  'use strict';\n  return { onPress: function () { ${body} } };\n});\n`,
+  );
+}
+
+/** The good app: scaffold as the product writes it, plus a harmless "Ping" action. */
+export async function buildGoodApp(root: string, ui5Version?: string): Promise<HarnessApp> {
+  const app = await scaffold(root, 'good', 'z.harness.good', ui5Version);
+  await addTableAction(root, 'good', 'Ping', {});
+  await wireHandler(app, 'Ping', 'return;');
+  return app;
+}
+
+/** The broken app: the "Boom" action's handler throws. */
+export async function buildBrokenApp(root: string, ui5Version?: string): Promise<HarnessApp> {
+  const app = await scaffold(root, 'broken', 'z.harness.broken', ui5Version);
+  await addTableAction(root, 'broken', 'Boom', {});
+  await wireHandler(app, 'Boom', `throw new Error(${JSON.stringify(BROKEN_MARKER)});`);
+  return app;
+}
+
+/**
+ * The broken-press app: a custom action whose press names a handler module that
+ * does not exist (a renamed or deleted ext file). fiori_fe_extend no longer
+ * writes an empty press — it always generates a handler — so the realistic
+ * broken case is a dangling reference.
+ */
+export async function buildBrokenPressApp(root: string, ui5Version?: string): Promise<HarnessApp> {
+  const app = await scaffold(root, 'broken-press', 'z.harness.brokenpress', ui5Version);
+  await addTableAction(root, 'broken-press', 'Boom', {});
+  const manifestPath = path.join(app.dir, 'webapp', 'manifest.json');
+  const manifest = JSON.parse(await readFile(manifestPath, 'utf8'));
+  manifest['sap.ui5'].routing.targets[`${DRAFT_MAIN_ENTITY}List`].options.settings.controlConfiguration[
+    '@com.sap.vocabularies.UI.v1.LineItem'
+  ].actions.Boom.press = `${app.appId}.ext.missing.Missing.onPress`;
+  await writeFile(manifestPath, JSON.stringify(manifest, null, 2));
+  return app;
+}