@cspeach/cli 0.6.5 → 0.7.1

package/dist/ui/widgets/coaching-picker.js

@@ -4,16 +4,40 @@ import { Box, Text, useInput } from 'ink';
 import { PICK_CANCELLED } from '../skill-picker.js';
 const PEACH = '#FFCBA4';
 /**
- * Ink-mode coaching picker rendered as an overlay inside <App>. The parent
- * (App) mounts this component only when coachingPending !== null, so the
- * component's useInput being always-active is safe — it can only fire
- * while the overlay is visible.
+ * Ink-mode coaching picker — compact single-line-per-option layout.
  *
- * Cursor starts at 0 when params.preSelect (coach mode — Enter accepts top-1)
- * and at -1 when false (picker mode — user must arrow-key to their choice).
+ * Phase D3+ (2026-05-16): the prior layout used a bordered Box per
+ * option with 3 text rows each (skill+confidence, Does:, Pick if:).
+ * For 5 options that's ~25 lines — exceeded available vertical space
+ * once mounted inline between Body and Footer, and Ink overflow-
+ * clipped only the BOTTOM line of each option leaving a garbled
+ * picker (screenshot 71). This rewrite uses one line per option +
+ * a "details" line only for the highlighted entry, total height
+ * bounded to ~8 lines regardless of option count.
+ *
+ * Layout (example, 3 options):
+ *   ╭ Pick a skill for: "What is the best part…?" ───────────╮
+ *   │  ▸ /abap-explain   72%   Plain-language code explainer  │
+ *   │    /abap-review     0%   Code review vs quality criteria│
+ *   │    /abap-document   0%   Generate ABAP documentation    │
+ *   │                                                          │
+ *   │  ▸ /abap-explain — Pick if: pick this to teach code to a human   │
+ *   │  ↑/↓ navigate · Enter select · Esc cancel                │
+ *   ╰──────────────────────────────────────────────────────────╯
  */
 export function CoachingPicker({ params, onResolve }) {
-    const [cursor, setCursor] = useState(params.preSelect ? 0 : -1);
+    // 2026-05-17 — initial cursor position priority:
+    //   1. preferSkill (the just-used skill, if present in options) — lets
+    //      the user confirm "same skill as last turn" with one Enter press
+    //   2. preSelect=true → top-1 (classifier's best guess)
+    //   3. -1 → no selection, user must arrow-key to a choice
+    const preferIdx = params.preferSkill
+        ? params.options.findIndex((o) => o.skill === params.preferSkill)
+        : -1;
+    const initialCursor = preferIdx >= 0
+        ? preferIdx
+        : params.preSelect ? 0 : -1;
+    const [cursor, setCursor] = useState(initialCursor);
     useInput((_input, key) => {
         if (key.escape) {
             onResolve(PICK_CANCELLED);
@@ -37,5 +61,28 @@ export function CoachingPicker({ params, onResolve }) {
                 onResolve(chosen.skill);
         }
     }, { isActive: true });
-    return (_jsxs(Box, { borderStyle: "round", borderColor: PEACH, flexDirection: "column", padding: 1, children: [_jsxs(Text, { bold: true, children: ["I'm not sure which skill fits for: \"", params.prompt.slice(0, 50), params.prompt.length > 50 ? '...' : '', "\"."] }), _jsx(Text, { bold: true, children: "Pick one:" }), params.options.map((opt, i) => (_jsxs(Box, { borderStyle: i === cursor ? 'round' : 'single', borderColor: i === cursor ? PEACH : 'gray', flexDirection: "column", marginTop: 1, children: [_jsxs(Text, { bold: true, children: ["/", opt.skill, " \u00B7 ", Math.round(opt.confidence * 100), "%"] }), _jsxs(Text, { dimColor: true, children: ["Does: ", opt.whatItDoes] }), _jsxs(Text, { dimColor: true, children: ["Pick if: ", opt.whenToPick] })] }, opt.skill))), _jsx(Text, { dimColor: true, children: "\u2191/\u2193 navigate \u00B7 Enter select \u00B7 Esc cancel" })] }));
+    const promptPreview = params.prompt.length > 60
+        ? params.prompt.slice(0, 57) + '…'
+        : params.prompt;
+    const highlighted = cursor >= 0 ? params.options[cursor] : undefined;
+    return (
+    // flexShrink={0} (2026-05-17) — without this, Ink's default
+    // flexShrink: 1 lets the picker get squashed when vertical space is
+    // tight, and the TOP options clip off (only the bottom one remained
+    // visible — see screenshot 74). flexShrink={0} guarantees the picker
+    // claims its natural height; Body shrinks to make room (and Body
+    // content stays recoverable via PgUp/Ctrl+B scroll).
+    _jsxs(Box, { borderStyle: "round", borderColor: PEACH, flexDirection: "column", paddingX: 1, flexShrink: 0, children: [_jsxs(Text, { bold: true, children: ["Pick a skill for: ", _jsxs(Text, { color: "cyan", children: ["\"", promptPreview, "\""] })] }), _jsx(Box, { marginTop: 1, flexDirection: "column", children: params.options.map((opt, i) => {
+                    const isCursor = i === cursor;
+                    const arrow = isCursor ? '▸ ' : '  ';
+                    // 2026-05-17 — hide the "0%" cruft. Confidence is 0 for any
+                    // alternate / fallback option (we never had a real score for
+                    // them), AND for top-1 picks where the classifier itself
+                    // returned 0. In both cases displaying "0%" looks broken.
+                    // Show "%" only when there's a meaningful number.
+                    const pctNum = Math.round(opt.confidence * 100);
+                    const pct = pctNum > 0 ? `${pctNum.toString().padStart(3, ' ')}%` : '    ';
+                    const name = `/${opt.skill}`.padEnd(20, ' ');
+                    return (_jsxs(Text, { color: isCursor ? PEACH : undefined, bold: isCursor, children: [arrow, name, " ", pct, "  ", opt.whatItDoes.slice(0, 60)] }, opt.skill));
+                }) }), highlighted && (_jsx(Box, { marginTop: 1, children: _jsxs(Text, { dimColor: true, children: ["Pick if: ", highlighted.whenToPick] }) })), _jsx(Box, { marginTop: 1, children: _jsx(Text, { dimColor: true, children: "\u2191/\u2193 navigate \u00B7 Enter select \u00B7 Esc cancel" }) })] }));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cspeach/cli",
-  "version": "0.6.5",
+  "version": "0.7.1",
   "description": "CSPeach — AI-assisted ABAP development CLI. Direct SAP access, 34 skills, safety gates.",
   "keywords": [
     "abap",