@crvouga/atlas 1.3.0 → 1.5.0

package/packages/visualizer/src/explorer/RunsView.tsx

@@ -7,7 +7,8 @@ import { Alert, Anchor, Box, Button, Code, Flex, Group, List, Stack, Table, Text
  * tests and how they went, how long it took, whether it has recordings to watch, and a link to the run. Opening one lists
  * every test it ran, filterable, with a way to show exactly those tests in the explorer. Videos are counted as
  * references (every mention) and as distinct playable recordings (identical bytes are one), and a reference whose file
- * was never stored is shown as unavailable, never as a recording.
+ * was never stored is shown as unavailable, never as a recording. An opened run lists its artifacts first (see
+ * `RunArtifacts`), and a run of no checks says so instead of reading as passed.
  */
 import { videoCounts } from '@crvouga/atlas/reports/evidence-detail';
 import type { VideoCounts, VideoRef } from '@crvouga/atlas/reports/evidence-types';
@@ -19,6 +20,7 @@ import { useMemo, useState } from 'react';
 import { ago, exactTime, plural, shortSha, statusWord, useNow } from '../evidence/format';
 import { Meter, StatusMark } from '../evidence/marks';
 import { useRunDetail, useRunList } from './catalog';
+import { RunArtifacts } from './RunArtifacts';
 import { FilterBar } from './filters';
 import { patched, useExplorerNavigate, useExplorerSearch } from './navigate';
 import { runName } from './parts';
@@ -44,6 +46,13 @@ function Freshness({ run }: { run: RunSummary }) {
   );
 }
 function Counts({ run }: { run: RunSummary }) {
+  // A run of no checks (only files) has not passed anything: say so, rather than "0 passed".
+  if (run.tests === 0 && Object.values(run.counts).every((count) => count === 0))
+    return (
+      <Text span inherit c="dimmed" data-status="none">
+        No checks recorded
+      </Text>
+    );
   return (
     <Text span inherit>
       {run.counts.failed > 0 && (
@@ -88,14 +97,35 @@ function Unavailable({ videos }: { videos: VideoCounts }) {
 /** A run's videos in its row: a link to the recordings, how many references they come from, and what cannot be played. */
 function RunVideos({ run }: { run: RunSummary }) {
   const videos = run.videos;
-  if (!videos) return <Text span inherit c="dimmed" data-video="none">No video</Text>;
+  const files = run.attachments ? (
+    <Anchor
+      aria-label={`Open the ${plural(run.attachments, 'file', 'files')} of run ${runName(run.key)}`}
+      renderRoot={(props) => (
+        <Link {...props} to="/" search={patched({ openRun: run.key, layer: undefined, artifact: undefined, video: undefined })} resetScroll={false} activeOptions={{ exact: true }} />
+      )}
+    >
+      <Text span inherit data-run-files>
+        {plural(run.attachments, 'run file', 'run files')}
+      </Text>
+    </Anchor>
+  ) : null;
+  if (!videos)
+    return (
+      <Stack gap={0}>
+        <Text span inherit c="dimmed" data-video="none">
+          No video
+        </Text>
+        {files}
+      </Stack>
+    );
   return (
     <Stack gap={0} data-video={videos.recordings > 0 ? 'available' : 'unavailable'}>
+      {files}
       {videos.recordings > 0 && (
         <Anchor
           aria-label={`Watch ${plural(videos.recordings, 'recording', 'recordings')} in run ${runName(run.key)}`}
           renderRoot={(props) => (
-            <Link {...props} to="/" search={patched({ openRun: run.key, video: true })} resetScroll={false} activeOptions={{ exact: true }} />
+            <Link {...props} to="/" search={patched({ openRun: run.key, layer: undefined, artifact: undefined, video: true })} resetScroll={false} activeOptions={{ exact: true }} />
           )}
         >
           <IconVideo size={16} aria-hidden="true" /> {plural(videos.recordings, 'video', 'videos')}
@@ -204,12 +234,12 @@ function RunTable() {
           </Table.Thead>
           <Table.Tbody>
             {list.slice(0, shown).map((run) => (
-              <Table.Tr key={run.key} data-status={run.counts.failed ? 'failed' : 'passed'}>
+              <Table.Tr key={run.key} data-status={run.counts.failed ? 'failed' : run.tests === 0 ? 'not-run' : 'passed'}>
                 <Table.Td title={exactTime(run.endedAtMs)}>
                   <Anchor
                     aria-label={`Open run ${runLabel(run)}`}
                     renderRoot={(props) => (
-                      <Link {...props} to="/" search={patched({ openRun: run.key, video: undefined })} resetScroll={false} activeOptions={{ exact: true }} />
+                      <Link {...props} to="/" search={patched({ openRun: run.key, layer: undefined, artifact: undefined, video: undefined })} resetScroll={false} activeOptions={{ exact: true }} />
                     )}
                   >
                     {ago(run.endedAtMs, now)}
@@ -319,7 +349,7 @@ function RunDetailView({ runKey }: { runKey: string }) {
   const back = (
     <Anchor
       renderRoot={(props) => (
-        <Link {...props} to="/" search={patched({ openRun: undefined })} resetScroll={false} activeOptions={{ exact: true }} />
+        <Link {...props} to="/" search={patched({ openRun: undefined, layer: undefined, artifact: undefined })} resetScroll={false} activeOptions={{ exact: true }} />
       )}
     >
       <Text aria-hidden="true" span inherit>
@@ -395,7 +425,7 @@ function RunDetailView({ runKey }: { runKey: string }) {
           <Meter counts={run.counts} />
         </Text>
         <Text span inherit>
-          {plural(run.tests, 'test', 'tests')}
+          {run.tests === 0 ? 'No tests' : plural(run.tests, 'test', 'tests')}
         </Text>
         <Counts run={run} />
       </Stack>
@@ -406,13 +436,14 @@ function RunDetailView({ runKey }: { runKey: string }) {
           <Unavailable videos={run.videos} />
         </Text>
       )}
+      <RunArtifacts detail={detail.data} />
       <Flex gap="xs" align="center" wrap="wrap">
         <Anchor
           renderRoot={(props) => (
             <Link
               {...props}
               to="/"
-              search={patched({ tab: undefined, openRun: undefined, inRun: run.key, test: undefined, layer: undefined })}
+              search={patched({ tab: undefined, openRun: undefined, inRun: run.key, test: undefined, layer: undefined, artifact: undefined })}
               resetScroll={false}
               activeOptions={{ exact: true }}
             />
@@ -488,7 +519,7 @@ function RunDetailView({ runKey }: { runKey: string }) {
                     <Link
                       {...props}
                       to="/"
-                      search={patched({ tab: undefined, openRun: undefined, test: result.key, layer: result.layer })}
+                      search={patched({ tab: undefined, openRun: undefined, artifact: undefined, test: result.key, layer: result.layer })}
                       resetScroll={false}
                       activeOptions={{ exact: true }}
                     />

package/packages/visualizer/src/explorer/search.ts

@@ -2,7 +2,7 @@
  * @module Explorer address
  *
  * Everything the test explorer shows is in the address of the `/` route, so a link reproduces the view: the open test,
- * the words searched, the filters, the grouping, the order, the Runs tab with the run opened in it, and the exact layer a test's detail is pinned to. Filters that
+ * the words searched, the filters, the grouping, the order, the Runs tab with the run opened in it, the exact layer a test's detail is pinned to, and the one file of a run's layer its Artifacts select. Filters that
  * take several values are comma-separated (`status=failed,flaky`); a comma or backslash inside a value is written `\,`
  * or `\\`, and the router encodes `#` and spaces. Anything unreadable is dropped, never an error.
  *
@@ -60,8 +60,10 @@ export const ExplorerSearchFields = {
   tab: z.enum(['runs', 'artifacts']).optional().catch(undefined),
   /** The run opened in the Runs tab. */
   openRun: text,
-  /** Pins the open test's detail to one exact layer (a run's record of it), instead of the latest combined evidence. */
+  /** Pins the open test's detail to one exact layer (a run's record of it), instead of the latest combined evidence. With `openRun` and `artifact` it names the layer the file is in. */
   layer: text,
+  /** With `openRun` and `layer`: the one file of that layer (an `artifactRef`: `id:…`, `key:…` or `name:…`) the run's Artifacts select. */
+  artifact: text,
   /** Only the runs, and the results of an opened run, that have a playable video recording. */
   video: z.preprocess((value) => (value === 'true' ? true : value), z.literal(true)).optional().catch(undefined)
 };
@@ -91,6 +93,7 @@ export type ExplorerSearch = {
   readonly tab?: 'runs' | 'artifacts';
   readonly openRun?: string;
   readonly layer?: string;
+  readonly artifact?: string;
   readonly video?: true;
 };