@crvouga/atlas 1.11.0 → 1.13.0

package/packages/schema/schemas/critique.schema.json

@@ -0,0 +1,254 @@
+{
+  "$id": "https://github.com/crvouga/atlas/schemas/critique.schema.json",
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "type": "object",
+  "properties": {
+    "schema": {
+      "type": "integer",
+      "exclusiveMinimum": 0,
+      "maximum": 9007199254740991,
+      "description": "The version of this extension. 1"
+    },
+    "subject": {
+      "type": "object",
+      "properties": {
+        "entryKey": {
+          "type": "string",
+          "minLength": 1,
+          "description": "The catalog entry that was judged"
+        },
+        "imageSha256": {
+          "type": "string",
+          "minLength": 1,
+          "description": "The hash of the exact image bytes that were judged. When the entry's image changes, this critique judged an earlier image"
+        },
+        "state": {
+          "description": "The kind of UI state: `screen`, `overlay`, `loading`, `error`, `empty`…",
+          "type": "string",
+          "minLength": 1
+        }
+      },
+      "required": [
+        "entryKey",
+        "imageSha256"
+      ],
+      "additionalProperties": {}
+    },
+    "critic": {
+      "type": "object",
+      "properties": {
+        "name": {
+          "type": "string",
+          "minLength": 1
+        },
+        "version": {
+          "type": "string",
+          "minLength": 1,
+          "description": "Of the critic's own logic. A newer version replaces an older one"
+        },
+        "kind": {
+          "description": "Open vocabulary: `model`, `llm`, `ml`, `heuristic`…",
+          "type": "string",
+          "minLength": 1
+        }
+      },
+      "required": [
+        "name",
+        "version"
+      ],
+      "additionalProperties": {}
+    },
+    "model": {
+      "type": "object",
+      "properties": {
+        "id": {
+          "type": "string",
+          "minLength": 1
+        },
+        "provider": {
+          "type": "string"
+        }
+      },
+      "required": [
+        "id"
+      ],
+      "additionalProperties": {}
+    },
+    "parameters": {
+      "description": "Everything else that explains the result: temperature, seed, the SHA-256 of the rubric",
+      "type": "object",
+      "propertyNames": {
+        "type": "string"
+      },
+      "additionalProperties": {}
+    },
+    "verdict": {
+      "type": "object",
+      "properties": {
+        "score": {
+          "description": "A finite number. `scale` says what it means",
+          "type": "number"
+        },
+        "scale": {
+          "description": "For example `0..1, higher is better`",
+          "type": "string"
+        },
+        "label": {
+          "description": "Open vocabulary, conventionally `ok` or `needs-polish`",
+          "type": "string"
+        },
+        "confidence": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 1
+        },
+        "relative": {
+          "type": "object",
+          "properties": {
+            "stateKind": {
+              "type": "string",
+              "minLength": 1,
+              "description": "The kind of UI state the score is relative to: `screen`, `overlay`, `loading`, `error`, `empty`…"
+            },
+            "percentile": {
+              "description": "Where the score falls among the project's scores of the same state kind, 0..100, higher is better",
+              "type": "number",
+              "minimum": 0,
+              "maximum": 100
+            },
+            "sampleSize": {
+              "description": "How many scores of that state kind the percentile is over",
+              "type": "integer",
+              "minimum": 0,
+              "maximum": 9007199254740991
+            },
+            "previousScore": {
+              "description": "The same entry's score for its previous image, from the same critic",
+              "type": "number"
+            },
+            "delta": {
+              "description": "`score` minus `previousScore`",
+              "type": "number"
+            }
+          },
+          "required": [
+            "stateKind"
+          ],
+          "additionalProperties": {}
+        }
+      },
+      "additionalProperties": {}
+    },
+    "findings": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "properties": {
+          "id": {
+            "description": "Stable within the critique, so a reviewer can mark this finding valid or not",
+            "type": "string",
+            "minLength": 1
+          },
+          "category": {
+            "description": "Open vocabulary: `spacing`, `contrast`, `alignment`, `overflow`, `hierarchy`…",
+            "type": "string",
+            "minLength": 1
+          },
+          "severity": {
+            "description": "Open vocabulary, conventionally `info`, `minor`, `major`",
+            "type": "string",
+            "minLength": 1
+          },
+          "confidence": {
+            "type": "number",
+            "minimum": 0,
+            "maximum": 1
+          },
+          "region": {
+            "type": "object",
+            "properties": {
+              "unit": {
+                "type": "string",
+                "minLength": 1,
+                "description": "`px` (pixels of the stored image) or `normalized` (0..1 of its width and height). Open vocabulary"
+              },
+              "x": {
+                "type": "number"
+              },
+              "y": {
+                "type": "number"
+              },
+              "w": {
+                "type": "number",
+                "minimum": 0
+              },
+              "h": {
+                "type": "number",
+                "minimum": 0
+              }
+            },
+            "required": [
+              "unit",
+              "x",
+              "y",
+              "w",
+              "h"
+            ],
+            "additionalProperties": {}
+          },
+          "rationale": {
+            "type": "string"
+          },
+          "suggestion": {
+            "type": "string"
+          }
+        },
+        "additionalProperties": {}
+      }
+    },
+    "failure": {
+      "type": "object",
+      "properties": {
+        "reason": {
+          "type": "string",
+          "minLength": 1
+        },
+        "message": {
+          "type": "string"
+        }
+      },
+      "required": [
+        "reason"
+      ],
+      "additionalProperties": {}
+    },
+    "usage": {
+      "type": "object",
+      "properties": {
+        "inputTokens": {
+          "type": "number",
+          "minimum": 0
+        },
+        "outputTokens": {
+          "type": "number",
+          "minimum": 0
+        },
+        "latencyMs": {
+          "type": "number",
+          "minimum": 0
+        },
+        "costUsd": {
+          "type": "number",
+          "minimum": 0
+        }
+      },
+      "additionalProperties": {}
+    }
+  },
+  "required": [
+    "schema",
+    "subject",
+    "critic"
+  ],
+  "additionalProperties": {}
+}

package/packages/schema/schemas/server-config.schema.json

@@ -40,10 +40,11 @@
                 "type": "string",
                 "enum": [
                   "read",
+                  "critic",
                   "publish",
                   "admin"
                 ],
-                "description": "`read` may look. `publish` may also upload. `admin` may also remove scratch objects"
+                "description": "`read` may look. `critic` may also publish critiques (layers of producer `critic.*` whose parts are all of kind `critique`). `publish` may also upload. `admin` may also remove scratch objects"
               },
               "token": {
                 "description": "The token. Prefer `tokenEnv`, so the file holds no secret",

package/packages/schema/schemas/server-info.schema.json

@@ -18,6 +18,7 @@
       "type": "string",
       "enum": [
         "read",
+        "critic",
         "publish",
         "admin"
       ],

package/packages/server/openapi.json

@@ -2,9 +2,9 @@
   "openapi": "3.1.0",
   "info": {
     "title": "Atlas server API",
-    "version": "1.5.0",
+    "version": "1.6.0",
     "summary": "Take in test results from every environment, keep them, and show everyone the combined report, live.",
-    "description": "One Atlas node serves multiple projects. Clients select a project using ?project=<slug>, X-Atlas-Project, or /api/projects/<slug>/… . Each project has independent specs, layers, recordings, status, and event streams. Within each project, the newest completed result of every check wins its slot. Unqualified requests address the legacy default project.\n\n**Authentication.** With tokens configured, send `Authorization: Bearer <token>`. Roles: `read` < `publish` < `admin`. Uploading needs a Bearer token; a browser's HTTP Basic sign-in (any user name, the token as the password) is accepted for reading only. A server with no tokens is open and listens on this machine only unless told otherwise.\n\n**Errors** are [RFC 9457](https://www.rfc-editor.org/rfc/rfc9457) problem documents (`application/problem+json`) with a `detail` that says what to do. `401` send a token, `403` that token may not, `409` upload what this depends on first or you are changing something immutable, `413` too large, `422` not valid, `503` still starting (retry after `Retry-After`).\n\n**Compatibility.** Within `/api` the API only grows: optional parameters, optional response fields, new events. Ignore what you do not know.\n\nGuides: `/llms.txt`. Source: https://github.com/crvouga/atlas.",
+    "description": "One Atlas node serves multiple projects. Clients select a project using ?project=<slug>, X-Atlas-Project, or /api/projects/<slug>/… . Each project has independent specs, layers, recordings, status, and event streams. Within each project, the newest completed result of every check wins its slot. Unqualified requests address the legacy default project.\n\n**Authentication.** With tokens configured, send `Authorization: Bearer <token>`. Roles: `read` < `critic` < `publish` < `admin`. A `critic` token may read, and publish critiques (layers of automated reviewers) and nothing else. Uploading needs a Bearer token; a browser's HTTP Basic sign-in (any user name, the token as the password) is accepted for reading only. A server with no tokens is open and listens on this machine only unless told otherwise.\n\n**Errors** are [RFC 9457](https://www.rfc-editor.org/rfc/rfc9457) problem documents (`application/problem+json`) with a `detail` that says what to do. `401` send a token, `403` that token may not, `409` upload what this depends on first or you are changing something immutable, `413` too large, `422` not valid, `503` still starting (retry after `Retry-After`).\n\n**Compatibility.** Within `/api` the API only grows: optional parameters, optional response fields, new events. Ignore what you do not know.\n\nGuides: `/llms.txt`. Source: https://github.com/crvouga/atlas.",
     "license": {
       "name": "MIT",
       "identifier": "MIT"
@@ -2683,8 +2683,8 @@
           "Store protocol"
         ],
         "summary": "Upload an object",
-        "description": "The write half of the `ObjectStore` interface. The server checks what it can from the bytes in hand and says no to what would corrupt the report for everyone:\n\n- a **layer manifest** (`layers/manifests/<id>.json`) must be a valid layer whose content hashes to `<id>`, and its blobs must already be there (`409` otherwise);\n- a **blob** (`layers/blobs/<sha256>.gz`) must be gzip of content whose SHA-256 is its name; a **spec file** likewise;\n- a **catalog entry** (`…/index/…`) must name something already uploaded (`409` otherwise): it is what makes a layer visible, so it is written last;\n- a **run manifest** must have passed its privacy scan;\n- keys are immutable: the same bytes again are `200` (a retry), other bytes under the same key are `409`.\n\nUpload in dependency order: blobs, then the manifest, then the catalog entry. `atlas report publish`, `atlas report stream` and `httpStore` do. Needs a `Bearer` token of role `publish` or `admin`; a browser's sign-in box is refused.\n\nRole needed: `publish`.",
-        "x-atlas-role": "publish",
+        "description": "The write half of the `ObjectStore` interface. The server checks what it can from the bytes in hand and says no to what would corrupt the report for everyone:\n\n- a **layer manifest** (`layers/manifests/<id>.json`) must be a valid layer whose content hashes to `<id>`, and its blobs must already be there (`409` otherwise);\n- a **blob** (`layers/blobs/<sha256>.gz`) must be gzip of content whose SHA-256 is its name; a **spec file** likewise;\n- a **catalog entry** (`…/index/…`) must name something already uploaded (`409` otherwise): it is what makes a layer visible, so it is written last;\n- a **run manifest** must have passed its privacy scan;\n- keys are immutable: the same bytes again are `200` (a retry), other bytes under the same key are `409`.\n\nUpload in dependency order: blobs, then the manifest, then the catalog entry. `atlas report publish`, `atlas report stream` and `httpStore` do. Needs a `Bearer` token of role `publish` or `admin`; a browser's sign-in box is refused.\n\nA token of role `critic` may upload only what a critic publishes: blobs, and layers (and their catalog entries) whose `producer` is `critic.<name>` and whose parts are all of kind `critique`. Anything else is `403` with the rule it broke, and nothing is stored.\n\nRole needed: `critic`.",
+        "x-atlas-role": "critic",
         "security": [
           {
             "bearer": []
@@ -3029,8 +3029,8 @@
           "Store protocol"
         ],
         "summary": "Upload an object",
-        "description": "The write half of the `ObjectStore` interface. The server checks what it can from the bytes in hand and says no to what would corrupt the report for everyone:\n\n- a **layer manifest** (`layers/manifests/<id>.json`) must be a valid layer whose content hashes to `<id>`, and its blobs must already be there (`409` otherwise);\n- a **blob** (`layers/blobs/<sha256>.gz`) must be gzip of content whose SHA-256 is its name; a **spec file** likewise;\n- a **catalog entry** (`…/index/…`) must name something already uploaded (`409` otherwise): it is what makes a layer visible, so it is written last;\n- a **run manifest** must have passed its privacy scan;\n- keys are immutable: the same bytes again are `200` (a retry), other bytes under the same key are `409`.\n\nUpload in dependency order: blobs, then the manifest, then the catalog entry. `atlas report publish`, `atlas report stream` and `httpStore` do. Needs a `Bearer` token of role `publish` or `admin`; a browser's sign-in box is refused.\n\nScoped to one project. The same project may be selected on the unprefixed API using ?project= or X-Atlas-Project. Unknown projects return 404 on reads and are created by an authenticated upload.\n\nRole needed: `publish`.",
-        "x-atlas-role": "publish",
+        "description": "The write half of the `ObjectStore` interface. The server checks what it can from the bytes in hand and says no to what would corrupt the report for everyone:\n\n- a **layer manifest** (`layers/manifests/<id>.json`) must be a valid layer whose content hashes to `<id>`, and its blobs must already be there (`409` otherwise);\n- a **blob** (`layers/blobs/<sha256>.gz`) must be gzip of content whose SHA-256 is its name; a **spec file** likewise;\n- a **catalog entry** (`…/index/…`) must name something already uploaded (`409` otherwise): it is what makes a layer visible, so it is written last;\n- a **run manifest** must have passed its privacy scan;\n- keys are immutable: the same bytes again are `200` (a retry), other bytes under the same key are `409`.\n\nUpload in dependency order: blobs, then the manifest, then the catalog entry. `atlas report publish`, `atlas report stream` and `httpStore` do. Needs a `Bearer` token of role `publish` or `admin`; a browser's sign-in box is refused.\n\nA token of role `critic` may upload only what a critic publishes: blobs, and layers (and their catalog entries) whose `producer` is `critic.<name>` and whose parts are all of kind `critique`. Anything else is `403` with the rule it broke, and nothing is stored.\n\nScoped to one project. The same project may be selected on the unprefixed API using ?project= or X-Atlas-Project. Unknown projects return 404 on reads and are created by an authenticated upload.\n\nRole needed: `critic`.",
+        "x-atlas-role": "critic",
         "security": [
           {
             "bearer": []
@@ -10011,6 +10011,7 @@
             "type": "string",
             "enum": [
               "read",
+              "critic",
               "publish",
               "admin"
             ],

package/packages/visualizer/src/app/router.tsx

@@ -30,6 +30,9 @@ const SpecSearch = RootSearch.extend({
   spec: z.string().min(1).optional().catch(undefined),
   check: z.string().min(1).optional().catch(undefined),
   layer: z.string().min(1).optional().catch(undefined),
+  /** A shared moment: the exact recording (an `attachmentIdentity`) of that layer, and the position in it in milliseconds. */
+  clip: z.coerce.string().min(1).optional().catch(undefined),
+  clipAt: z.coerce.number().nonnegative().optional().catch(undefined),
   view: z.enum(['recording']).optional().catch(undefined),
   moment: z.coerce.number().int().positive().optional().catch(undefined),
   /** The release evidence is read against: its build, commit and platform, and the evidence filter (see `evidence/applicability.ts`). A build such as `90` is read from a typed link as a number: coerced back to its text. */

package/packages/visualizer/src/evidence/artifacts.tsx

@@ -1,5 +1,5 @@
 import type { CheckDetail, EvidenceHolder } from '@crvouga/atlas/reports/evidence-detail';
-import { isVideoAttachment, roleOfType } from '@crvouga/atlas/reports/evidence-detail';
+import { attachmentIdentity, isVideoAttachment, roleOfType } from '@crvouga/atlas/reports/evidence-detail';
 import { effectiveScope } from '@crvouga/atlas/reports/evidence-scope';
 import type { LayerHeader, LayerRow } from '@crvouga/atlas/reports/evidence-types';
 import { contentTypeOf } from '@crvouga/atlas/reports/media-types';
@@ -12,6 +12,8 @@ import { reportAssetUrl, reportJson, reportText } from './api';
 import { ScopeNotice, ScopeProvider, useScope } from './evidence-scope';
 import { duration, plural, safeUri } from './format';
 import { StatusMark } from './marks';
+import { MomentBar, MomentPlayback, momentOwner, SeekStep, useIsPlaying, useMomentVideo, useRequestedMoment } from './moments';
+import { videosIn } from './outcome';
 /**
  * How one kind of attachment is shown. The first renderer that matches wins, so a new kind of artifact (a
  * flame graph, a HAR, a coverage map) is one more entry, and an attachment nobody has a renderer for is still
@@ -38,6 +40,8 @@ const label = (attachment: Attachment) => attachment.description ?? attachment.n
 /** A video that plays inline; when the file cannot be loaded or this browser cannot play it, it says so and offers the file, instead of an empty player. */
 function VideoPlayer({ attachment, url }: { attachment: Attachment; url: string }) {
   const [failed, setFailed] = useState(false);
+  // Inside a result's playback the player is the one its steps seek and that marks the step playing.
+  const moments = useMomentVideo(attachment);
   if (failed)
     return (
       <Alert role="alert" color="orange" title="This video cannot be played">
@@ -50,7 +54,19 @@ function VideoPlayer({ attachment, url }: { attachment: Attachment; url: string
         </Text>
       </Alert>
     );
-  return <Box src={url} controls preload="metadata" aria-label={label(attachment)} component="video" maw="100%" w="100%" onError={() => setFailed(true)} />;
+  return (
+    <Box
+      src={url}
+      controls
+      preload="metadata"
+      aria-label={label(attachment)}
+      component="video"
+      maw="100%"
+      w="100%"
+      onError={() => setFailed(true)}
+      {...moments}
+    />
+  );
 }
 function TextValue({ attachment, path }: { attachment: Attachment; path: string | null }) {
   const stored = useQuery({
@@ -261,37 +277,11 @@ export function Timeline({ steps, layer }: { steps: readonly Step[]; layer: stri
   }, [steps]);
   const render = (parent: string | null): ReactNode => (
     <List spacing="xs" listStyleType="none" type="ordered">
-      {(tree.get(parent) ?? []).map((step, index) => {
-        const status = STEP_STATUS[(step.status ?? '').toLowerCase()];
-        return (
-          <List.Item data-evidence-step key={`${step.id ?? step.name}:${index}`} data-status={status ?? step.status ?? 'none'}>
-            <Flex gap="xs" align="center" wrap="wrap">
-              <StatusMark status={status ?? 'none'} size={14} />
-              <Text span inherit>
-                {step.name}
-              </Text>
-              {step.kind && (
-                <Text span inherit>
-                  {step.kind}
-                </Text>
-              )}
-              {step.status && !status && (
-                <Text span inherit>
-                  {step.status}
-                </Text>
-              )}
-              <Box flex={1} />
-              <Text span inherit c="dimmed">
-                {[step.offsetMs !== undefined ? `+${duration(step.offsetMs)}` : '', duration(step.durationMs)].filter(Boolean).join(' · ')}
-              </Text>
-            </Flex>
-            {step.detail && <Text component="div">{step.detail}</Text>}
-            {step.annotations && <Notes notes={step.annotations} />}
-            {step.attachments && <Attachments attachments={step.attachments} layer={layer} />}
-            {step.id && tree.has(step.id) && render(step.id)}
-          </List.Item>
-        );
-      })}
+      {(tree.get(parent) ?? []).map((step, index) => (
+        <TimelineStep key={`${step.id ?? step.name}:${index}`} step={step} layer={layer}>
+          {step.id && tree.has(step.id) && render(step.id)}
+        </TimelineStep>
+      ))}
     </List>
   );
   return (
@@ -299,10 +289,52 @@ export function Timeline({ steps, layer }: { steps: readonly Step[]; layer: stri
       <Title order={4} mb="sm">
         {plural(steps.length, 'step', 'steps')}
       </Title>
+      <MomentBar />
       {render(null)}
     </Box>
   );
 }
+/** One step of the timeline: its outcome and times, a control to show it in the recording when there is one, and what it carries. */
+function TimelineStep({ step, layer, children }: { step: Step; layer: string; children: ReactNode }) {
+  const status = STEP_STATUS[(step.status ?? '').toLowerCase()];
+  const playing = useIsPlaying(step);
+  return (
+    <List.Item
+      data-evidence-step
+      data-status={status ?? step.status ?? 'none'}
+      data-playing={playing || undefined}
+      aria-current={playing ? 'step' : undefined}
+      {...(playing ? { bg: 'blue.0' } : {})}
+    >
+      <Flex gap="xs" align="center" wrap="wrap">
+        <StatusMark status={status ?? 'none'} size={14} />
+        <Text span inherit>
+          {step.name}
+        </Text>
+        {step.kind && (
+          <Text span inherit>
+            {step.kind}
+          </Text>
+        )}
+        {step.status && !status && (
+          <Text span inherit>
+            {step.status}
+          </Text>
+        )}
+        {playing && <Badge variant="light">Playing now</Badge>}
+        <Box flex={1} />
+        <SeekStep step={step} />
+        <Text span inherit c="dimmed">
+          {[step.offsetMs !== undefined ? `+${duration(step.offsetMs)}` : '', duration(step.durationMs)].filter(Boolean).join(' · ')}
+        </Text>
+      </Flex>
+      {step.detail && <Text component="div">{step.detail}</Text>}
+      {step.annotations && <Notes notes={step.annotations} />}
+      {step.attachments && <Attachments attachments={step.attachments} layer={layer} />}
+      {children}
+    </List.Item>
+  );
+}
 export function Notes({ notes }: { notes: readonly Annotation[] }) {
   if (!notes.length) return null;
   return (
@@ -333,6 +365,7 @@ export function Notes({ notes }: { notes: readonly Annotation[] }) {
     </List>
   );
 }
+const NO_FILES: readonly Attachment[] = [];
 function Tries({ attempts, layer }: { attempts: readonly Attempt[]; layer: string }) {
   if (!attempts.length) return null;
   return (
@@ -355,7 +388,11 @@ function Tries({ attempts, layer }: { attempts: readonly Attempt[]; layer: strin
             </Flex>
             {attempt.detail && <Text component="div">{attempt.detail}</Text>}
             <ScopeProvider scope={attempt.scope}>
-              {attempt.attachments && <Attachments attachments={attempt.attachments} layer={layer} />}
+              {/* A try is placed in its own recording with that recording's own timing, never in another try's. */}
+              <MomentPlayback steps={attempt.steps} attachments={attempt.attachments ?? NO_FILES} layer={layer}>
+                {attempt.steps && attempt.steps.length > 0 ? <Timeline steps={attempt.steps} layer={layer} /> : <MomentBar />}
+                {attempt.attachments && <Attachments attachments={attempt.attachments} layer={layer} />}
+              </MomentPlayback>
             </ScopeProvider>
           </List.Item>
         ))}
@@ -413,15 +450,17 @@ function Facts({ holder }: { holder: EvidenceHolder }) {
     </Stack>
   );
 }
-function Evidence({ holder, layer, steps }: { holder: EvidenceHolder; layer: string; steps?: boolean }) {
+function Evidence({ holder, layer, steps = false, owner }: { holder: EvidenceHolder; layer: string; steps?: boolean; owner?: string }) {
   return (
     <ScopeProvider scope={holder.scope}>
-      <Facts holder={holder} />
-      {holder.annotations && <Notes notes={holder.annotations} />}
-      {steps && holder.steps && holder.steps.length > 0 && <Timeline steps={holder.steps} layer={layer} />}
-      {holder.attempts && holder.attempts.length > 1 && <Tries attempts={holder.attempts} layer={layer} />}
-      {holder.attachments && <Attachments attachments={holder.attachments} layer={layer} />}
-      {holder.extensions && <Raw extensions={holder.extensions} />}
+      <MomentPlayback steps={steps ? holder.steps : undefined} attachments={holder.attachments ?? NO_FILES} layer={layer} primary={steps} owner={owner}>
+        <Facts holder={holder} />
+        {holder.annotations && <Notes notes={holder.annotations} />}
+        {steps && holder.steps && holder.steps.length > 0 ? <Timeline steps={holder.steps} layer={layer} /> : <MomentBar />}
+        {holder.attempts && holder.attempts.length > 1 && <Tries attempts={holder.attempts} layer={layer} />}
+        {holder.attachments && <Attachments attachments={holder.attachments} layer={layer} />}
+        {holder.extensions && <Raw extensions={holder.extensions} />}
+      </MomentPlayback>
     </ScopeProvider>
   );
 }
@@ -444,6 +483,7 @@ export function useCheckDetail(layer: LayerHeader, row: LayerRow, enabled = true
 export function ResultEvidence({ layer, row }: { layer: LayerHeader; row: LayerRow }) {
   const wanted = row.evidence !== undefined || layer.evidence !== undefined;
   const detail = useCheckDetail(layer, row);
+  const requested = useRequestedMoment();
   if (!wanted) return null;
   if (detail.isLoading)
     return (
@@ -466,13 +506,19 @@ export function ResultEvidence({ layer, row }: { layer: LayerHeader; row: LayerR
     <ArtifactTagsProvider layer={layer.id} kind={row.kind} check={row.id} holders={[check, run]}>
       <Stack aria-label="Evidence" gap="sm" miw={0}>
         <TagFilterBar holders={[check, run]} />
+        {requested.clip !== undefined && requested.layer === layer.id && ![...videosIn(check), ...videosIn(run)].some((video) => attachmentIdentity(video) === requested.clip) && (
+          <Alert role="status" color="orange" title="The recording this link names is not in this result" data-moment-missing>
+            The link names a recording that this run did not record for this check. Nothing is played in its place, and no other run is
+            substituted.
+          </Alert>
+        )}
         {declared && (
           <Box aria-label="Scope of this result" component="section">
             <ScopeNotice scope={declared} name={row.title} />
           </Box>
         )}
         <ScopeProvider scope={inheritedScope}>
-          <Evidence holder={check} layer={layer.id} steps />
+          <Evidence holder={check} layer={layer.id} steps owner={momentOwner(layer.id, row.kind, row.id)} />
         </ScopeProvider>
         {hasRun && (
           <Box aria-label="From the run" component="section" mb="lg">