@crowdstrike/glide-core 0.8.0 → 0.9.1

package/dist/dropdown.test.events.multiple.js

@@ -1,10 +1,211 @@
 /* eslint-disable @typescript-eslint/no-unused-expressions */
 import * as sinon from 'sinon';
 import { aTimeout, expect, fixture, html, oneEvent } from '@open-wc/testing';
+import { sendKeys } from '@web/test-runner-commands';
 import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
 GlideCoreDropdownOption.shadowRootOptions.mode = 'open';
+it('dispatches one "change" event when an option is selected via click', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    setTimeout(() => {
+        // Calling `click()` isn't sufficient because it simply sets
+        // `selected` and so isn't likely to produce a duplicate event,
+        // we assert against below. The checkbox, because it produces
+        // its own "change" event, is most likely where the duplicate would
+        // come from.
+        component
+            .querySelector('glide-core-dropdown-option')
+            ?.shadowRoot?.querySelector('[data-test="checkbox"]')
+            ?.click();
+    });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: 'Enter' });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when an option is selected via Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: ' ' });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via click', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    setTimeout(() => {
+        // Calling `click()` isn't sufficient because it simply sets
+        // `selected` and so isn't likely to produce a duplicate event,
+        // we assert against below. The checkbox, because it produces
+        // its own "change" event, is most likely where the duplicate would
+        // come from.
+        component
+            .querySelector('glide-core-dropdown-option')
+            ?.shadowRoot?.querySelector('[data-test="checkbox"]')
+            ?.click();
+    });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: 'Enter' });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: ' ' });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
 it('dispatches one "change" event when Select All is clicked', async () => {
     const component = await fixture(html `<glide-core-dropdown
       label="Label"
@@ -32,7 +233,7 @@ it('dispatches one "change" event when Select All is clicked', async () => {
             ?.click();
     });
     await aTimeout(0);
-    expect(spy.calledOnce).to.be.true;
+    expect(spy.callCount).to.equal(1);
 });
 it('dispatches one "input" event when Select All is clicked', async () => {
     const component = await fixture(html `<glide-core-dropdown
@@ -61,7 +262,7 @@ it('dispatches one "input" event when Select All is clicked', async () => {
             ?.click();
     });
     await aTimeout(0);
-    expect(spy.calledOnce).to.be.true;
+    expect(spy.callCount).to.equal(1);
 });
 it('does not dispatch a "change" event when `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown
@@ -92,7 +293,7 @@ it('does not dispatch a "change" event when `value` is changed programmatically'
         component.value = ['one', 'two'];
     });
     await aTimeout(0);
-    expect(spy.called).to.be.false;
+    expect(spy.callCount).to.equal(0);
 });
 it('continues to dispatch "change" events upon selection after `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown
@@ -156,7 +357,7 @@ it('does not dispatch an "input" event when `value` is changed programmatically'
         component.value = ['one', 'two'];
     });
     await aTimeout(0);
-    expect(spy.called).to.be.false;
+    expect(spy.callCount).to.equal(0);
 });
 it('continues to dispatch "input" events upon selection after `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown
@@ -191,7 +392,7 @@ it('continues to dispatch "input" events upon selection after `value` is changed
     const event = await oneEvent(component, 'input');
     expect(event instanceof Event).to.be.true;
 });
-it('dispatches a "change" event when an option is selected after Select All is clicked', async () => {
+it('dispatches one "change" event when an option is selected after Select All is clicked', async () => {
     const component = await fixture(html `<glide-core-dropdown
       label="Label"
       placeholder="Placeholder"
@@ -222,9 +423,9 @@ it('dispatches a "change" event when an option is selected after Select All is c
         component.querySelector('glide-core-dropdown-option')?.click();
     });
     await aTimeout(0);
-    expect(spy.called).to.be.true;
+    expect(spy.callCount).to.equal(1);
 });
-it('dispatches an "input" event when an option is selected after Select All is clicked', async () => {
+it('dispatches one "input" event when an option is selected after Select All is clicked', async () => {
     const component = await fixture(html `<glide-core-dropdown
       label="Label"
       placeholder="Placeholder"
@@ -255,5 +456,61 @@ it('dispatches an "input" event when an option is selected after Select All is c
         component.querySelector('glide-core-dropdown-option')?.click();
     });
     await aTimeout(0);
-    expect(spy.called).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when a tag is removed', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+        selected
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    setTimeout(() => {
+        component.shadowRoot
+            ?.querySelector('[data-test="tag"]')
+            ?.click();
+    });
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    await aTimeout(0);
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when a tag is removed', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      open
+      multiple
+    >
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+        selected
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    setTimeout(() => {
+        component.shadowRoot
+            ?.querySelector('[data-test="tag"]')
+            ?.click();
+    });
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    await aTimeout(0);
+    expect(spy.callCount).to.equal(1);
 });

package/dist/dropdown.test.events.single.js

@@ -2,8 +2,163 @@
 import './dropdown.option.js';
 import * as sinon from 'sinon';
 import { aTimeout, expect, fixture, html, oneEvent } from '@open-wc/testing';
+import { sendKeys } from '@web/test-runner-commands';
 import GlideCoreDropdown from './dropdown.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
+it('dispatches one "change" event when an option is selected via click', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: 'Enter' });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when an option is selected via Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: ' ' });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via click', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: 'Enter' });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: ' ' });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
 it('does not dispatch a "change" event when `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       <glide-core-dropdown-option
@@ -23,7 +178,7 @@ it('does not dispatch a "change" event when `value` is changed programmatically'
         component.value = ['one'];
     });
     await aTimeout(0);
-    expect(spy.called).to.be.false;
+    expect(spy.callCount).to.equal(0);
 });
 it('continues to dispatch "change" events upon selection after `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
@@ -64,7 +219,49 @@ it('does not dispatch an "input" event when `value` is changed programmatically'
         component.value = ['one'];
     });
     await aTimeout(0);
-    expect(spy.called).to.be.false;
+    expect(spy.callCount).to.equal(0);
+});
+it('does not dispatch a "change" event when an already selected option is selected', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+        selected
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    await aTimeout(0);
+    expect(spy.callCount).to.equal(0);
+});
+it('does not dispatch an "input" event when an already selected option is selected', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+        selected
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    await aTimeout(0);
+    expect(spy.callCount).to.equal(0);
 });
 it('continues to dispatch "input" events upon selection after `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>

package/dist/dropdown.test.focus.filterable.js

@@ -1,5 +1,5 @@
 import './dropdown.option.js';
-import { assert, expect, fixture, html } from '@open-wc/testing';
+import { aTimeout, assert, expect, fixture, html } from '@open-wc/testing';
 import { sendMouse } from '@web/test-runner-commands';
 import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
@@ -61,7 +61,7 @@ const defaultSlot = html `
     value="eleven"
   ></glide-core-dropdown-option>
 `;
-it('focuses the input when `focus` is called', async () => {
+it('focuses the input when `focus()` is called', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
       ${defaultSlot}
     </glide-core-dropdown>`);
@@ -78,12 +78,14 @@ it('retains focus on the input when an option is selected via click', async () =
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
     const option = component.querySelector('glide-core-dropdown-option');
     assert(option);
     const { x, y } = option.getBoundingClientRect();
     // A simple `option.click()` won't do because we need a "mousedown" so that
-    // `#onOptionsMousedown` gets covered.
+    // `#onOptionsMousedown` is covered.
     await sendMouse({
         type: 'click',
         position: [Math.ceil(x), Math.ceil(y)],
@@ -92,9 +94,11 @@ it('retains focus on the input when an option is selected via click', async () =
     expect(component.shadowRoot?.activeElement).to.equal(input);
 });
 it('retains focus on the the input when an option is selected via Enter', async () => {
-    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
     component
         .querySelector('glide-core-dropdown-option')
@@ -104,7 +108,7 @@ it('retains focus on the the input when an option is selected via Enter', async
     expect(component.shadowRoot?.activeElement).to.equal(input);
 });
 it('retains focus on the the input when the button is clicked', async () => {
-    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       ${defaultSlot}
     </glide-core-dropdown>`);
     component.focus();

package/dist/dropdown.test.focus.js

@@ -33,5 +33,5 @@ it('closes and reports validity when it loses focus', async () => {
     expect(component.open).to.be.false;
     expect(component.shadowRoot?.activeElement).to.equal(null);
     expect(component.validity.valid).to.equal(false);
-    expect(component.shadowRoot?.querySelector('glide-core-label')?.error).to.equal(true);
+    expect(component.shadowRoot?.querySelector('glide-core-private-label')?.error).to.equal(true);
 });

package/dist/dropdown.test.focus.multiple.js

@@ -4,7 +4,7 @@ import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
 GlideCoreDropdownOption.shadowRootOptions.mode = 'open';
-it('focuses the button when `focus` is called', async () => {
+it('focuses the button when `focus()` is called', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" multiple>
       <glide-core-dropdown-option
         label="One"

package/dist/dropdown.test.focus.single.js

@@ -4,7 +4,7 @@ import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
 GlideCoreDropdownOption.shadowRootOptions.mode = 'open';
-it('focuses the button when `focus` is called', async () => {
+it('focuses the button when `focus()` is called', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
       <glide-core-dropdown-option
         label="Label"