@crowdstrike/glide-core 0.8.0 → 0.9.0

package/dist/dropdown.test.events.single.js

@@ -2,8 +2,163 @@
 import './dropdown.option.js';
 import * as sinon from 'sinon';
 import { aTimeout, expect, fixture, html, oneEvent } from '@open-wc/testing';
+import { sendKeys } from '@web/test-runner-commands';
 import GlideCoreDropdown from './dropdown.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
+it('dispatches one "change" event when an option is selected via click', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: 'Enter' });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "change" event when an option is selected via Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: ' ' });
+    const event = await oneEvent(component, 'change');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via click', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: 'Enter' });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
+it('dispatches one "input" event when an option is selected via Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+        selected
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    // Activate the first option before selecting it. The second option is
+    // currently active because it's selected.
+    component
+        .querySelector('glide-core-dropdown-option')
+        ?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
+    component.focus();
+    sendKeys({ press: ' ' });
+    const event = await oneEvent(component, 'input');
+    expect(event instanceof Event).to.be.true;
+    expect(event.bubbles).to.be.true;
+    expect(spy.callCount).to.equal(1);
+});
 it('does not dispatch a "change" event when `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       <glide-core-dropdown-option
@@ -23,7 +178,7 @@ it('does not dispatch a "change" event when `value` is changed programmatically'
         component.value = ['one'];
     });
     await aTimeout(0);
-    expect(spy.called).to.be.false;
+    expect(spy.callCount).to.equal(0);
 });
 it('continues to dispatch "change" events upon selection after `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
@@ -64,7 +219,49 @@ it('does not dispatch an "input" event when `value` is changed programmatically'
         component.value = ['one'];
     });
     await aTimeout(0);
-    expect(spy.called).to.be.false;
+    expect(spy.callCount).to.equal(0);
+});
+it('does not dispatch a "change" event when an already selected option is selected', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+        selected
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('change', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    await aTimeout(0);
+    expect(spy.callCount).to.equal(0);
+});
+it('does not dispatch an "input" event when an already selected option is selected', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
+      <glide-core-dropdown-option
+        label="One"
+        value="one"
+        selected
+      ></glide-core-dropdown-option>
+
+      <glide-core-dropdown-option
+        label="Two"
+        value="two"
+      ></glide-core-dropdown-option>
+    </glide-core-dropdown>`);
+    const spy = sinon.spy();
+    component.addEventListener('input', spy);
+    setTimeout(() => {
+        component.querySelector('glide-core-dropdown-option')?.click();
+    });
+    await aTimeout(0);
+    expect(spy.callCount).to.equal(0);
 });
 it('continues to dispatch "input" events upon selection after `value` is changed programmatically', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>

package/dist/dropdown.test.focus.filterable.js

@@ -1,5 +1,5 @@
 import './dropdown.option.js';
-import { assert, expect, fixture, html } from '@open-wc/testing';
+import { aTimeout, assert, expect, fixture, html } from '@open-wc/testing';
 import { sendMouse } from '@web/test-runner-commands';
 import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
@@ -61,7 +61,7 @@ const defaultSlot = html `
     value="eleven"
   ></glide-core-dropdown-option>
 `;
-it('focuses the input when `focus` is called', async () => {
+it('focuses the input when `focus()` is called', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
       ${defaultSlot}
     </glide-core-dropdown>`);
@@ -78,12 +78,14 @@ it('retains focus on the input when an option is selected via click', async () =
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
     const option = component.querySelector('glide-core-dropdown-option');
     assert(option);
     const { x, y } = option.getBoundingClientRect();
     // A simple `option.click()` won't do because we need a "mousedown" so that
-    // `#onOptionsMousedown` gets covered.
+    // `#onOptionsMousedown` is covered.
     await sendMouse({
         type: 'click',
         position: [Math.ceil(x), Math.ceil(y)],
@@ -92,9 +94,11 @@ it('retains focus on the input when an option is selected via click', async () =
     expect(component.shadowRoot?.activeElement).to.equal(input);
 });
 it('retains focus on the the input when an option is selected via Enter', async () => {
-    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
     component
         .querySelector('glide-core-dropdown-option')
@@ -104,7 +108,7 @@ it('retains focus on the the input when an option is selected via Enter', async
     expect(component.shadowRoot?.activeElement).to.equal(input);
 });
 it('retains focus on the the input when the button is clicked', async () => {
-    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       ${defaultSlot}
     </glide-core-dropdown>`);
     component.focus();

package/dist/dropdown.test.focus.js

@@ -33,5 +33,5 @@ it('closes and reports validity when it loses focus', async () => {
     expect(component.open).to.be.false;
     expect(component.shadowRoot?.activeElement).to.equal(null);
     expect(component.validity.valid).to.equal(false);
-    expect(component.shadowRoot?.querySelector('glide-core-label')?.error).to.equal(true);
+    expect(component.shadowRoot?.querySelector('glide-core-private-label')?.error).to.equal(true);
 });

package/dist/dropdown.test.focus.multiple.js

@@ -4,7 +4,7 @@ import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
 GlideCoreDropdownOption.shadowRootOptions.mode = 'open';
-it('focuses the button when `focus` is called', async () => {
+it('focuses the button when `focus()` is called', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" multiple>
       <glide-core-dropdown-option
         label="One"

package/dist/dropdown.test.focus.single.js

@@ -4,7 +4,7 @@ import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
 GlideCoreDropdown.shadowRootOptions.mode = 'open';
 GlideCoreDropdownOption.shadowRootOptions.mode = 'open';
-it('focuses the button when `focus` is called', async () => {
+it('focuses the button when `focus()` is called', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
       <glide-core-dropdown-option
         label="Label"

package/dist/dropdown.test.interactions.filterable.js

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unused-expressions */
-import { assert, elementUpdated, expect, fixture, html, } from '@open-wc/testing';
+import { aTimeout, assert, elementUpdated, expect, fixture, html, } from '@open-wc/testing';
 import { sendKeys } from '@web/test-runner-commands';
 import GlideCoreDropdown from './dropdown.js';
 import GlideCoreDropdownOption from './dropdown.option.js';
@@ -72,7 +72,11 @@ it('opens on click', async () => {
     component.shadowRoot
         ?.querySelector('[data-test="input"]')
         ?.dispatchEvent(new CustomEvent('click', { bubbles: true, detail: 1 }));
+    // Wait for it to open.
+    await aTimeout(0);
+    const options = component.shadowRoot?.querySelector('[data-test="options"]');
     expect(component.open).to.be.true;
+    expect(options?.checkVisibility()).to.be.true;
 });
 it('filters', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
@@ -85,10 +89,12 @@ it('filters', async () => {
     ].filter(({ hidden }) => !hidden);
     expect(options.length).to.equal(1);
 });
-it('clears the filter term when an option is selected', async () => {
+it('unfilters when an option is selected via click', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
     await sendKeys({ type: ' one ' });
     const option = [
@@ -102,6 +108,20 @@ it('clears the filter term when an option is selected', async () => {
     expect(input?.value).to.equal('');
     expect(options.length).to.equal(11);
 });
+it('unfilters when an option is selected via Enter', async () => {
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
+      ${defaultSlot}
+    </glide-core-dropdown>`);
+    component.focus();
+    await sendKeys({ type: ' one ' });
+    await sendKeys({ press: 'Enter' });
+    const input = component.shadowRoot?.querySelector('[data-test="input"]');
+    const options = [
+        ...component.querySelectorAll('glide-core-dropdown-option'),
+    ].filter(({ hidden }) => !hidden);
+    expect(input?.value).to.equal('');
+    expect(options.length).to.equal(11);
+});
 it('shows the magnifying glass icon when there is a filter term', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
       ${defaultSlot}
@@ -119,9 +139,11 @@ it('hides the magnifying glass icon when there is no filter term', async () => {
     expect(icon?.checkVisibility()).to.be.not.ok;
 });
 it('hides the magnifying glass icon when an option is selected', async () => {
-    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder">
+    const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
     await sendKeys({ type: ' one ' });
     const option = [
@@ -147,10 +169,14 @@ it('hides the options when all of them are filtered out', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" open>
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     component.focus();
-    await sendKeys({ type: 'twelve' });
+    await sendKeys({ type: 'fifty' });
+    // Wait for it to close.
+    await aTimeout(0);
     const options = component.shadowRoot?.querySelector('[data-test="options"]');
-    expect(options?.dataset.testVisible).to.equal('false');
+    expect(options?.checkVisibility()).to.be.false;
 });
 it('hides Select All when filtering', async () => {
     const component = await fixture(html `<glide-core-dropdown
@@ -194,6 +220,20 @@ it('updates `value` when an option `value` is changed programmatically', async (
     option.value = 'two';
     expect(component.value).to.deep.equal(['two']);
 });
+it('does not select options on Space', async () => {
+    const component = await fixture(html `<glide-core-dropdown
+      label="Label"
+      placeholder="Placeholder"
+      multiple
+      open
+    >
+      ${defaultSlot}
+    </glide-core-dropdown>`);
+    const options = component.querySelectorAll('glide-core-dropdown-option');
+    options[0]?.focus();
+    await sendKeys({ press: ' ' });
+    expect(options[0]?.selected).to.be.false;
+});
 it('deselects options on Backspace', async () => {
     const component = await fixture(html `<glide-core-dropdown label="Label" placeholder="Placeholder" multiple>
       ${defaultSlot}
@@ -244,6 +284,8 @@ it('sets `aria-activedescendant` on ArrowDown', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     const options = component.querySelectorAll('glide-core-dropdown-option');
     options[0]?.focus();
     await sendKeys({ press: 'ArrowDown' });
@@ -259,6 +301,8 @@ it('sets `aria-activedescendant` on ArrowUp', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     const options = component.querySelectorAll('glide-core-dropdown-option');
     options[1]?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
     options[1]?.focus();
@@ -275,6 +319,8 @@ it('sets `aria-activedescendant` on Home', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     const options = component.querySelectorAll('glide-core-dropdown-option');
     options[1]?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
     options[1].focus();
@@ -291,6 +337,8 @@ it('sets `aria-activedescendant` on PageUp', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
     const options = component.querySelectorAll('glide-core-dropdown-option');
     options[1].dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
     options[1].focus();
@@ -298,7 +346,7 @@ it('sets `aria-activedescendant` on PageUp', async () => {
     const input = component.shadowRoot?.querySelector('[data-test="input"]');
     expect(input?.getAttribute('aria-activedescendant')).to.equal(options[0].id);
 });
-it('sets `aria-activedescendant` on ArrowUp + Meta', async () => {
+it('sets `aria-activedescendant` on Meta + ArrowUp', async () => {
     const component = await fixture(html `<glide-core-dropdown
       label="Label"
       placeholder="Placeholder"
@@ -307,9 +355,11 @@ it('sets `aria-activedescendant` on ArrowUp + Meta', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
+    component.focus();
     const options = component.querySelectorAll('glide-core-dropdown-option');
     options[1]?.dispatchEvent(new MouseEvent('mouseover', { bubbles: true }));
-    options[1].focus();
     await sendKeys({ down: 'Meta' });
     await sendKeys({ press: 'ArrowUp' });
     await sendKeys({ up: 'Meta' });
@@ -327,7 +377,8 @@ it('sets `aria-activedescendant` on open via click', async () => {
     component.shadowRoot
         ?.querySelector('[data-test="button"]')
         ?.dispatchEvent(new CustomEvent('click', { bubbles: true, detail: 1 }));
-    await elementUpdated(component);
+    // Wait for it to open.
+    await aTimeout(0);
     const input = component.shadowRoot?.querySelector('[data-test="input"]');
     const option = component.querySelector('glide-core-dropdown-option');
     expect(input?.getAttribute('aria-activedescendant')).to.equal(option?.id);
@@ -351,11 +402,13 @@ it('sets `aria-activedescendant` on End', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
+    component.focus();
     // Made into an array because the linter forces `at(-1)` instead of
     // `[options.length - 1]` but doesn't take into account that `options`
     // isn't an actual array and doesn't have an `at()` method.
     const options = [...component.querySelectorAll('glide-core-dropdown-option')];
-    options[0]?.focus();
     await sendKeys({ press: 'End' });
     const input = component.shadowRoot?.querySelector('[data-test="input"]');
     expect(input?.getAttribute('aria-activedescendant')).to.equal(options.at(-1)?.id);
@@ -369,11 +422,13 @@ it('sets `aria-activedescendant` on PageDown', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
+    component.focus();
     // Made into an array because the linter forces `at(-1)` instead of
     // `[options.length - 1]` but doesn't take into account that `options`
     // isn't an actual array and doesn't have an `at()` method.
     const options = [...component.querySelectorAll('glide-core-dropdown-option')];
-    options[0]?.focus();
     await sendKeys({ press: 'PageDown' });
     const input = component.shadowRoot?.querySelector('[data-test="input"]');
     expect(input?.getAttribute('aria-activedescendant')).to.equal(options.at(-1)?.id);
@@ -387,11 +442,13 @@ it('sets `aria-activedescendant` on Meta + ArrowDown', async () => {
     >
       ${defaultSlot}
     </glide-core-dropdown>`);
+    // Wait for it to open.
+    await aTimeout(0);
+    component.focus();
     // Spread into an array because the linter forces `at(-1)` instead of
     // `[options.length - 1]` but doesn't take into account that `options`
     // isn't an actual array and doesn't have an `at()` method.
     const options = [...component.querySelectorAll('glide-core-dropdown-option')];
-    options[0]?.focus();
     await sendKeys({ down: 'Meta' });
     await sendKeys({ press: 'ArrowDown' });
     await sendKeys({ up: 'Meta' });