@crouton-kit/crouter 0.3.31 → 0.3.32

package/dist/core/__tests__/helpers/harness.js

@@ -200,7 +200,13 @@ export async function createHarness(opts = {}) {
     }
     function nodeDirs() {
         try {
-            return readdirSync(join(home, 'nodes'));
+            // Node ids are minted by newNodeId() (runtime/nodes.ts) as `<base36-ts>-<8
+            // hex>`. Scope the scan to that shape so a stray non-node sibling under
+            // nodes/ is never miscounted as a new node dir — e.g. a `reports/` dir
+            // created for an empty node id (the rare CI flake on full-tier run
+            // 27459304455 that broke the spawn counters with
+            // `expected exactly 1 new node dir, got [<id>, reports]`).
+            return readdirSync(join(home, 'nodes')).filter((d) => /^[0-9a-z]+-[0-9a-f]{8}$/.test(d));
         }
         catch {
             return [];

package/dist/core/canvas/paths.js

@@ -73,6 +73,12 @@ export function injectedDocsPath(nodeId) {
 }
 /** Create the full directory skeleton for a node. Idempotent. */
 export function ensureNodeDirs(nodeId) {
+    // Refuse an empty nodeId: it would mint stray `nodes/context`, `nodes/job`,
+    // `nodes/reports` siblings (non-node entries the test harness's node-dir
+    // scan would miscount). A node skeleton must belong to a real node id.
+    if (!nodeId) {
+        throw new Error('ensureNodeDirs: empty nodeId — refusing to create stray node-skeleton dirs under nodes/');
+    }
     for (const d of [contextDir(nodeId), jobDir(nodeId), reportsDir(nodeId)]) {
         mkdirSync(d, { recursive: true });
     }

package/dist/core/feed/__tests__/empty-node-guard.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/core/feed/__tests__/empty-node-guard.test.js

@@ -0,0 +1,45 @@
+// Regression: a report/skeleton write for an EMPTY node id used to resolve
+// reportsDir('') → `nodes/reports` and silently mint a stray non-node sibling
+// under nodes/. That stray entry broke the full-tier test harness's node-dir
+// counter (`expected exactly 1 new node dir, got [<id>, reports]` — the rare
+// flake on CI run 27459304455). The boundary now refuses an empty node id loudly
+// instead of writing garbage. This locks that in.
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { mkdtempSync, existsSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
+import { tmpdir } from 'node:os';
+import { push } from '../feed.js';
+import { ensureNodeDirs, nodesRoot } from '../../canvas/paths.js';
+test('push() rejects an empty nodeId and creates no stray nodes/reports dir', async () => {
+    const home = mkdtempSync(join(tmpdir(), 'crtr-emptyguard-'));
+    const orig = process.env['CRTR_HOME'];
+    process.env['CRTR_HOME'] = home;
+    try {
+        await assert.rejects(() => push('', { kind: 'update', body: 'orphan report' }), /empty nodeId/);
+        assert.equal(existsSync(join(nodesRoot(), 'reports')), false, 'no stray nodes/reports dir was created');
+    }
+    finally {
+        if (orig === undefined)
+            delete process.env['CRTR_HOME'];
+        else
+            process.env['CRTR_HOME'] = orig;
+        rmSync(home, { recursive: true, force: true });
+    }
+});
+test('ensureNodeDirs() rejects an empty nodeId and creates no stray skeleton dirs', () => {
+    const home = mkdtempSync(join(tmpdir(), 'crtr-emptyguard-'));
+    const orig = process.env['CRTR_HOME'];
+    process.env['CRTR_HOME'] = home;
+    try {
+        assert.throws(() => ensureNodeDirs(''), /empty nodeId/);
+        assert.equal(existsSync(join(nodesRoot(), 'reports')), false, 'no stray nodes/reports dir was created');
+    }
+    finally {
+        if (orig === undefined)
+            delete process.env['CRTR_HOME'];
+        else
+            process.env['CRTR_HOME'] = orig;
+        rmSync(home, { recursive: true, force: true });
+    }
+});

package/dist/core/feed/feed.js

@@ -70,6 +70,14 @@ function tierFor(kind) {
  *   (c) If kind === 'final', mark the node done.
  */
 export async function push(nodeId, opts) {
+    // A report MUST belong to a node. An empty nodeId would resolve reportsDir('')
+    // to `nodes/reports` and silently mint a stray non-node sibling under nodes/
+    // (the latent corruption behind the full-tier flake on CI run 27459304455).
+    // Refuse it loudly at the boundary so a bad caller surfaces with a stack
+    // instead of writing garbage.
+    if (!nodeId) {
+        throw new Error(`push: empty nodeId (kind=${opts.kind}) — a report must belong to a node`);
+    }
     const { kind, body } = opts;
     const from = opts.from ?? nodeId;
     const now = new Date();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@crouton-kit/crouter",
-  "version": "0.3.31",
+  "version": "0.3.32",
   "description": "crtr — fast access to skills, plugins, and marketplaces",
   "type": "module",
   "main": "dist/index.js",